* [dpdk-dev] [PATCH] common/cnxk: fix build failure
@ 2021-10-27 13:12 Tejasree Kondoj
2021-10-28 7:01 ` Anoob Joseph
2021-10-28 17:32 ` Ferruh Yigit
0 siblings, 2 replies; 5+ messages in thread
From: Tejasree Kondoj @ 2021-10-27 13:12 UTC (permalink / raw)
To: Akhil Goyal, Jiang, YuX, Longfeng Liang
Cc: Tejasree Kondoj, Anoob Joseph, dev
Fixing build failure with EXTRA_CFLAGS='-O1'.
Fixes: d85f9749f915 ("common/cnxk: add hash generation API")
Reported-by: Longfeng Liang <longfengx.liang@intel.com>
Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
---
drivers/common/cnxk/roc_hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/cnxk/roc_hash.c b/drivers/common/cnxk/roc_hash.c
index 092286e41e..4a34c7fbf8 100644
--- a/drivers/common/cnxk/roc_hash.c
+++ b/drivers/common/cnxk/roc_hash.c
@@ -23,7 +23,7 @@ roc_hash_sha1_gen(uint8_t *msg, uint32_t *hash)
0x67452301, 0xEFCDAB89, 0x98BADCFE, 0x10325476,
0xC3D2E1F0};
int i;
- uint32_t temp; /* Temporary word value */
+ uint32_t temp = 0; /* Temporary word value */
uint32_t W[80]; /* Word sequence */
uint32_t A, B, C, D, E; /* Word buffers */
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] common/cnxk: fix build failure
2021-10-27 13:12 [dpdk-dev] [PATCH] common/cnxk: fix build failure Tejasree Kondoj
@ 2021-10-28 7:01 ` Anoob Joseph
2021-10-28 12:59 ` Jerin Jacob
2021-10-28 17:32 ` Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: Anoob Joseph @ 2021-10-28 7:01 UTC (permalink / raw)
To: Tejasree Kondoj, Akhil Goyal, YuX, Longfeng Liang; +Cc: Tejasree Kondoj, dev
> Subject: [PATCH] common/cnxk: fix build failure
>
> Fixing build failure with EXTRA_CFLAGS='-O1'.
>
> Fixes: d85f9749f915 ("common/cnxk: add hash generation API")
>
> Reported-by: Longfeng Liang <longfengx.liang@intel.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] common/cnxk: fix build failure
2021-10-28 7:01 ` Anoob Joseph
@ 2021-10-28 12:59 ` Jerin Jacob
0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2021-10-28 12:59 UTC (permalink / raw)
To: Anoob Joseph, Ferruh Yigit
Cc: Tejasree Kondoj, Akhil Goyal, YuX, Longfeng Liang, dev
On Thu, Oct 28, 2021 at 12:31 PM Anoob Joseph <anoobj@marvell.com> wrote:
>
> > Subject: [PATCH] common/cnxk: fix build failure
> >
> > Fixing build failure with EXTRA_CFLAGS='-O1'.
> >
> > Fixes: d85f9749f915 ("common/cnxk: add hash generation API")
> >
> > Reported-by: Longfeng Liang <longfengx.liang@intel.com>
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Changed subject to: common/cnxk: fix build with -O1
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] common/cnxk: fix build failure
2021-10-27 13:12 [dpdk-dev] [PATCH] common/cnxk: fix build failure Tejasree Kondoj
2021-10-28 7:01 ` Anoob Joseph
@ 2021-10-28 17:32 ` Ferruh Yigit
2021-10-29 4:57 ` [dpdk-dev] [EXT] " Tejasree Kondoj
1 sibling, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2021-10-28 17:32 UTC (permalink / raw)
To: Tejasree Kondoj, Akhil Goyal, Jiang, YuX, Longfeng Liang
Cc: Anoob Joseph, dev
On 10/27/2021 2:12 PM, Tejasree Kondoj wrote:
> Fixing build failure with EXTRA_CFLAGS='-O1'.
>
For future, can you please provide a little more detail in the commit
log related to the build error,
like which compiler or compiler version cause the issue, what is the
build error and put part of the log in commit log that can help to
people searching for the error log.
Plus if the build error is genuine build error, or if you are just
silencing compiler false positive.
> Fixes: d85f9749f915 ("common/cnxk: add hash generation API")
>
> Reported-by: Longfeng Liang <longfengx.liang@intel.com>
> Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> ---
> drivers/common/cnxk/roc_hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_hash.c b/drivers/common/cnxk/roc_hash.c
> index 092286e41e..4a34c7fbf8 100644
> --- a/drivers/common/cnxk/roc_hash.c
> +++ b/drivers/common/cnxk/roc_hash.c
> @@ -23,7 +23,7 @@ roc_hash_sha1_gen(uint8_t *msg, uint32_t *hash)
> 0x67452301, 0xEFCDAB89, 0x98BADCFE, 0x10325476,
> 0xC3D2E1F0};
> int i;
> - uint32_t temp; /* Temporary word value */
> + uint32_t temp = 0; /* Temporary word value */
> uint32_t W[80]; /* Word sequence */
> uint32_t A, B, C, D, E; /* Word buffers */
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [EXT] Re: [PATCH] common/cnxk: fix build failure
2021-10-28 17:32 ` Ferruh Yigit
@ 2021-10-29 4:57 ` Tejasree Kondoj
0 siblings, 0 replies; 5+ messages in thread
From: Tejasree Kondoj @ 2021-10-29 4:57 UTC (permalink / raw)
To: Ferruh Yigit, Akhil Goyal, Jiang, YuX, Longfeng Liang; +Cc: Anoob Joseph, dev
Sure Ferruh.
Thanks
Tejasree
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, October 28, 2021 11:02 PM
> To: Tejasree Kondoj <ktejasree@marvell.com>; Akhil Goyal
> <gakhil@marvell.com>; Jiang@mx0b-0016f401.pphosted.com; YuX
> <yux.jiang@intel.com>; Longfeng Liang <longfengx.liang@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; dev@dpdk.org
> Subject: [EXT] Re: [dpdk-dev] [PATCH] common/cnxk: fix build failure
>
> External Email
>
> ----------------------------------------------------------------------
> On 10/27/2021 2:12 PM, Tejasree Kondoj wrote:
> > Fixing build failure with EXTRA_CFLAGS='-O1'.
> >
>
> For future, can you please provide a little more detail in the commit log
> related to the build error, like which compiler or compiler version cause the
> issue, what is the build error and put part of the log in commit log that can
> help to people searching for the error log.
> Plus if the build error is genuine build error, or if you are just silencing
> compiler false positive.
>
> > Fixes: d85f9749f915 ("common/cnxk: add hash generation API")
> >
> > Reported-by: Longfeng Liang <longfengx.liang@intel.com>
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> > ---
> > drivers/common/cnxk/roc_hash.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/cnxk/roc_hash.c
> > b/drivers/common/cnxk/roc_hash.c index 092286e41e..4a34c7fbf8 100644
> > --- a/drivers/common/cnxk/roc_hash.c
> > +++ b/drivers/common/cnxk/roc_hash.c
> > @@ -23,7 +23,7 @@ roc_hash_sha1_gen(uint8_t *msg, uint32_t *hash)
> > 0x67452301, 0xEFCDAB89, 0x98BADCFE,
> 0x10325476,
> > 0xC3D2E1F0};
> > int i;
> > - uint32_t temp; /* Temporary word value */
> > + uint32_t temp = 0; /* Temporary word value */
> > uint32_t W[80]; /* Word sequence */
> > uint32_t A, B, C, D, E; /* Word buffers */
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-29 4:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 13:12 [dpdk-dev] [PATCH] common/cnxk: fix build failure Tejasree Kondoj
2021-10-28 7:01 ` Anoob Joseph
2021-10-28 12:59 ` Jerin Jacob
2021-10-28 17:32 ` Ferruh Yigit
2021-10-29 4:57 ` [dpdk-dev] [EXT] " Tejasree Kondoj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).