RE: [PATCH v2] app/test: add additional stream cipher tests

[Tejasree Kondoj <ktejasree@marvell.com>]

Hi Ciara,

Thanks for pointing it out. Will rework test vectors and submit new version.

Thanks
Tejasree

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Tuesday, June 21, 2022 7:58 PM
> To: Akhil Goyal <gakhil@marvell.com>; Tejasree Kondoj
> <ktejasree@marvell.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Ankur Dwivedi
> <adwivedi@marvell.com>; dev@dpdk.org
> Subject: [EXT] RE: [PATCH v2] app/test: add additional stream cipher tests
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Tejasree , Akhil,
> 
> > -----Original Message-----
> > From: Akhil Goyal <gakhil@marvell.com>
> > Sent: Tuesday 21 June 2022 13:51
> > To: Tejasree Kondoj <ktejasree@marvell.com>; Zhang, Roy Fan
> > <roy.fan.zhang@intel.com>; Power, Ciara <ciara.power@intel.com>
> > Cc: Anoob Joseph <anoobj@marvell.com>; Ankur Dwivedi
> > <adwivedi@marvell.com>; dev@dpdk.org
> > Subject: RE: [PATCH v2] app/test: add additional stream cipher tests
> >
> > > Adding zuc, snow3g and aes-ctr-cmac auth-cipher test vectors with
> > > same auth and cipher offsets and total digest data encrypted.
> > > Existing tests have different cipher and auth offsets and partial or
> > > no digest encrypted.
> > >
> > > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> > > ---
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > @Ciara Power: Do you have comments on this patch?
> 
> [CP]
> Tested this patch and there are no fails for QAT, SNOW3G, ZUC, AESNI_MB
> PMDs (a combination of passed and skipped).
> 
> One observation is the test vectors don't appear to match the spec for cipher
> and auth IV - although this seems to occur for other existing auth_cipher
> vectors I have noticed.
> This is based on the spec I see here:
> SNOW3G: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.gsma.com_aboutus_wp-
> 2Dcontent_uploads_2014_12_uea2uia2d1v21.pdf&d=DwIFAg&c=nKjWec2b6
> R0mOyPaz7xtfQ&r=NjpqGUAf6Xc0ZLzxCvv4idf8zRFeSJHioNlG1Wif1Gs&m=Lu
> QUS0xRBdqoB-HkggX8l2lVEvlN-
> 8JUOSqZbNXEzqFISwm_UZLnF8eQabCahkMl&s=_CSrhs6637angbaRgKua6fSb
> 70EKYnmyPg1C0eJqiIo&e=
> ZUC 128: https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.gsma.com_security_wp-2Dcontent_uploads_2019_05_EEA3-
> 5FEIA3-5Fspecification-5Fv1-
> 5F8.pdf&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=NjpqGUAf6Xc0ZLzxCvv
> 4idf8zRFeSJHioNlG1Wif1Gs&m=LuQUS0xRBdqoB-HkggX8l2lVEvlN-
> 8JUOSqZbNXEzqFISwm_UZLnF8eQabCahkMl&s=BzAkYZxJofomR4lkzeiPKXMn
> ewV25NLzB6MpFdlV3kk&e=
> 
> Thanks,
> Ciara