From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: Jerin Jacob <jerinj@marvell.com>, "nd@arm.com" <nd@arm.com>,
"wathsala.vithanage@arm.com" <wathsala.vithanage@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] Re: [PATCH v5 1/3] config/arm: avoid mcpu and march conflicts
Date: Mon, 26 Feb 2024 07:08:48 +0000 [thread overview]
Message-ID: <PH0PR18MB40860F033FD0D89C3D9F8626DE5A2@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAOb5WZZdBMNAgES3eimQi1_tbfm6J4wDBynZRf+YaAwyTxd=HA@mail.gmail.com>
> Other than the one point below,
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
>
> > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > index 36f21d2259..d05d54b564 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> <snip>
> > @@ -695,13 +698,37 @@ if update_flags
> >
> > machine_args = [] # Clear previous machine args
> >
> > - # probe supported archs and their features
> > + march_features = []
> > + if part_number_config.has_key('march_features')
> > + march_features += part_number_config['march_features']
> > + endif
> > + if soc_config.has_key('extra_march_features')
> > + march_features += soc_config['extra_march_features']
> > + endif
> > +
> > + candidate_mcpu = ''
> > candidate_march = ''
> > - if part_number_config.has_key('march')
> > +
> > + if part_number_config.has_key('mcpu') and
> > + cc.has_argument('-mcpu=' + part_number_config['mcpu'])
> > + candidate_mcpu = '-mcpu=' + part_number_config['mcpu']
> > + foreach feature: march_features
> > + if cc.has_argument('+'.join([candidate_mcpu, feature]))
> > + candidate_mcpu = '+'.join([candidate_mcpu, feature])
> > + else
> > + warning('The compiler does not support feature @0@'
> > + .format(feature))
> > + endif
> > + endforeach
> > + machine_args += candidate_mcpu
> > + elif part_number_config.has_key('march')
> > + # probe supported archs and their features
> > if part_number_config.get('force_march', false)
> > - candidate_march = part_number_config['march']
> > + if cc.has_argument('-march=' + part_number_config['march'])
> > + candidate_march = part_number_config['march']
> > + endif
>
> The check was omitted here by design because aarch32 builds with some
> compilers don't support -march=armv8-a alone, only with -mfpu= as
> well.
>
I see, I will remove the check in v6, Thanks.
> > else
> > - supported_marchs = ['armv8.6-a', 'armv8.5-a', 'armv8.4-a', 'armv8.3-
> a',
> > + supported_marchs = ['armv9-a', 'armv8.6-a', 'armv8.5-a', 'armv8.4-
> a', 'armv8.3-a',
> > 'armv8.2-a', 'armv8.1-a', 'armv8-a']
> > check_compiler_support = false
> > foreach supported_march: supported_marchs
> > @@ -717,32 +744,31 @@ if update_flags
> > endif
> > endforeach
> > endif
> > - if candidate_march == ''
> > - error('No suitable armv8 march version found.')
> > - endif
> > +
> > if candidate_march != part_number_config['march']
> > - warning('Configuration march version is ' +
> > - '@0@, but the compiler supports only @1@.'
> > - .format(part_number_config['march'], candidate_march))
> > + warning('Configuration march version is @0@, not supported.'
> > + .format(part_number_config['march']))
> > + if candidate_march != ''
> > + warning('Using march version @0@.'.format(candidate_march))
> > + endif
> > endif
> > - candidate_march = '-march=' + candidate_march
> >
> > - march_features = []
> > - if part_number_config.has_key('march_features')
> > - march_features += part_number_config['march_features']
> > - endif
> > - if soc_config.has_key('extra_march_features')
> > - march_features += soc_config['extra_march_features']
> > + if candidate_march != ''
> > + candidate_march = '-march=' + candidate_march
> > + foreach feature: march_features
> > + if cc.has_argument('+'.join([candidate_march, feature]))
> > + candidate_march = '+'.join([candidate_march, feature])
> > + else
> > + warning('The compiler does not support feature @0@'
> > + .format(feature))
> > + endif
> > + endforeach
> > + machine_args += candidate_march
> > endif
> > - foreach feature: march_features
> > - if cc.has_argument('+'.join([candidate_march, feature]))
> > - candidate_march = '+'.join([candidate_march, feature])
> > - else
> > - warning('The compiler does not support feature @0@'
> > - .format(feature))
> > - endif
> > - endforeach
> > - machine_args += candidate_march
> > + endif
> > +
> > + if candidate_mcpu == '' and candidate_march == ''
> > + error('No suitable ARM march/mcpu version found.')
> > endif
> >
> > # apply supported compiler options
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2024-02-26 7:08 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 9:36 [PATCH 1/2] " pbhagavatula
2024-01-21 9:36 ` [PATCH 2/2] config/arm: add support for fallback march pbhagavatula
2024-01-22 6:30 ` Ruifeng Wang
2024-01-22 11:04 ` Juraj Linkeš
2024-01-22 12:16 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-01-22 16:29 ` Juraj Linkeš
2024-01-24 15:25 ` Pavan Nikhilesh Bhagavatula
2024-01-22 6:29 ` [PATCH 1/2] config/arm: avoid mcpu and march conflicts Ruifeng Wang
2024-01-22 10:55 ` Juraj Linkeš
2024-01-22 11:54 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-01-22 16:26 ` Juraj Linkeš
2024-01-24 15:21 ` Pavan Nikhilesh Bhagavatula
2024-01-29 8:44 ` Juraj Linkeš
2024-01-30 16:16 ` Pavan Nikhilesh Bhagavatula
2024-01-31 9:03 ` Juraj Linkeš
2024-02-01 21:57 ` [PATCH v2 1/3] " pbhagavatula
2024-02-01 21:57 ` [PATCH v2 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-01 21:57 ` [PATCH v2 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-07 2:55 ` Honnappa Nagarahalli
2024-02-10 6:47 ` Pavan Nikhilesh Bhagavatula
2024-02-10 16:36 ` Honnappa Nagarahalli
2024-02-10 16:40 ` Pavan Nikhilesh Bhagavatula
2024-02-02 8:50 ` [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts pbhagavatula
2024-02-02 8:50 ` [PATCH v3 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-07 20:24 ` Wathsala Wathawana Vithanage
2024-02-02 8:50 ` [PATCH v3 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-10 16:56 ` Honnappa Nagarahalli
2024-02-12 19:21 ` Wathsala Wathawana Vithanage
2024-02-06 4:10 ` [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts Wathsala Wathawana Vithanage
2024-02-06 4:44 ` Honnappa Nagarahalli
2024-02-06 10:21 ` Pavan Nikhilesh Bhagavatula
2024-02-07 0:01 ` Wathsala Wathawana Vithanage
2024-02-10 6:49 ` Pavan Nikhilesh Bhagavatula
2024-02-10 15:20 ` Honnappa Nagarahalli
2024-02-10 17:21 ` Honnappa Nagarahalli
2024-02-21 20:20 ` [PATCH v4 " pbhagavatula
2024-02-21 20:20 ` [PATCH v4 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-22 10:47 ` Juraj Linkeš
2024-02-22 12:32 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-21 20:20 ` [PATCH v4 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-22 9:37 ` [PATCH v4 1/3] config/arm: avoid mcpu and march conflicts Juraj Linkeš
2024-02-22 9:49 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-22 12:45 ` [PATCH v5 " pbhagavatula
2024-02-22 12:45 ` [PATCH v5 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-23 11:49 ` Juraj Linkeš
2024-02-26 7:11 ` [EXT] " Pavan Nikhilesh Bhagavatula
2024-02-26 7:31 ` Juraj Linkeš
2024-02-26 7:34 ` Juraj Linkeš
2024-02-22 12:45 ` [PATCH v5 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-02-23 11:19 ` [PATCH v5 1/3] config/arm: avoid mcpu and march conflicts Juraj Linkeš
2024-02-26 7:08 ` Pavan Nikhilesh Bhagavatula [this message]
2024-02-26 7:38 ` [PATCH v6 " pbhagavatula
2024-02-26 7:38 ` [PATCH v6 2/3] config/arm: add support for fallback march pbhagavatula
2024-02-26 7:38 ` [PATCH v6 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-03-06 15:49 ` [PATCH v7 1/3] config/arm: avoid mcpu and march conflicts pbhagavatula
2024-03-06 15:49 ` [PATCH v7 2/3] config/arm: add support for fallback march pbhagavatula
2024-03-06 15:49 ` [PATCH v7 3/3] config/arm: allow WFE to be enabled config time pbhagavatula
2024-03-07 3:57 ` [PATCH v7 1/3] config/arm: avoid mcpu and march conflicts Pavan Nikhilesh Bhagavatula
2024-03-14 11:38 ` [PATCH v8 1/5] " pbhagavatula
2024-03-14 11:38 ` [PATCH v8 2/5] config/arm: add armv9-a march support pbhagavatula
2024-03-14 11:38 ` [PATCH v8 3/5] config/arm: add crypto march feature to thunderxt83 pbhagavatula
2024-03-14 12:00 ` Jerin Jacob
2024-03-14 11:38 ` [PATCH v8 4/5] config/arm: add support for fallback march pbhagavatula
2024-03-14 11:38 ` [PATCH v8 5/5] config/arm: allow WFE to be enabled config time pbhagavatula
2024-03-15 11:17 ` [PATCH v8 1/5] config/arm: avoid mcpu and march conflicts Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB40860F033FD0D89C3D9F8626DE5A2@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).