DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Shijith Thotton <sthotton@marvell.com>,
	 "abdullah.sevincer@intel.com" <abdullah.sevincer@intel.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>,
	"harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
	"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
	"liangma@liangbit.com" <liangma@liangbit.com>,
	"peter.mccarthy@intel.com" <peter.mccarthy@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXTERNAL] Re: [PATCH v5 0/6] Introduce event pre-scheduling
Date: Fri, 4 Oct 2024 16:50:07 +0000	[thread overview]
Message-ID: <PH0PR18MB408615F7B8D1037FF8357638DE722@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20241004093500.4826372a@hermes.local>

> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Event pre-scheduling improves scheduling performance by assigning events
> > to event ports in advance when dequeues are issued.
> > This series introduces various types and levels of pre-scheduling to the
> > eventdev library.
> >
> > pre-scheduling Types:
> >  * RTE_EVENT_PRESCHEDULE_NONE: No pre-scheduling.
> >  * RTE_EVENT_PRESCHEDULE: Always issue a pre-schedule when dequeue is
> issued.
> >  * RTE_EVENT_PRESCHEDULE_ADAPTIVE: Delay issuing pre-schedule until
> there
> >    are no forward progress constraints with the held flow contexts.
> >
> > pre-scheduling Levels:
> >  * Event Device Level Pre-scheduling: Pre-scheduling can be enabled or
> disabled at the
> >    event device during configuration. Event devices can indicate pre-
> scheduling
> >    capabilities using `RTE_EVENT_DEV_CAP_EVENT_PRESCHEDULE` and
> >   `RTE_EVENT_DEV_CAP_EVENT_PRESCHEDULE_ADAPTIVE` via the event
> device info
> >   function `info.event_dev_cap`.
> >  * Event Port Level Prefetch: Pre-scheduling can be selectively enabled or
> disabled
> >    at the event port during runtime. Event devices can indicate this capability
> >    using `RTE_EVENT_PORT_CAP_PER_PORT_PRESCHEDULE` via the event
> device info
> >    function `info.event_port_cap`.
> >  * Application Controlled Prefetch Hint: Applications can provide hints to the
> >    event device to start pre-scheduling events using the new API
> >    `rte_event_port_pre-schedule`. Event devices can indicate this capabilities
> using
> >    `RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT` via the event device info
> function
> >    `info.event_dev_cap`.
> >
> > The rte_event_dequeue_burst operation initiates the pre-schedule
> operation, which
> > completes in parallel without affecting the flow context of the dequeued
> events and
> > dequeue latency. On the next dequeue operation, the pre-scheduleed events
> are
> > dequeued, and pre-schedule operation is initiated again.
> >
> > In the case of application-controlled pre-schedule hints, the currently held
> flow
> > contexts, if any, are not affected by the pre-schedule operation. On the next
> > dequeue operation, the pre-scheduleed events are returned, but pre-
> schedule is not
> > initiated again until the application provides the hint again. If pre-scheduling
> > is already enabled at the event device level or event port level, the hint is
> ignored.
> >
> > v2 Changes:
> > - s/prefetch/pre-schedule (Mattias).
> > v3 Changes:
> > - Add CNXK preschedule implementation.
> > - Update test-eventdev to use prescheduling.
> > - Update examples to use prescheduling.
> > v4 Changes:
> > - Fix compilation.
> > v5 Changes:
> > - Update ABI changes
> > - s/RTE_EVENT_DEV_PRESCHEDULE/RTE_EVENT_PRESCHEDULE/
> > -
> s/RTE_EVENT_DEV_CAP_SW_PRESCHEDULE/RTE_EVENT_DEV_CAP_PRESCHE
> DULE_EXPLICIT/
> > -
> s/RTE_EVENT_PORT_CAP_EVENT_PER_PORT_PRESCHEDULE/RTE_EVENT_PO
> RT_CAP_PER_PORT_PRESCHEDULE
> > - Various documentation fixes and updates.
> >
> >
> > Pavan Nikhilesh (6):
> >   eventdev: introduce event pre-scheduling
> >   eventdev: add event port pre-schedule modify
> >   eventdev: add event preschedule hint
> >   event/cnkx: add pre-schedule support
> >   app/test-eventdev: add pre-scheduling support
> >   examples: use eventdev pre-scheduling
> >
> >  app/test-eventdev/evt_common.h                |  45 +++--
> >  app/test-eventdev/evt_options.c               |  17 ++
> >  app/test-eventdev/evt_options.h               |   1 +
> >  app/test/test_eventdev.c                      | 143 ++++++++++++++++
> >  doc/guides/eventdevs/cnxk.rst                 |  10 --
> >  doc/guides/eventdevs/features/cnxk.ini        |   1 +
> >  doc/guides/eventdevs/features/default.ini     |   1 +
> >  doc/guides/prog_guide/eventdev/eventdev.rst   |  48 ++++++
> >  doc/guides/rel_notes/release_24_11.rst        |  13 ++
> >  doc/guides/tools/testeventdev.rst             |   6 +
> >  drivers/event/cnxk/cn10k_eventdev.c           |  19 ++-
> >  drivers/event/cnxk/cn10k_worker.c             |  21 +++
> >  drivers/event/cnxk/cn10k_worker.h             |   2 +
> >  drivers/event/cnxk/cnxk_eventdev.c            |   2 -
> >  drivers/event/cnxk/cnxk_eventdev.h            |   1 -
> >  .../pipeline_worker_generic.c                 |   6 +
> >  .../eventdev_pipeline/pipeline_worker_tx.c    |   6 +
> >  examples/ipsec-secgw/event_helper.c           |   6 +
> >  examples/l2fwd-event/l2fwd_event_generic.c    |   6 +
> >  .../l2fwd-event/l2fwd_event_internal_port.c   |   6 +
> >  examples/l3fwd/l3fwd_event_generic.c          |   6 +
> >  examples/l3fwd/l3fwd_event_internal_port.c    |   6 +
> >  lib/eventdev/eventdev_pmd.h                   |   4 +
> >  lib/eventdev/eventdev_private.c               |  41 ++++-
> >  lib/eventdev/eventdev_trace_points.c          |   6 +
> >  lib/eventdev/rte_eventdev.h                   | 159 ++++++++++++++++++
> >  lib/eventdev/rte_eventdev_core.h              |  14 +-
> >  lib/eventdev/rte_eventdev_trace_fp.h          |  19 ++-
> >  lib/eventdev/version.map                      |   6 +
> >  29 files changed, 592 insertions(+), 29 deletions(-)
> 
> Looks good, but the new API's should be experimental right?

Ah yes, my bad, Thanks Stephen, I will mark them as experimental in next version.

      reply	other threads:[~2024-10-04 16:50 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10  8:31 [RFC 0/3] Introduce event prefetching pbhagavatula
2024-09-10  8:31 ` [RFC 1/3] eventdev: introduce " pbhagavatula
2024-09-10  8:31 ` [RFC 2/3] eventdev: allow event ports to modified prefetches pbhagavatula
2024-09-10  8:31 ` [RFC 3/3] eventdev: add SW event prefetch hint pbhagavatula
2024-09-10  9:08 ` [RFC 0/3] Introduce event prefetching Mattias Rönnblom
2024-09-10 11:53   ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-09-17  7:11 ` [PATCH v2 0/3] Introduce event pre-scheduling pbhagavatula
2024-09-17  7:11   ` [PATCH v2 1/3] eventdev: introduce " pbhagavatula
2024-09-18 22:38     ` Pathak, Pravin
2024-09-19 13:13       ` Pavan Nikhilesh Bhagavatula
2024-09-23  8:57         ` Mattias Rönnblom
2024-09-25 10:30           ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-09-26  2:54             ` Pathak, Pravin
2024-09-26 10:03               ` Pavan Nikhilesh Bhagavatula
2024-09-27  3:31                 ` Pathak, Pravin
2024-09-17  7:11   ` [PATCH v2 2/3] eventdev: add event port pre-schedule modify pbhagavatula
2024-09-17  7:11   ` [PATCH v2 3/3] eventdev: add SW event preschedule hint pbhagavatula
2024-10-01  6:14   ` [PATCH v3 0/6] Introduce event pre-scheduling pbhagavatula
2024-10-01  6:14     ` [PATCH v3 1/6] eventdev: introduce " pbhagavatula
2024-10-01  6:14     ` [PATCH v3 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-01  6:14     ` [PATCH v3 3/6] eventdev: add SW event preschedule hint pbhagavatula
2024-10-01  6:14     ` [PATCH v3 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-01  6:14     ` [PATCH v3 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-01  6:14     ` [PATCH v3 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-01 13:18     ` [PATCH v4 0/6] Introduce event pre-scheduling pbhagavatula
2024-10-01 13:18       ` [PATCH v4 1/6] eventdev: introduce " pbhagavatula
2024-10-04  4:47         ` Jerin Jacob
2024-10-01 13:18       ` [PATCH v4 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-04  5:02         ` Jerin Jacob
2024-10-01 13:18       ` [PATCH v4 3/6] eventdev: add SW event preschedule hint pbhagavatula
2024-10-04  5:14         ` Jerin Jacob
2024-10-01 13:18       ` [PATCH v4 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-01 13:19       ` [PATCH v4 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-01 13:19       ` [PATCH v4 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-01 15:33       ` [PATCH v4 0/6] Introduce event pre-scheduling Stephen Hemminger
2024-10-03  5:46         ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-04 16:24       ` [PATCH v5 " pbhagavatula
2024-10-04 16:24         ` [PATCH v5 1/6] eventdev: introduce " pbhagavatula
2024-10-04 16:24         ` [PATCH v5 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-04 16:24         ` [PATCH v5 3/6] eventdev: add event preschedule hint pbhagavatula
2024-10-04 16:24         ` [PATCH v5 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-04 16:24         ` [PATCH v5 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-04 16:24         ` [PATCH v5 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-04 16:35         ` [PATCH v5 0/6] Introduce event pre-scheduling Stephen Hemminger
2024-10-04 16:50           ` Pavan Nikhilesh Bhagavatula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB408615F7B8D1037FF8357638DE722@PH0PR18MB4086.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=abdullah.sevincer@intel.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=liangma@liangbit.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=peter.mccarthy@intel.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=stephen@networkplumber.org \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).