From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1729EA034F; Wed, 31 Mar 2021 08:40:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F02B4069E; Wed, 31 Mar 2021 08:40:22 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id E1FE040141 for ; Wed, 31 Mar 2021 08:40:20 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12V6L4qn006361; Tue, 30 Mar 2021 23:40:20 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by mx0b-0016f401.pphosted.com with ESMTP id 37ma9w1dca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Mar 2021 23:40:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kfq0p5UKLyIL0cqpYAE3DXm6fFbs7nZGQobSD2K/A7My+JfWVGu1OGCvs22LVCAE1LIGNv5OXqiw69t/6A7BlkcqOxrdafPYzHOLZbb5ipqujO07+vSrGcQcFMaBjyemw5SAe/rbpp6lGYCYd6Eaf049wTPcrVKBmlW62z2NkyN+shRMb35CRDQcWcAJ0t4q1cMM59PfcNvuM0mmmp1pYBy4vZj6L5YqhxpdF2wvzkbKdjfUjJYR0NAsOpof8Z9MKpWLsN7gqN0SiYkNTG5O0Nt3XcB63NDa1QilaWVELkTrB/NeUuSc6RCzIMg5bnwWlK4irgwRdrSy02MoO2uSDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4tFOaLhzCbFM/jt2IrjW68ldSDr0J2nVerP4GAM1Yo=; b=S2kj9MMMFdtzyFrj/7kv6kDNFLix70Ag8TjdqCCHM1H8gmLbDndeZkD4NlkBzIUjrvdWwZ5XyLgIuszZgr8LkR8gJP4YoquLXW8VcmH6N6W+DVqYHYpa8A/D+FmqIaR51xZVkyz0eDjplT3UXjzG7C9CwGOTQ9CLVyjNbdC648nGau0c6cDlRSFiBnTqxKNqTD+9nsI6uZMb7I4Ic/QNxGd6jJz9rOmm4+zHDwyUB/IO+6I/jNXnG2lt8ea8noropG20X/Lkj2MMkZbHXQjMCtkK5NMr1fiMeiXa/q8HzJpNF5lSf4uasyz4Lr6XNLwcSSZGp4HQFEXQ/bwLGFG0NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t4tFOaLhzCbFM/jt2IrjW68ldSDr0J2nVerP4GAM1Yo=; b=AyuGtOWNyjMra//42zUTkcUaRu81jQ9I7tYXZbTHNPRyzLg/gZ/ZWa3zLxwlor2ccip5pxioQLijiIAZTb20O7UYvb/daGcDV/F7ve5dXPR6raOs8gxP6U8Fw1cW7wmLt0KsGK13Sh6+lpTjkvxSXppd/Lce8bMbfdZF/5uBpi4= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by PH0PR18MB3798.namprd18.prod.outlook.com (2603:10b6:510:24::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Wed, 31 Mar 2021 06:40:18 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::79fe:d64:bdf1:d85e]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::79fe:d64:bdf1:d85e%5]) with mapi id 15.20.3999.027; Wed, 31 Mar 2021 06:40:18 +0000 From: Pavan Nikhilesh Bhagavatula To: "Jayatheerthan, Jay" , Jerin Jacob Kollanukkaran , "Carrillo, Erik G" , "Gujjar, Abhinandan S" , "McDaniel, Timothy" , "hemant.agrawal@nxp.com" , "Van Haaren, Harry" , mattias.ronnblom , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support Thread-Index: AQHXJT3eIjewR20knUWcZ3Z0HJ6zMaqdpZEAgAAAR2A= Date: Wed, 31 Mar 2021 06:40:18 +0000 Message-ID: References: <20210326140850.7332-1-pbhagavatula@marvell.com> <20210330082212.707-1-pbhagavatula@marvell.com> <20210330082212.707-5-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2405:201:d009:304d:345d:621d:1802:dddc] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0405b4a-aa89-4afd-70e0-08d8f40fd97c x-ms-traffictypediagnostic: PH0PR18MB3798: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dBA04MlsxKjaMz7kkhat6Sym7Uj5WkZp3wXtdtcOfdlM9RckaE2C1P/pOAwiJn+KJDMdB3CAwWEdZDBHrXe2G//rk8GrSgr7XFOQKzjjtllOF93kS1fMzcAzb3Od797UvszkcwbPztRZ1Aqay/xQaOr2UE2RmnRzqrqzijEFr4sticcl53IQOO5pSGtbcxfcD0Wu2olQV4b4CjWNuXg1HMQ9VdMnW1y2r7jRlgRBqm1tJNh7dPgp1cgt5nP8sRNtb+zYnd0fNO+JyAPMIEhriC7PtD1GmGNmpmJRZiQKAA0W4ICCgYqBsL0o2cU8X1x5mN+e2UHyf+5q36O3fYl441d+N1FGbtipJxgSat3CpgKpG+o9mLvOVdtVbDXwBn4t/tvIcLoTG1gG2WppBa9wmtv/zojIgot8IHV132fxgmdaH/C1PXCipd3elIXQqElaRiGgvMZsm+jOh4DUOz7O7md95unbIQGfpu77bs4TFOM809oPV11Cd+Pd615KowGrtQhy39FTliAxU1wFBmrGmPUurCQQIgPWjzj8+yX0DQfztcamfUQjJE9SVRLkrv0pJEEcdZ4gHSqFBi3W2Pgn51yC59jSIEbjndKJdKe+pZ2nP2O4qVSfU+cPGZwO5nwqnEhetIzeYb45tE9sdQ78Y2vy53XzjgKsMXic9ZohY8AnCiZP57azvx19+xFxFJv5 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(30864003)(6506007)(8676002)(38100700001)(52536014)(53546011)(83380400001)(5660300002)(4326008)(186003)(71200400001)(8936002)(110136005)(2906002)(55016002)(33656002)(64756008)(66446008)(76116006)(66476007)(66946007)(316002)(66556008)(86362001)(478600001)(7696005)(9686003)(921005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Bre2b6Txrxlniq3ii0OrULC83uyheXDtFxcEZ1N+XlcwAK61Zs2Qbkjgu5AU?= =?us-ascii?Q?LnzTJYiTkbkHEYEsq+5dRMkQfgrWIPgNjXKeS6jJ5SWY+8kS/3IOTCVmJkG4?= =?us-ascii?Q?9BCqLHZ+c0fthBkDiTzx3cnUZxc3MufWDC15JPhUvC+90mI/7s7HP042awjj?= =?us-ascii?Q?utSIEbx955QTJe1j6a+L5ztwFw0gmtOph96u7VV5LLHf7b8AHpGxc4XJyblv?= =?us-ascii?Q?NE07hbPT2Dvdovj/e79nRxZnKEWlx3bJzXU2ao7MZNESSIRqibzZyi73z7T1?= =?us-ascii?Q?xCQGRhQhIOht+GqlrAfLbIf+5oTYFMs5N/Fi7pGgdqn5yMl/J6skBUb9UGeu?= =?us-ascii?Q?9Na+rrbwB4z/3Nz8IKblSISlGaobLdY5bRmuGgPxTNWroCQ2/bI5Ki57F3Gl?= =?us-ascii?Q?F2nDzVLQHaWqMPdHdgG4VOQHy244Z9T50KHxhkuNANZAmNtSR0tq3jk8vwX1?= =?us-ascii?Q?7Cq78GwNmPfSzbs5iQLvYeSBxurerl/2pJzWIfpvPuZR/nOZWg+BRZ3njGm7?= =?us-ascii?Q?7vhsD9W4fB2+jff1B1AyUCZ4ZCIlVRNp0QgD5tS4NNapZrpWbOSRV5FmB9Bp?= =?us-ascii?Q?6eZj7AYGHoPFpA8cAgLJdZUnrj+GOmHBk5B5R3YSHNdc1LtphhSGSYhtG69t?= =?us-ascii?Q?mnjZA0LrCPeDGtChgreZvxZNOzWVLWJExAhsE36mfvHjVshNeApEGcXeh4kQ?= =?us-ascii?Q?EzqWaSW6CRookosdfUCbV2caF6+ShJNZLBsEd+im3S8sEnHjD5WBHJw4+nML?= =?us-ascii?Q?kInzMCTyASS89xEhAB4fnZZXGMVlBhZ96kvdS6wzs3dOSt5HEuIFeMGQWFZp?= =?us-ascii?Q?bt9zEXbssl36dQfqZ+n5GAQqR7YkohvdD9rdSMj1U8fZ3QEcx3tsEk4zyO4f?= =?us-ascii?Q?6kMFIBdiIT397xdkEnWPoY5iGYRHdzrv7zeBEimFq3aphOtSie49aK+oddmg?= =?us-ascii?Q?FSL7KreL59DL+2yIq3/W2QsrzPATqxYWnprnpvfTmoj4Cfh5Gps8uGYtkZGZ?= =?us-ascii?Q?zeSgGB91v29ZM3f4uHfElwNBLihJGpVPtnPMTC1itcjkPRu8jqELkpoUPQzy?= =?us-ascii?Q?MlxeJHAn0+tyY68uprtqTCUuZzkWejO/nBmWjKhvdPpWrvrqWghXlhXHbl9i?= =?us-ascii?Q?eZYDYD3jXv42dnHyMSB8HErov54QagplpIFriThO8ereM3vhcwFOmaRvrbM9?= =?us-ascii?Q?WDHlEYL38keezidzqCQx6O+wgTnCja6e8Foqx91Nn/2Ky8qG18Pr4ojNbO0Z?= =?us-ascii?Q?so3wQwbmaM4MW/3ZJmVphIO9xsxS42GlP4uVVjhjsOl9lUuRr7CQc8ykAEWO?= =?us-ascii?Q?Ue5V7AbPnXC56SndLqe3lznNGMvU1gTDmX0ozRIr48wFTcmz23cZfZgdW/t5?= =?us-ascii?Q?TvIQOAUx0GL1oLWaP72z9MYLYr+n?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0405b4a-aa89-4afd-70e0-08d8f40fd97c X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2021 06:40:18.1929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cFWk4vpePvimGdb+04bBW7cKoHj84uDmvDFxn/LB1YbMCbGPCJLqtIgieULbzA7K9ZJUexbdzyVMtemrFX1hCCzsQtTQvYaRZ+DCv7Z8MYw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3798 X-Proofpoint-GUID: t0csSinjLj5ka9ASz1-n0WraSyQPiBzi X-Proofpoint-ORIG-GUID: t0csSinjLj5ka9ASz1-n0WraSyQPiBzi X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-31_01:2021-03-30, 2021-03-31 signatures=0 Subject: Re: [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> -----Original Message----- >> From: pbhagavatula@marvell.com >> Sent: Tuesday, March 30, 2021 1:52 PM >> To: jerinj@marvell.com; Jayatheerthan, Jay >; Carrillo, Erik G >; Gujjar, >> Abhinandan S ; McDaniel, Timothy >; hemant.agrawal@nxp.com; Van >> Haaren, Harry ; mattias.ronnblom >; Ma, Liang J >> >> Cc: dev@dpdk.org; Pavan Nikhilesh >> Subject: [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event >vector support >> >> From: Pavan Nikhilesh >> >> Add event vector support for event eth Rx adapter, the >implementation >> creates vector flows based on port and queue identifier of the >received >> mbufs. >> The flow id for SW Rx event vectorization will use 12-bits of queue >> identifier and 8-bits port identifier when custom flow id is not set >> for simplicity. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> .../prog_guide/event_ethernet_rx_adapter.rst | 11 + >> lib/librte_eventdev/eventdev_pmd.h | 7 +- >> .../rte_event_eth_rx_adapter.c | 278 ++++++++++++++++-- >> lib/librte_eventdev/rte_eventdev.c | 6 +- >> 4 files changed, 278 insertions(+), 24 deletions(-) >> >> diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >> index 5eefef355..06fa864fa 100644 >> --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >> +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >> @@ -224,3 +224,14 @@ A loop processing ``rte_event_vector`` >containing mbufs is shown below. >> case ... >> ... >> } >> + >> +Rx event vectorization for SW Rx adapter >> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> + >> +For SW based event vectorization, i.e., when the >> +``RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT`` is not set >in the adapter's >> +capabilities flags for a particular ethernet device, the service >function >> +creates a single event vector flow for all the mbufs arriving on the >given >> +Rx queue. >> +The 20-bit event flow identifier is set to 12-bits of Rx queue identifi= er >> +and 8-bits of ethernet device identifier. >> diff --git a/lib/librte_eventdev/eventdev_pmd.h >b/lib/librte_eventdev/eventdev_pmd.h >> index 9297f1433..0f724ac85 100644 >> --- a/lib/librte_eventdev/eventdev_pmd.h >> +++ b/lib/librte_eventdev/eventdev_pmd.h >> @@ -69,9 +69,10 @@ extern "C" { >> } \ >> } while (0) >> >> -#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \ >> - > ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | >\ >> - > (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ)) >> +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP >\ >> + ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | >\ >> + (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ) | >\ >> + (RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR)) >> >> #define RTE_EVENT_CRYPTO_ADAPTER_SW_CAP \ >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA >> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c >b/lib/librte_eventdev/rte_event_eth_rx_adapter.c >> index ac8ba5bf0..e273b3acf 100644 >> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c >> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c >> @@ -26,6 +26,10 @@ >> #define BATCH_SIZE 32 >> #define BLOCK_CNT_THRESHOLD 10 >> #define ETH_EVENT_BUFFER_SIZE (4*BATCH_SIZE) >> +#define MAX_VECTOR_SIZE 1024 >> +#define MIN_VECTOR_SIZE 4 >> +#define MAX_VECTOR_NS 1E9 >> +#define MIN_VECTOR_NS 1E5 >> >> #define ETH_RX_ADAPTER_SERVICE_NAME_LEN 32 >> #define ETH_RX_ADAPTER_MEM_NAME_LEN 32 >> @@ -59,6 +63,20 @@ struct eth_rx_poll_entry { >> uint16_t eth_rx_qid; >> }; >> >> +struct eth_rx_vector_data { >> + TAILQ_ENTRY(eth_rx_vector_data) next; >> + uint16_t port; >> + uint16_t queue; >> + uint16_t max_vector_count; >> + uint64_t event; >> + uint64_t ts; >> + uint64_t vector_timeout_ticks; >> + struct rte_mempool *vector_pool; >> + struct rte_event_vector *vector_ev; >> +} __rte_cache_aligned; >> + >> +TAILQ_HEAD(eth_rx_vector_data_list, eth_rx_vector_data); >> + >> /* Instance per adapter */ >> struct rte_eth_event_enqueue_buffer { >> /* Count of events in this buffer */ >> @@ -92,6 +110,14 @@ struct rte_event_eth_rx_adapter { >> uint32_t wrr_pos; >> /* Event burst buffer */ >> struct rte_eth_event_enqueue_buffer event_enqueue_buffer; >> + /* Vector enable flag */ >> + uint8_t ena_vector; >> + /* Timestamp of previous vector expiry list traversal */ >> + uint64_t prev_expiry_ts; >> + /* Minimum ticks to wait before traversing expiry list */ >> + uint64_t vector_tmo_ticks; >> + /* vector list */ >> + struct eth_rx_vector_data_list vector_list; >> /* Per adapter stats */ >> struct rte_event_eth_rx_adapter_stats stats; >> /* Block count, counts up to BLOCK_CNT_THRESHOLD */ >> @@ -198,9 +224,11 @@ struct eth_device_info { >> struct eth_rx_queue_info { >> int queue_enabled; /* True if added */ >> int intr_enabled; >> + uint8_t ena_vector; >> uint16_t wt; /* Polling weight */ >> uint32_t flow_id_mask; /* Set to ~0 if app provides flow id else >0 */ >> uint64_t event; >> + struct eth_rx_vector_data vector_data; >> }; >> >> static struct rte_event_eth_rx_adapter **event_eth_rx_adapter; >> @@ -722,6 +750,9 @@ rxa_flush_event_buffer(struct >rte_event_eth_rx_adapter *rx_adapter) >> &rx_adapter->event_enqueue_buffer; >> struct rte_event_eth_rx_adapter_stats *stats =3D &rx_adapter- >>stats; >> >> + if (!buf->count) >> + return 0; >> + >> uint16_t n =3D rte_event_enqueue_new_burst(rx_adapter- >>eventdev_id, >> rx_adapter->event_port_id, >> buf->events, >> @@ -742,6 +773,77 @@ rxa_flush_event_buffer(struct >rte_event_eth_rx_adapter *rx_adapter) >> return n; >> } >> >> +static inline void >> +rxa_init_vector(struct rte_event_eth_rx_adapter *rx_adapter, >> + struct eth_rx_vector_data *vec) >> +{ >> + vec->vector_ev->nb_elem =3D 0; >> + vec->vector_ev->port =3D vec->port; >> + vec->vector_ev->queue =3D vec->queue; >> + vec->vector_ev->attr_valid =3D true; >> + TAILQ_INSERT_TAIL(&rx_adapter->vector_list, vec, next); >> +} >> + >> +static inline uint16_t >> +rxa_create_event_vector(struct rte_event_eth_rx_adapter >*rx_adapter, >> + struct eth_rx_queue_info *queue_info, >> + struct rte_eth_event_enqueue_buffer *buf, >> + struct rte_mbuf **mbufs, uint16_t num) >> +{ >> + struct rte_event *ev =3D &buf->events[buf->count]; >> + struct eth_rx_vector_data *vec; >> + uint16_t filled, space, sz; >> + >> + filled =3D 0; >> + vec =3D &queue_info->vector_data; >> + >> + if (vec->vector_ev =3D=3D NULL) { >> + if (rte_mempool_get(vec->vector_pool, >> + (void **)&vec->vector_ev) < 0) { >> + rte_pktmbuf_free_bulk(mbufs, num); >> + return 0; >> + } >> + rxa_init_vector(rx_adapter, vec); >> + } >> + while (num) { >> + if (vec->vector_ev->nb_elem =3D=3D vec- >>max_vector_count) { >> + /* Event ready. */ >> + ev->event =3D vec->event; >> + ev->vec =3D vec->vector_ev; >> + ev++; >> + filled++; >> + vec->vector_ev =3D NULL; >> + TAILQ_REMOVE(&rx_adapter->vector_list, vec, >next); >> + if (rte_mempool_get(vec->vector_pool, >> + (void **)&vec->vector_ev) < >0) { >> + rte_pktmbuf_free_bulk(mbufs, num); >> + return 0; >> + } >> + rxa_init_vector(rx_adapter, vec); >> + } >> + >> + space =3D vec->max_vector_count - vec->vector_ev- >>nb_elem; >> + sz =3D num > space ? space : num; >> + memcpy(vec->vector_ev->mbufs + vec->vector_ev- >>nb_elem, mbufs, >> + sizeof(void *) * sz); >> + vec->vector_ev->nb_elem +=3D sz; >> + num -=3D sz; >> + mbufs +=3D sz; >> + vec->ts =3D rte_rdtsc(); >> + } >> + >> + if (vec->vector_ev->nb_elem =3D=3D vec->max_vector_count) { >> + ev->event =3D vec->event; >> + ev->vec =3D vec->vector_ev; >> + ev++; >> + filled++; >> + vec->vector_ev =3D NULL; >> + TAILQ_REMOVE(&rx_adapter->vector_list, vec, next); >> + } >> + >> + return filled; >> +} >> + >> static inline void >> rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_adapter, >> uint16_t eth_dev_id, >> @@ -766,29 +868,33 @@ rxa_buffer_mbufs(struct >rte_event_eth_rx_adapter *rx_adapter, >> uint16_t nb_cb; >> uint16_t dropped; >> >> - /* 0xffff ffff if PKT_RX_RSS_HASH is set, otherwise 0 */ >> - rss_mask =3D ~(((m->ol_flags & PKT_RX_RSS_HASH) !=3D 0) - 1); >> - do_rss =3D !rss_mask && !eth_rx_queue_info->flow_id_mask; >> - >> - for (i =3D 0; i < num; i++) { >> - m =3D mbufs[i]; >> - >> - rss =3D do_rss ? >> - rxa_do_softrss(m, rx_adapter->rss_key_be) : >> - m->hash.rss; >> - ev->event =3D event; >> - ev->flow_id =3D (rss & ~flow_id_mask) | >> - (ev->flow_id & flow_id_mask); >> - ev->mbuf =3D m; >> - ev++; >> + if (!eth_rx_queue_info->ena_vector) { >> + /* 0xffff ffff if PKT_RX_RSS_HASH is set, otherwise 0 */ >> + rss_mask =3D ~(((m->ol_flags & PKT_RX_RSS_HASH) !=3D 0) - >1); >> + do_rss =3D !rss_mask && !eth_rx_queue_info- >>flow_id_mask; >> + for (i =3D 0; i < num; i++) { >> + m =3D mbufs[i]; >> + >> + rss =3D do_rss ? rxa_do_softrss(m, rx_adapter- >>rss_key_be) >> + : m->hash.rss; >> + ev->event =3D event; >> + ev->flow_id =3D (rss & ~flow_id_mask) | >> + (ev->flow_id & flow_id_mask); >> + ev->mbuf =3D m; >> + ev++; >> + } >> + } else { >> + num =3D rxa_create_event_vector(rx_adapter, >eth_rx_queue_info, >> + buf, mbufs, num); >> } >> >> - if (dev_info->cb_fn) { >> + if (num && dev_info->cb_fn) { >> >> dropped =3D 0; >> nb_cb =3D dev_info->cb_fn(eth_dev_id, rx_queue_id, >> - ETH_EVENT_BUFFER_SIZE, buf- >>count, ev, >> - num, dev_info->cb_arg, >&dropped); >> + ETH_EVENT_BUFFER_SIZE, buf- >>count, >> + &buf->events[buf->count], >num, >> + dev_info->cb_arg, &dropped); >> if (unlikely(nb_cb > num)) >> RTE_EDEV_LOG_ERR("Rx CB returned %d (> %d) >events", >> nb_cb, num); >> @@ -1124,6 +1230,30 @@ rxa_poll(struct rte_event_eth_rx_adapter >*rx_adapter) >> return nb_rx; >> } >> >> +static void >> +rxa_vector_expire(struct eth_rx_vector_data *vec, void *arg) >> +{ >> + struct rte_event_eth_rx_adapter *rx_adapter =3D arg; >> + struct rte_eth_event_enqueue_buffer *buf =3D >> + &rx_adapter->event_enqueue_buffer; >> + struct rte_event *ev; >> + >> + if (buf->count) >> + rxa_flush_event_buffer(rx_adapter); >> + >> + if (vec->vector_ev->nb_elem =3D=3D 0) >> + return; >> + ev =3D &buf->events[buf->count]; >> + >> + /* Event ready. */ >> + ev->event =3D vec->event; >> + ev->vec =3D vec->vector_ev; >> + buf->count++; >> + >> + vec->vector_ev =3D NULL; >> + vec->ts =3D 0; >> +} >> + >> static int >> rxa_service_func(void *args) >> { >> @@ -1137,6 +1267,24 @@ rxa_service_func(void *args) >> return 0; >> } >> >> + if (rx_adapter->ena_vector) { >> + if ((rte_rdtsc() - rx_adapter->prev_expiry_ts) >=3D >> + rx_adapter->vector_tmo_ticks) { >> + struct eth_rx_vector_data *vec; >> + >> + TAILQ_FOREACH(vec, &rx_adapter->vector_list, >next) { >> + uint64_t elapsed_time =3D rte_rdtsc() - >vec->ts; >> + >> + if (elapsed_time >=3D vec- >>vector_timeout_ticks) { >> + rxa_vector_expire(vec, >rx_adapter); >> + TAILQ_REMOVE(&rx_adapter- >>vector_list, >> + vec, next); >> + } >> + } >> + rx_adapter->prev_expiry_ts =3D rte_rdtsc(); >> + } >> + } >> + >> stats =3D &rx_adapter->stats; >> stats->rx_packets +=3D rxa_intr_ring_dequeue(rx_adapter); >> stats->rx_packets +=3D rxa_poll(rx_adapter); >> @@ -1640,11 +1788,35 @@ rxa_update_queue(struct >rte_event_eth_rx_adapter *rx_adapter, >> } >> } >> >> +static void >> +rxa_set_vector_data(struct eth_rx_queue_info *queue_info, >uint16_t vector_count, >> + uint64_t vector_ns, struct rte_mempool *mp, int32_t >qid, >> + uint16_t port_id) >> +{ >> +#define NSEC2TICK(__ns, __freq) (((__ns) * (__freq)) / 1E9) >> + struct eth_rx_vector_data *vector_data; >> + uint32_t flow_id; >> + >> + vector_data =3D &queue_info->vector_data; >> + vector_data->max_vector_count =3D vector_count; >> + vector_data->port =3D port_id; >> + vector_data->queue =3D qid; >> + vector_data->vector_pool =3D mp; >> + vector_data->vector_timeout_ticks =3D >> + NSEC2TICK(vector_ns, rte_get_timer_hz()); >> + vector_data->ts =3D 0; >> + flow_id =3D queue_info->event & 0xFFFFF; >> + flow_id =3D >> + flow_id =3D=3D 0 ? (qid & 0xFFF) | (port_id & 0xFF) << 12 : >flow_id; >> + vector_data->event =3D (queue_info->event & ~0xFFFFF) | >flow_id; >> +} >> + >> static void >> rxa_sw_del(struct rte_event_eth_rx_adapter *rx_adapter, >> struct eth_device_info *dev_info, >> int32_t rx_queue_id) >> { >> + struct eth_rx_vector_data *vec; >> int pollq; >> int intrq; >> int sintrq; >> @@ -1663,6 +1835,14 @@ rxa_sw_del(struct >rte_event_eth_rx_adapter *rx_adapter, >> return; >> } >> >> + /* Push all the partial event vectors to event device. */ >> + TAILQ_FOREACH(vec, &rx_adapter->vector_list, next) { >> + if (vec->queue !=3D rx_queue_id) >> + continue; >> + rxa_vector_expire(vec, rx_adapter); >> + TAILQ_REMOVE(&rx_adapter->vector_list, vec, next); >> + } >> + > >We are doing packet related activity (rxa_flush_event_buffer()) outside >of rxa_service_func() although it wouldn't be running since queue del >code has the lock. It would also be done in the context of a control >thread. I don't know if there is a precedence for this. What do you think >of just freeing the vector data and mbufs ? Since we are just enqueueing to event device it should work fine. The teardown sequence for event devices is to quiesce all producers first and finally the event device. This will make sure that the packets get handled properly with the stop=20 callback registered through `rte_event_dev_stop_flush_callback_register`.=20 > >> pollq =3D rxa_polled_queue(dev_info, rx_queue_id); >> intrq =3D rxa_intr_queue(dev_info, rx_queue_id); >> sintrq =3D rxa_shared_intr(dev_info, rx_queue_id); >> @@ -1741,6 +1921,42 @@ rxa_add_queue(struct >rte_event_eth_rx_adapter *rx_adapter, >> } >> } >> >> +static void >> +rxa_sw_event_vector_configure( >> + struct rte_event_eth_rx_adapter *rx_adapter, uint16_t >eth_dev_id, >> + int rx_queue_id, >> + const struct rte_event_eth_rx_adapter_event_vector_config >*config) >> +{ >> + struct eth_device_info *dev_info =3D &rx_adapter- >>eth_devices[eth_dev_id]; >> + struct eth_rx_queue_info *queue_info; >> + struct rte_event *qi_ev; >> + >> + if (rx_queue_id =3D=3D -1) { >> + uint16_t nb_rx_queues; >> + uint16_t i; >> + >> + nb_rx_queues =3D dev_info->dev->data->nb_rx_queues; >> + for (i =3D 0; i < nb_rx_queues; i++) >> + rxa_sw_event_vector_configure(rx_adapter, >eth_dev_id, i, >> + config); >> + return; >> + } >> + >> + queue_info =3D &dev_info->rx_queue[rx_queue_id]; >> + qi_ev =3D (struct rte_event *)&queue_info->event; >> + queue_info->ena_vector =3D 1; >> + qi_ev->event_type =3D >RTE_EVENT_TYPE_ETH_RX_ADAPTER_VECTOR; >> + rxa_set_vector_data(queue_info, config->vector_sz, >> + config->vector_timeout_ns, config- >>vector_mp, >> + rx_queue_id, dev_info->dev->data->port_id); >> + rx_adapter->ena_vector =3D 1; >> + rx_adapter->vector_tmo_ticks =3D >> + rx_adapter->vector_tmo_ticks ? >> + RTE_MIN(config->vector_timeout_ns >> 1, >> + rx_adapter->vector_tmo_ticks) : >> + config->vector_timeout_ns >> 1; >> +} >> + >> static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter, >> uint16_t eth_dev_id, >> int rx_queue_id, >> @@ -1967,6 +2183,7 @@ >rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, >> rx_adapter->conf_cb =3D conf_cb; >> rx_adapter->conf_arg =3D conf_arg; >> rx_adapter->id =3D id; >> + TAILQ_INIT(&rx_adapter->vector_list); >> strcpy(rx_adapter->mem_name, mem_name); >> rx_adapter->eth_devices =3D rte_zmalloc_socket(rx_adapter- >>mem_name, >> RTE_MAX_ETHPORTS * >> @@ -2081,6 +2298,15 @@ >rte_event_eth_rx_adapter_queue_add(uint8_t id, >> return -EINVAL; >> } >> >> + if ((cap & >RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR) =3D=3D 0 && >> + (queue_conf->rx_queue_flags & >> + RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR)) { >> + RTE_EDEV_LOG_ERR("Event vectorization is not >supported," >> + " eth port: %" PRIu16 " adapter id: %" >PRIu8, >> + eth_dev_id, id); >> + return -EINVAL; >> + } >> + >> if ((cap & >RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ) =3D=3D 0 && >> (rx_queue_id !=3D -1)) { >> RTE_EDEV_LOG_ERR("Rx queues can only be connected >to single " >> @@ -2143,6 +2369,17 @@ >rte_event_eth_rx_adapter_queue_add(uint8_t id, >> return 0; >> } >> >> +static int >> +rxa_sw_vector_limits(struct >rte_event_eth_rx_adapter_vector_limits *limits) >> +{ >> + limits->max_sz =3D MAX_VECTOR_SIZE; >> + limits->min_sz =3D MIN_VECTOR_SIZE; >> + limits->max_timeout_ns =3D MAX_VECTOR_NS; >> + limits->min_timeout_ns =3D MIN_VECTOR_NS; >> + >> + return 0; >> +} >> + >> int >> rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t >eth_dev_id, >> int32_t rx_queue_id) >> @@ -2333,7 +2570,8 @@ >rte_event_eth_rx_adapter_queue_event_vector_config( >> ret =3D dev->dev_ops- >>eth_rx_adapter_event_vector_config( >> dev, &rte_eth_devices[eth_dev_id], >rx_queue_id, config); >> } else { >> - ret =3D -ENOTSUP; >> + rxa_sw_event_vector_configure(rx_adapter, >eth_dev_id, >> + rx_queue_id, config); >> } >> >> return ret; >> @@ -2371,7 +2609,7 @@ >rte_event_eth_rx_adapter_vector_limits_get( >> ret =3D dev->dev_ops- >>eth_rx_adapter_vector_limits_get( >> dev, &rte_eth_devices[eth_port_id], limits); >> } else { >> - ret =3D -ENOTSUP; >> + ret =3D rxa_sw_vector_limits(limits); >> } >> >> return ret; >> diff --git a/lib/librte_eventdev/rte_eventdev.c >b/lib/librte_eventdev/rte_eventdev.c >> index be0499c52..62824654b 100644 >> --- a/lib/librte_eventdev/rte_eventdev.c >> +++ b/lib/librte_eventdev/rte_eventdev.c >> @@ -122,7 +122,11 @@ rte_event_eth_rx_adapter_caps_get(uint8_t >dev_id, uint16_t eth_port_id, >> >> if (caps =3D=3D NULL) >> return -EINVAL; >> - *caps =3D 0; >> + >> + if (dev->dev_ops->eth_rx_adapter_caps_get =3D=3D NULL) >> + *caps =3D RTE_EVENT_ETH_RX_ADAPTER_SW_CAP; >> + else >> + *caps =3D 0; >> >> return dev->dev_ops->eth_rx_adapter_caps_get ? >> (*dev->dev_ops- >>eth_rx_adapter_caps_get)(dev, >> -- >> 2.17.1