DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob <jerinj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files
Date: Thu, 6 Mar 2025 16:22:44 +0000	[thread overview]
Message-ID: <PH0PR18MB40866C647EC942C165BA723EDECA2@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <4055192.n0HT0TaD9V@thomas>

> 06/03/2025 16:25, pbhagavatula@marvell.com:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > SKIP_FILES should include the path of the file.
> > Update the regex to match the path.
> >
> > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > -		-v SKIP_FILES='roc_platform*' \
> > +		-v SKIP_FILES='.*roc_platform*' \
> 
> I don't think it is what you want.
> The last part should be .*
> 

I tested with 0001-common-cnxk-support-for-inline-inbound-queue.patch
with SKIP_FILES='roc_platform.*' and It doesn’t work.

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 63638bc7fa35..64f7b316ea0a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -236,7 +236,7 @@ check_forbidden_additions() { # <patch>
 
        # forbid rte_ symbols in cnxk base driver
        awk -v FOLDERS='drivers/common/cnxk/roc_*' \
-               -v SKIP_FILES='.*roc_platform*' \
+               -v SKIP_FILES='roc_platform.*' \
                -v EXPRESSIONS="rte_ RTE_" \
                -v RET_ON_FAIL=1 \
                -v MESSAGE='Use plt_ symbols instead of rte_ API in cnxk base driver' \
(python-venv)  lab_pvn@lab-pvn  dpdk.org   main ±  ./devtools/checkpatches.sh 0001-common-cnxk-support-for-inline-inbound-queue.patch

### [PATCH] common/cnxk: support for inline inbound queue

total: 0 errors, 0 warnings, 1 checks, 1173 lines checked
Warning in drivers/common/cnxk/roc_platform.h:
Use plt_ symbols instead of rte_ API in cnxk base driver



  reply	other threads:[~2025-03-06 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 15:25 pbhagavatula
2025-03-06 16:13 ` Thomas Monjalon
2025-03-06 16:22   ` Pavan Nikhilesh Bhagavatula [this message]
2025-03-06 16:15 ` Thomas Monjalon
2025-03-06 16:23   ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-03-06 17:12 ` [PATCH v2] devtools: fix regex of " pbhagavatula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB40866C647EC942C165BA723EDECA2@PH0PR18MB4086.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).