From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Shijith Thotton <sthotton@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: Shijith Thotton <sthotton@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v1] common/cnxk: fix initialization of timer LF count
Date: Tue, 14 Mar 2023 05:59:42 +0000 [thread overview]
Message-ID: <PH0PR18MB408679F82EF3AADDC418F63DDEBE9@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <e25bb2c73d173211c49616b37d4fa344ceb7d360.1678765587.git.sthotton@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Tuesday, March 14, 2023 9:17 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [PATCH v1] common/cnxk: fix initialization of timer LF count
>
> Assignment of nb_lfs variable with the available number of timer LFs was
> not happening in the success case after the addition of the new label
> "done". This patch fixes the same by moving the assignment under the
> label.
>
> Fixes: 44a9307c0908 ("common/cnxk: support mailbox locking")
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> drivers/common/cnxk/roc_tim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_tim.c
> b/drivers/common/cnxk/roc_tim.c
> index 6f256c60fa..f8607b2852 100644
> --- a/drivers/common/cnxk/roc_tim.c
> +++ b/drivers/common/cnxk/roc_tim.c
> @@ -394,11 +394,11 @@ roc_tim_init(struct roc_tim *roc_tim)
> } else {
> goto done;
> }
> - roc_tim->nb_lfs = nb_lfs;
>
> fail:
> mbox_put(dev->mbox);
> done:
> + roc_tim->nb_lfs = nb_lfs;
> return nb_lfs;
> }
>
> --
> 2.25.1
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 23601 bytes --]
next prev parent reply other threads:[~2023-03-14 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 3:46 Shijith Thotton
2023-03-14 5:59 ` Pavan Nikhilesh Bhagavatula [this message]
2023-03-15 5:52 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB408679F82EF3AADDC418F63DDEBE9@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).