From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26F72A0548; Mon, 10 May 2021 11:50:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A159840140; Mon, 10 May 2021 11:50:09 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D43664003E; Mon, 10 May 2021 11:50:07 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14A9kRH3029607; Mon, 10 May 2021 02:50:06 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2177.outbound.protection.outlook.com [104.47.59.177]) by mx0a-0016f401.pphosted.com with ESMTP id 38eg89jeuf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 May 2021 02:50:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JZ64Hy51qNnw1Zsg2AaWZr4xFoZB9NH+t+hspcNubcGpcYnjn8g438olUrYWsuHDwcrThxFGzH7O4FVLkJulTt2hF4q8VpWtf2xEyMlqGRFFhTndrsRjqg6mMWU9dyIQNofglNQjJS752RFQpWVgulxA3PwySrBx/huawgE+5EdJdqi/HNblkvyDZPHCReqlH6jNYle4J44aa4HMbnSzDGAk90ZdIpyGsVNiwWUCbWbrbmo5vXkuu+wVHgCPnAmYGHJI86LNnp3HMY12HCCZ6Cv1XwBnk9d3MEmYszqq2sPDHI5WAV/a3S2R13pGuUUJmO1KnkqCsAf/KSaihNyt/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rq9BhLrQcFDDfh8yY7u/vdoUsSzmHX5o+1ZhLTW7WF4=; b=WJl9v90BHJ8P/IvS3T3CPi+ePGSyIoSHVs2gHBvWQZcp3BQ9tN9Cfpe+9LYqEQ0IcQ42fhlqJ3UoScPrqlcGzbPQEedwXc++ufdvnEHVUQqBRbcMc1jka1p/cJvqIzHiH756NN7AwRxlbfUHXZ2uknBmaTVYhn9KukTZj8a040qzRyuDHMwVYe6YY2vnollwIAfDH7GomwEsyhZdzCXME3t6xDQjP1MS88JgiO2EboVhTw4Ci4W+xM1FXL1n+8AvyxkaS9K79/xHV0JgsRxC5hc0qH2ALa0zRtVEoQ/EXBIONfrGqkyCtTj+5i2JHmfmhlu1loLEvcGG836/55CFaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rq9BhLrQcFDDfh8yY7u/vdoUsSzmHX5o+1ZhLTW7WF4=; b=RNpUL3XAlrrvszpJV+etiBelGndP7CEUHNpUHrMHXhG6S6iUVGxkr5Pqdog3fp1s3o/TXashe9TDU+b5i8L1pSkibC6+qXZbCiwTu+joI1Eg1xljwxVs7UcLZjKXrW8sMtp6TGwhoRstU4gIvz68zR+ENGbuM5KO0Bv2l3F4+Cs= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by PH0PR18MB4006.namprd18.prod.outlook.com (2603:10b6:510:2e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.28; Mon, 10 May 2021 09:50:05 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::a187:4890:1cd6:30d2]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::a187:4890:1cd6:30d2%7]) with mapi id 15.20.4108.031; Mon, 10 May 2021 09:50:04 +0000 From: Pavan Nikhilesh Bhagavatula To: Stephen Hemminger CC: "david.marchand@redhat.com" , Haiyue Wang , Jiawen Wu , Jian Wang , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH 2/2] eal: fix side effects in ptr align macros Thread-Index: AQHXRPdOb6BlFa1J+EWYl4G1ykDdEarbjCGAgADrOfA= Date: Mon, 10 May 2021 09:50:04 +0000 Message-ID: References: <20210509171803.1385-1-pbhagavatula@marvell.com> <20210509171803.1385-2-pbhagavatula@marvell.com> <20210509123931.463d6861@hermes.local> In-Reply-To: <20210509123931.463d6861@hermes.local> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2405:201:d009:304d:a48b:71f6:b5cc:6407] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67f0289f-d82d-4879-af32-08d91398fcf8 x-ms-traffictypediagnostic: PH0PR18MB4006: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z2f6MR2ejQKMWDGUTuWJxDi9iBtsBLMQUysP1+mORPn+5E9NQPWHn9ROOYOrVzh55CcGWEfIcf1FUg2XTC83jwr+ouOc227GM3SWocXwZRq5r0yhBaLhZd5gY0bvBctsrek92p1hkvzaTTeBnAlK6QAoPiySl4/FpfFZwHEfDBeWv8U4Qm49tWTq/dL3AvYNQMx/UK59WW0oWEWrb2zZAz6W8i85EgPY4CRpijN9fCJxeb24eXhclJ4rpaAMOI/Hbm/SSaxDF9JKa/d7B58cfqOXQhvfhYzqDc3Dcc1N1wwRMxv7LOJe+68qJKeIP0cVaTu7PppRlsJ/+TXVn1cXGTJPFjZti+LCycU/bg0tjwHEWwpNfYTUArFkcJKoDKs9/Xpvi3DA2eW7KPD51M9seURKBDn7mNENl7b4hBsF2hre6Bkf99DwBpxA+U4+4WK1URXGgfC5bkur//I++g/RHYcwUqOA9IzZme02plDAVQ3V/45qeordaPUN519G8vD5IUVoayGupAIJQbuCfUV9EUDG4b7PWLvGzd7L+TXngGgMDoB/F2OpPPAHZMawn3MwNTYYO3uEX9LCWTRUHyBp8nDBewzGsK0UmoQyBGY4xq/SpTtUHM1sgZM/tOMJ2Te4iVu3oavDDdptgy9wmOwodQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(8936002)(52536014)(4744005)(7696005)(66946007)(83380400001)(2906002)(64756008)(66446008)(66556008)(66476007)(9686003)(76116006)(33656002)(8676002)(55016002)(4326008)(316002)(122000001)(86362001)(478600001)(7416002)(54906003)(6506007)(186003)(71200400001)(38100700002)(6916009)(5660300002)(56340200001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?o2WJIZTjEYFK6Y12zo3ZGYuE/4NIP1RkiZGw7loOoab2qs/khGcftkp9odYw?= =?us-ascii?Q?Ynm5KxzVAu/C1gpuyoVDQjvmG4wH4xFN9NyZ3tv7lBmDu1lrfHmY8E53JuPv?= =?us-ascii?Q?R7YZz4BFY5EScHySIN+Ou83emXtYA472Cy0Iwn+0rAqzu10de7mrtf89VKvC?= =?us-ascii?Q?TadPQ0Ubq3wVgEVi7Sc6Rv7HdkusSxaNdUdQV+WFwdt3DvotLkR9pVcbCxY8?= =?us-ascii?Q?mi2hJ920TnvqBGCTMwX4UjXeAkrlk7zlYimCzh3+C+g55+q3UFbmCG7xyCVU?= =?us-ascii?Q?svmLtmrG2C7lqvdaaoFtqjMYR2k6K9QTuqkeV8Sbqz773GdfNHCffsiZX9Ar?= =?us-ascii?Q?UO/bxU/i6i0r2UDfHMWcw9YKNAKQ+NQjLuOOhajr97uE8WxNobNPbsUROEZw?= =?us-ascii?Q?PqIqBwz7IwHn4cbpPe+45h5qiA+iiKSt8U58R2lKZCrxW/7WZxQsGb56DaW0?= =?us-ascii?Q?pmlMC29UNDZL8EJQS+1Wdh0OsEVPd+KPaY0wIdY2qGFOz7eo5G7nkm9PpuW9?= =?us-ascii?Q?bBRJAynZ+84vI3BQpf97Vob2Lg8j8jtQ4ZqEwBgL1qBZj9uUrIHmKTZxT2AG?= =?us-ascii?Q?0QaOOqAvsZyfJyL+B/gAUpLIpIyobfJoUUU6N4UL70AOGyZbc8uoPiLKLY7Y?= =?us-ascii?Q?hiQVmc40yTN4yRPcNvxvPGkii/IyFCRb9NddRSzqypSym0HCJSfzHbhzPWoY?= =?us-ascii?Q?zA2USjbKkcVVHYaSyD8uEuWHOAZx+NqvA049gPDiuvfVlrCxqgdDMutWhhJY?= =?us-ascii?Q?kntZkQTDLPKGUAtWIaGTGNikHuWl5RLnE5OnrM/6gvYzxLDRT2glKo+WdhCg?= =?us-ascii?Q?CpMqVtOXmBkMoFvYpNXEcz1t6WOxjSp5Elb2iN2cQoYwRQmFSL/4Qp0aCUuo?= =?us-ascii?Q?ST3LEpK49gDsaqXvko8TUr2dXhKsi0CBNgkYvfB+uFINl0qpw+b+8ME2Zsgs?= =?us-ascii?Q?7WE79QtskZiDcEU9zN8+epzVBlXYQ4wlwE594pUhdH545zh6Nraa/VAl3j3K?= =?us-ascii?Q?9sxfgq14MEo39u29yUJ71lQFyZCT99V72ShWSqEhulwIA5U2BAvot5YNrGnR?= =?us-ascii?Q?a5h5bgq7LhoYAh1HFTTFhtrXIjQ44IIl2N3v5CaTNRy6n6bqZtzwSJw+QeWL?= =?us-ascii?Q?uozSue7AQWy4srJZFis6pVX1LRAakP0Rf+9AINCIiGy9ZI9PrNbdCRJqZEDl?= =?us-ascii?Q?q3AVG3snr30BNhIzF4c4ee3CPyUkvW/LT52gkn+MgnAmcJSbLracycp+0TxR?= =?us-ascii?Q?U++8tZcPSqOw4s4SFA3LdQ0uDxQJ4kPHlvvbc4/oAGN7NgSBetKWpPeIliiu?= =?us-ascii?Q?g32pRsUqQU4+wm9PpVwZJDabUggNnfeiXNWU3ROx8lHuozV1htI24C8GNFE/?= =?us-ascii?Q?Zp6OfsJNqaBkBsTAvs/sKPapwYzj?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67f0289f-d82d-4879-af32-08d91398fcf8 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2021 09:50:04.8583 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kChrX73+REYYlEhEQzpCPxsVlzqDNkzzCE6wtmMWP0pBI8X/lsa6uVkpS6Mu2Zz8XTuvsouUU21goVXh3S2HGYx7V7bGLMp+NOFX1rPVc+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4006 X-Proofpoint-GUID: -EDD1NJaCiFDbdERlHGUmtp9a3QwwAWB X-Proofpoint-ORIG-GUID: -EDD1NJaCiFDbdERlHGUmtp9a3QwwAWB X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-10_04:2021-05-10, 2021-05-10 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] eal: fix side effects in ptr align macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >On Sun, 9 May 2021 22:48:02 +0530 > wrote: > >> From: Pavan Nikhilesh >> >> Avoid expanding parameters inside RTE_*_ALIGN macros. >> Update common_autotest to detect macro side effects. >> Workaround static arrays relying on RTE_ALIGN macros. >> >> Fixes: af75078fece3 ("first public release") >> Cc: stable@dpdk.org >> >> Signed-off-by: Pavan Nikhilesh >> Signed-off-by: David Marchand > >Why not split these up? It looks like the Intel driver and common part >could be separate? The common changes break intel/mlx5 driver compilation can't separate them.