From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Jerin Jacob <jerinj@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
"abdullah.sevincer@intel.com" <abdullah.sevincer@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>,
"harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
"liangma@liangbit.com" <liangma@liangbit.com>,
"peter.mccarthy@intel.com" <peter.mccarthy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXTERNAL] Re: [PATCH v7 1/6] eventdev: introduce event pre-scheduling
Date: Sun, 6 Oct 2024 17:03:16 +0000 [thread overview]
Message-ID: <PH0PR18MB4086AD4F8366977FB64419BEDE7C2@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20241005091135.37b0ee46@hermes.local>
> On Sat, 5 Oct 2024 13:29:56 +0530
> <pbhagavatula@marvell.com> wrote:
>
> > +static int
> > +preschedule_test(enum rte_event_dev_preschedule_type
> preschedule_type, const char *preschedule_name)
> > +{
> > +#define NB_EVENTS 1024
> > + uint64_t start, total;
> > + struct rte_event ev;
> > + int rc, cnt;
> > +
> > + ev.event_type = RTE_EVENT_TYPE_CPU;
> > + ev.queue_id = 0;
> > + ev.op = RTE_EVENT_OP_NEW;
> > + ev.u64 = 0xBADF00D0;
> > +
> > + for (cnt = 0; cnt < NB_EVENTS; cnt++) {
> > + ev.flow_id = cnt;
> > + rc = rte_event_enqueue_burst(TEST_DEV_ID, 0, &ev, 1);
> > + TEST_ASSERT(rc == 1, "Failed to enqueue event");
> > + }
> > +
> > + RTE_SET_USED(preschedule_type);
>
> If you respin this patch. My preference is to use the __rte_unused attribute in
> the function
> declaration rather RTE_SET_USED(), mainly because it makes it more obvious
> in the start of the function.
Hi Stephen,
I am respinning the series but the RTE_SET_USED is removed in the 2/6.
- RTE_SET_USED(preschedule_type);
+ if (modify) {
+ rc = rte_event_port_preschedule_modify(TEST_DEV_ID, 0, preschedule_type);
+ TEST_ASSERT_SUCCESS(rc, "Failed to modify preschedule type");
+ }
+
Thanks,
Pavan.
next prev parent reply other threads:[~2024-10-06 17:03 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 8:31 [RFC 0/3] Introduce event prefetching pbhagavatula
2024-09-10 8:31 ` [RFC 1/3] eventdev: introduce " pbhagavatula
2024-09-10 8:31 ` [RFC 2/3] eventdev: allow event ports to modified prefetches pbhagavatula
2024-09-10 8:31 ` [RFC 3/3] eventdev: add SW event prefetch hint pbhagavatula
2024-09-10 9:08 ` [RFC 0/3] Introduce event prefetching Mattias Rönnblom
2024-09-10 11:53 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-09-17 7:11 ` [PATCH v2 0/3] Introduce event pre-scheduling pbhagavatula
2024-09-17 7:11 ` [PATCH v2 1/3] eventdev: introduce " pbhagavatula
2024-09-18 22:38 ` Pathak, Pravin
2024-09-19 13:13 ` Pavan Nikhilesh Bhagavatula
2024-09-23 8:57 ` Mattias Rönnblom
2024-09-25 10:30 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-09-26 2:54 ` Pathak, Pravin
2024-09-26 10:03 ` Pavan Nikhilesh Bhagavatula
2024-09-27 3:31 ` Pathak, Pravin
2024-09-17 7:11 ` [PATCH v2 2/3] eventdev: add event port pre-schedule modify pbhagavatula
2024-09-17 7:11 ` [PATCH v2 3/3] eventdev: add SW event preschedule hint pbhagavatula
2024-10-01 6:14 ` [PATCH v3 0/6] Introduce event pre-scheduling pbhagavatula
2024-10-01 6:14 ` [PATCH v3 1/6] eventdev: introduce " pbhagavatula
2024-10-01 6:14 ` [PATCH v3 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-01 6:14 ` [PATCH v3 3/6] eventdev: add SW event preschedule hint pbhagavatula
2024-10-01 6:14 ` [PATCH v3 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-01 6:14 ` [PATCH v3 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-01 6:14 ` [PATCH v3 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-01 13:18 ` [PATCH v4 0/6] Introduce event pre-scheduling pbhagavatula
2024-10-01 13:18 ` [PATCH v4 1/6] eventdev: introduce " pbhagavatula
2024-10-04 4:47 ` Jerin Jacob
2024-10-01 13:18 ` [PATCH v4 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-04 5:02 ` Jerin Jacob
2024-10-01 13:18 ` [PATCH v4 3/6] eventdev: add SW event preschedule hint pbhagavatula
2024-10-04 5:14 ` Jerin Jacob
2024-10-01 13:18 ` [PATCH v4 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-01 13:19 ` [PATCH v4 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-01 13:19 ` [PATCH v4 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-01 15:33 ` [PATCH v4 0/6] Introduce event pre-scheduling Stephen Hemminger
2024-10-03 5:46 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-04 16:24 ` [PATCH v5 " pbhagavatula
2024-10-04 16:24 ` [PATCH v5 1/6] eventdev: introduce " pbhagavatula
2024-10-04 16:24 ` [PATCH v5 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-04 16:24 ` [PATCH v5 3/6] eventdev: add event preschedule hint pbhagavatula
2024-10-04 16:24 ` [PATCH v5 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-04 16:24 ` [PATCH v5 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-04 16:24 ` [PATCH v5 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-04 16:35 ` [PATCH v5 0/6] Introduce event pre-scheduling Stephen Hemminger
2024-10-04 16:50 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-10-05 7:25 ` [PATCH v6 " pbhagavatula
2024-10-05 7:25 ` [PATCH v6 1/6] eventdev: introduce " pbhagavatula
2024-10-05 7:25 ` [PATCH v6 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-05 7:25 ` [PATCH v6 3/6] eventdev: add event preschedule hint pbhagavatula
2024-10-05 7:25 ` [PATCH v6 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-05 7:25 ` [PATCH v6 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-05 7:26 ` [PATCH v6 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-05 7:59 ` [PATCH v7 0/6] Introduce event pre-scheduling pbhagavatula
2024-10-05 7:59 ` [PATCH v7 1/6] eventdev: introduce " pbhagavatula
2024-10-05 16:11 ` Stephen Hemminger
2024-10-06 17:03 ` Pavan Nikhilesh Bhagavatula [this message]
2024-10-05 7:59 ` [PATCH v7 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-05 7:59 ` [PATCH v7 3/6] eventdev: add event preschedule hint pbhagavatula
2024-10-05 7:59 ` [PATCH v7 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-05 8:00 ` [PATCH v7 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-05 8:00 ` [PATCH v7 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-06 17:06 ` [PATCH v8 0/6] Introduce event pre-scheduling pbhagavatula
2024-10-06 17:06 ` [PATCH v8 1/6] eventdev: introduce " pbhagavatula
2024-10-06 17:06 ` [PATCH v8 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-06 17:06 ` [PATCH v8 3/6] eventdev: add event preschedule hint pbhagavatula
2024-10-07 12:24 ` Jerin Jacob
2024-10-06 17:06 ` [PATCH v8 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-06 17:06 ` [PATCH v8 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-06 17:06 ` [PATCH v8 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-07 13:09 ` [PATCH v9 0/6] Introduce event pre-scheduling pbhagavatula
2024-10-07 13:09 ` [PATCH v9 1/6] eventdev: introduce " pbhagavatula
2024-10-07 13:09 ` [PATCH v9 2/6] eventdev: add event port pre-schedule modify pbhagavatula
2024-10-07 13:09 ` [PATCH v9 3/6] eventdev: add event preschedule hint pbhagavatula
2024-10-07 13:09 ` [PATCH v9 4/6] event/cnkx: add pre-schedule support pbhagavatula
2024-10-07 13:09 ` [PATCH v9 5/6] app/test-eventdev: add pre-scheduling support pbhagavatula
2024-10-07 13:09 ` [PATCH v9 6/6] examples: use eventdev pre-scheduling pbhagavatula
2024-10-08 5:17 ` [PATCH v9 0/6] Introduce event pre-scheduling Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4086AD4F8366977FB64419BEDE7C2@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=abdullah.sevincer@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=liangma@liangbit.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=peter.mccarthy@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=stephen@networkplumber.org \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).