From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E388E432C9; Tue, 7 Nov 2023 18:35:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7888E402D4; Tue, 7 Nov 2023 18:35:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id AFBA7402A1 for ; Tue, 7 Nov 2023 18:35:12 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A7HYNqw002013; Tue, 7 Nov 2023 09:35:11 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3u7srpg04y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Nov 2023 09:35:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ik3FaVQLS83A/fH/l5bdhQwRtHWvng3tARF4ISG/63U4WU+yS57N6ggG5ODWDIIXbnjj8jT/YSBi5eAsBWay/fDAM8mujBMYq7dtr2/tdomwxZLSAiB/EWUK4GaW4c+jN7bbCjnz49xRWkV8QnU2vpCTTw8oPdtTj1gHiKfr1TRhGO3BAy/l1Q60mYpw6JaCXr+arwSujeR0f36M6MR5cCAttHGPh+W5eMrYbocQ1RvzrNqhJmtjDN//xZ7XDCqAd4YeLfUNTm91jgmCVytKQjimLEbIoOuebt47Tu1WpriWUXDm+qo7/r0agtNMBdd1oyJ1+PFvAUhPYp2gR5mbqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cU1TOrJrB9A1BpdX52AHJo3uNf2L1iT8U1qTRjxtTAs=; b=UD2t6U2+o+8revRm3ZNKZl6NtD9mcehMaTXAgRJ0MBsRI4zE1KUxVPxHmsvtHjXtdf0EI3QqOuWq+gaSKuUqlRWDWv1DU4nOnZKCbA6D6tWohDhoRkScJXcG5F+pNX5Uxf0n210ePUs++2mYVz0nqZSsp+Gj4Lsf0FJyephTZ5aOsGPKdgu3ITzSVJ9Wdcv99WXnw+5W7zxwtecD1+q+PwAVKnYOpSvhRs8qfsDKP4BP93A3QSEjJcoiz5qymrgX/C3/IewvDn0HcLV2SJkygxhCxroUEjsbODUBKhqW1AZJsYjy437DNPbJ0arpqt3ulp+sZ/O04Aa935WH5LJkVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cU1TOrJrB9A1BpdX52AHJo3uNf2L1iT8U1qTRjxtTAs=; b=OQ9oW1lOu6e1q3aYly3b89ZcI21EhaI4eVZSthIb+yyCo42AnrcfOCrCXhwaQ+akU7SnsoDkP+MpxhuGWoCxHlvgTEIAihi2e3/dD60qF2Dp4lPUQF3nqzxN3+m32v1CStPWmS+5GRXblsO1o9AbT9+9AlJrjYkv70LNwKhcNUs= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by DM4PR18MB5076.namprd18.prod.outlook.com (2603:10b6:8:48::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Tue, 7 Nov 2023 17:35:09 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::eb23:6b0f:a84c:bdc9]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::eb23:6b0f:a84c:bdc9%7]) with mapi id 15.20.6954.028; Tue, 7 Nov 2023 17:35:09 +0000 From: Pavan Nikhilesh Bhagavatula To: Bruce Richardson , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran Subject: RE: [EXT] [PATCH] test/eventdev: avoid configuring port or queue twice Thread-Topic: [EXT] [PATCH] test/eventdev: avoid configuring port or queue twice Thread-Index: AQHaEZkL0qCTiHBHwE6KCrtiPWfSwrBvHiyA Date: Tue, 7 Nov 2023 17:35:08 +0000 Message-ID: References: <20231107163926.55825-1-bruce.richardson@intel.com> In-Reply-To: <20231107163926.55825-1-bruce.richardson@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|DM4PR18MB5076:EE_ x-ms-office365-filtering-correlation-id: 647b7ee4-5aa4-47a5-ba71-08dbdfb7e36d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WGO8hULqk71s8IM83is4yLaBBxjKKdGeiftbMLDemIjbLCbrAKDe1BVCKTWxGKN4wmNgcLH5P2F0WK/NATrXqiqEG+wr372Rtp2wafKB3m/80Xqpe66m6vQ3MPpg1id850+jkI33mJDJUHWnXGp7Bmd8DLSqnmJWtdI0+QhKrZ8QVkkjU4t5BLIRCofikTJe5UoXbBAK7K/13ZKKpTHi8N1SuxtgNLxN5OyPEw0PSxlmGwFw1WqyHS6NjFWMrpisTsIvktvEv2/ScPYfx6eoPCFKavRZnzr3UnnAxC5Bx93liM1OOCH1gGB0zsAoxYOHCWVm6EAcGl7feD/swDmh23Eh2WKsWfWzR5DVCzJ/30neXRfNgF3NDMUZqx2YD3ZD6ZQtb8h1bCBcZ+Vk3h59QPAImsjvDlifMzsdtqWQxELnYcxbPNqW/YBwbgmwd8gcO1gsQ/k1At4UvE6Oe3fud4Yrmn7+H17qa6Qf2JCR8FbLS7eUIg2ekSc2xbFoYY1EVVmPMOGtjNsWz4dAfLxjeDjtvTL4LH+nGKYCkODviar9dacurx6m+5Fp688CoENdpqZAb5Yg+IYkNPgRjFB0jzQ1eGMPhC/qZAkUSPWYeYI6a7EHKioxKBOM0fxX04G2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(376002)(136003)(39860400002)(346002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(107886003)(7696005)(6506007)(9686003)(41300700001)(26005)(4326008)(71200400001)(8676002)(52536014)(5660300002)(64756008)(2906002)(66446008)(76116006)(66946007)(66556008)(478600001)(8936002)(316002)(110136005)(38070700009)(66476007)(38100700002)(122000001)(33656002)(86362001)(83380400001)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jmwLDuv/pp/Ycc+WinJ6DDmxKasg71nZfEDmoHKM/t9878xknLjN8xV4KN2k?= =?us-ascii?Q?PwUKkXoZUKCOQBDOdTGvLzGDi48GAmO4W0WfjEB5BnfIEy5oGVU067EqCzz5?= =?us-ascii?Q?RoFMW/JahkBaKTUP4LxNIuL785AqqPieuVspW2ZNpcbvVZOJFqMbSiD0/hps?= =?us-ascii?Q?ohNlp8C6SJjqshFom/zgJXDFGFo0zqxsECBAEICfMAjVV9Fbjn6LoUL0ITNp?= =?us-ascii?Q?Ha5QkXzx5YYL7vhOd6hT9wL85xI+2VwPi1+7dXrZcHkT+8ANiNx1f1xO9hTa?= =?us-ascii?Q?OQkag4Ex+PsxWTvqUKWH4D/LAkMA3k1C0+WDh0h1WuWGARmXzs8LVc1RgtLK?= =?us-ascii?Q?u4Dbvtdz9yVltGejFvgGlxUiHoMsLt/4H2i8qYXCzGg5YQLuXbF1Jq+Bb7cQ?= =?us-ascii?Q?rAoNJqu0woRfpqw+m9fFyOvDKwmedkoadvMKZ4evJsw9xwWmOY4kWS7bpBQr?= =?us-ascii?Q?xjdtbOrFCbxX51iyVIDM54ov0T2KhrkIxecpeQC4o04wtGONE20fslqQhkNG?= =?us-ascii?Q?Kzekc7WEtoWILKhyIf5DNQh3I44M8V7LMrniQXem/GJbL1jKwidC0wYlATLR?= =?us-ascii?Q?RHYax4DGRH/w1xqiwSP30vP5IYV57K2gfquQkpo+ckLU5MVkhG6Zt3S1OEVJ?= =?us-ascii?Q?SVkSTOB6KYzYu2nn8oCDCsddXxWWJpfXiCyBW50g9UZrsvMInTbcfwx5b2SP?= =?us-ascii?Q?/pNP75Jm6OQU8CYWKPE5Kmfv+5K8EEwYqTI+0xLldGdMiWoe1pakXjuATb1q?= =?us-ascii?Q?btkAPxEbTy/xfB2MfZQfeklT3E/jFAw2OlcbWJHUL+xrEu8ilL6gdEhXgYJa?= =?us-ascii?Q?NAY/LD8Vw0WI7iJsJi3xcXEFQLELTcDZGijw34qjr27C7+xcwB1MGtCBLUNQ?= =?us-ascii?Q?gwe9GgyBqVoBir1OdWThYYuxchxvyCZyrI8w/G0TaOtA1b0qLYhf13PEm5u4?= =?us-ascii?Q?NJkjB8bp2tsZQzM/2REqwHtxAqnS+Cy3wzBkCljD2MkXmEi88w18LsG6OEeB?= =?us-ascii?Q?m0WGYLjxktVmGgFWZpPskNYE7GHabv/LkxUONut55r5ORG+AixZ2KfvXPT3P?= =?us-ascii?Q?h5eSCxkPh7N3Y0F9pmKAcxKTMTMijmHz7l+a5OIvmoFgKeMO+vfKhjRasAaX?= =?us-ascii?Q?Mfp4v9y73V8MABJB23JKSgFBZZWfRhFp/t6gC9F7jmtibnCAo6wzw3DQDsuc?= =?us-ascii?Q?qy4u8LbVEegmb6aAq6Al0IA0AIv9IBodsQylJOSoxhnwCjEPPKcq57Ne7mc+?= =?us-ascii?Q?92AD75TVRhxs9ts7BnMgiVD3QX5F4GrmPpZtjpf2ZFNEQbj6ywyI/t9SnVhj?= =?us-ascii?Q?/3RV1aJrQ8aBfmTMHJ4LNr9Gc12fEFNuezVEAw5ytkrW4D81dmUL917A/4c1?= =?us-ascii?Q?Jm81z6hruyMSfNaIP5+lHJivZHPbMnS8hzSGpC2xxTvgb/Xpsef2lBH8xYLB?= =?us-ascii?Q?BiO1oYq4VE3E0vFtB2y3foia3SwarTZWrfXBUalIMlZuLfRQgXgqPgRe6XOf?= =?us-ascii?Q?L8jF6lnHyuuithQ2bN5hE4eOelbNuz7UlCLQBzzz+VB1IhSEQne0zIMajnom?= =?us-ascii?Q?0HNZmb1zcfx5JH+bYsrN6E0i/aBCh8VWkznephgY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 647b7ee4-5aa4-47a5-ba71-08dbdfb7e36d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2023 17:35:09.0256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8Z6bXdrKq22cNgCm72Rd80gcT35mFGiB+B8WUkx3JEtKZng7l97+XSkp/8XS22ka4mkpXbgnERsoRgi+z3gHM7DeYGuGO+lbb0DQv8jt9yY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5076 X-Proofpoint-ORIG-GUID: Ok1UvqsID7lEiZ7iOmDrVmK00vVzLepE X-Proofpoint-GUID: Ok1UvqsID7lEiZ7iOmDrVmK00vVzLepE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-07_09,2023-11-07_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > In the basic sanity tests of eventdev for queue and port setup, queue 0 > was configured separately before running a loop to configure the rest of > the queues. This loop started from 0, so reconfigured queue 0, and a > similar reconfiguration happens with port 0 in the later port setup > test. While most eventdevs should handle this reconfiguration without > stop/start correctly, it can cause issues, and should be tested > separately from basic config tests. >=20 > Therefore, adjust loops to start at 1 rather than 0 and avoid > configuring queue 0 and port 0 twice. >=20 > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > --- > app/test/test_eventdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c > index 993e49af3b..71de947ce4 100644 > --- a/app/test/test_eventdev.c > +++ b/app/test/test_eventdev.c > @@ -313,7 +313,7 @@ test_eventdev_queue_setup(void) > RTE_EVENT_DEV_ATTR_QUEUE_COUNT, > &queue_count), > "Queue count get failed"); >=20 > - for (i =3D 0; i < (int)queue_count; i++) { > + for (i =3D 1; i < (int)queue_count; i++) { > ret =3D rte_event_queue_setup(TEST_DEV_ID, i, NULL); > TEST_ASSERT_SUCCESS(ret, "Failed to setup queue%d", i); > } > @@ -786,7 +786,7 @@ test_eventdev_port_setup(void) > RTE_EVENT_DEV_ATTR_PORT_COUNT, > &port_count), "Port count get failed"); >=20 > - for (i =3D 0; i < (int)port_count; i++) { > + for (i =3D 1; i < (int)port_count; i++) { > ret =3D rte_event_port_setup(TEST_DEV_ID, i, NULL); > TEST_ASSERT_SUCCESS(ret, "Failed to setup port%d", i); > } > -- > 2.39.2