DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Shijith Thotton <sthotton@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Shijith Thotton <sthotton@marvell.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Akhil Goyal <gakhil@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>,
	Ankur Dwivedi <adwivedi@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/2] event/octeontx2: configure crypto adapter xaq pool
Date: Mon, 26 Apr 2021 10:17:59 +0000
Message-ID: <PH0PR18MB4086D9448E292E389007DCEEDE429@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <cf038681aa36428b21cef0738e4abe304f907014.1618513149.git.sthotton@marvell.com>



>-----Original Message-----
>From: Shijith Thotton <sthotton@marvell.com>
>Sent: Friday, April 16, 2021 12:40 AM
>To: dev@dpdk.org
>Cc: Shijith Thotton <sthotton@marvell.com>; Jerin Jacob Kollanukkaran
><jerinj@marvell.com>; Akhil Goyal <gakhil@marvell.com>; Anoob
>Joseph <anoobj@marvell.com>; Ankur Dwivedi
><adwivedi@marvell.com>; Pavan Nikhilesh Bhagavatula
><pbhagavatula@marvell.com>
>Subject: [PATCH v1 2/2] event/octeontx2: configure crypto adapter xaq
>pool
>
>Configure xaq pool based on number of in-use crypto queues to avoid
>CPT
>add work failure due to xaq buffer run out. This patch configures
>OTX2_CPT_DEFAULT_CMD_QLEN number of xae entries per queue
>pair.
>
>Fixes: 29768f78d5a7 ("event/octeontx2: add crypto adapter
>framework")
>
>Signed-off-by: Shijith Thotton <sthotton@marvell.com>
>---
> drivers/event/octeontx2/otx2_evdev_adptr.c        | 2 +-
> drivers/event/octeontx2/otx2_evdev_crypto_adptr.c | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/event/octeontx2/otx2_evdev_adptr.c
>b/drivers/event/octeontx2/otx2_evdev_adptr.c
>index d69f269df..d85c3665c 100644
>--- a/drivers/event/octeontx2/otx2_evdev_adptr.c
>+++ b/drivers/event/octeontx2/otx2_evdev_adptr.c
>@@ -1,5 +1,5 @@
> /* SPDX-License-Identifier: BSD-3-Clause
>- * Copyright(C) 2019 Marvell International Ltd.
>+ * Copyright(C) 2019-2021 Marvell.
>  */
>
> #include "otx2_evdev.h"
>diff --git a/drivers/event/octeontx2/otx2_evdev_crypto_adptr.c
>b/drivers/event/octeontx2/otx2_evdev_crypto_adptr.c
>index 3a96b2e34..79a6d5577 100644
>--- a/drivers/event/octeontx2/otx2_evdev_crypto_adptr.c
>+++ b/drivers/event/octeontx2/otx2_evdev_crypto_adptr.c
>@@ -88,6 +88,14 @@ otx2_ca_qp_add(const struct rte_eventdev
>*dev, const struct rte_cryptodev *cdev,
> 	sso_evdev->rx_offloads |= NIX_RX_OFFLOAD_SECURITY_F;
> 	sso_fastpath_fns_set((struct rte_eventdev *)(uintptr_t)dev);
>
>+	/* Update crypto adapter xae count */
>+	if (queue_pair_id == -1)
>+		sso_evdev->adptr_xae_cnt =
>+			vf->nb_queues *
>OTX2_CPT_DEFAULT_CMD_QLEN;

This should be sso_evdev->adaptr_xae_cnt += (vf->nb_queues * OTX2_CPT_DEFAULT_CMD_QLEN);

>+	else
>+		sso_evdev->adptr_xae_cnt +=
>OTX2_CPT_DEFAULT_CMD_QLEN;
>+	sso_xae_reconfigure((struct rte_eventdev *)(uintptr_t)dev);
>+
> 	return 0;
> }
>
>--
>2.25.1

With above changes
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>


  reply	other threads:[~2021-04-26 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 19:10 [dpdk-dev] [PATCH v1 0/2] event/octeontx2: fixes for crypto adapter Shijith Thotton
2021-04-15 19:10 ` [dpdk-dev] [PATCH v1 1/2] event/octeontx2: fix crypto adapter queue pair ops Shijith Thotton
2021-04-15 19:10 ` [dpdk-dev] [PATCH v1 2/2] event/octeontx2: configure crypto adapter xaq pool Shijith Thotton
2021-04-26 10:17   ` Pavan Nikhilesh Bhagavatula [this message]
2021-04-26 12:21 ` [dpdk-dev] [PATCH v2 0/2] event/octeontx2: fixes for crypto adapter Shijith Thotton
2021-04-26 12:21   ` [dpdk-dev] [PATCH v2 1/2] event/octeontx2: fix crypto adapter queue pair ops Shijith Thotton
2021-04-26 14:44     ` Ankur Dwivedi
2021-04-26 12:21   ` [dpdk-dev] [PATCH v2 2/2] event/octeontx2: configure crypto adapter xaq pool Shijith Thotton
2021-04-29  8:50   ` [dpdk-dev] [PATCH v2 0/2] event/octeontx2: fixes for crypto adapter Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB4086D9448E292E389007DCEEDE429@PH0PR18MB4086.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=adwivedi@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git