From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C910FA0C45;
Tue, 21 Sep 2021 22:51:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4FECA4003F;
Tue, 21 Sep 2021 22:51:56 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174])
by mails.dpdk.org (Postfix) with ESMTP id B0B664003C
for <dev@dpdk.org>; Tue, 21 Sep 2021 22:51:54 +0200 (CEST)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18LGskQT011039;
Tue, 21 Sep 2021 13:51:53 -0700
Received: from nam02-sn1-obe.outbound.protection.outlook.com
(mail-sn1anam02lp2041.outbound.protection.outlook.com [104.47.57.41])
by mx0a-0016f401.pphosted.com with ESMTP id 3b7kb4gvhn-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Tue, 21 Sep 2021 13:51:53 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=VQzokAm7M0Uj3bcxtmEVtSPR9MdYm1lgF5Pl4JFjdYhBsudYN/fU4WdxGck7SV9DHPTKcJr+y/CVvp1lnIg4/9JRol13uIcG3a+7UCIRKvrX/vIZBXw/qFxCADJUS/CzHSEuTsn6WjuxHRkDMqRGZGFc1u5VEPJZZwEcTIAuuspYdSGB2A7pX7BxSFwuozv4uT3Hnq5uEgzgPWtlAfyOdUENcOSnXFnEXQHOdQHTzZtXmxMk92lTtqO3ZNzPgSuv9IA64RIB0T9TgL5/8DUEwOcsXA9OnTedWm0yaiJJDuEX4jxSG8IjqCsWW1EbRAK3vDW1bD6+LFVWnkaVh8SjZg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=D/MRmdXyEv0RANElRt/GK+aBMiXuiiUd9FoVLv30tsY=;
b=P+P/2oqROGJmxtx0G8wnyGpC7kxcV1NG5FBP2/Gwd6chel7nE+xxxYQiF6ptSvX9PcuGNMdHhJxTLdHAjeH9QRsWJu1+q61toem/W8waFwCnr0uGe2zsLKqR047PDwc7wMGGf1XDFrkmXh/mrpAEi6bGEsIPFYvKD+CJPnfQFBPKp8NEoMY9wvSbL41naGMeFwT9ic8paalHfOqCxrKfmUoMY5PBqFMRHPLsRLXm1mNvCcMj+Lw6hJlcw4azOyF8+WFRlDldZFPXbNzPC+/ck5UrEs0zz/nWKi5733qHqw1ZDB3THARMG3Xe8mRx/aw8vSwMFMJ3672OWx+SBG60Jg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=D/MRmdXyEv0RANElRt/GK+aBMiXuiiUd9FoVLv30tsY=;
b=dIok3tG8jVAOAeR7dKvuc4DxRUY6KBcH5R3iawkPsRjoABI8h4iQynq9qMqmKxvD8n+lGXCvf3o831jBCnOQ7a7SvNqDWYBKYph9ppZUpHHtJDTYnkbsPtARpnPkKw0nBt8b8Z0HEPpvZtnbrISxFtrbDCbEBIoB8XOMeG2FkbM=
Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by
PH0PR18MB3927.namprd18.prod.outlook.com (2603:10b6:510:2b::23) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4523.14; Tue, 21 Sep 2021 20:51:51 +0000
Received: from PH0PR18MB4086.namprd18.prod.outlook.com
([fe80::94d1:2b0c:115f:5a75]) by PH0PR18MB4086.namprd18.prod.outlook.com
([fe80::94d1:2b0c:115f:5a75%7]) with mapi id 15.20.4523.018; Tue, 21 Sep 2021
20:51:51 +0000
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Naga Harish K S V <s.v.naga.harish.k@intel.com>, Jerin Jacob Kollanukkaran
<jerinj@marvell.com>, "jay.jayatheerthan@intel.com"
<jay.jayatheerthan@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [EXT] [dpdk-dev] [PATCH v2 4/5] eventdev/rx_adapter: implement
per queue event buffer
Thread-Index: AQHXrs2OPe04MTPfTk6tMpolXPLo56uu9aIA
Date: Tue, 21 Sep 2021 20:51:51 +0000
Message-ID: <PH0PR18MB4086F85FF4127944054A8927DEA19@PH0PR18MB4086.namprd18.prod.outlook.com>
References: <20210918131140.3543317-1-s.v.naga.harish.k@intel.com>
<20210921094559.1788022-1-s.v.naga.harish.k@intel.com>
<20210921094559.1788022-4-s.v.naga.harish.k@intel.com>
In-Reply-To: <20210921094559.1788022-4-s.v.naga.harish.k@intel.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0eb313ad-bdb7-45a7-18ef-08d97d41a336
x-ms-traffictypediagnostic: PH0PR18MB3927:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <PH0PR18MB3927D61B7D115999F0A200A6DEA19@PH0PR18MB3927.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5797;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Q5KH69I3lVsJeeAaMIBO0OrowQAMwIuPhhSZRPW/4Nhhc9/Sk6TPEsv4nDjyTY8mfDJA3qRPF9PvxVKPOq49Y1rzX7mVk3La4UKprJUuqw6rcBtwgak2LR0cPeJqLKNTpRLm06mSHdWl7Vv5Pop2WnreOPu60T99M8oDiZ8PmqKASktLh5ms1YavaDVziHwDpFkoJd4ukBzyx6Q587juMHosYAUnFlhL9WPPciYcGSjD0J0mP5UW1eOE/5buhZZKbv0pzLx5kbmOhKboEpcqcT2fDx+8+lnBVRhVE2/YbSTODgVoubl5y33y8zvwmzSvpJEjk0CTWaPc+17v7WCX9z0m2og4EiH+e67iDyYags8RoowNgVWYA2UAVYt5eK9FedUNEgzlXHsOX02kzYWPgp2EIOZ4GezFPZBAzUfCFJ7M2LpxM3mKZB3Jl942mkm0mKEXSBZ0+FvSkwZw0YBiM51Q4+o8PYq3PPgWBGA5COO2a972EYIPlH1ymc33C4iCA80vyM1DBV5NqyVl5+zzsLqPFtW8Rmu5NK3hM1q7xHSqtMmHo9mDN+frpS6Fu8m4c+KrpkbNczLljhqawHXmm5p03v1ixGixr8EpR85y1j/YcBrOkhUYqxOrZj+JbV0abgq4RP+SRy4BJ6H5/F2s6Z6o8EfVgXEn1jrKIuMwDAjp5Y5HZYh/1v//hMemdaKQSrkRMVUBf3AtrZouxg+LiQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(110136005)(86362001)(122000001)(8936002)(52536014)(76116006)(2906002)(7696005)(4326008)(5660300002)(316002)(38100700002)(66446008)(64756008)(186003)(66556008)(66476007)(9686003)(6506007)(55016002)(8676002)(66946007)(83380400001)(33656002)(38070700005)(508600001)(71200400001);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R+yyxvuCmB+gCG3RJyfgCqUjAavENfr+RvzF6mLlkeQsYL214w9SR2kXzYWx?=
=?us-ascii?Q?8UaS7qPNoCH9BTbn5/g6gS653d0yZPr5I4nGxSX6iKBHnzG8bFha/uOWBGR0?=
=?us-ascii?Q?G3mlMRQAJh6qaEEPDmsHr3T5kTDUKXDrkkeJmN9Hb4qtRpWj2nCMKvtEnSKy?=
=?us-ascii?Q?vTjTZk21fPid5KavzfrGjaAYhZnhYQbKuIjLJEWeWBbctNar1+PUL1V0YVAr?=
=?us-ascii?Q?abNsL17Phv0DoRhEROadX0kXUJv3/4tIX7bWahNHWeTuiNi473/itliHr2rQ?=
=?us-ascii?Q?OcEEBWPlWFmk7oQ1D0SHyviugoyCXU4hHwe+YTAs7wlhJyfBamfOHDC71mOh?=
=?us-ascii?Q?iPm6rhCC+FDPK0DmO/zpRf46DAYUvIjNH8AJsGhX/48I3KyDr5pK/lSjicAV?=
=?us-ascii?Q?IgQE1MLQ6Oc6B35i9ZzmAjlh1wHWa5k0VozQzgdJWJre0m0ELTWSoHD7KHdL?=
=?us-ascii?Q?xuHKrBY2Ui+dGAHhxXCJHWV9d86XcqK8eabz+EoV5pD7LW30xISpIH6TtsZc?=
=?us-ascii?Q?X/K7T+tkhIYRdWsBfH9HqITvQ5NU+6NWw7CXVfe70V7+mHw8APDu1rcZub8C?=
=?us-ascii?Q?puGtMsywoKAoubPrd81QGwpsv/9iibGWe8tN1Ud+BvOYW5itFtAIJ/G6MLbC?=
=?us-ascii?Q?A9u7pLS5HPk7UAOp6SjM8YOO/7tGYQNuHH5TKtP6nYtHEJzrOcYtElW7T6Sf?=
=?us-ascii?Q?Pi0X6zpUCXO3zNGO2uxxtVOdgtnujL5cb+qXiehU9gRs6kbCUjJb3npU6xGz?=
=?us-ascii?Q?QxWL9btCsyNgKmv/GP2cChGCS/UO8ZNhbBPV743eBj13cjnVYONB3by3XjOp?=
=?us-ascii?Q?ODcGF+qUIvO+JeZZ0nLG9AFzo3GGRJqbexcTp7+4prsFm9HbfLp1SNUsvYiw?=
=?us-ascii?Q?CCt6skyOo2Zk2YFd1TvVBaAxpBTv10KyyMHkyIweFZIeFDZ/zkskOUcTmt/7?=
=?us-ascii?Q?4PtiH3iOGzAZ1Ewwi03uEfI0wYvr8thck8zIjh76HOFl2L5w/YxsxA3hfgCE?=
=?us-ascii?Q?9QXM7sLRJbcXCnsct/ubNZKG2xw1+c2qIAMyJVivPZBrZT8mnTAF9tZC0+hG?=
=?us-ascii?Q?ayCCCLXG6DT/V2T2fM0jYW4MYw0tW/NjH+OEKRh65uh54EtQTeNaPJQTiRIR?=
=?us-ascii?Q?GmBxg7uxUVrcesyAByDzGlLxXeXgVOsWri2H/wykBb8HuYjESj9/cWYdQ7FZ?=
=?us-ascii?Q?38aEU//iNcAaU91aAjLjcPD6YJFX/Vu3kZJtYy75dZS4+rsDW3UH9Utb6JJS?=
=?us-ascii?Q?iGQF8yblKddHmQ0iVvOuS58i/SkHlLiaZ7Zu1o0m9ICao4bEzlyhOXx6Sl8a?=
=?us-ascii?Q?qQYgV/U00USlQuAhS0LzpJvshvjEOZNuDCQipNcAirQQmkOHE3j6JHl8Cq8+?=
=?us-ascii?Q?9i2uBJlsRjiX37SGKK82lEUg0mOB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0eb313ad-bdb7-45a7-18ef-08d97d41a336
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2021 20:51:51.2431 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7AA198lPcNxXeb45pePZF07IVddkQJQw2oiz075aDwZM/PyHtb9+fwKXr4Wggbnxl6HYnFl/jIy//FiXEvMCFY7Zuv2+dPQLeIbGNKdm3j8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3927
X-Proofpoint-ORIG-GUID: xBPxkFHSRvJ4BsNQvktp5B1jH6R5el0W
X-Proofpoint-GUID: xBPxkFHSRvJ4BsNQvktp5B1jH6R5el0W
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
definitions=2021-09-21_06,2021-09-20_01,2020-04-07_01
Subject: Re: [dpdk-dev] [EXT] [PATCH v2 4/5] eventdev/rx_adapter: implement
per queue event buffer
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
>this patch implement the per queue event buffer after
>required validations.
>
>Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
>---
> lib/eventdev/rte_event_eth_rx_adapter.c | 188
>++++++++++++++++++------
> 1 file changed, 139 insertions(+), 49 deletions(-)
>
<snip>
>@@ -2277,6 +2356,8 @@
>rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
>
> /* Event buffer with default size =3D 6*BATCH_SIZE */
> rxa_params.event_buf_size =3D ETH_EVENT_BUFFER_SIZE;
>+ rxa_params.use_queue_event_buf =3D false;
>+
Both these params should be passed to the driver layer when=20
RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT is set in caps.
> return rxa_create(id, dev_id, &rxa_params, conf_cb, conf_arg);
> }
>
>@@ -2296,9 +2377,9 @@
>rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t
>dev_id,
> if (rxa_params =3D=3D NULL) {
> rxa_params =3D &temp_params;
> rxa_params->event_buf_size =3D
>ETH_EVENT_BUFFER_SIZE;
>- }
>-
>- if (rxa_params->event_buf_size =3D=3D 0)
>+ rxa_params->use_queue_event_buf =3D false;
>+ } else if ((!rxa_params->use_queue_event_buf &&
>+ rxa_params->event_buf_size =3D=3D 0))
> return -EINVAL;
>
> pc =3D rte_malloc(NULL, sizeof(*pc), 0);
>@@ -2364,7 +2445,8 @@ rte_event_eth_rx_adapter_free(uint8_t id)
> if (rx_adapter->default_cb_arg)
> rte_free(rx_adapter->conf_arg);
> rte_free(rx_adapter->eth_devices);
>- rte_free(rx_adapter->event_enqueue_buffer.events);
>+ if (!rx_adapter->use_queue_event_buf)
>+ rte_free(rx_adapter->event_enqueue_buffer.events);
> rte_free(rx_adapter);
> event_eth_rx_adapter[id] =3D NULL;
>
>@@ -2468,6 +2550,14 @@
>rte_event_eth_rx_adapter_queue_add(uint8_t id,
> return -EINVAL;
> }
>
>+ if ((rx_adapter->use_queue_event_buf &&
>+ queue_conf->event_buf_size =3D=3D 0) ||
>+ (!rx_adapter->use_queue_event_buf &&
>+ queue_conf->event_buf_size !=3D 0)) {
>+ RTE_EDEV_LOG_ERR("Invalid Event buffer size for the
>queue");
>+ return -EINVAL;
>+ }
>+
> dev_info =3D &rx_adapter->eth_devices[eth_dev_id];
>
> if (cap &
>RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
>--
>2.25.1