From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC2E4A00C4; Fri, 30 Sep 2022 11:59:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9088240E5A; Fri, 30 Sep 2022 11:59:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6FB9B40684 for ; Fri, 30 Sep 2022 11:59:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28TL3dml022710; Fri, 30 Sep 2022 02:57:29 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jw1rt69hj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Sep 2022 02:57:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=exgQLIJbxVL6kjL8iISFlJEydBelzCDfZyTzsaIZ1iWCyCmqc2Tp+O+G/EVfubafxU+syayyzF0/eHAO9HLPBdSp1RD6ZNNy3wd805Ji48sIX9s2O6twfoz5KvWvoVbuY0blNNpoAB9GVAr7spJCMyn21jtfL4GlNXNipupR5PzFc85ck9hB4XjBw73P3DQjFuR9VISuRsuVZU75lUrU5aRhMDFVoVLZRoqlscQrUSjHPf8qk/vKGfX1no83+C3OOG8ONjeRQzy4e4kAsQjUmYW/kk6ba9Sx3XkjpGxXw5oLSpu2cS+JSJTqgtfSp4qlcSI7G69i7WFV7lLUVRp5Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zNSKHbDlNWLxzQsv119dz8ASjgcPFumZ/aF6Ul1vKR4=; b=QXKq/EsF7Xm5Sjhqq7k65xun6hoLPxYmHucGa3j2dfEOXUA5NXVI/kR2A6LRZtUF9LP8lm1Trc9N4g6p/CBMIdJ82NxTnq4mfnv5qmZ8mxzDFpqxYh7/t6CizucDap6M/+A+WQ4EBUKjfv1oVh3g2uEeYju0FwULNi4aPWIYt48vY8b6RqmlcDZlMXT2doKPBJzKBjNXFgk70bn44UnrA9LfU8RUmrSGBxmtEiZwBQ5PkWqMoBkmpCFaPDeO6v9QsFqiq8f/LBZ27p6deKVG/2nAD7mELQ6JHNLKvh7++BKmP2z+8W7WV2OelYLL0s9tJI0BxLiHCTpemXL854zdVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zNSKHbDlNWLxzQsv119dz8ASjgcPFumZ/aF6Ul1vKR4=; b=olofrGq5vMqrgR3Ym3lVDDDkvXpqy+X//HbMgPGCxiu8hweD/xaUi9qe/fpU0/rKAVCnFzi9hPFNh7vBl+Q+YR+Lkva1iHQ/tjsAdNMD9SbwVQUMR7Btdp5Fo4rUSVdhQ5yw0cudGpAd8R34ro/88M1+IxkcgnT2TWKdMEQbQCQ= Received: from PH0PR18MB4409.namprd18.prod.outlook.com (2603:10b6:510:e3::13) by MW4PR18MB5232.namprd18.prod.outlook.com (2603:10b6:303:1b6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.19; Fri, 30 Sep 2022 09:57:27 +0000 Received: from PH0PR18MB4409.namprd18.prod.outlook.com ([fe80::ae7a:67d5:bdf:1493]) by PH0PR18MB4409.namprd18.prod.outlook.com ([fe80::ae7a:67d5:bdf:1493%6]) with mapi id 15.20.5676.023; Fri, 30 Sep 2022 09:57:26 +0000 From: Satha Koteswara Rao Kottidi To: Satha Koteswara Rao Kottidi , Aman Singh , Yuying Zhang , Ray Kinsella , Ajit Khaparde , Somnath Kotur , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Sunil Kumar Kori , Qiming Yang , Wenjun Wu , Jiawen Wu , Jian Wang , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko CC: "dev@dpdk.org" , "ferruh.yigit@amd.com" , "bruce.richardson@intel.com" , "konstantin.v.ananyev@yandex.ru" , Jerin Jacob Kollanukkaran Subject: RE: [PATCH v3] ethdev: queue rate parameter changed from 16b to 32b Thread-Topic: [PATCH v3] ethdev: queue rate parameter changed from 16b to 32b Thread-Index: AQHY0v58noIEMJ/OjEqz+9jP/kMRJa33v8QA Date: Fri, 30 Sep 2022 09:57:26 +0000 Message-ID: References: <1663939018-18898-1-git-send-email-skoteshwar@marvell.com> <1664344318-3594-1-git-send-email-skoteshwar@marvell.com> In-Reply-To: <1664344318-3594-1-git-send-email-skoteshwar@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4409:EE_|MW4PR18MB5232:EE_ x-ms-office365-filtering-correlation-id: 92c3221b-d74d-4290-8f67-08daa2ca2e37 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KAr0I/oT8YEHGL+JQQEbKgeNUxBAuZwJoOUeVEYFGbFfGQb8bgXpT8Wl5sYP77WKc6h3EUEgBGhkX6QvA69vTTfebI95QvIMwgJ8MTMMlWHUAu38j+9GshLyr8zsoMtO+YnFJF+pvgbHqUYqoC12hy3jqQVLbFvYyNVBX/aWDgslt0Wu/TrkupIkC1ri+sMLNB+23K2ztF8edRr7eHTLcdj/nPWeWYGAKUvN1AeVt8ph9PWd5GItTmsWijMgPWuUnDHHTadX/mHgCexjHXIENjSshjZdH82AsJ5Ulz2qR+xB41MAOLWWLKhoB/7bJuxGR6JU+C0ZpdxWg3MASclHeDfjFIAX49YaIDDHtIlzjcIWu5j614x9F8YWdAw/64Nlbdfn72lnDKu4h0kViKJNZ0FpeBfoopoUA95MFG7mXjQRYyfJ22yd5kYB4LWeaQeodUcKo7pm+aZ28hInwiPE4yFVG819v2o047fvm2cYzLMif4enVJKx8DvzwFpDOC+uGexyN84863RMWdop8pCvHNJXzmo02Bm8Typ1ceeYSafWJE0n/VMyms63CMTVo27mIukCABlVrkZ/u+OjgQx1cP2g+iedk9UiRqgoj/xQcxMWNfeaW9SxoPEzvpAi2KN1/6TjlrKw8+D4nvefbCnikQ5eRYS57UJ/W68KDyOIMgBVf8Q57/pMkSTesDp9nnuz2N2JitJseohI7edXSs0KnfF4bhenLIZGLLgV8GRHPiifFN1MWzjgY9IIyulRzODLdekh55uq187hO7Bu4UeoSgO/HJvvJmURpL8iuKkqF9nGUprX+xx2f7zmu8/GIV+WhmHia39C+zVuYJc1PfQHXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4409.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(451199015)(53546011)(9686003)(26005)(7696005)(83380400001)(478600001)(6506007)(107886003)(186003)(2906002)(55016003)(8936002)(7416002)(30864003)(52536014)(8676002)(66446008)(54906003)(66556008)(41300700001)(66946007)(110136005)(4326008)(66476007)(316002)(71200400001)(76116006)(64756008)(5660300002)(921005)(33656002)(38070700005)(86362001)(122000001)(38100700002)(23180200003)(357404004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h/Ppz1bSM2EIj4qUuyH0DaNAPlO3BX0Gez6CTgaYNHQwKC1A646n1okbMC7I?= =?us-ascii?Q?/ex9fL6H/xd0C/VvncK41EXv3sR30ibail++c755aYUpvefgzj37XMTPBGMn?= =?us-ascii?Q?2pZF0AQldEvcVnEM0GxoVGtIrg4KtpRG5bXDLScPPZSkld6hZ4VafIKB3rii?= =?us-ascii?Q?XxXj0/m79Um8/AO9Fo0Axl1cV66QSnEoXmvVAFm1MLRLX/TFSJMu7Jln9bA8?= =?us-ascii?Q?er4Z03cOVgT+XOo7TvhfCiO6Rz5UvLUueuydOg4YO9DXlnSmrm1Y+jkqcIf8?= =?us-ascii?Q?wGfQsJyP27iYMqoi2443+irhqSBA1pNbb8MRivP15iq8pCkfc1X8NiBSMaHo?= =?us-ascii?Q?AF7Td90vC0Ju+8JwtvM4FQ1xjKgk6Pvi8AePNIvX/0R6xsvEZkzcZiW21FlK?= =?us-ascii?Q?n3PM3cl0Sktycq1V7cT8FGqLEuFIyEK2JYPbRE/GZUAYjIZUhfnR6ZRBKwwc?= =?us-ascii?Q?BmMwEm6Vh1+Hr2hpElN1U60Alox8tT7Q2xSX0I7eJPT8fJ6mBXm8gI82pV4Q?= =?us-ascii?Q?YMD1cszr3rvWK5mAc7db1C3h57PcpmLc+HcO5cW+xVNqnPZ6DVIvC2E0dVk9?= =?us-ascii?Q?P4SVAYqaX2TSEQ5difzQquTHYAa47aHS0f9VPPIAM8iHplzZCak6AloT/3QZ?= =?us-ascii?Q?CRy0kDxu72jxDk7KbCrxslR4v54TVcnRgzus1wWoQDlYUwi1H1Lj4iWtLG8J?= =?us-ascii?Q?/tGqiTV7EUGxKTY6+NPKkIg2om2uu4Bz40bgOkDejle7Hw5lyFu6bQZ0m7pU?= =?us-ascii?Q?YpzSqE3E9xjBxxK93zxoL9IJ7x7477O/T/llbazomu98i8R8E8QzkCcRTsbV?= =?us-ascii?Q?aui6U5lhH2HPewUgp7wmSnml38jW9EVPy8Ud5mLlGyJLwWYJFYM3DNat/A0B?= =?us-ascii?Q?3bsrVocMBnsAZQOtIR2rk/uOFV3JY2cLSNYgXrevu0OQIbKei/G81qFyULQH?= =?us-ascii?Q?XKgC/N/faxjR5S76SBm/V2HOgMb9jy2QjfGHOAaBxIkRmz8NSW8tb+w6ssWO?= =?us-ascii?Q?kT/TwzeCivH1vgn0f4wl46hJKMgHVzvlzEt6RxKCLEoVazEtNo9gkvz3FUK6?= =?us-ascii?Q?maPmUYhn/qZ7jijepJ6r5WVXUHRe5nuTQsh2IXXvTogUrp6QQerxyukBLm17?= =?us-ascii?Q?0Dc5GdOLNpMzBaKFrHKMSlt3gXQ6b8c8Y1qG7QyiDfH0I2+KymZa72YuzfoO?= =?us-ascii?Q?lzNqPxDr3N2rChxAyBw/UkXzGOrW7UmyJNqb1dot6tLibS1n9WBYa6DL+6bH?= =?us-ascii?Q?D7wAlUltfTXSZmGmiqfhfwdInZW++87dInPeW5jBeDXD1uNWR1acROpQgTQy?= =?us-ascii?Q?VrXWSlEKywSy5N2YR0NWPLT6kncV4pN9uAPWwlwIsLshDSL/dTO4HolpOgLO?= =?us-ascii?Q?9KrZVinlRBbej5+8I2aDowCE1Es2beyYfePGcz5pyoSi2iEXvzhVHmWC6Q+T?= =?us-ascii?Q?/hij2CSSMp0CrQAoZQkC5CTSkQlgtSRSstyEw005pBfucyfNb/YajqKIwCe1?= =?us-ascii?Q?3zgTKrJ2ylLwVXSkaHxfuRKVNkqPtVfc8NhAFkTrAhK7FN1GTIEsqUjHl7ys?= =?us-ascii?Q?PxicSOssC9nSACEP646oRLVilO65jgQ01wm56Eju?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4409.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92c3221b-d74d-4290-8f67-08daa2ca2e37 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 09:57:26.8520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4/HzNfE6nuYU6ni8Xb44rqsf5K1YNOZG4GygWWHylUZ3R32CPJZ6f4CbTjwmkDACJHBxF5oIz4jHk1ko5QsEmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR18MB5232 X-Proofpoint-GUID: PPxByIZ-kzGvLIiMTbTK5350me3o96t3 X-Proofpoint-ORIG-GUID: PPxByIZ-kzGvLIiMTbTK5350me3o96t3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-30_04,2022-09-29_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi All, Could you please review and provide suggestions if any. Thanks, Satha. -----Original Message----- From: skoteshwar@marvell.com =20 Sent: Wednesday, September 28, 2022 11:22 AM To: Aman Singh ; Yuying Zhang ; Ray Kinsella ; Ajit Khaparde ; Somnath Kotur ; Nithin Kumar Dabilpuram = ; Kiran Kumar Kokkilagadda ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi ; Qiming Yang ; Wenjun Wu ; Jiawen Wu ; Jian Wang ; Thomas Monjalon ; Ferruh Yigit ; Andrew Rybchenko Cc: dev@dpdk.org; ferruh.yigit@amd.com; bruce.richardson@intel.com; konstan= tin.v.ananyev@yandex.ru; Jerin Jacob Kollanukkaran Subject: [PATCH v3] ethdev: queue rate parameter changed from 16b to 32b From: Satha Rao The rate parameter modified to uint32_t, so that it can work for more than = 64 Gbps. Signed-off-by: Satha Rao --- v2: Fixed checkpatch warnings v3: updated release notes, cleanup deprecation, addressed review comments app/test-pmd/cmdline.c | 8 ++++---- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 4 ++-- doc/guides/rel_notes/deprecation.rst | 5 ----- doc/guides/rel_notes/release_22_11.rst | 3 +++ drivers/net/bnxt/rte_pmd_bnxt.c | 4 ++-- drivers/net/bnxt/rte_pmd_bnxt.h | 2 +- drivers/net/cnxk/cnxk_ethdev.h | 2 +- drivers/net/cnxk/cnxk_tm.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- drivers/net/ixgbe/ixgbe_ethdev.h | 4 ++-- drivers/net/ixgbe/rte_pmd_ixgbe.c | 2 +- drivers/net/ixgbe/rte_pmd_ixgbe.h | 2 +- drivers/net/txgbe/txgbe_ethdev.c | 2 +- drivers/net/txgbe/txgbe_ethdev.h | 2 +- lib/ethdev/ethdev_driver.h | 2 +- lib/ethdev/rte_ethdev.c | 2 +- lib/ethdev/rte_ethdev.h | 2 +- 18 files changed, 27 insertions(+), 29 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 51321de.= .adfdc1d 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -8106,7 +8106,7 @@ struct cmd_queue_rate_limit_result { cmdline_fixed_string_t queue; uint8_t queue_num; cmdline_fixed_string_t rate; - uint16_t rate_num; + uint32_t rate_num; }; =20 static void cmd_queue_rate_limit_parsed(void *parsed_result, @@ -8147,7 +8= 147,7 @@ static void cmd_queue_rate_limit_parsed(void *parsed_result, rate, "rate"); static cmdline_parse_token_num_t cmd_queue_rate_limit_ratenum =3D TOKEN_NUM_INITIALIZER(struct cmd_queue_rate_limit_result, - rate_num, RTE_UINT16); + rate_num, RTE_UINT32); =20 static cmdline_parse_inst_t cmd_queue_rate_limit =3D { .f =3D cmd_queue_rate_limit_parsed, @@ -8174,7 +8174,7 @@ struct cmd_vf_rate_limit_result { cmdline_fixed_string_t vf; uint8_t vf_num; cmdline_fixed_string_t rate; - uint16_t rate_num; + uint32_t rate_num; cmdline_fixed_string_t q_msk; uint64_t q_msk_val; }; @@ -8218,7 +8218,7 @@ static void cmd_vf_rate_limit_parsed(void *parsed_res= ult, rate, "rate"); static cmdline_parse_token_num_t cmd_vf_rate_limit_ratenum =3D TOKEN_NUM_INITIALIZER(struct cmd_vf_rate_limit_result, - rate_num, RTE_UINT16); + rate_num, RTE_UINT32); static cmdline_parse_token_string_t cmd_vf_rate_limit_q_msk =3D TOKEN_STRING_INITIALIZER(struct cmd_vf_rate_limit_result, q_msk, "queue_mask"); diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index c90cdfe..6= dd543d 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -5914,7 +5914,7 @@ struct igb_ring_desc_16_bytes { } =20 int -set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) +set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint32_t=20 +rate) { int diag; struct rte_eth_link link; @@ -5942,7 +5942,7 @@ struct igb_ring_desc_16_bytes { } =20 int -set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, uint64_t q= _msk) +set_vf_rate_limit(portid_t port_id, uint16_t vf, uint32_t rate,=20 +uint64_t q_msk) { int diag =3D -ENOTSUP; =20 diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index ddf5e21.= .0af3aa1 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -1097,8 +1097,8 @@ void port_rss_reta_info(portid_t port_id, uint16_t nb_rx_desc, unsigned int socket_id, struct rte_eth_rxconf *rx_conf, struct rte_mempool *mp); =20 -int set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t ra= te); -int set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, +int set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint32_t=20 +rate); int set_vf_rate_limit(portid_t port_id, uint16_t vf, uint32_t=20 +rate, uint64_t q_msk); =20 int set_rxq_avail_thresh(portid_t port_id, uint16_t queue_id, diff --git a= /doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rs= t index e0fa5ef..9292080 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -87,11 +87,6 @@ Deprecation Notices us extending existing enum/define. One solution can be using a fixed size array instead of ``.*MAX.*`` valu= e. =20 -* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` in = Mbps. - The queue rate is limited to 64 Gbps because declared as ``uint16_t``. - The ``rate`` parameter will be modified to ``uint32_t`` in DPDK 22.11 - so that it can work for more than 64 Gbps. - * ethdev: Since no single PMD supports ``RTE_ETH_RX_OFFLOAD_HEADER_SPLIT`` offload and the ``split_hdr_size`` field in structure ``rte_eth_rxmode`` to enable per-port header split, they will be removed in DPDK 22.11. diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/= release_22_11.rst index 2e076ba..3c7e471 100644 --- a/doc/guides/rel_notes/release_22_11.rst +++ b/doc/guides/rel_notes/release_22_11.rst @@ -129,6 +129,9 @@ API Changes configuration (``dev_conf.fdir_conf``). Moved corresponding structures to internal API since some drivers still use it internally. =20 +* ethdev: The type of parameter ``rate`` of the=20 +``rte_eth_set_queue_rate_limit`` + changed from ``uint16_t`` to ``uint32_t`` to support more than 64 Gbps. + =20 ABI Changes ----------- diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnx= t.c index 77ecbef..4dc38a2 100644 --- a/drivers/net/bnxt/rte_pmd_bnxt.c +++ b/drivers/net/bnxt/rte_pmd_bnxt.c @@ -172,12 +172,12 @@ int rte_pmd_bnxt_set_vf_mac_addr(uint16_t port, uint1= 6_t vf, } =20 int rte_pmd_bnxt_set_vf_rate_limit(uint16_t port, uint16_t vf, - uint16_t tx_rate, uint64_t q_msk) + uint32_t tx_rate, uint64_t q_msk) { struct rte_eth_dev *eth_dev; struct rte_eth_dev_info dev_info; struct bnxt *bp; - uint16_t tot_rate =3D 0; + uint32_t tot_rate =3D 0; uint64_t idx; int rc; =20 diff --git a/drivers/net/bnxt/rte_pmd_bnxt.h b/drivers/net/bnxt/rte_pmd_bnx= t.h index 86b8d71..174c18a 100644 --- a/drivers/net/bnxt/rte_pmd_bnxt.h +++ b/drivers/net/bnxt/rte_pmd_bnxt.h @@ -184,7 +184,7 @@ int rte_pmd_bnxt_set_vf_vlan_filter(uint16_t port, uint= 16_t vlan, * - (-EINVAL) if *vf* or *mac_addr* is invalid. */ int rte_pmd_bnxt_set_vf_rate_limit(uint16_t port, uint16_t vf, - uint16_t tx_rate, uint64_t q_msk); + uint32_t tx_rate, uint64_t q_msk); =20 /** * Get VF's statistics diff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.= h index c09e9bf..5204c46 100644 --- a/drivers/net/cnxk/cnxk_ethdev.h +++ b/drivers/net/cnxk/cnxk_ethdev.h @@ -558,7 +558,7 @@ int cnxk_nix_timesync_write_time(struct rte_eth_dev *et= h_dev, uint64_t cnxk_nix_rxq_mbuf_setup(struct cnxk_eth_dev *dev); int cn= xk_nix_tm_ops_get(struct rte_eth_dev *eth_dev, void *ops); int cnxk_nix_tm= _set_queue_rate_limit(struct rte_eth_dev *eth_dev, - uint16_t queue_idx, uint16_t tx_rate); + uint16_t queue_idx, uint32_t tx_rate); int cnxk_nix_tm_mark_vlan_dei(struct rte_eth_dev *eth_dev, int mark_green, int mark_yellow, int mark_red, struct rte_tm_error *error); diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c index = d45e70a..9d8cd3f 100644 --- a/drivers/net/cnxk/cnxk_tm.c +++ b/drivers/net/cnxk/cnxk_tm.c @@ -751,7 +751,7 @@ struct rte_tm_ops cnxk_tm_ops =3D { =20 int cnxk_nix_tm_set_queue_rate_limit(struct rte_eth_dev *eth_dev, - uint16_t queue_idx, uint16_t tx_rate_mbps) + uint16_t queue_idx, uint32_t tx_rate_mbps) { struct cnxk_eth_dev *dev =3D cnxk_eth_pmd_priv(eth_dev); uint64_t tx_rate =3D tx_rate_mbps * (uint64_t)1E6; diff --git a/drivers/n= et/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 1dfad0e..9ff8ee0 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2475,7 +2475,7 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_devi= ce *pci_dev) =20 int ixgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf, - uint16_t tx_rate, uint64_t q_msk) + uint32_t tx_rate, uint64_t q_msk) { struct ixgbe_hw *hw; struct ixgbe_vf_info *vfinfo; @@ -6090,7 +6090,7 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev *= dev, bool on) =20 int ixgbe_set_queue_rate_limit(struct rte_eth_dev *dev, - uint16_t queue_idx, uint16_t tx_rate) + uint16_t queue_idx, uint32_t tx_rate) { struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint32_t rf_dec, rf_int; diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_eth= dev.h index 0773a7e..b4db3f4 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.h +++ b/drivers/net/ixgbe/ixgbe_ethdev.h @@ -753,13 +753,13 @@ void ixgbe_fdir_stats_get(struct rte_eth_dev *dev, =20 int ixgbe_vt_check(struct ixgbe_hw *hw); int ixgbe_set_vf_rate_limit(stru= ct rte_eth_dev *dev, uint16_t vf, - uint16_t tx_rate, uint64_t q_msk); + uint32_t tx_rate, uint64_t q_msk); bool is_ixgbe_supported(struct rte_eth_dev *dev); int ixgbe_tm_ops_get(st= ruct rte_eth_dev *dev, void *ops); void ixgbe_tm_conf_init(struct rte_eth_= dev *dev); void ixgbe_tm_conf_uninit(struct rte_eth_dev *dev); int ixgbe_= set_queue_rate_limit(struct rte_eth_dev *dev, uint16_t queue_idx, - uint16_t tx_rate); + uint32_t tx_rate); int ixgbe_rss_conf_init(struct ixgbe_rte_flow_rss_conf *out, const struct rte_flow_action_rss *in); int ixgbe_action_rss_same(const= struct rte_flow_action_rss *comp, diff --git a/drivers/net/ixgbe/rte_pmd_i= xgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c index 9729f85..4ff7f37 100644 --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c @@ -498,7 +498,7 @@ =20 int rte_pmd_ixgbe_set_vf_rate_limit(uint16_t port, uint16_t vf, - uint16_t tx_rate, uint64_t q_msk) + uint32_t tx_rate, uint64_t q_msk) { struct rte_eth_dev *dev; =20 diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_= ixgbe.h index 426fe58..7ca1126 100644 --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h @@ -380,7 +380,7 @@ int rte_pmd_ixgbe_macsec_select_rxsa(uint16_t port, uin= t8_t idx, uint8_t an, * - (-EINVAL) if bad parameter. */ int rte_pmd_ixgbe_set_vf_rate_limit(uint16_t port, uint16_t vf, - uint16_t tx_rate, uint64_t q_msk); + uint32_t tx_rate, uint64_t q_msk); =20 /** * Set all the TCs' bandwidth weight. diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_eth= dev.c index 4422472..86ef979 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -3764,7 +3764,7 @@ static int txgbe_dev_xstats_get_names_by_id(struct rt= e_eth_dev *dev, =20 int txgbe_set_queue_rate_limit(struct rte_eth_dev *dev, - uint16_t queue_idx, uint16_t tx_rate) + uint16_t queue_idx, uint32_t tx_rate) { struct txgbe_hw *hw =3D TXGBE_DEV_HW(dev); uint32_t bcnrc_val; diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_eth= dev.h index e425ab4..5171a6c 100644 --- a/drivers/net/txgbe/txgbe_ethdev.h +++ b/drivers/net/txgbe/txgbe_ethdev.h @@ -586,7 +586,7 @@ int txgbe_set_vf_rate_limit(struct rte_eth_dev *dev, ui= nt16_t vf, void txgbe_tm_conf_init(struct rte_eth_dev *dev); void txgbe_t= m_conf_uninit(struct rte_eth_dev *dev); int txgbe_set_queue_rate_limit(str= uct rte_eth_dev *dev, uint16_t queue_idx, - uint16_t tx_rate); + uint32_t tx_rate); int txgbe_rss_conf_init(struct txgbe_rte_flow_rss_conf *out, const struct rte_flow_action_rss *in); int txgbe_action_rss_same(const= struct rte_flow_action_rss *comp, diff --git a/lib/ethdev/ethdev_driver.h = b/lib/ethdev/ethdev_driver.h index a0e0b2a..a89450c 100644 --- a/lib/ethdev/ethdev_driver.h +++ b/lib/ethdev/ethdev_driver.h @@ -598,7 +598,7 @@ typedef int (*eth_uc_all_hash_table_set_t)(struct rte_e= th_dev *dev, /** @internal Set queue Tx rate. */ typedef int (*eth_set_queue_rate_limit_t)(struct rte_eth_dev *dev, uint16_t queue_idx, - uint16_t tx_rate); + uint32_t tx_rate); =20 /** @internal Add tunneling UDP port. */ typedef int (*eth_udp_tunnel_por= t_add_t)(struct rte_eth_dev *dev, diff --git a/lib/ethdev/rte_ethdev.c b/li= b/ethdev/rte_ethdev.c index 1979dc0..4b11dae 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -4388,7 +4388,7 @@ enum { } =20 int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx, - uint16_t tx_rate) + uint32_t tx_rate) { struct rte_eth_dev *dev; struct rte_eth_dev_info dev_info; diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index b62ac5= b..7149dd7 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -4165,7 +4165,7 @@ int rte_eth_dev_uc_hash_table_set(uint16_t port_id, s= truct rte_ether_addr *addr, * - (-EINVAL) if bad parameter. */ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx, - uint16_t tx_rate); + uint32_t tx_rate); =20 /** * Configuration of Receive Side Scaling hash computation of Ethernet devi= ce. -- 1.8.3.1