From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4504A00C4; Thu, 29 Sep 2022 06:52:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C577840FAE; Thu, 29 Sep 2022 06:52:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id AB4AD40E5A for ; Thu, 29 Sep 2022 06:52:02 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28T1UXrZ022478; Wed, 28 Sep 2022 21:51:57 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jw1rt0kdw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Sep 2022 21:51:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6Y60TqCWZPWssZo+mNrO1QAwcFEOveCSpj+jVn53eT86xk5jYPOXiA9wjMb2ieFqCcwL0OxATBWzgRObx4TVRQ4ybIoYyUrMjTxIRVGjX79tvI48ZsHik6zYC3BlF9u7YDFe1wmRit8N8vs/dZzJwlomKZHJ1HhTJG+QFSvlZ5uLL95NZWA+c4Qi8Zt50Z4tMAuQwAd74oqG9mrkmbEGytlUYPnM7xUVizl3s6S6el+2iAC1Sl6gTdpf8vC9KkIBUNJI9Q2SiPkedHOSGAoCkRwoVcVN696CvOYZuGUVQwK+LGcn8KejrZ5pBJvJgqgFr5zMYyQFZXtXTeRswauKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H5SCuQv4lGiz/Sn9cXZEy62fFbD52SwwbFcoFQEzmJQ=; b=XdjehvDCur2ScJRj9TxsX40bRXqv03IgLZO8zUVLGr/Cnv65fi7SObZ2cdTAX+p/Be6FWc/BuB4bjj2bXYsA1wsFCyfyQvBN0rIP9n6a479+dS8S7h2pzfWB+Aupci+zruhbwFaqE3ElFzFM2tmMTLz3SrFrppPq5/oX1uuMYFceFjkzt05EYoJn6XcNw8ShvCJJ8J+BbVWTNAdiJ0ChpONAGdWUZ+KCsrS8apwXPABedhVTA74Ks8d3wVGjuJidx2syTGHmHd2vj8XTh9v1u6WpuFvSBM+mE63dhMISnsyyfn4tsUkTCL1A7hm0FqUdwJ6NQbAuoI62IblCHly12Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H5SCuQv4lGiz/Sn9cXZEy62fFbD52SwwbFcoFQEzmJQ=; b=T3JiKG1jo1LI/EupieWMs1/siQFV9exKahOqY3WWJQ24WD7xBAbGGTKepuSYul2kAatp5Uk2Go+rfU3fPFdpRKtyUT2L6BSA/YtQ5ACHtfdsq3Wok2fJsxEVOtPHYmnv2qxbZOYOScTQKFekzMff/Gr1cVutNES06AXw/fiPqTE= Received: from PH0PR18MB4425.namprd18.prod.outlook.com (2603:10b6:510:ef::13) by MN2PR18MB3511.namprd18.prod.outlook.com (2603:10b6:208:264::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 04:51:54 +0000 Received: from PH0PR18MB4425.namprd18.prod.outlook.com ([fe80::16f8:9275:a441:cfec]) by PH0PR18MB4425.namprd18.prod.outlook.com ([fe80::16f8:9275:a441:cfec%5]) with mapi id 15.20.5676.017; Thu, 29 Sep 2022 04:51:54 +0000 From: Shijith Thotton To: Olivier Matz CC: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula , "Honnappa.Nagarahalli@arm.com" , "bruce.richardson@intel.com" , Jerin Jacob Kollanukkaran , "mb@smartsharesystems.com" , "stephen@networkplumber.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v3 0/5] mbuf dynamic field expansion Thread-Topic: [EXT] Re: [PATCH v3 0/5] mbuf dynamic field expansion Thread-Index: AQHYzcH9viM6SU85XUWUs/rM3C70N6301sYAgAEJPUA= Date: Thu, 29 Sep 2022 04:51:53 +0000 Message-ID: References: <20220907134340.3629224-1-sthotton@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4425:EE_|MN2PR18MB3511:EE_ x-ms-office365-filtering-correlation-id: cb007136-53db-46f9-298c-08daa1d6549a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qidkSwtBqFDhzzlk96ABK64DinUe1LXbQ8pz4Pp8RPanAPqE0bsGJeNrKWQjsL4MqOb0xr0dzmMA4vILZs7LkqGloL3QVOjffPWLKqz+XWv2aO4L+8cZpebcvU7mTuaxrdnoM20/ZejNKblBRUAehK2N//HtMoJre4vhHAa2XDEHpQF70Aj3SOAxA727TAA1rM70G5iAmmnx61s3G+NYjimQ5aMU0BPTjGWDatK/oLhxfygip699V+4kOMpvQ/rgC0R0ZXpYZFjwUNiXAKyaXjfoKBvTmR13Bm0OG77o3zopnEkZIsgza3Re3jBUtCvv8Ekj9X6UQVn63K3g97w3/wX2YUmmtGKazcD+01JXGBqhlYSX2eww8RJAA9BB9Nh2QHV23s6iJlm6qm9zD3OiwVmQgpX2qrjgP/5k3AkhhB3zzmhc0I0Ej4IehKlc4wcaU0I+u/fQocWS8AW4JVQrpilkbaIB1LKESKJ93vBOTkKuZjqKvtT01/RE7fkjSWPpr4Moh8gEagjel+UwPQ05puHEuDyQ1tGY6SaaFrhv1rgbDoJwAf05tgThsQz4bcfl4IUVS6lO4Ga++b9DmJm9QxHuM12Ja9uIM9fmseCFAgblbgaRnYq/3nC8EBsGbt+hSHVZAtLRClnpjGU4gX3EKjYPqYKJHbbzdckBxcisj1ZfYIalINrC2+liMy7ZZlUl+Tre5GUvSMXiz2LcBOxJvslS1GWoeND+CH5gCvC2djiRXA7ICcMouv61EOhE1GfIuwPQF3lyy8edXqllOfO+YKX9NXNY2hm6sy5qSmDai9I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4425.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199015)(33656002)(54906003)(6916009)(86362001)(316002)(38070700005)(122000001)(186003)(83380400001)(38100700002)(966005)(26005)(478600001)(71200400001)(66556008)(9686003)(76116006)(4326008)(8676002)(66446008)(6506007)(66946007)(7696005)(66476007)(41300700001)(52536014)(5660300002)(2906002)(64756008)(55016003)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QaaU8GOzRJPWNE7XcXm1iBciF4NRZFMAvYVbeBH5QbEBzXuubNR8DmujvROu?= =?us-ascii?Q?WMaIKTB3MypnyPtq97W9+d7fmr1IJyo7jXt9M66JAxYkeIN4gxNuJx6lsKzg?= =?us-ascii?Q?K8SD524K31vNcV+FphAFZHBv/zDJo5IQuNaJbhK6TwBWlLfUKFUBd2dShour?= =?us-ascii?Q?ISrj9OVL0kENRdnSYBoylslJj2jeXr5cZ3I+8nhZLRWUZoCjtYnQeQ7/QwDo?= =?us-ascii?Q?iWkiwWMUYcfdOCop9EjrI6M2sFnnBAd1YN12NkeYDhxKa6n0s6NKXxNQ24B2?= =?us-ascii?Q?l48gi1EXuu4Jk3yJXLN3HX9j1KEBKQ5KASk81opAuO3eiGbNK1Fg9Qy9rtcs?= =?us-ascii?Q?bIteBX66pn9RptrPQgKvlQaVJkDESIFNo05SzFnuX86A60nMzGW4BevsTXIo?= =?us-ascii?Q?WX8suwlAMjQL34vYKZhjBaB6xIqQqJ63I60lHLil5pfkU/LlZSqLSLG7Iw5a?= =?us-ascii?Q?FAwkPDysZLnnaV9Qp80Dd1m3OMA/1Fo86gyct6f9zmgWFJ18vIVegFm8FU7i?= =?us-ascii?Q?IsP5V/v1QZR24x8Kbyf9cdNKcjdXrfSpoWYuO/0U8JubiObF8f1tPO//6fc8?= =?us-ascii?Q?kwqMhd2M4TCw5Wky3yKhY9raAW22l8hGQRrEz7DC5y01Zp/YLBN+Pv0zNGQc?= =?us-ascii?Q?8clbbmCrcSKg85L8DqAInVk+79x0hUv6fuR9VKBKJ+SQWM2qE9qALMKWWhzP?= =?us-ascii?Q?oBwA5NWOfjxUqMdt2p/lEu4CQFEFzn1cjuX91CJhHPMIfDM0tKc9zNJ3tr76?= =?us-ascii?Q?P2Mx442BGnxu0m1TxehmpKPY1GYVijm/TpUm8fFkoENONQm0yj00GQrhSL7i?= =?us-ascii?Q?qli3SLSkpGTkaB5vHo21FPxQAVnUSwbkbpFUlrx7Y6npjISLxePHLnhVvz55?= =?us-ascii?Q?dm0wzQS9T43hcRvGIM/cvGZsO+EdLYQKjP1Jh4ciesxvJDxG74daUS3B3I4D?= =?us-ascii?Q?TA+GUZ13LZWayrR10QxUIPJOlfEcJ6x/VWraRI89rg7stMK/kFAfDIB0XFnl?= =?us-ascii?Q?JKC3XncsqRpX5Y4Wd951uoBcHAN+56GM17szqguQ9EjNaDsPt1yOf/SAuD9E?= =?us-ascii?Q?tzdjI0pF0oGwfJwBcFpLfLxEy3eX7/Hkx7YLzxrIPZJqFm2ZpO0GQYD9dpCZ?= =?us-ascii?Q?LGNUroqVag3xc1JR+TOjetlhmuuFdKSHGxWYmL014vFAtJn1TzGSj5g6Zjwr?= =?us-ascii?Q?pjpnYwuvEvPyZw2FMkAfWNT7DEWMr2EAO9rStlP2wDZgOGbP2l7IR7Z6bKfg?= =?us-ascii?Q?l30YrGRWnzUVjPycUbcexLpLN7viVF3CT79Ao8+XZ9qCatl4YRU1s4MYuIiX?= =?us-ascii?Q?k2dP8pJJKo2m1Wf/XMJ6yO5QA4In18jyts4CpSt7xcfqYPS4M/5tmueKG1cT?= =?us-ascii?Q?I4ldEGpTdwx/sWFcKKvqV4Ev1rEVPztCqhNasIhUXeUALGUFU1FL93rGTQXX?= =?us-ascii?Q?9Dpujh6WEU17IlaMqQuxGlgThagUzCdqhvhNtj6iN7aXqhHhp67+L25hzW0M?= =?us-ascii?Q?AEecnJ2APP1G6Sh1fLbZalNFuQkHc3U9W2ue80ILVv/9iXmROw2/BpzfVukq?= =?us-ascii?Q?1TkcPtfKoRh6QGpbyKRWUhMpB9e35WCs1nxYsBUZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4425.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb007136-53db-46f9-298c-08daa1d6549a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2022 04:51:54.0340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lygTFhtmWAk1xL+nd8N8jyEUnkZLHrqkXKsc6M239ztWtREbsuwOLI76fUOaMtv1wLr9qhTnDRmyFGQTrajXZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3511 X-Proofpoint-GUID: f-pc4JKMmdpacnz0Ba0xdXXhINO9SdCE X-Proofpoint-ORIG-GUID: f-pc4JKMmdpacnz0Ba0xdXXhINO9SdCE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-29_02,2022-09-28_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Olivier, Thanks for the review. >On Wed, Sep 21, 2022 at 07:26:16PM +0530, Shijith Thotton wrote: >> This is a continuation of the discussions[1] to add mbuf physical addres= s field to >dynamic field. >> Previous version was to add PA field to dynamic field area based on the = EAL >IOVA mode option. It was >> deemed unsafe as some components could still use the PA field without >checking IOVA mode and there >> are drivers which need PA to work. One suggestion was to make the IOVA m= ode >check at compile time so >> that drivers which need PA can be disabled during build. This series add= s this >new meson build >> options. Second patch adds mbuf PA field to dynamic field on such builds= . Last >two patches enable >> Marvell cnxk PMDs and software PMDs in IOVA as VA build as they work wit= hout >PA field. > >Thank you for this patchset. > >To be honnest, initially I was really reserved to remove the use of >buf_iova for some specific platforms. > >But what made me change my mind is that the removal if buf_iova will >likely happen in the long-term future. It looks there is a consensus on >this. I think your patchset is a good way to prepare this transition. > >What is missing, I think, is a good description of the problem you are >solving: > >- more space for dynamic mbuf fields -> why? can you give more detail abou= t > this need? =20 Idea was to let app/lib use an additional 8-bytes of dynamic area. >- increase performance -> you previously said that it was not your point, > but if we move the next field into the first cache line, I think this > has to be highlighted. Out of curiosity, did you made measurements? > I'm yet to do it. I will update, once I have the numbers. >> >> 1. https://urldefense.proofpoint.com/v2/url?u=3Dhttps- >3A__inbox.dpdk.org_dev_57d2ab7fff672716d37ba4078e2e3bb2db126607.1656605 >763.git.sthotton- >40marvell.com_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DG9w4KsPaQLACBf >GCL35PtiRH996yqJDxAZwrWegU2qQ&m=3DO9JeIb0lfExyVnC8dV3WUADowh165KkS >3s9JrmAjLwj8Uw5Iyb0tqSQ9YvQWpbIc&s=3DDaHEYGwUqUmAFmQ9Jkj8jGnOS4aw8 >iZ8Tcww-jPTdFE&e=3D . >> >> v3: >> * Cleared use of buf_iova from cnxk PMD. >> >> v2: >> * Used RTE_IOVA_AS_VA instread of rte_is_iova_as_va_build(). >> * Moved mbuf next pointer to first cacheline if RTE_IOVA_AS_VA =3D 1. >> >> Shijith Thotton (5): >> build: add meson option to configure IOVA mode as VA >> mbuf: add second dynamic field member for VA only build >> lib: move mbuf next pointer to first cache line >> drivers: mark Marvell cnxk PMDs work with IOVA as VA >> drivers: mark software PMDs work with IOVA as VA >> >> app/test-bbdev/test_bbdev_perf.c | 2 +- >> app/test-crypto-perf/cperf_test_common.c | 5 +-- >> app/test/test_bpf.c | 2 +- >> app/test/test_dmadev.c | 33 ++++++-------- >> app/test/test_mbuf.c | 12 +++--- >> app/test/test_pcapng.c | 2 +- >> config/arm/meson.build | 8 +++- >> config/meson.build | 1 + >> drivers/common/cnxk/meson.build | 1 + >> drivers/crypto/armv8/meson.build | 1 + >> drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 4 +- >> drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 2 +- >> drivers/crypto/cnxk/meson.build | 2 + >> drivers/crypto/ipsec_mb/meson.build | 1 + >> drivers/crypto/null/meson.build | 1 + >> drivers/crypto/openssl/meson.build | 1 + >> drivers/dma/cnxk/meson.build | 1 + >> drivers/dma/skeleton/meson.build | 1 + >> drivers/event/cnxk/meson.build | 1 + >> drivers/event/dsw/meson.build | 1 + >> drivers/event/opdl/meson.build | 1 + >> drivers/event/skeleton/meson.build | 1 + >> drivers/event/sw/meson.build | 1 + >> drivers/mempool/bucket/meson.build | 1 + >> drivers/mempool/cnxk/meson.build | 1 + >> drivers/mempool/ring/meson.build | 1 + >> drivers/mempool/stack/meson.build | 1 + >> drivers/meson.build | 6 +++ >> drivers/net/af_packet/meson.build | 1 + >> drivers/net/af_xdp/meson.build | 2 + >> drivers/net/bonding/meson.build | 1 + >> drivers/net/cnxk/cn10k_tx.h | 55 +++++++----------------- >> drivers/net/cnxk/cn9k_tx.h | 55 +++++++----------------- >> drivers/net/cnxk/cnxk_ethdev.h | 1 - >> drivers/net/cnxk/meson.build | 1 + >> drivers/net/failsafe/meson.build | 1 + >> drivers/net/memif/meson.build | 1 + >> drivers/net/null/meson.build | 1 + >> drivers/net/pcap/meson.build | 1 + >> drivers/net/ring/meson.build | 1 + >> drivers/net/tap/meson.build | 1 + >> drivers/raw/cnxk_bphy/meson.build | 1 + >> drivers/raw/cnxk_gpio/meson.build | 1 + >> drivers/raw/skeleton/meson.build | 1 + >> lib/eal/linux/eal.c | 7 +++ >> lib/mbuf/rte_mbuf.c | 8 ++-- >> lib/mbuf/rte_mbuf.h | 17 +++++--- >> lib/mbuf/rte_mbuf_core.h | 55 ++++++++++++++++++------ >> lib/mbuf/rte_mbuf_dyn.c | 2 + >> lib/meson.build | 3 ++ >> lib/vhost/vhost.h | 2 +- >> lib/vhost/vhost_crypto.c | 54 +++++++++++++++++------ >> meson_options.txt | 2 + >> 53 files changed, 220 insertions(+), 150 deletions(-) >> >> -- >> 2.25.1 >>