From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D63CAA04FF; Mon, 4 Apr 2022 11:35:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8762240696; Mon, 4 Apr 2022 11:35:55 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id F186E4068C for <dev@dpdk.org>; Mon, 4 Apr 2022 11:35:53 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2340MvbR011266; Mon, 4 Apr 2022 02:35:50 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2174.outbound.protection.outlook.com [104.47.58.174]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3f6kupeh8n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Apr 2022 02:35:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CaFK5jj+fAWcbPzuTDSBlaFBKivL3ANeEmMd/0CyX0y5F4M/yP6JQHupRRVRZKXzRu/qJEjpPOKrY6pE9XtZg5qlkPkU1u5iPQit3A4FpwqZvGs7pmqwYWt0HQ778QUH2uYynoNcshrdSEIbcBxyZANWmhTinHNP9XTqdaVkWvvxNmHvkndFAjnzn74jhmSmRpJRnPiPqDX6/vaeIJ7JU46k8L3WXg+CKwmXmEGJzeVWFMNI2APQugpGhwmth4UUwlHdiJm+VlQn+2KO3sP9b06BK0hG7MHYqr7KCosuLhAz5IK3A7kQuvfSVnJ6LWIYA15onFudt5gIh4vnNxCVZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DbBIpSD6+ycsFA4YvMcF+EJNDA9FEC6P0Fgv3KYz4l4=; b=JOIB3rFlMlyZC1oTT84LMr8bQcAXlu3NM6BQKVM18WTh5pd4ZI0XvokVqW9Swp+GYxYXftEcvIIJcmAX57kBcqxVku0eDxt4wISKWDDRDEa8fIKgR8V8QzGT9k5ii6dgMHNWDHz3u+kR5pK6uNa5cUqQ/t37bAduHnL9IkhMMLgiQedWv53QiHGyoR/DcnmELjlRKnDtMWmdHmmSnwhXpUyJF50RHML7uA/NYNM5BayavLMzFDcCo7T7iO3EPTTq0F0wacoHt9s/KuGScXTNPL/01YiUlEPecpCwW5jPE8A0xZPzQFyZXg3ZkhdZBLD0FPT2LEOoxdoa/YYeBuaaUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DbBIpSD6+ycsFA4YvMcF+EJNDA9FEC6P0Fgv3KYz4l4=; b=qLM5XOHXji41DoBBDSJlGUQGbIMBWYZbjOSb2tfXVJdPoczAwnd5PjQRVP9IAE3nYdDaAGK1xCSEU/T7JO3No7pGXSOAl0iDDJCqgHPJyfqedDM8OhCNmbY/uaHIvOapvMs6FLc709/y3qKXnVwBWAgFgPBwdR5sJBLw/whxPg0= Received: from PH0PR18MB4425.namprd18.prod.outlook.com (2603:10b6:510:ef::13) by BN8PR18MB2980.namprd18.prod.outlook.com (2603:10b6:408:aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 09:35:47 +0000 Received: from PH0PR18MB4425.namprd18.prod.outlook.com ([fe80::3967:c554:ec3e:b8a9]) by PH0PR18MB4425.namprd18.prod.outlook.com ([fe80::3967:c554:ec3e:b8a9%9]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 09:35:47 +0000 From: Shijith Thotton <sthotton@marvell.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com> CC: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>, Ray Kinsella <mdr@ashroe.eu> Subject: RE: [PATCH 1/6] eventdev: support to set queue attributes at runtime Thread-Topic: [PATCH 1/6] eventdev: support to set queue attributes at runtime Thread-Index: AQHYQ26Vr6/K+JhwFUmxKj0g+tQsoazXw0kAgAfD8qA= Date: Mon, 4 Apr 2022 09:35:47 +0000 Message-ID: <PH0PR18MB4425A1FFDFC49F6908231FCAD9E59@PH0PR18MB4425.namprd18.prod.outlook.com> References: <cover.1648549553.git.sthotton@marvell.com> <159a14ece2480a3704ee34ee0d81dda331c16957.1648549553.git.sthotton@marvell.com> <BL3PR11MB5699C703B56731DC9F9500EDD71F9@BL3PR11MB5699.namprd11.prod.outlook.com> In-Reply-To: <BL3PR11MB5699C703B56731DC9F9500EDD71F9@BL3PR11MB5699.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd0af62e-56b3-4239-0322-08da161e7fe5 x-ms-traffictypediagnostic: BN8PR18MB2980:EE_ x-microsoft-antispam-prvs: <BN8PR18MB2980B05AE329A98744BCD8F3D9E59@BN8PR18MB2980.namprd18.prod.outlook.com> x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /PKtufiLi2IuGWafB9y3/QJKBUWs2GuzL7Q7Np6CJ+0P5daSYQBy5Doi6Q9phle80IowUIu7FNEQ8cJQyzrG3XOdGPR08n5hIcubESsl33b2LUECteXV1aoyLHrEuIoBABk+rbBQ1ZJvp5+/jy6arrL0uM7GH0xx+qFc60aQ23qaLCVFNEKvs8tEAL9NUokeFcA3vcBJeRMFYFZr9NFVylLXFN3zM8jom5N0Ii+5SLO8e+CMl8T7SqG2OjBQtJDeqO7+gkdswv3r43AMt4haVc6t2YabQ+BdVwGn0WBqdcDK5XxnCq0RbYeGueTEKV2uzN8nA4ZMbRZ8fcMU/DdIaeODwpV9cyqInRAt60Eu7tTWaiPrgf+z/kICxiSXk8bxJE+2qYgeeRBfk5H6+8UqGT1Jeg/SMG1CquHPy96wiDxY2XtYJVRijoMFOLP+YCMEERiS5TXdfOKCg464Xm8t3Sdu+BumYyb1P+MczTBGhMZSHP1kvwdus5+yL1VyH+i64fmilYUy5Zh8m/upQClHBDqxrDTU3rdWgTM5OlF3YPLJaB5jQplugOBli+FCwstuuCcEbFbHfNZTUaznHjmahe3tf72bWfVH2yBYX9VPfG5P6PPIxH1x3s810FAQa0T5bqykJGjQsBmLO6pCog03XWTS9ZmuwQMEY4m/jzsWprL/ek/uARLq6k885tTnJOCcYwjM1Vt+Zw7Boz8qf/c7Nw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4425.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(52536014)(8936002)(38100700002)(508600001)(4744005)(7696005)(122000001)(54906003)(6636002)(9686003)(6506007)(71200400001)(5660300002)(2906002)(110136005)(316002)(66556008)(8676002)(76116006)(83380400001)(86362001)(64756008)(66446008)(66476007)(26005)(33656002)(4326008)(55016003)(186003)(66946007)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aHoqlkk4/+T3rOdGEATVX+z7hugOv0ht8jglsXz1zg2tgvrJPe3G2QKmEiXm?= =?us-ascii?Q?aGV81o4L8NISaMrfd6+s8deov9krc/5Wz9G7yuNfyD9Aap+lphmIU9UpIFEH?= =?us-ascii?Q?XMcf/ZxTUiA5Z/7gYm1oG9y/Lyc7NSUqMgFwApNx5uWwGq4AC60lyeX/Ww5E?= =?us-ascii?Q?dQgq9mybFcc2hM+yJpRgwq3RzfGNkvJSbdq9AngyKkV0za7uz2ugvsQbC6uK?= =?us-ascii?Q?Q8trWmC79lUMswejI56lMNKxhdPwsOnxKiw8d6QiJ68TvZdz9g2ig8unMdnL?= =?us-ascii?Q?9IQ95739ZApTlSa869YTNIvlqrd2cZIJCRfMfSWMpG7irphcuvSFbfRUs1Vc?= =?us-ascii?Q?d1MPWYNL9JjoqLfojSkaSPbKCZn3F7lzsBJFZASOjH8057+3Bwa95r0p5XJe?= =?us-ascii?Q?767xEYhyEBrAlobyI13MTrfbi/wuxHqIKXl3awXBMseFd/JqtdljVvALA/zr?= =?us-ascii?Q?F5Mwd9qmSbuRFZJzyL3fTCgzD2ssqCdfLN4PSWPZvRDtHXvpxUiFBh+JtLrc?= =?us-ascii?Q?1G45J7Ga62SrNHCwNkrSZGsOt4WSaKQufLDymYJskQKEDUm+VQjilEufnw9D?= =?us-ascii?Q?XzrVqKDqEMouIaxnuuZslONmdR7kfZyNuLZPA+OGTIveQo1KfN774h6K675G?= =?us-ascii?Q?fIpH/HQ0GzLykFSxCq1k6b3F4pzK1OxwxcULpknZNK3Ud2bEaJiKHdcI9jae?= =?us-ascii?Q?PIeD85FpDkx9M3JeuMKOAuUVZOT+zLj+hck7BT7XKGzGA08LPwFnbaf9j7h1?= =?us-ascii?Q?KBaeAAIdDLCMdImO2VLtchkjF67p7vz/dxIWIOj47ASqSPUw3wJHRA+gA8L4?= =?us-ascii?Q?QaD13dbxqjrmmiolObWAxp3z7xfBno7fLE6B4eL+fpocxYEZULRM3lEt8sRd?= =?us-ascii?Q?bOo3xalWnZZAWBgaGGjva4em1rGrcsV11SNEv0FNVKyMe5DnHkQ2gPGL2a01?= =?us-ascii?Q?mOXEwIb8acA2ZoG2ZNhKy7ejx+uGNb6TZt/M9WsqP/v4+9a/ouuTJ/Q2oSx7?= =?us-ascii?Q?HOG0APDIrhtv0tEMFqp2qdEy+8h4rXIM7ojeDBq+ltCCUf0yMyDjXZbJdtvI?= =?us-ascii?Q?x/iIW6qMHRbnvOxpZ1e2nhHF8SSn9cE5AXrinyuNiNhosZYDwg/AL9WeCHxk?= =?us-ascii?Q?QmPgbehoG9hCPtyQ8fLBlab5e3nfLIRx8pJzOdTnlBbxTTGiC/ZoFXUi9H3/?= =?us-ascii?Q?k+T5nL1/mRRf0mdYpwg/mZJb0Js4qxPU02cfHupYhEwIOhMSAzhX54RIHrYT?= =?us-ascii?Q?zJ6UIwRo5+WKnu87J3BmfBNYdLvWnmLfrnXbLhmop91zDWDuzExvqz8vmpwr?= =?us-ascii?Q?/qc6W14DD6uU4jitymnC3yLKBKIh+UUAH/RKiyxGupIJVCy+PXS1/zO7Amyf?= =?us-ascii?Q?0B+Pfp64PJvWm1l7V6wC2IiaYxMezS83laDvBhYGiLJwtsdhrLoP3pfquN6s?= =?us-ascii?Q?W4bCa6cHPGHXvwGeXUJiBA/DWnVrW2fIvWlc5NbSWbL1RCA/e6xAMce60Lfq?= =?us-ascii?Q?rib1zbnrknlNr/QV/D0laPDAa40vFH0mZ9VPcYmZJMYenhwfBFn2InSDITwa?= =?us-ascii?Q?s8Vcy7swEdrBhz4MXWGY7w7I/ibKNXxm+XryubGuY70acNmTX7gDDhtmRsOL?= =?us-ascii?Q?l/AOVvbO3MV/XvWyAf7Ecl2np9DRfs/ZXKHPE18zTKlbHppKQsxn2KTldRNY?= =?us-ascii?Q?cwii05sXBPnW/QzibLgja75c0wD5W1+zH9A0/HNKus4e0tSHYC11o1eMc0sZ?= =?us-ascii?Q?0xybEmcRjw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4425.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd0af62e-56b3-4239-0322-08da161e7fe5 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2022 09:35:47.5954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xva/pT1Cpdr0q5lf/Ifch8ii8exBT5JQrTQ2+MdZgLUM9hZCEOszEZGRuCsgKNnG6Qi4Wnor8W4xxX26tSBioA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2980 X-Proofpoint-ORIG-GUID: vadSE39N-gTzC-7eqc0fuCpn6eYLnpp9 X-Proofpoint-GUID: vadSE39N-gTzC-7eqc0fuCpn6eYLnpp9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-04_03,2022-03-31_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org ><snip> > >> +/** >> + * Set an event queue attribute at runtime. >> + * >> + * @param dev >> + * Event device pointer >> + * @param queue_id >> + * Event queue index >> + * @param attr_id >> + * Event queue attribute id >> + * @param attr_value >> + * Event queue attribute value >> + * >> + * @return >> + * - 0: Success. >> + * - <0: Error code on failure. >> + */ >> +typedef int (*eventdev_queue_attr_set_t)(struct rte_eventdev *dev, >> + uint8_t queue_id, uint32_t attr_id, >> + uint32_t attr_value); > >Is using a uint64_t a better type for attr_value? Given there might be mor= e in >future, >limiting to 32-bits now may cause headaches later, and uint64_t doesn't co= st >extra? > >I think 32-bits of attr_id is enough :) > >Same comment on the _get() API in patch 2/6, a uint64_t * would be a bette= r fit >there in my opinion. > ><snip> =20 Changing size of attr_value will an ABI break. Can we wait till a need aris= es ?