DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shijith Thotton <sthotton@marvell.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Subject: RE: [EXT] [PATCH v2 3/3] app/eventdev: prevent mempool exhaustion
Date: Thu, 18 May 2023 15:47:29 +0000	[thread overview]
Message-ID: <PH0PR18MB4425DDFF3E761DB931D6704FD97F9@PH0PR18MB4425.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20230425195110.4223-3-pbhagavatula@marvell.com>

>From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
>Prevent mempool exhaustion due to elements being stuck in lcore
>local caches.
>
>Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Acked-by: Shijith Thotton <sthotton@marvell.com>

>---
> app/test-eventdev/test_perf_common.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/app/test-eventdev/test_perf_common.c b/app/test-
>eventdev/test_perf_common.c
>index 68af3cb346..5e0255cfeb 100644
>--- a/app/test-eventdev/test_perf_common.c
>+++ b/app/test-eventdev/test_perf_common.c
>@@ -1859,34 +1859,35 @@ int
> perf_mempool_setup(struct evt_test *test, struct evt_options *opt)
> {
> 	struct test_perf *t = evt_test_priv(test);
>+	unsigned int cache_sz;
>
>+	cache_sz = RTE_MIN(RTE_MEMPOOL_CACHE_MAX_SIZE, (opt->pool_sz /
>1.5) / t->nb_workers);
> 	if (opt->prod_type == EVT_PROD_TYPE_SYNT ||
> 			opt->prod_type ==
>EVT_PROD_TYPE_EVENT_TIMER_ADPTR) {
> 		t->pool = rte_mempool_create(test->name, /* mempool name */
> 				opt->pool_sz, /* number of elements*/
> 				sizeof(struct perf_elt), /* element size*/
>-				512, /* cache size*/
>+				cache_sz, /* cache size*/
> 				0, NULL, NULL,
> 				perf_elt_init, /* obj constructor */
> 				NULL, opt->socket_id, 0); /* flags */
> 	} else if (opt->prod_type == EVT_PROD_TYPE_EVENT_CRYPTO_ADPTR &&
>-			opt->crypto_op_type ==
>RTE_CRYPTO_OP_TYPE_ASYMMETRIC)  {
>+		   opt->crypto_op_type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC)
>{
> 		t->pool = rte_mempool_create(test->name, /* mempool name */
> 				opt->pool_sz, /* number of elements*/
> 				sizeof(struct perf_elt) +
>modex_test_case.result_len,
> 				/* element size*/
>-				512, /* cache size*/
>+				cache_sz, /* cache size*/
> 				0, NULL, NULL,
> 				NULL, /* obj constructor */
> 				NULL, opt->socket_id, 0); /* flags */
> 	} else {
> 		t->pool = rte_pktmbuf_pool_create(test->name, /* mempool
>name */
> 				opt->pool_sz, /* number of elements*/
>-				512, /* cache size*/
>+				cache_sz, /* cache size*/
> 				0,
> 				RTE_MBUF_DEFAULT_BUF_SIZE,
> 				opt->socket_id); /* flags */
>-
> 	}
>
> 	if (t->pool == NULL) {
>--
>2.25.1


  reply	other threads:[~2023-05-18 15:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 20:01 [PATCH 1/3] event/cnxk: use LMTST for enqueue new burst pbhagavatula
2023-04-19 20:01 ` [PATCH 2/3] app/eventdev: use enqueue new event burst routine pbhagavatula
2023-04-19 20:01 ` [PATCH 3/3] app/eventdev: prevent mempool exhaustion pbhagavatula
2023-04-25 19:51 ` [PATCH v2 1/3] event/cnxk: use LMTST for enqueue new burst pbhagavatula
2023-04-25 19:51   ` [PATCH v2 2/3] app/eventdev: use enqueue new event burst routine pbhagavatula
2023-05-18 15:47     ` [EXT] " Shijith Thotton
2023-04-25 19:51   ` [PATCH v2 3/3] app/eventdev: prevent mempool exhaustion pbhagavatula
2023-05-18 15:47     ` Shijith Thotton [this message]
2023-05-18 15:42   ` [PATCH v2 1/3] event/cnxk: use LMTST for enqueue new burst Shijith Thotton
2023-05-22  7:23     ` Jerin Jacob
2023-05-22 11:56   ` [PATCH v3] " pbhagavatula
2023-05-23  6:09     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB4425DDFF3E761DB931D6704FD97F9@PH0PR18MB4425.namprd18.prod.outlook.com \
    --to=sthotton@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).