From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7E6BA04A6; Mon, 24 Jan 2022 08:44:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A67F7410E3; Mon, 24 Jan 2022 08:44:35 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 8F2DC40DDD for ; Mon, 24 Jan 2022 08:44:34 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20O5tlKZ008210; Sun, 23 Jan 2022 23:44:34 -0800 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2107.outbound.protection.outlook.com [104.47.70.107]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3dspd2084f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 23 Jan 2022 23:44:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GtODMdvnatNJ3MK/hVBTtg+BlGEoO2FDx65C4nmWs410wk/FrXTqNp5sEU4q5k3dReNIQ7AuSeJfsF/eUlq0y5nacIevsPRClLsqmrSh6GMlCJD8ujYakcI5UDnfn5uH/x79Vk3RAt9JZIVT/wp2RNesLtOjyR56PGbmv4nEoLH+/Lo99Z4Fiyis7iAfi0mP1BmkdcOWCoU1YZ5zdw+fRGGijaBuX3yN4QKwHZC5pc5myMUvd7HmNGHim+x5KtFDhjci61HK9nEZjgHVXsD1MY2QaNDTXkpRKH3NBIelkfuambMTkuPUA4WwyD4Yky1vygCUV5gp0jxx3RZGaE9iTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gkXxsXEejR+E9gHH11lFOuJ6kNxYhj5dfm/RfEpJX9g=; b=E6m/r9zXwCi7PWMDdTkQB0VgE7rRp9qn87keQfq9/yWIkxpmCH4s0Itv3kY79JS4y6n4GF7QLCA7kYkt/Cha98ZPWyPXEWv81r9QzV0+LB3hN+9rgN+F4B514AnsSqAT7mpz9hFSSOUxDb7RNSF/Pt/7KmZlVNn72WAQZXW5iHbJKpFTO5QkyZDuVp63RpUcpuNLRw8TzI1oUeq5mAVMa7BoQ5l09Z+/SyrZLERJMg0ZZXzFdVnJlOUYqmTodqDnrIhftHRV0FbkC0Qu3pk/AFVL6ET/cbMCJTUbPJoJNscBd8gq5zTZyeCsH/GVkfso+Chs4gf+WsPFR8EII3nu5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gkXxsXEejR+E9gHH11lFOuJ6kNxYhj5dfm/RfEpJX9g=; b=CMigyYax7GaF+H6uSXOzJTvZcF4vju1slfiBcVyS9i15AqTYPFURexG/5iEW47GF5DnjIMFk/SIXpZmKjIi/hwrYZy2xrPTL1sK5YcNOtpoHVWDXfm/i6QOCFt6HJVv42yh/ce1XI5tHE2lMFvCwo3Dg9UNqiPh0XYOSk8JETX0= Received: from PH0PR18MB4473.namprd18.prod.outlook.com (2603:10b6:510:d4::18) by SN4PR18MB4871.namprd18.prod.outlook.com (2603:10b6:806:1ef::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Mon, 24 Jan 2022 07:44:32 +0000 Received: from PH0PR18MB4473.namprd18.prod.outlook.com ([fe80::98d5:32e8:240b:ca02]) by PH0PR18MB4473.namprd18.prod.outlook.com ([fe80::98d5:32e8:240b:ca02%3]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 07:44:32 +0000 From: Liron Himi To: Stephen Hemminger , "dev@dpdk.org" CC: Michael Shamis , Liron Himi Subject: RE: [EXT] [PATCH 32/82] crypto/mvsam: remove unnecessary NULL checks Thread-Topic: [EXT] [PATCH 32/82] crypto/mvsam: remove unnecessary NULL checks Thread-Index: AQHYELYqQ8DGoNrgH0qW5hfbcyabFqxxyvQA Date: Mon, 24 Jan 2022 07:44:32 +0000 Message-ID: References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124000518.319850-33-stephen@networkplumber.org> In-Reply-To: <20220124000518.319850-33-stephen@networkplumber.org> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1778955a-7f6b-4052-ddde-08d9df0d5c34 x-ms-traffictypediagnostic: SN4PR18MB4871:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fRvOkNAlSq8/EuYoOUBMDfb6/d6UBMa1jIGko91QHZlKANvh1l/v79G8oAvsViRpu/hMsczax/2gRtGjVYR0N4nkl6JPnRceCa0DpMCN/TXNgbhdgn4cjBeyfR3zZix6trcjyQnqnoVqcJwouKCUxSTp5TMDzdMnpp+SLhe46WPU9jQcGIw1V7sG3lMC3cWZ1lj/cyjSHI0wWOFOkZMLUlGXHFMc1gEQIur5If3ikck28rtua2BcXt0JhDV94jdl1lCqMbDS1ENo0cv4kqzcawUw+pt0fLS3ymNJclwZ4i1zp+kVkEpzkBFv9ASgbvJmUoJtI+2mDMK6FVRhxqI3NszIb5Lewo9vJPr6UeAj3wSAmi97ftANVGYZcm/Bnk9eG9BRnWqWyTTrLXTnfTQQDD3Apvxv4GRaaugchHIY85RcWvjLVH+ptNODY3z3TiyZc+v4saNMr8J/6yhO8wW1Qo1vPQocyNLZD/EqGrC64L8mBPnGl7L8eX08zFNgYspeqrbfje6Px3i+ThRW8vLS36HjGyRS+VSO8oKd9CFyeGDSc7QDT3rruJVGprc26skREWrUtOak6M+UzJaotlZcjaDJucfwG3CKBzE/IcPECAwLYHymGRYTUJAqW2ckg5/77znmXpnaFkHkW9H+iIwzZ2UGRc72rsfQP6UsPAZr2ByAgHH90hbm8r/LYI6x+I4uzhvK1BsEccq6CoW56qKd7w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4473.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38070700005)(66556008)(8676002)(2906002)(33656002)(38100700002)(52536014)(26005)(76116006)(107886003)(8936002)(83380400001)(5660300002)(86362001)(66946007)(122000001)(55016003)(110136005)(508600001)(186003)(54906003)(316002)(53546011)(9686003)(66446008)(6506007)(66476007)(64756008)(71200400001)(4326008)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FYwMdSuwd4Y3JOdnxCXgWeo/byhnoxsoara2oo4Irfx8N0dcmHDYB30Jr0N1?= =?us-ascii?Q?4HjCFrXELJ7Q+6pwmUpl6nFl3UzyoNhQ5KAou1kpKpIl8Km014GpWcRjr1Pm?= =?us-ascii?Q?DTNWmkL2nb0SpxYufpacdrXL05Cllp5vyJmIdMawXiZ5S9xLSlKBlLWPWdpR?= =?us-ascii?Q?zncIph6iZEYtHtauzfoDS5qCHqRWWYf/hA72L+ydMlpsnk3ssuYsKkqsD5+F?= =?us-ascii?Q?jDvcGLWAOq7CcC2h24WxTE/BwUptrDEkQh6q4ILgglvrPKXtfueTJvMKmQ2Q?= =?us-ascii?Q?yoCdZ0l3JJW9ultsfUpef8K/iceR51N9t9CQ43hIganlU5YL2jrIuOiZK+1c?= =?us-ascii?Q?uxYzqK+U0RzajOUhbclTeJR92W7qgOilYr/Lgy1Sn5Vb7QEXw9CVnYSPh3xA?= =?us-ascii?Q?u7WY1e1VREMAL7Rhu5B/dvMzaRNTNN18IQJ+blie9ViCe7p/LFjKfjaCBdhC?= =?us-ascii?Q?N+xBXNd7wkf7au/C7ipsF0y2NfyNwAXhH6rtAqviTXZ18W1Y02jXbqXEzSTp?= =?us-ascii?Q?faB7W1D2N62NTqaxegYLvtLv/egZkAiDPryWr/UolTQeZtBUOt9Oup68PhUf?= =?us-ascii?Q?2Ch4713v+GExPhxhMZj1AFrfKyBzSsieLHGaHkjpUFP3oVHCd8qlbkr4D29e?= =?us-ascii?Q?mwCp7TeHbYRvxic0gp/Pb33+vfQl7tOPqtlbrtDLgKIhGSOiEvd58BgxbP9l?= =?us-ascii?Q?QYisfvfMFoH3jawlqYpLTPWxTR3i2eLY61gTxyKIBuzjzIZPl339s9pZP/ZO?= =?us-ascii?Q?6vNf5E7MTfmSk5tND/6DU311RZkRp1GO1bSsixRGIaIwvE9/rCCl5pXP4yRo?= =?us-ascii?Q?KeEn2eozB65ZLsKjhzM2G/EaqnSwa2Wj4Y0xMIGG2ah9Xs8pyVF9WwI41NOy?= =?us-ascii?Q?qvvh8QgMIB5ptAqJSlNmH4Qy5HpP4YKZmWRvPo38AGLaIB7EAlGC4mKaamXJ?= =?us-ascii?Q?BPrs6GllDlRBifyb5oUsrmIFLcOD8s54Nvqgas3HkqRin5HogP4eaOgYaZOw?= =?us-ascii?Q?ZDgGpbLxnSMl7oiVIi6x75GRNSvFhvtlGhYXfswwptJOUA54KsyUns4JpfEu?= =?us-ascii?Q?2NVr8k93qgbSOuaGScOMePu2aWq4SwJXGJmNuItdFVsSRraAhCXdgReFms3i?= =?us-ascii?Q?NIwfgJn3ifp08WMCKwisbAaDWFnP86b07n/WSSrFv/1x2XgftY6TPz2Yf4pH?= =?us-ascii?Q?gg2wCLvTeBKccNAtZ2Cy8hFHA6LkPtTKfntxTKXeOmUgWCxoSZDvL7HKgO0r?= =?us-ascii?Q?5mMCjNay51sYocRk+G+EpIN0X3TvlKywzoH3TzA4kKC6O5y0XsyuaLwlsF6+?= =?us-ascii?Q?qmG7z4pSZijZaZUWocpRkdl3Qd6YoilFA6gnLaZ0EnH4k/Ttg1k+BPbOZPWL?= =?us-ascii?Q?aTL2hML+65B8T8fNcwxcU7/9nOpOviw/UzRJJ+VPic3drNNllW+x9zA5qkbR?= =?us-ascii?Q?vnkzQxPtB9jp2xlSxzQ+D6589DySY2IgAkMLDG4XOe9AladGf8/urNzAFQQ3?= =?us-ascii?Q?yQqa1R/gNr7rga/7jSEIqcjdmRVaKI2qJ5SMMfm5V/wdCLby7nIao3tzvz+A?= =?us-ascii?Q?sRDYm8Lu1cZ/8u+9DtBMLVuXlRhD4DjY8QSBrqoIu4er4znsJUxL0LPimFCH?= =?us-ascii?Q?MQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4473.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1778955a-7f6b-4052-ddde-08d9df0d5c34 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 07:44:32.3235 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nE4updY9gZN4McXUbPoSjKmNH2cKXMbBl3u+aR3pmdyFzZllGIy7fBMMYe3FfyJmZrPwUFLZQD2UBaseCmya/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR18MB4871 X-Proofpoint-GUID: hmDAzJ5xQ4UlPJMymFnw9SPTVtENuOfg X-Proofpoint-ORIG-GUID: hmDAzJ5xQ4UlPJMymFnw9SPTVtENuOfg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-24_05,2022-01-21_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Liron Himi -----Original Message----- From: Stephen Hemminger =20 Sent: Monday, 24 January 2022 02:04 To: dev@dpdk.org Cc: Stephen Hemminger ; Michael Shamis ; Liron Himi Subject: [EXT] [PATCH 32/82] crypto/mvsam: remove unnecessary NULL checks External Email ---------------------------------------------------------------------- Remove redundant NULL pointer checks before free functions found by nullfre= e.cocci Signed-off-by: Stephen Hemminger --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam= /rte_mrvl_pmd_ops.c index 3064b1f136fe..f828dc9db5f6 100644 --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c @@ -774,10 +774,8 @@ mrvl_crypto_pmd_sym_session_configure(__rte_unused str= uct rte_cryptodev *dev, } =20 /* free the keys memory allocated for session creation */ - if (mrvl_sess->sam_sess_params.cipher_key !=3D NULL) - free(mrvl_sess->sam_sess_params.cipher_key); - if (mrvl_sess->sam_sess_params.auth_key !=3D NULL) - free(mrvl_sess->sam_sess_params.auth_key); + free(mrvl_sess->sam_sess_params.cipher_key); + free(mrvl_sess->sam_sess_params.auth_key); =20 return 0; } -- 2.30.2