From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE040A04A6; Mon, 24 Jan 2022 08:44:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABA94410E9; Mon, 24 Jan 2022 08:44:20 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id EE76040DDD for ; Mon, 24 Jan 2022 08:44:18 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20NMEXp7019060; Sun, 23 Jan 2022 23:44:17 -0800 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2102.outbound.protection.outlook.com [104.47.70.102]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dse3psa3j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 23 Jan 2022 23:44:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMRFl4uOd475HrRSiCIE1ECW1Pdf3CQGvyUcBThO34uCAgEQujd2/NVi0yRElOBVfArRnfrO5xq5ttpJrw5l9RUhm6HtOSWni6a0YozZEZkhqom6FYXIEaPzMIa1JBAx7J42VmbMyaGcZWPXEKBT/Yn5S4gEyu+uGyNky0YpbAJZ/oIY92z8QMdeOIG4Ihd8q1l1nPXEnwvlKxsuQH5FEd5stVBvWQ19gK8e/9UdsTqtwQwH43NpSlAk7+Mt6XJlXncWqr8wIUYMPJxYu82nQZ9QNCa5eqmVYYS5NGJ+Musm9KPNUPmD52aZtesQV+eBKlW5jvYGHXnl9XLK8zDuyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=77PmvRIp+oewMErS65GyO01M8g3QIhYCjdqOWVMMbLo=; b=ghv4Ac3tQzH0tgtQuLCzKQMOLSj6Vrvm7295ZMsRWlszZi57+A0QlqfJZpUDP+gHZrHtp29ed0f+IpC1QAroclhH50m1boFEKlAhfLqSul4AuS1tLWtDmpMzh6xjAGjJ0OprOa3ud5k4UTVJt8o8Fjyd8odQlTRwQ4EFWXFlZI8oc7lB15DA9Fk7t99z4C9stzad/jInx0A2EVMzFgjxdFzz8kNJz3ssOjHNErelNKQeopojQFg/Bd6oeI2HLRKpzxAWdYDZ2Dnd26KvE+JJt250z8GRnAS8b0EUdW80apLOUYYjzFzTe1gWE7+zl4bRtpTE5zHJMW0AQuCCAnmTFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=77PmvRIp+oewMErS65GyO01M8g3QIhYCjdqOWVMMbLo=; b=Qcko0ESgsbJyR+yywI7+9++OQUE+8kQtCiEp+vHjbmk9HUcuhQUMSBEtjHwIfUW0xFxVy/G8/aLJjS1C5RguihRhQw6BHGAmkZTdi0KeMyE/XPaZrDwsV2XIw5TADLahvAnxP8Yab//5GO82O3gwa/12C0wDkuDNM+QAmyjH3pY= Received: from PH0PR18MB4473.namprd18.prod.outlook.com (2603:10b6:510:d4::18) by SN4PR18MB4871.namprd18.prod.outlook.com (2603:10b6:806:1ef::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Mon, 24 Jan 2022 07:44:15 +0000 Received: from PH0PR18MB4473.namprd18.prod.outlook.com ([fe80::98d5:32e8:240b:ca02]) by PH0PR18MB4473.namprd18.prod.outlook.com ([fe80::98d5:32e8:240b:ca02%3]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 07:44:15 +0000 From: Liron Himi To: Stephen Hemminger , "dev@dpdk.org" CC: Liron Himi Subject: RE: [EXT] [PATCH 58/82] net/mvpp2: remove unnecessary NULL checks Thread-Topic: [EXT] [PATCH 58/82] net/mvpp2: remove unnecessary NULL checks Thread-Index: AQHYELY7Lvq1BTuBoUKtdAAhrG+qk6xxyulg Date: Mon, 24 Jan 2022 07:44:15 +0000 Message-ID: References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124000518.319850-59-stephen@networkplumber.org> In-Reply-To: <20220124000518.319850-59-stephen@networkplumber.org> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d05cf88f-cc37-425d-2dd2-08d9df0d5230 x-ms-traffictypediagnostic: SN4PR18MB4871:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1060; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oW3aKoG2qt5EhDmT9u7eU3GQKGx/XgmrhFliMAX81G1yl5e2HJzZl7c8qYP/59D86lx8zhdFCg8+hhJxF0bFzcrfiuh9f4lZUOq7kNKoG6i1VejSVJRBTst9AQAWWlZ9loTHzyjhhaR95ekU2IAqRFovNI0f7efmN5x5Qkb7cuLkkxXa6Ld2EbbpdZrUOIrCyxR8yA9V33mEo9xv96KDiO64tc3pvFjiGNA7Kzxf51ikMDnpK3ygLtwzIioqfArcIim2pWwG193Eq0JlhEWXDCu2coBxNMRAMV2Dh80RHrqEEfxExq1/iYHmrXlk8YYBw5JwUWGfrjekYu0EmCM94IeFsGKOktCRedRjPsAxSunehO8fEXgMA7kwxbkFwPArEiFrHwZ7RKyy/JFa+sy+GTfZlUGP3W2zguESzQO4CiiHVx5iuyAcMY6W/PYMIFiWC7d1+O7JVTn7PpJM67fUahGTyxpb2gQ0v9/aUbvr381yybVLGFwhT4bJK6zozFM2deB1FRXhyzDwIeM2pQHpbPpfglud1MG+JJ520cfJn48HePGUzzp5LPrkCarI105peRWJdM1D2Wa5fuSM1QhwMCuRlbXb80tzgVX/Zx1iqUyNi46uq+XHssbycJluRBiNfwUGFFUecDtQyT2v4ihYwk94E/mPs2CAlYXjFHOUIeS/CUMI8arXWUeHuXpP2qb1KF4CU7EeNPX87g5xm6MBbA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4473.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38070700005)(66556008)(8676002)(2906002)(33656002)(4744005)(38100700002)(52536014)(26005)(76116006)(107886003)(8936002)(83380400001)(5660300002)(86362001)(66946007)(122000001)(55016003)(110136005)(508600001)(186003)(316002)(53546011)(9686003)(66446008)(6506007)(66476007)(64756008)(71200400001)(4326008)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D92vz2JKmeOYLtpcyxlxXbcmkIL+pJZj7SpcFmVN/Yp6rKKP90S2bdVVHH+W?= =?us-ascii?Q?mDLyMNfqHZ8ptmF8abGxwn2Uv+6+8JsCS1yPt9mu9oj3V77yRwVE1zimOTFv?= =?us-ascii?Q?hkDQWhOjSSnBwsyv0lTw8LLhNdxP7JUbT+xM9beyV0JPfXBQxlc0T8b/fYE1?= =?us-ascii?Q?3nwaZQ3XyTh9cuS9ebbqhat1/ROnJnBs9dm60DPCwrODCA52K/OEeFPqMNTD?= =?us-ascii?Q?iYYPYGaUTjBuU32NEGUzFofE2rdGtWbPDiAMoKiOk9wMGBhCbZPGootWd0GO?= =?us-ascii?Q?9hWOLJMNIDf1rXxOe9RSxKmrfTmNF5b2pRh+QyN6UKFOlHV6gvNP/EdLefwD?= =?us-ascii?Q?Vx47t/wrAq0nqsEf3n10VBDmL59jobMh+mNmrL2ThXh44XBKcvR9VpKBFzV4?= =?us-ascii?Q?Rp8F1vw4iP+xBIu3I436I09MzR+adVy1iTyK78z8Kmj5GycVN6fGE0XFANGL?= =?us-ascii?Q?vD+FkRSg+UxDRqKnalY3JdqN/9fRWn4GyfvH8uc0qFILiW/g70rQpreaiZgD?= =?us-ascii?Q?enAp5kICBdrMOr0oXPA+52sEg7srsLrXvypopIX7ME8roWI/4pPCrrJj+HrS?= =?us-ascii?Q?P1hM0cxZwpvG2Jr06o5G46IhP3go7tGhViQd5m1VwYdIhgDuauQiB7eFguFS?= =?us-ascii?Q?pdOksorStmolhI0CB57Tcp3Wujhp22g9wz5V+JKOyrOx0YgLrq9n12sUdin5?= =?us-ascii?Q?pfqglFQhDpm3358cHXEa+qBJMkplxGZku0ek5gZ66u+PYoVwhAUcuhydwFxb?= =?us-ascii?Q?ZZM6A6FPhVhVHj8g3A2yLH0xPghH7XhTF5EGi8lbdlwNg0UrECeKOBT8Q9Ql?= =?us-ascii?Q?5XrJIA2AXkVYetwbnAqu2CzXEXWoeuPxFwIHZBswUSK5OZjJzcVr7wZDGZiV?= =?us-ascii?Q?84EXOLovX4+trCjHPTqWnnb2sYSv3FS3Zor0JoolnNX7VjXjwZlvGZKORDsf?= =?us-ascii?Q?MCYHzJ89kGgDvD9iKVV0HxMf4ReK0RjVZ+hOQ1ZeYqgvYlFtZpG9gzJg2TBP?= =?us-ascii?Q?Cn29wa+3YiZb/cdgtm0tBN2De6ULNvLECflwWU+FQMNtX5wqP3LVr1Ro64Al?= =?us-ascii?Q?6S8+jT/gyKxY6KiR7ukDDJ395JvnCTEsHDuXWuRQB/S2amOkcoddNgxdSbe+?= =?us-ascii?Q?KVU8YkM8q/pK7PGPyO/2ugsM8ZQ8usGQMFxldrvgFUypSum5wRVb9QhsytBv?= =?us-ascii?Q?FcTwyoHsLzYLdW+fPtXzo/tdC0BXHgrKZvb3/xUjYAlnNOyF+9WNVuQp4DXm?= =?us-ascii?Q?W2bYOaZs+Eo7LSr6/2JpdgdiK1aUupSiBYRctrkl+2AEjtuShru1FQedfiNT?= =?us-ascii?Q?OT3+gXmBiw+SIwtNA601dgdtE2/1Ne1C/hFZexP2gGJKAq5YBN3V6w+Xf696?= =?us-ascii?Q?xszY8aa2DyHzvwiUhSAG8G2Hogh8D5Jkub6t8COK/NiAcMc64+G0wvTjRLgS?= =?us-ascii?Q?EjZ5T5tydoVkBogFGTWt6bzKDOW7kL/3q+TgT9p2rlpwsDPDEcLpq94iHDo4?= =?us-ascii?Q?qJ0bFVwBL22n2C5wFxReCNd4YuuMEHrReinc9WQXSSszs7IRAdT7LRnFSbFG?= =?us-ascii?Q?uOhvI2JDDPXFDYNYQqzYToVfmRZ6f5HaE9fP+FW+NmmQ9F/kEfqauJanemb8?= =?us-ascii?Q?vA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4473.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d05cf88f-cc37-425d-2dd2-08d9df0d5230 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 07:44:15.4989 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wGqQBZO7jS0kJNkdiqoVvRJGCy4U+raZwKIeqF0kxF8Di5ex2mMSfovU/d3mX+X55FfuTIf+niCQcWzUpUyyRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR18MB4871 X-Proofpoint-ORIG-GUID: zbDNqxzrPeJQvStCCFV-ryjNixn7PZcz X-Proofpoint-GUID: zbDNqxzrPeJQvStCCFV-ryjNixn7PZcz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-24_05,2022-01-21_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Liron Himi -----Original Message----- From: Stephen Hemminger =20 Sent: Monday, 24 January 2022 02:05 To: dev@dpdk.org Cc: Stephen Hemminger ; Liron Himi Subject: [EXT] [PATCH 58/82] net/mvpp2: remove unnecessary NULL checks External Email ---------------------------------------------------------------------- Remove redundant NULL pointer checks before free functions found by nullfre= e.cocci Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c in= dex 99f0ee56d1a7..f43217bc589c 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -945,8 +945,7 @@ setup_tc(struct pp2_ppio_tc_params *param, uint8_t inqs= , param->num_in_qs =3D inqs; =20 /* Release old config if necessary. */ - if (param->inqs_params) - rte_free(param->inqs_params); + rte_free(param->inqs_params); =20 param->inqs_params =3D inq_params; =20 -- 2.30.2