From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 728D8A0548; Thu, 11 Nov 2021 12:33:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2F8B4113D; Thu, 11 Nov 2021 12:33:00 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2FA5440E2D for ; Thu, 11 Nov 2021 12:32:59 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AB9Wj01017148; Thu, 11 Nov 2021 03:32:58 -0800 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2170.outbound.protection.outlook.com [104.47.58.170]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3c90mt8g8s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Nov 2021 03:32:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ErLVpYEzC66/E5XOtmcZOBCYLz0GLrW4UYorR1ys0zPTb7BcIu1JezcfbWgM17UCY96nBZwoualJ8C+AloaidgmPeQ4cvkFy/BQXgq99vgG+QoMCuMhjiVGuBPR9GqGpsZ2E2I1ZsLzOcdxNM4wiErz81gPnZqJW9cOnDqy+KCt+JO2IYF3XGA/CuQRfJ6mGiIGO4Rl9BAl7sldY28Q7u1w0bCNjoirbXNJsvYi1GsC8wci0t0Ub6h16m8+gQQJQHiO2qwa7rCMiksaLheQpvSrGETf67CknSEt3UE6Ag6objxopdyEkskli5hy8hR39TyINiZ2B1DHd8GWuPsmeGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HNWrxQqnYrtCfIHpGz75ZtGzEbGIaTchEqGsfGSw3kw=; b=mpXUIJQhyDwM8sDygbMrz7IrphBpcAsnJlCEAU4ytPuOcxb3PfyWoau95IjTcrgxMbaqGagzK0zRtLdFDLH3gaPg4ztTTHlS6kvGyC5TREJCPYkqkE/8cxKTNNkC/DDiehboeRg0TrV8sOnfkjNFn5KaunWsZcuWElozwHdXqe1bDfrZGCsXWbFuMTvNBVCCXtLp/j9r5LOmE05v3JlPyMM8PAjBSvwwIEy27dU9Cvb+eBNQtvw9AlWeck3yyYBNivF4rPLMEmgR6FxK4Vc4a7AaZiWcb2hkL/IjplmFi765F65uQ28ygGjeeN7j+TjVxJFRlALc7+QYT5fVyMKGtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HNWrxQqnYrtCfIHpGz75ZtGzEbGIaTchEqGsfGSw3kw=; b=ZVrBjyqE1O2BchZTuZ0t7LRx+f2dIly3fikviPjE6m+GoBHWZ0MAbuTBeJE1r3YsgnKbUZoRdRxxqcwX1gl4gfJE00Ev8ff9mweN3bVGfxm87/+OzyjT6UY5AwTqD4Ahksu3413whZgTcctj0+Xy+8huQf9mPbu42U5bG0A6g6o= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by PH0PR18MB4428.namprd18.prod.outlook.com (2603:10b6:510:e1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.18; Thu, 11 Nov 2021 11:32:56 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::944b:49db:20a2:2d0e]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::944b:49db:20a2:2d0e%6]) with mapi id 15.20.4669.016; Thu, 11 Nov 2021 11:32:56 +0000 From: Akhil Goyal To: Changsheng Wu , "fiona.trahe@intel.com" , Ashish Gupta CC: "dev@dpdk.org" , "rose.chen@huawei.com" Subject: RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init Thread-Topic: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init Thread-Index: AQHX1J0N7dBzT+J2uEaaKYIr5lGoC6v+NXaQ Date: Thu, 11 Nov 2021 11:32:56 +0000 Message-ID: References: <20211108123542.404239-1-wuchangsheng2@huawei.com> In-Reply-To: <20211108123542.404239-1-wuchangsheng2@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d2947ee4-d384-45f9-9486-08d9a50701bc x-ms-traffictypediagnostic: PH0PR18MB4428: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NJWzRNIb3HBAsN4GBiB4YqM9hhUMPbLv2YTCyEaSp4seGIfiJSpFLGAKC62fGcXq5Bee28RMwvqUkufEu7E3mtxBFCLAyq/m46aqsk8kmbIucCi95JzaOIC30sJsZHuRbmX0npu9ABWI+SY0LuS8N1q2Ux9p2AjP6yYHj6Ofeu04ccSbgdJavYU1lZPBIONuzWCMJR+G2ij8MF01pLe9KUS5KNG067jqrFvKPaYYfAXvns3HUSC+WosaN7eXFrvi6CK2FStDdr70kHM0krKxpKbt9AqZkbLUue2D6dlln4XEBuxbK3NnVaVGiiO4MXONe9paAxayJoyIcA6Yehd2KsHabzo19juqNERtZS/FwMsGrgJzfR9QHg6o9d1dI5+DLR4tGiC/s2PuO4Avyye0k0mdk6xxjnThsR2dNtemFhCXKCeljmYf8ILIQ40lGxSad9RPAJeScR5rE2vSXOz6RBpSQz6ItGhO3rc0ZBkZ37QdJq1zcfyjPr5OFcqDJ7k5M4prZ+y8JWeektr3JRwU4jPx8X5AnKy8ppeWhO+yHdqWldgqTx1pVv2Z3pYb9FVkRq+TTOevWWnlNYXk+nEEG+jkuB1Ra5M1TdMLqgBQ8TfeERHgymp8SOHwxUTEa3eCYIqZBOOtaoeeSWZ9MiS/DkmV5/ETNqckY5lKMQppLtN3OCb9nuJSxK9/gbA6P8aib+xyvNCcSaT3+9hhzaSi6Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(83380400001)(38100700002)(64756008)(5660300002)(4326008)(86362001)(76116006)(508600001)(6506007)(2906002)(33656002)(38070700005)(55016002)(26005)(6636002)(66946007)(55236004)(316002)(122000001)(8676002)(8936002)(7696005)(110136005)(66476007)(71200400001)(54906003)(66556008)(9686003)(52536014)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+QFb3xX4WQDiNFE+EayKDKZAC0hx7LHBGnH6zphxcDVGUVR1lEm0JD4u/aDz?= =?us-ascii?Q?mioeYZBnDTahG7sdXMxwL7n6r7GUavWv92sxjHxhC6Rto3TLaeJ2mKe3U26K?= =?us-ascii?Q?wclyt1WGFbj5bXdVypW4lFQmlk3c3uvF+T8GobJXyrQCc5tV8dnPWsmQBbLg?= =?us-ascii?Q?KOc8DJ04ibqObmHUQiWLrv1ElmFWCQJRSlKjF6CbbioVId+aLTatISCHMoTj?= =?us-ascii?Q?C7HnFmabMQ1KgLIeY9IMxFIJ2Qr1wkONBBdr4RGT4TmVx7E4hr8wxzzCBwNM?= =?us-ascii?Q?Mgb+rZRJg4/KIPIAiq6+ZfIPNwJQeQFzq3UTHuVtsRWKyvG+qRwfTBHZ9DRF?= =?us-ascii?Q?HZIif0npbYnSWiZrHv0jvDAQj9rsEbD56kyO2KB6dF8NelSNTMxMOrpne04D?= =?us-ascii?Q?ril0hEL/pdxMdfZnMyMRiBTB27WhrJhfNj5cuuSZHz53yPtdRnwVBHStJ4CK?= =?us-ascii?Q?gijZOjUyPJ7gQBRF+bMFDK0lA97oQHuwaetfhsqx1wjmLihfsk05LMFXrhe+?= =?us-ascii?Q?gbEOTxuQwJWYOzVoL3jfJekFhiLIWmd7ntdmprP7pfMLouwLACTvncDRwD7w?= =?us-ascii?Q?cx/qOOQxtga9gShE1KzZC26joYY4X89EMNkXm76wDasC6f9uSpLvorNPG4VV?= =?us-ascii?Q?MepB+dK/C7Aqm83CU1tGgxkPOIMECTvsgkqmB8CFvhnhJVNihWU0RioXPxAC?= =?us-ascii?Q?kDPzJ53rze3WW1VuLd55JoQv4Auj2Tzvb7xkn1biRG4wQghu8gOUZYOx/5Uk?= =?us-ascii?Q?2n1Ip1A1Me4DtSFf9xTqV4e5WUbRZbNVUPuE7kAu7JQ4nJTuyeY/dlKA4D2Y?= =?us-ascii?Q?aDrH6F+7p/C21+fMuNnDTpY2RC7nk4CgNv7xJ7gpYhQqLMMc3+vAt9lxLIq1?= =?us-ascii?Q?t6r82SqKaDMJvZri0wpa0aAXS5UOJizdmiNbf6PMMAJoEW4Bomy3BVON62VW?= =?us-ascii?Q?yg4IShRzM+ZyJrsJgsIUC+KgIZn+pgaxq7Y4H5J3MGSzdG+8ODz740JupvAp?= =?us-ascii?Q?4pyiEbSDlAFuwtwWKkrd5OUSm+K7RXqBomO+7M1Vr+vNp0VX2huenOHxfiYY?= =?us-ascii?Q?+TpHY/l4MIiWxO7r2MCPxIh4jtteJn1Xdbbwe5Ydfz3AA9crWPQXNWQtZ/Me?= =?us-ascii?Q?851IkPNwghSs7yuOZhTJ0wrqaaVzMzWpp3VnUQMxa7CO5/7S6MQbx+WupBRL?= =?us-ascii?Q?Ht2E2mVaEfZZMdNseLIA1DvBWbBELhn0sVc30SUcWc6xOhaYISXM9dZv4oey?= =?us-ascii?Q?PnAi4GvG9y5gbuzd2A6mWl9Ojp33AInNvPWWLU7xfbZlwLN7bsWbW8nMezGo?= =?us-ascii?Q?j0uhynjciPREfbAv/uToRZLPNmPTKGTCB/KbkyJAqE+9LDNX2zW6osSM3maN?= =?us-ascii?Q?5aF5N4Q6c8yMd7PSMHs/N0dWSk7bEUPoA1VnHE3M3DRw85Iff5OLDeQGbayw?= =?us-ascii?Q?Wq6mq7Zra+JKsTS4DuqiBnfj6MuffxJ/iKtUvfCU5iKfCpYvJgJZb6nJv4jL?= =?us-ascii?Q?o3MPSFu1S7qqyB4iw3afgAxryaceF1ALNqvkiHUQgoMwJNgKiYXquCEWoDje?= =?us-ascii?Q?1QlSKFyntfOaeBTQa8YIO47ITmJP+GSixgDLFdV+l5jpXgIloeGKm99xiati?= =?us-ascii?Q?+hnOdyVXIgI4jsd8SqBKucA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2947ee4-d384-45f9-9486-08d9a50701bc X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2021 11:32:56.0602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mSUaAjC5EZlk7LkrE/ZzkfAdJa2Gm4tktYrUdyfviJmREoro0aKFVQ0KmWh0Qr9M8jqbKuJsec+1DbhhGEcFkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4428 X-Proofpoint-ORIG-GUID: TRlhngSB4-nbY0OdE-ZaqiSa4Y0L7g4M X-Proofpoint-GUID: TRlhngSB4-nbY0OdE-ZaqiSa4Y0L7g4M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-11_03,2021-11-08_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > The testsuite_setup function in the compressdev_autotest test case, > the rte_compressdev_count() return 0 due to the lack of device init. > It is considered that there is no equitment to skip execution. > So add rte_vdev_init init compress_zlib device. Why? Devices can be added as command line argument. * Use ``--vdev=3D"compress_isal"`` in the EAL options, which will call ``rt= e_vdev_init()`` internally. See documentation of compressdevs. And if at all it is required, why only the zlib, there are other devices as= well. >=20 > Signed-off-by: Changsheng Wu > --- > app/test/test_compressdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c > index a1b9f06250..f15fbe7f2d 100644 > --- a/app/test/test_compressdev.c > +++ b/app/test/test_compressdev.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include >=20 > #include "test_compressdev_test_buffer.h" > #include "test.h" > @@ -197,6 +198,11 @@ testsuite_setup(void) > uint32_t max_buf_size =3D 0; > unsigned int i; >=20 > + if (rte_vdev_init("compress_zlib", NULL) !=3D 0) { > + RTE_LOG(WARNING, USER1, "not find compress_zlib > device\n"); > + return TEST_SKIPPED; > + } > + > if (rte_compressdev_count() =3D=3D 0) { > RTE_LOG(WARNING, USER1, "Need at least one compress > device\n"); > return TEST_SKIPPED; > -- > 2.27.0