From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BF45A0C57; Wed, 8 Sep 2021 16:09:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A90E41102; Wed, 8 Sep 2021 16:09:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C06CB4003E for ; Wed, 8 Sep 2021 16:09:24 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1889rEno001107; Wed, 8 Sep 2021 07:09:24 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by mx0b-0016f401.pphosted.com with ESMTP id 3axtxc0ydv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Sep 2021 07:09:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7Es+0HnJpL8c8ztYOnrBuKk3+hfXCpkc+evsZVEd1YvaQ130xJk6Yi/gjFpG+fTeogHkx6JGTFbHqZqvQfjWjnRhUmXOkixVPFxApqPcXkBMd0ezeWhgn/bsKwnHenpOY1LczD4K5C53kJiNaVTjumYT/InFdqeD1a109Gw7kVoIV9SJGtw/41XpHVSjlXG2mHmNC6fWWqC2+Vv4WtL+CT+QOkGYx4D0jlkcwoleN+MRkJHKEgxcqzquzzuv9nRXqPtXPIG05aMAEfBktYAqpjBebIiaSIG3a8T17rAstC1KbH5EWr3wQSAq4mKyckbYHQbdTv4ZxbSB4QL+YxvYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bHUBFfgHcx/5NT4J2jGF2q+FJcCYfef8R7KMrVR+vnE=; b=dTR3nQwJ8IT942ODozZX4ZQfuPROQ0rCJcgasVqzXGkPv8CpM9D7RYMdIUSqE5ThUss7SVSmSGim1pNLOwO18UscqgTN2+nsU+BYXNYAVEbGTv2+waVeYkCsqEs+fddve+J4TGRjEDrX7PHE4ybiPRge2oZ1vdZDzn9MVXDaLOrKxV/cIuc1uyAtJXU8eJh0LrUSr2HTO+I/DgT/KhLHhxj/ounsvlbSexIXClORDCeKoLrTAX8X1sEdvYg3zvjZkiNYTo2aHwFzdMmVCjOaUs7hKlj8H9v9i2mpdlYYXKSZqvEPAh5omoJ6ZT1scVaK1tnGFQAyoP7MJ+le5u6iuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bHUBFfgHcx/5NT4J2jGF2q+FJcCYfef8R7KMrVR+vnE=; b=ZY8i7etz27EiyxM9AZ1QxyD8VGEIYzkct92mfDYGFJxML25DBpFz2JThkRI8h5w869QXVRudViifDj7wk4qu7TduzrvI02EokzEwQ086FiX9P0klazhh8j11ssMngJiYH/fK73gZMQ6iUVKsg5M4FBAeHWwekbLDbS5VOgTbfF0= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by PH0PR18MB4426.namprd18.prod.outlook.com (2603:10b6:510:e9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 14:09:20 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::5511:79c8:c025:a250]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::5511:79c8:c025:a250%7]) with mapi id 15.20.4500.016; Wed, 8 Sep 2021 14:09:20 +0000 From: Akhil Goyal To: Radu Nicolau CC: "dev@dpdk.org" , "declan.doherty@intel.com" Thread-Topic: [EXT] [PATCH 5/7] examples/ipsec-secgw: add support for telemetry Thread-Index: AQHXoLbnukPfHkhDnECS3nG74Eivf6uaK6rg Date: Wed, 8 Sep 2021 14:09:20 +0000 Message-ID: References: <20210903112257.303961-1-radu.nicolau@intel.com> <20210903112257.303961-6-radu.nicolau@intel.com> In-Reply-To: <20210903112257.303961-6-radu.nicolau@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 775c7d8e-57c0-468b-307a-08d972d240b9 x-ms-traffictypediagnostic: PH0PR18MB4426: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fxQa4D5K6D3TslvSZitTdHT+QLPTCYUoEAqVn7ps34PTfdPbX0lpy64/pfXEQZxHCx7QhaQKn3t4hU7f3Io3LoelmQ30j8xJA0Mm260JjFeM+8FUjxvsQ89DsNfsVlgKhrLdS4noAYZ6LCqZE/JBWuW+xkljrkwiBLr6eD+Y2+SYxrteEekkKQH20FoG0PWXrOUHZXw8wdyAPwlw8EbRN7oktQ3699yIE8RDcQG2wH7C71/E5a8rsIDg6FXSr7CpNzY1TN1ncHMUo5cafX3m5/tKgQXtmJW1T/wDWY8ZNRHplFqkgIRBddA7zHQ1j0JgQAkVKsK5X4CY2Re1uO1SxR7k0vGfUYQ+wsBaed1Wq/T9lj1mWVspTc+/IY+DWLVpsIaC72cYnM6t1+2TwPO0rZbJDZpKFzr3fglEl01Sf5e/zxREsfF3LBGd9/iBNqtDJpOKP3/dHKWtox6H7eLvWeGAXLpHlQn+h4okonqI1ETxd+X8f7XXeXwdiIEwAInLoqjX+QOQGkGuhNreqTxRWOahAhMscufRKEJajEpLReiQXey/AMGB2vtuBb1WVPwa3+/T6daGeKPEMPzjl04Zk0ypBUaQ3gErTdJKzqFVVdo1Uenkqocaov8p93EHY28w4+I9ym8uhmSs5WpHZpKBLXmGGKQrrWpjQdqEEt6Mojra10O1tskos2FJygmv35qrYJ5AvUzNXx9yIfBzvsr6jw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(316002)(38100700002)(122000001)(4326008)(478600001)(54906003)(66476007)(71200400001)(66446008)(9686003)(6916009)(66946007)(5660300002)(26005)(66556008)(83380400001)(38070700005)(76116006)(86362001)(64756008)(52536014)(8936002)(55016002)(6506007)(8676002)(186003)(2906002)(33656002)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OsDyDkzBE4nsiZz1fruFyCF1xc04JM0bZclfbGUYGJLeJ+FEYsE/SbvEgABD?= =?us-ascii?Q?ZJdaqwRG0a8N/SnLDba7ugaeXFaN1C2Vv7L6gwlh4MXwac9WfvuQ8wqnI4jj?= =?us-ascii?Q?E4UEOTtbdMyOlQm4YsnCDcjicvT/OY4Gx8hOAh09wUsH7B8QvYuNdIiAKgUF?= =?us-ascii?Q?iZ1lWunv5Zz5CMz0U8h9ppcvH3BdLgluzbN4kvyXUwkO0GS/PkA/iRl4z7Vz?= =?us-ascii?Q?IegaPiwg8YB+YJpZjn8k+xBHOGaMacnaosakVTn7ciMLPnFd704B4UgRGVIX?= =?us-ascii?Q?UD9Eq8L17FsSz/KmandSx+bPX707emKL5WoCVJC1uWg53Z58Z5untJpqoEUb?= =?us-ascii?Q?SSFgs6H8XYoLWdl0j4xYB0/I+sETxHEjOcEz5XIPVAvrz5V7KbdkvpO2FCMd?= =?us-ascii?Q?n6pQU9/Ttvy5yW6Sc3efNmQWV37RMzEzDMxyUeKwhBfioFNl8Rnj0RunMAOF?= =?us-ascii?Q?FPTZQku/nBu2tgkzPIGQmMeSH5/awztjyVWGz+A8WwdFJdoYWuRD4LLIT6T+?= =?us-ascii?Q?G1KV/uprYwXGh7Bf1pdC89j40AFohprS2p+/nMhvTUSdZQdh8ZAM59seNF/l?= =?us-ascii?Q?rPXCGy7F88LcFOhtOeM80v/aLt3i7f3U9VGJbgjgvitjc4fsg5Wtz4/ORa4G?= =?us-ascii?Q?PfGh+amvOfV3IipfY2uDRqiKFpncaxU9Sf1s/akxCo+YqCDLn/TDYfPLypdN?= =?us-ascii?Q?pHouaTi+B6vLVzd3BaUUv2f0q9oE8BfOEdb0EXmF661/yN2ejFDgw+vk2n+1?= =?us-ascii?Q?V/0ZOiP0TUgGl2FgZtbPo/nOZv7gsQ8m5fqmkMEAsWwR5wmPaCVwVDajO7Yq?= =?us-ascii?Q?O9nwW8K4tpgQ//5EwrX+xSIBl/TWjo1A57cBcHYHgYiPpqRSDDHHb0NiG6gn?= =?us-ascii?Q?3BeLRjFkvdzXPjv2VOsxUI1qdZxfd9CgYSDMC8GZZxgmJLHReQhpto9tgG9U?= =?us-ascii?Q?N8dYrTbMkZCBKUUmW4RvjIXOlwnKYHVbf4tnK8fK9bGz7/kjluc2Di/STEEu?= =?us-ascii?Q?MGrdUU7bLkyGFUbtzbPIEmyQzA6DTHnBiJvaPpllElnbsqD8oZ9pj4YVuh8e?= =?us-ascii?Q?rXfs5OkiVghKvHBIjQrfSGSzTDYqCOn9HRH4c2jpXp/bMR4V6F/xzM6NT8fL?= =?us-ascii?Q?JqWMUw4SaOrL7dwXwyFRVJKyro2D/9pwWKzD26StZeNehgFUis1cPgjLwWhM?= =?us-ascii?Q?nA3txLQH3zxt1G0ZMzIvg+raoVPimKA/l8bJ0DyjJrMlFiiPmHNfRtv2lRNM?= =?us-ascii?Q?CG8SGyT1m6bNuwlCSu4+6iKYCtp4jw6QWlSEvyOeKYA+b9CDW/5KPbt6Bbto?= =?us-ascii?Q?JShArqA2oZWDes3Eqmxjcf5w?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 775c7d8e-57c0-468b-307a-08d972d240b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 14:09:20.2619 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /m0Azcqyq9kI7kK6+raCyC+UPzL032aSiKn8MX/8HF9PQ5br90KlBN9J/yhD61D/oq9JrWT0Y18IGMKNJLMxrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4426 X-Proofpoint-ORIG-GUID: CoqjJRRdyTqAPNi1LfKvCuZ5CZd4Ffq1 X-Proofpoint-GUID: CoqjJRRdyTqAPNi1LfKvCuZ5CZd4Ffq1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-08_06,2021-09-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH 5/7] examples/ipsec-secgw: add support for telemetry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Add telemetry support to the IPsec GW sample app >=20 Add description about how user can use this feature. > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > @@ -779,20 +790,27 @@ outbound_sp(struct sp_ctx *sp, struct traffic_type > *ip, > if (ip->num =3D=3D 0 || sp =3D=3D NULL) > return; >=20 > - rte_acl_classify((struct rte_acl_ctx *)sp, ip->data, ip->res, > - ip->num, DEFAULT_MAX_CATEGORIES); > + rte_acl_classify((struct rte_acl_ctx *)sp, > + ip->data, ip->res, ip->num, > + DEFAULT_MAX_CATEGORIES); Unnecessary change. > @@ -804,15 +822,20 @@ process_pkts_outbound(struct ipsec_ctx > *ipsec_ctx, > { > struct rte_mbuf *m; > uint16_t idx, nb_pkts_out, i; > + unsigned int lcoreid =3D rte_lcore_id(); >=20 > /* Drop any IPsec traffic from protected ports */ > free_pkts(traffic->ipsec.pkts, traffic->ipsec.num); >=20 > traffic->ipsec.num =3D 0; >=20 > - outbound_sp(ipsec_ctx->sp4_ctx, &traffic->ip4, &traffic->ipsec); > + outbound_spd_lookup(ipsec_ctx->sp4_ctx, > + &traffic->ip4, &traffic->ipsec, > + &core_statistics[lcoreid].outbound.spd4); >=20 > - outbound_sp(ipsec_ctx->sp6_ctx, &traffic->ip6, &traffic->ipsec); > + outbound_spd_lookup(ipsec_ctx->sp6_ctx, > + &traffic->ip6, &traffic->ipsec, > + &core_statistics[lcoreid].outbound.spd4); It should be core_statistics[lcoreid].outbound.spd6 > + rte_tel_data_add_dict_u64(data, "packets dopped", > + total_pkts_dropped); > + > + Extra line > + return 0; > +} > + > + if (strcmp(tokens[ti], "telemetry") =3D=3D 0) { > + rule->flags |=3D SA_TELEMETRY_ENABLE; > + continue; > + } Documentation update missing for this new option Please do not add new features without documentation.