From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E198A0032; Fri, 21 Oct 2022 17:13:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02920400D6; Fri, 21 Oct 2022 17:13:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 64B2C40042; Fri, 21 Oct 2022 17:13:49 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29L8psEH005700; Fri, 21 Oct 2022 08:13:48 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2047.outbound.protection.outlook.com [104.47.66.47]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3kb125em49-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Oct 2022 08:13:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N96rUvCr0AaOlC3zN3Ii5cX6aqz6hxiGfeWdCbTmdlupvmRAZ8hiEmd9js3Iszi8nSbhsBCkjJiSDb6j8ixVSMjI3ldqTTgmhideMPHtyLJMHiFrEXWzxHU7hDEyAwipIq5HyBfNe563S+QBuqjfUCJTTalf6RfV94FLpVZRo/t8vns4pKYTlB5jWkOAbvNSvWhUbCT4aCBEco/2jR+9QAgoRr0VZHUElLh9MTKYci1SZdo79cgZdqmTb91lf6CLaZz2Nhp92cNc3LLyaoB5r3bJfRHUraos0516U8lvnZW6a/nfFRTbotkndO7wpFJifj49bC5BRPbTYYBVaH1Etw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/LxU9/sOTLfa502MN+JOxrrrumWz/mpRM3eDqo+ipM=; b=JPtmH40e5QoqYOICLBRio1AP6Zl6OCvSRBp5x5e6d7TvbsPpzxXxPtvMhn4NXtxKDlVW8WMCMx4sFzuwELpthVBqCqVQ/QAV+Pr54vwrrXzX6o4EWytL/buMSomf+F62JV3oI9ebw+unO2kp4YMfEcfuQ2LxkMR7IIW6BceT95QBhs/FDxgJWCeA9MyIVH4RpJJSykU25yBQLIv8Net2YvgWjgfce8Nka/UY3hkylodsFcufpqu0GjJpnhB7D8XpcK43kgPzeWW59lzKamYkxVzT0y4AaVlXB54iRaFeqxujaUm74uU+hrXJcEZLrOxFR3BIHDrRKiSRNHyyDYAHVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/LxU9/sOTLfa502MN+JOxrrrumWz/mpRM3eDqo+ipM=; b=HL8Xa2b+8wGQTFP2Sz2w8WO2LJ9wv2We0AzqN+YFhSVuwBM6lBpPeX9DnPHxOVUVMY6moTo2yQoBkVqSnLk6xtyGMMLCi2XxamQp8pdZDt/n1NgkMO2HInNbQB6cpYkx5ErgD8nJ1KKHyTXDztwzAgj+ny6BJLXxPMjW+Av9Tts= Received: from PH0PR18MB4491.namprd18.prod.outlook.com (2603:10b6:510:e6::13) by MW5PR18MB5149.namprd18.prod.outlook.com (2603:10b6:303:1c7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 21 Oct 2022 15:13:45 +0000 Received: from PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::bbbc:1f13:37e0:691d]) by PH0PR18MB4491.namprd18.prod.outlook.com ([fe80::bbbc:1f13:37e0:691d%5]) with mapi id 15.20.5723.034; Fri, 21 Oct 2022 15:13:45 +0000 From: Akhil Goyal To: Anoob Joseph , "techboard@dpdk.org" CC: Aakash Sasidharan , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Thomas Monjalon , Hemant Agrawal , Sachin Saxena , Ciara Power Subject: RE: [PATCH 0/1] Add security perf application Thread-Topic: [PATCH 0/1] Add security perf application Thread-Index: AQHYrTbILTUNLo3EQ0mh0YdmXtVBKa20bRfwgAFwtgCAO9umAIACNQOAgADR3ICAJKRPIA== Date: Fri, 21 Oct 2022 15:13:45 +0000 Message-ID: References: <20220811035933.802-1-anoobj@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4491:EE_|MW5PR18MB5149:EE_ x-ms-office365-filtering-correlation-id: ce5da592-0bb5-48d6-f537-08dab376d917 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ltlKVBOfwgkwDaCO78dk4iCYEtZ0wvXl7Nr58J1iFMtwftTkmiSc0drpONmg/U9+EoQ3px1zrK358jfkGkhWC9kkcKnFGKkTr+OTzsrtYQs9sfeLnxUaHaoLlFejGtIWI5d9SLkcbnu2JG8qW7Bjhm3FeOSWAtMVC3swYUytiVj7hiGbLPnFcJ0cdsnKv3g+HjGbLEhVLQ4FO/6WD5VULuTXctb2Y7y4lj0php22HsUAjwIa6cx6aauxWyIZRNd619k5kkTim1S6IsnDUVCAuAirTuB2K6Qgxr2OTQu5IloAGN4C7M5zlrQGqGCIgTb1uK+gCTqQ9KeLZFtJqCVfXG+P3p74OyF7XEAMI8xj0Iky1l3JhesEk/O47DlS3CAG7uAJiNg3EcHStWiDE8WlhZap0QIcMyJc0qV4CkwGnWXp3woj8wr3T9DyQ/+GvbdPOlkpwngcjici8m9bd/ZNQeUxmv6SLfVn1A7KTB1XgAtVuxtslzGlRa/Vkpxy9ui3/jfSUaLVtexeG3G2yiHDNUp6S0gfuPmdRUlFHhi12X/ehI8P8blYokIeofTtoNAsAkqdDldTnc+2dc8LgoRgZ9j6SABx/eSt6jBb6DEq61b6VrqN2fKkD9LHfuLfVTQt8hX5BTsHsw7LnJcI67kNkPebO1C0JfDoV1o4Yn7qUfV+Yv1Mbi8hbn+2Et8CDB9tQAxxBEMmxIToxvh0LLthRXMaRHY2aMnVZiTywniW/TR6s79MSZA3qZ/4SpA3CmU0M5MP5a4DGlNjiVOYdvxByQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4491.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(366004)(396003)(451199015)(5660300002)(186003)(66899015)(66556008)(2906002)(7696005)(6506007)(110136005)(38100700002)(26005)(316002)(53546011)(54906003)(86362001)(55236004)(8676002)(64756008)(41300700001)(8936002)(66446008)(9686003)(66476007)(15650500001)(83380400001)(4326008)(122000001)(52536014)(38070700005)(55016003)(478600001)(71200400001)(66946007)(76116006)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RydYhm9IQcpONrQhMP7tZh4y3cnBVTvh87PxgztJICy8BVDINYpj7WmQK1nS?= =?us-ascii?Q?S7rLzvDX0PIoY93vhxOOZBPkuPuXjVIeoe6Wva6dc1XFQq0/XUzoapZLlXuj?= =?us-ascii?Q?UfXorFDcH1Jj+2rteOmGGZ/7YfTt1dX72CLYxD/5atqcFk+biGJoh3WAUTKj?= =?us-ascii?Q?AK8fFE85dwboyDNmZKIbKtozVPhZUVnRqaSusbUpIX7wgp61xxApR/uMRw4l?= =?us-ascii?Q?NzyTNG0PZ0yOJ3dRh4wK3Z1CyC3VVHExabhUVZmW7Xc09Lq1aq3cGrnt/aS6?= =?us-ascii?Q?Y0LRcq6HGQrdkxIMx74cSKM8mQxEq1/LKMSPFFDSBUSDrnpPjhJeJa/G4uFz?= =?us-ascii?Q?6YQoXWdhQeQ1DYpOxnhga/qAJMwwsMHqFrW7l2Pz+8CxtgOPnQconHA+Hn7p?= =?us-ascii?Q?ik0wqPA1FujuQ69YEc5ScFZuKsM/SOIru4qVpEt0GGwHcMDJMFhnY3qrUd+u?= =?us-ascii?Q?9UqCJfKKaocikfYpMqxZO4X2C14qlUXdMCcAIkEbeEyXX6zNyYWgDZ9oaKQC?= =?us-ascii?Q?brB1O7JCQgubiu1Jxcwhb4qKeVqgOE9tfOmnyZfhVMUU/yU08JonrH9clBfp?= =?us-ascii?Q?cTHzcU+WxKG08GzvXw3sknCx+Xg4Xxyjb5B2GE9KL6dtUNsgqSCpdONKNsAU?= =?us-ascii?Q?SbkQr/CbtwAaekt/F5TDhTKhTARkahl1JrbQOAJZJgc0fQbQBOTXUwiv2cz+?= =?us-ascii?Q?ZUc3QvJWLF2eeJTTOl4nIaQiykB26VhSvKPTWdNWH6KIpby5dLcaKHsVSuVh?= =?us-ascii?Q?hJS8gMg9DGAQObhReTtX1jGlDTclI/CErSFPJHYpPPNTA0qXd2zbHua0ZmUZ?= =?us-ascii?Q?plAdfWk7bmivt0OL1OTA1ifZeqfW03N3bSLEcWXfd9w+YOM2Qty6I92UBvkn?= =?us-ascii?Q?EPqhHlf99VT3Sro59bGXQv5UYC7Dt4Bf43UcUs+2WRb0h89WG3TAzgZWTAYw?= =?us-ascii?Q?VpvPlOru3GPOSN8gl0bk2HARlzDORfOXi4+8rmLKUwrTjr1fFrFd+2PWB5Ud?= =?us-ascii?Q?I/xtWksuGVgXWkrcDtWnDMl8sN0PaJAOXpe/nflQnuKQgVIHbVaoteAB26yo?= =?us-ascii?Q?qYNCqnKc9YXulUA46GZ+aoPSapdhVDwkCzcEIq1q3qWn17QRME7/QcvGbdbp?= =?us-ascii?Q?rjWRYPwmiN6yTWkn72TI665MW1gJM9tHJkOkVYAk623+YowzqGr4N+cQQASu?= =?us-ascii?Q?Xk6hs+YYkT+/69g+7DEwSbSCIQld1AY7kR0+ujyP1U1PM0wDEMuzqNEGZcKP?= =?us-ascii?Q?VRXS1UoypSCyERYw0+jdfmdusMgWv2Ruen/3J/mEFPDJ5l7fgUv3WSPPzlOp?= =?us-ascii?Q?eHTlG0gi73QonC62JfICpD6v7rI1yVaLQXKe0vCB0EHmQHxS0St1yvLKh6Jy?= =?us-ascii?Q?2NEF23afAERe/q8tmY8642wIZzeEUEbDrVdKTWqjPIlvgVPco5pzUUaySko/?= =?us-ascii?Q?BHtJYIlaF+ss2whaKI9SpJa84/0kmlPxoPUEL1N2HT6IpjnQ/cJHSBcsEJjp?= =?us-ascii?Q?MeqT+n33rLqKWzgIrUL0pQAjFHuV3x2Lp6A3iM/kleSg/awIepbEaO94Vi54?= =?us-ascii?Q?KsKH4YTv4JVzB6Q9Gx9J462D8HSnH0AxPrwJjFGi?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4491.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce5da592-0bb5-48d6-f537-08dab376d917 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2022 15:13:45.5772 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nFrpQ0jt/huKttzQ92XhC2yYlK/oksDhpf61E1Gq9S10g7lKLteclpmldj3RB3XcUYDLZe8bMzDR2iK8AE9c2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR18MB5149 X-Proofpoint-GUID: 2ZYUS7mzyUoPs5dsoJofIZi18-WkG8vV X-Proofpoint-ORIG-GUID: 2ZYUS7mzyUoPs5dsoJofIZi18-WkG8vV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Hi Akhil, >=20 > +Techboard for guidance >=20 The proposal is accepted in techboard. Please fix compilation issues reported in CI. > > I agree that common part would be init only but it can scale for non-se= curity > > sessions easily. >=20 > Currently, dpdk-test-crypto-perf has a data path framework which prepares > crypto_operations based on session. The proposed application is about > measuring performance when creating and destroying sessions. So it would = take > rte_security_conf as the argument and current data path framework would b= e > completely bypassed. Current dpdk-test-crypto-perf creates mbuf_pool etc = and > creates one session per core. This app would need larger pool for session= s and > no pool for crypto_op or mbuf. Moreover, dpdk-test-crypto-perf works on > cryptodev while security-perf can work on rte_ethdevs as well. I still do= not see > any community feedback on whether plugging rte_ethdev init etc in dpdk-te= st- > crypto-perf is the right thing to do. >=20 > So other than basic eal_init(), I do not see anything common and even in = the > long run, this gulf is bound to grow. If the app has to be integrated int= o dpdk- > test-crypto-perf, then it will be separate .c & .h files and completely b= ranch out > after very early init phase. The testing methodology and philosophy would= also > be different (for security-perf, we are running all algos supported as th= ere is no > need for command line parsing of all algos. CL parsing would be added for > protocol features like custom AR window size). DPDK community had earlier > encountered same issue with "test-flow-perf" which could have been integr= ated > into "test-pmd" in a similar manner. But DPDK community decided to allow > "test-flow-perf" and so the same logic can be applied here as well. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Wednesday, September 28, 2022 12:47 AM > > To: Anoob Joseph > > Cc: Aakash Sasidharan ; dev@dpdk.org; > > techboard@dpdk.org; Jerin Jacob Kollanukkaran ; > > Thomas Monjalon ; Hemant Agrawal > > ; Sachin Saxena > > ; Ciara Power > > Subject: RE: [PATCH 0/1] Add security perf application > > > > Hi Anoob, > > > Hi Akhil, > > > > > > Do you have any further comments? > > > > > > Subject: [PATCH 0/1] Add security perf application > > > > > > > > > > > > Add performance application to test security session create & > > > > > > destroy rates supported by the security enabled cryptodev PMD. > > > > > > The application would create specified number of sessions and > > > > > > captures the time taken for the same before proceeding to > > > > > > destroy of the same. When operating on multi-core, the number o= f > > > > > > sessions would be evenly distributed across all cores. > > > > > > > > > > > > The application would test with all combinations of cipher & > > > > > > auth algorithms supported by the PMD. > > > > > > > > > > > > The app is similar to 'test-flow-perf' tool which captures the > > > > > > rate at which flow rules can be created and destroyed. > > > > > > > > > > > Is it not good to add this into dpdk-test-crypto-perf? > > > > > > > > [Anoob] IMO, It is not good. Following are the reasons, > > > > > > > > Dpdk-test-crypto-perf is primarily for capturing crypto operation > > throughputs. > > > > And so the framework allocates minimal number of sessions and the > > > > datapath function pointer etc deals with only one session. The > > > > entire framework > > > available > > > > in that application is for populating crypto_op and mbuf, which is > > > > not required for this app. Touching that framework would mean > > > > throughput tests would get affected, which I don't think is the > > > > right thing to do. And for PMDs like Intel's (which don't have > > > > security support), it would be an unnecessary performance drop. > > > > > > > > The proposed app currently runs for all supported ciphers while in > > > > dpdk-test- crypto-perf, it runs only for a specific algorithm > > > > combination. If we want to > > > limit > > > > the functionality of the proposed app to match dpdk-test-crypto-per= f > > > > usage, that also calls for a major rework. > > > > > > > > And the only thing that can be reused is probably cryptodev init & > > > > queue pair configuration. As you are well aware, security device ca= n > > > > be cryptodev or an ethdev. Dpdk-test-crypto-perf doesn't have > > > > support for initializing ethdev and rightfully so. Adding this to a= n > > > > already complicated framework will be counter productive in the lon= g > > run. > > > > > > > > > Can we add as a separate .c file, say, cperf_test_sec_session.c i= n > > > > > test-crypto- perf folder and use the existing framework. > > > > > > > > [Anoob] As I mentioned earlier, nothing from the framework can be > > > > leveraged for this application. If you insist on not having a new > > > > app, then all this can be integrated into dpdk-test-crypto-perf, bu= t > > > > that will follow it's own path from very early stage (mempool > > > > allocations etc need to happen differently). And it would mean > > > > adding more command line options (which is currently at 37) as > > > we > > > > add more options for measuring security perf. > > > > > > Are you planning to add more options is that app? > > if not, then adding just one more option about nb_sess would do trick i= n > > test-crypto-perf. > > You would just need to add 2 new functions (test_security_session_perf = and > > sec_conf_init) in a new .c file in app/test-crypto-perf/ and the mempoo= l_init > > is being called from > > cperf_initialize_cryptodev() which we can hook to get the nb_sessions f= rom > > the command line arguments. > > I do not suspect any changes in datapath - so it won't be an issue. > > The point is not about the things being common in the two apps. The poi= nt is > > whether we can accommodate in existing app or not. We cannot have too > > many different apps. > > We only introduce apps which are not possible to accommodate in existin= g > > ones. > > I remember, there was discussion in past about having a new app for tes= ting > > multi-process for crypto. > > But that was dropped as we do not want too many apps. > > I agree that common part would be init only but it can scale for non-se= curity > > sessions easily. > > > > Regards, > > Akhil