From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85DACA0548; Wed, 15 Jun 2022 10:46:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7879D42820; Wed, 15 Jun 2022 10:46:39 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 399DB40220 for ; Wed, 15 Jun 2022 10:46:38 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25F478h7027940; Wed, 15 Jun 2022 01:46:37 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gq83ys4rp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Jun 2022 01:46:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KzWNSdAqd755UTWpXJpX7ECOjDXHXqZK6dhYWDosq1Y8kqHDJH8u2aHtHyYJWam8az/rMrZ5/8slY1YYrcfS0MsRgJzooDUfozU0pOBFCBIZsJvYP0dMibKtrlwXZChnNmI46PVNNWGcL7HGYJCbLZWy6o13fVNEvKQb0g2HTsmvg34l+SHBtqI28ggJRDG0xI7WPs4gr9AoKvViUIrFw2Aj5V7hkufaveEwuoB6A9AuyvAn6H0fPIbtpkQumUa+dyHbYnjE4FmU50QEClaEHWcAS/LBucyDh65xDR0e+2Sj5AdnT4CZ7MjpukR+NtpSQgwm5bzrrqWJzUEScpamcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9laWYiaiP73vKHOHG1CUuhLsBkN/PKQ/6rdnqN0epEI=; b=Sv/gMlf5XnjiyenEcCXMYjxjaYGh3oHj3gLXDHFLITrzfdOdLCjiZ7nnt8BInUjxqiSigq20bGV63MjahytP/RY1mIKnvzkEiKfzMtLWA2XJJeaMaN7jA4JKKd/NOffNLDjWKOSlHfp0IMLDhYeT/M6PvFkbQFjnl6uXqJLu1vMgV5Un4/Qb1kUVSQlsXxC8KR4jJ5WPH/MhEhUYZbOeXIBltLcQIUsFySnPbhpiFE2krXvi9kzgr1ENdtCnJd9FFp0JLLX9oN2l2z+yPYsNn3DfL39EhOpS9bXdngjEqCukZfXsoz6k2usBZ9Jpnn+f70JRcOxqIADU9+vtwi0eOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9laWYiaiP73vKHOHG1CUuhLsBkN/PKQ/6rdnqN0epEI=; b=j+5fCqPJgicfqvB+xHCGAI7dEcDSuV8dWU8PjCHiSxxivwpC15dQMRINqN4BD+GwdYCkWIsxHL90IQOcZtA7FHvb/SXUs++fn8EwdHU6K8PbsnrF4RYPvT0jt6ttu9V8Us7ilhuiTfoa4StpwcPb+xEHH8xd0r3CaSipefYmLxk= Received: from PH0PR18MB4573.namprd18.prod.outlook.com (2603:10b6:510:a6::19) by BN8PR18MB2707.namprd18.prod.outlook.com (2603:10b6:408:a6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.22; Wed, 15 Jun 2022 08:46:34 +0000 Received: from PH0PR18MB4573.namprd18.prod.outlook.com ([fe80::e052:dfbc:fb44:6189]) by PH0PR18MB4573.namprd18.prod.outlook.com ([fe80::e052:dfbc:fb44:6189%5]) with mapi id 15.20.5332.022; Wed, 15 Jun 2022 08:46:34 +0000 From: Jakub Palider To: Thomas Monjalon CC: "dev@dpdk.org" , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v2] devtools: ensure proper tag sequence Thread-Topic: [EXT] Re: [PATCH v2] devtools: ensure proper tag sequence Thread-Index: AQHYf3QkQxQfAHQ4+0+2q3XkOrA4lK1QAR6AgAAiDoA= Date: Wed, 15 Jun 2022 08:46:34 +0000 Message-ID: References: <20220613222143.1436424-1-jpalider@marvell.com> <5848204.lOV4Wx5bFT@thomas> In-Reply-To: <5848204.lOV4Wx5bFT@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 109cb470-4560-4f01-40fc-08da4eab8d25 x-ms-traffictypediagnostic: BN8PR18MB2707:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mZAumnCq9hVVW4lGZbLCDilqJ9cgji8O9oegd/mO3QxhUYWqTaqCph5dkHPtMdFHDB0TqSYnsAwQxVpFc755w3BVfMrUsIVXIoZvE+9VkWMOp1zmcC4swvMooaUwABxb5D5Lq85jV7udk9Es77wVG4hsWDkNnHXXcXI/OZfPUvAHr6Vh3INq7Hh2eFL/EyYOLlGMAYMr3yVd2AZS8sc4pAQkxFH3HZGxZKn8AMp2vjKG/mYAKKg9ojEMO0928H14FVRyJaL/CnKHXXsN+fkND1Kk00/pCmZktyWNVaMJIKl9wUwheapjyoD2+6NVI6I6iPHIAutSxQTwb83ixd4t4VGgJb9L+x9aaZFCUaiWSi0/kDeTGHgxt2LNpkrgDMFmZGACs1CZBkUEgMAhCejnE0nHWc9a+tgwCv/Yd9GKgZNKBSopbN/A80TKBeelAYxeYAuqSTLBkDyribsgd4KfX9T/ESwwW31htaahXn6aOnacycETw9b24Bsn7dJrkW/6FdVZDaG8k3IymX2/eUij/i0yUCyNL6EMtBQpxrPqmuhDXxPMOEgsE0KFHGQVEnz737rF2FUcmETEhhTNeX0DoUbYtOeqYbk4lrp9dOX14NeKKcJcrezncZb/m+07IN2jBDCY/jqfDShDmUT5zW/pOyiTte1a1S9ovJAhi/an/ObLGDSLKkFZY4/JVuO0visuuDBPjPjwYeR8Zr+davtGyw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4573.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(4326008)(66446008)(508600001)(66476007)(86362001)(64756008)(8676002)(316002)(71200400001)(76116006)(6916009)(7696005)(83380400001)(66946007)(54906003)(122000001)(66556008)(38070700005)(186003)(5660300002)(9686003)(6506007)(2906002)(52536014)(38100700002)(53546011)(8936002)(26005)(55016003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5ms72WYXY7raBE+z42H3GW9raeiNUqiuS+W9qFzfqpDxmsOLYPPJFRrnQ0yz?= =?us-ascii?Q?sSPaLMYZlHs4teCnHZTVP9PfWU+dx6GtQoReNx6mskS6ezz0TdKHVw0oq6G3?= =?us-ascii?Q?6YZhrtfbASrnkGrfinFQrX5AMsJ21Io4mvTfet9UWAC6xSy4WBdKVsu97nXY?= =?us-ascii?Q?CHUNEOQGDF775wAZnFG9qHHywJmo7tRZNTqBPiyX5tGuJkGNNsMsMf5Unq36?= =?us-ascii?Q?xtBNkHQHzy/9I8FhVsCwGUdFQULwGkuUFd44R5z16WX3sYH75zjFP7175t9b?= =?us-ascii?Q?CDWm15y/Z37Dn6Q0wfJqzTP7RzfR1lBd2l6QIsyjh1Wi+F+smWoIUJtrUT8h?= =?us-ascii?Q?mnmll2fqq5k34XFMsxE7v4XOIsSDe2ITqdWRK+k/xtIG7EdlsD4GK9Bh+785?= =?us-ascii?Q?2J1TxJgy+MTmB2XDRcVGFBmXJskQYQwBH3GqMUIvWzj62OZVUo5s2QKgWvDr?= =?us-ascii?Q?3b7dCiFdMmV1HUYMt79e3cYcs7M7w0FZJmykRMLnVnUCIOCF5u1+Eymv9ljX?= =?us-ascii?Q?C5M9XfNfsIubBlSzXKqzXnFCDQdjhnKHlxo6qPoIfqxMRnW1aWMu+3N1XEBJ?= =?us-ascii?Q?To4bbu/vAcbOJLewbK181A7FvHk9mzo0+syZnhOBfZDOly/LdzfnbjdVrPxu?= =?us-ascii?Q?uIfCOeRe0e1Mi4QxdB00+YbBXiO7YV6rgBnqpRw6OkEq5+eyFn01ZIBIRpa+?= =?us-ascii?Q?YDTVdCWx8Po+c4Bh8qOzDmuxaR7gHY4xgw4LAn9PpBJ9DRk3ci76hQnGTvnp?= =?us-ascii?Q?BQn1wVTFCJYpmC+mtakoln3KnnAxiIc7lVZfN0HWHfuwpLojN9PNdd1GMDvK?= =?us-ascii?Q?r1p5pKrFCMoCVHpRnv2gtUKKMWeiLgiAsHAbzOxeX/uKmXWJIQHwVCtVpUOS?= =?us-ascii?Q?0t1Ckf2lpNJqIbx5QxOoNhF+SxVDu4zbnQ1X+5sgMPkWOeLTJCjwau+qZYw9?= =?us-ascii?Q?N0C9cyqLezCwxKV5zIHjjKNjJXVv7teeyZPKOlzVJlMfjXdv5Gi7bMW2q+B8?= =?us-ascii?Q?dX8CbUPHZSQwrRBHNECpNtGyGh6zxCmHkk7Cy4JT9/OOPqnJy1KKUwGb2me4?= =?us-ascii?Q?CBGynSXjHx1RWPgH2fdJ7eJ1tD8zGcog/HlCL40T5m5RWyi+K7BCY1AYRhvF?= =?us-ascii?Q?whgaWZqMq147Huga7tiXau3Rovp1CTGDbkkQZvD3fwke1nhq3F4zmskltIrq?= =?us-ascii?Q?/6qvLpkqGg1CR1kApkL91SgcIplYbOE/PMcFmWTUng56MZVSaAkYgPkR8NiQ?= =?us-ascii?Q?TN2fKCpL6dDRW+9/tSk5cSoMbBu8vCzAJM/x3B5E/vfkCjDLdwfFHN1hlY54?= =?us-ascii?Q?ZFVIDQod1zidvF1QEVMiwhUp5yx/x99JJH4pRycztSuqlgAuJfD3YaTdsGEn?= =?us-ascii?Q?ULgLakSMEPEIBYdEcX1ZFBXeHj3wULSH9YT+g8Y6zcDYIPh359QRIJlhx7Fe?= =?us-ascii?Q?tgrgSdmuGdd/cp0PNSmXdBZPHu1mq6P2TQlxBDmgurwSJWUNKIhRS32iasbF?= =?us-ascii?Q?bJXPGx1l2HkCP2ye3h4aWXoYYGxGgN7rMbHTJZ3seSy5BAdjSiacCbXLdnmr?= =?us-ascii?Q?istQHNf5Rrzk8ZNMtrb3ENmwBYLNAeqDgB0liRmowq9Bvc750oyUUxX3Sh74?= =?us-ascii?Q?Byigw4I6mIP7DOe+dmpZRIWsGIVgb3glCSV3/LcgvqU+slhJsBdPn/YzIBRI?= =?us-ascii?Q?Ssbe4psW+3s21SYfVAA/AJH45X4AWFu+yczQMwRCPWBh/WUxgHbl1xj4Qrky?= =?us-ascii?Q?y7YIzjr0/g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4573.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 109cb470-4560-4f01-40fc-08da4eab8d25 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 08:46:34.0593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jK7v6LeDruYOP/iJvZ9SzvsgibeLQgU9/Phz2FoGmjzE8klwUiB1r1nTcLEtwNe6Fa7inb5vuiu20cGkvc4g1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2707 X-Proofpoint-ORIG-GUID: NrWihfv-zZPjZFEUmQT8c4Cfk8pGziQs X-Proofpoint-GUID: NrWihfv-zZPjZFEUmQT8c4Cfk8pGziQs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-15_03,2022-06-13_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, June 15, 2022 8:21 AM > To: Jakub Palider > Cc: dev@dpdk.org; david.marchand@redhat.com > Subject: [EXT] Re: [PATCH v2] devtools: ensure proper tag sequence >=20 > External Email >=20 > ---------------------------------------------------------------------- > 14/06/2022 00:21, jpalider@marvell.com: > > + SEQ[0] =3D "Coverity issue"; > > + SEQ[1] =3D "Bugzilla ID"; > > + SEQ[2] =3D "Fixes"; > > + SEQ[3] =3D "Cc"; > > + SEQ[4] =3D "^$"; > > + SEQ[5] =3D "Suggested-by"; > > + SEQ[6] =3D "Reported-by"; > > + SEQ[7] =3D "Signed-off-by"; > > + latest =3D 0; >=20 > Do you think you could check that Review, Ack and Test are added after th= e > first Signed-off? Ok, thank you for clarification. So any further Signed-offs need not to be = in a particular=20 sequence as long as the first one precedes Review/Ack/Test (these 3 in any = order). >=20 > > +Tag order > > +~~~~~~~~~ > > + > > +There is a pattern indicating how certain tags should relate to each o= ther. > > + > > +Example of proper tag sequence:: > > + > > + Coverity issue: > > + Bugzilla ID: > > + Fixes: > > + Cc: > > + > > + Suggested-by: > > + Reported-by: > > + Signed-off-by: >=20 > Given it is an example, you could add Reviewed-by, Acked-by and Tested-by= . Sure, I will restore it. > > + > > +Between first and second tag section there is and empty line. > > + > > +While ``Signed-off-by:`` is an obligatory tag and must exists in each > > +commit, all other tags are optional. Any tag, as long as it is in > > +proper location to other adjacent tags (if present), may occur multipl= e > times. > > + > > +Other tags shall be laid out in a chronological order. >=20 > Yes, after the first Signed-off-by. Side question: what about Sponsored-by, I noticed it appeared just recently= ?