From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B879A0C4B; Mon, 8 Nov 2021 05:32:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2BA640151; Mon, 8 Nov 2021 05:32:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id ABEDC40040 for ; Mon, 8 Nov 2021 05:32:12 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1A83KkYn014015; Sun, 7 Nov 2021 20:32:12 -0800 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3c6uwa070f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Nov 2021 20:32:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUMZAxVqsFeygYZiX8r8iYdr1jMmp/b4p5WJ334I7RhZASux+b47U4QRwunkoHnxQbY6VLFuGPDyPwjvQ7RLHPgPcXFyXErOPkU917VsNDmJmQTR1lYZzmqBmjN9BwVIwKdRWdL1qXbfZqrjxufizTvWe8QK2dXZBUPDAdycKdLcY5EwbxnaFWOxQ9LuwEca3aleoym1hCFwzsHWRIjSBjZ3H317YZJZjPdTGlH1fQqMpYtJPvlP7UP3Rp0Qz+84Aw2rAG2+DwTyqoDdVDFzavgBWEkYoYDoCGO/Ny/+JC7atT1fQay8DSGG6epY5CswAemJoB6fl0C/KKNf9uszcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L26X8Jay6FYlO2SupLmXMxSRIKDa7dLSR+IovnErbbw=; b=LMw/eAmBDe7g9JIF6rod9OSA82kgui4TT+AC5xVoeVnch6D1HsxOfGrq+qpmSOuf9VqjIaJUp5y85vSz0e4DKL3bDv/7O1QtNM2wKbYWkM8fBU3u/EyRbysqHufgOFkyPMc42CHEoBhWqldg1GmY/O+ltNTkxI3cXsA74XYPLR5/VKa0kBhRFBTKNdi3Ados6n8a+l7vpJEE/BH3PPUGmqNxjIdjzh6OgtbHeRCxEBHh108O2PehblnrAm8WQ6kozZQR74rEEyghOasFQxVeI9YPiYCSPy19rQpJsRPuyqvXs11xMVwaMvKYiBwuLeqn6CucOj8hPQTeBTjUDYqs0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L26X8Jay6FYlO2SupLmXMxSRIKDa7dLSR+IovnErbbw=; b=r+zdo92kUMftMOPDGMmzHAtxONjzCT+t005wmRsaiDuIHk0EcdapNGY+OokW7bY8L6w0PbqHg8MW9+Lg65F8rH96G4mXcxRyGc2aFNJflhysW5aSTAoevUD8Ko8W8zAPN4shhThIACarOtMZA0ld4v+YH4fbYCqV7or8yvyWq7Y= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by PH0PR18MB4800.namprd18.prod.outlook.com (2603:10b6:510:cf::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Mon, 8 Nov 2021 04:32:10 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::30fa:e30f:a8cc:92aa]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::30fa:e30f:a8cc:92aa%8]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 04:32:10 +0000 From: Anoob Joseph To: Anoob Joseph , Kai Ji , "dev@dpdk.org" , Akhil Goyal CC: "pablo.de.lara.guarch@intel.com" , "adamx.dybkowski@intel.com" , "roy.fan.zhang@intel.com" Thread-Topic: [dpdk-dev] [EXT] [dpdk-dev v1] test/cryptodev: fix incomplete data length Thread-Index: AQHX1FmYcH7mixk5MUCJ9x/wjJUz7g== Date: Mon, 8 Nov 2021 04:32:09 +0000 Message-ID: References: <20211105154204.7191-1-kai.ji@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 966a5868-e874-4200-8fd2-08d9a270baa1 x-ms-traffictypediagnostic: PH0PR18MB4800: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5Byij8rMBh5Qwc5l8TNZ5M6RCmRm9foKsgH36l+oVzhkI4FGvN/Xe0bJRHTw2G8kA/wF2x88LGRnFJ1J9ZoQjAld8sdy+KpxkwAQoZRc6wOMaxWK+yfrmXy4twNX8IISb0lUu7x2Bri+ZvgkeEWY4xgcXXnF4ZOgTxLeGMxZA3CJGw5cbrP/a8QLSb2AyPMFqMzG8ggqPBQRZBX1pja6n1k8YgI3c+Nit5YlSXMIETZQsVjRmlIt15p7Mol0RKB5S4dqxtLOs7mXPvbOKdFglHCy6xWZmHmG73tOCpzWMUP7cxLugHwovsWytKFCz+zeG3t4Pk0r5sx4TiuuVCZzGgniUmLMQ46YVGn3LuWoShd+SxYUco0yyCpbZFiUlW2BnVGocXZOmjDSKjPt1prT4hfIarCIGuqfHmeUWiS6oADE7JCTUQClSyAPUjEWAs2XXCBajGtuhSzKHQHNnb8ohc5p60uIbVYVaXkrUiZhMgIpAUH69+unmnskAiSXOJ6UTc/oli8QqoYNXMG5O6bMou+LUS2gEulyzfR5vDB1UjvQFohhQqlh1GvsKg2cf2pqAi2M+oK+ukAvXo55ENtUPmwljv8baTYSf8Kh5j9/zggx7rKCjRcvuSO6gXnxW6jMKfLjbpCD6xMD0MrQiuakl6nzhOcM1S5PQ7CeLwheW16nDk5UImDKpy49PYNPHQR27ta5klpTrS7HwLVjj9OORw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(508600001)(38070700005)(9686003)(26005)(83380400001)(76116006)(122000001)(71200400001)(6506007)(2940100002)(53546011)(6636002)(7696005)(110136005)(186003)(8936002)(8676002)(33656002)(38100700002)(316002)(66446008)(66556008)(64756008)(86362001)(54906003)(52536014)(66476007)(4326008)(66946007)(2906002)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nQEoH88BuPP6oncjoWWlFn4FTcKaMOtFW6l3PQi6xzoKzXnhJtqODVjBpzGS?= =?us-ascii?Q?afBeJ+5pA56e/T/XP79500SRIpqm9RKoJgetSpMkJxqpLrDWmkqacO0ItATs?= =?us-ascii?Q?AMUogjYgJn8jt8fwiIdxxUiUlXPsKKFK3RH43Pe6anm0N0KJsaa9bY2QIP0D?= =?us-ascii?Q?VBZzut1XRK44t7lPgyxiI7lyJOGUClyYWP9Afswraqp7kTPze0nZ4Lch1CVb?= =?us-ascii?Q?h4hGM3hRRpi2yO0gjFhVySgO1TEkuSvcNa85/LtnoIbr8WBtT6r9ZRc+uOW4?= =?us-ascii?Q?Rhq9AjIfx8sXOqTQwMQGbw8oIX+LmbzDCsTxW9+iH/mBu8spE0pz3MWRBjG1?= =?us-ascii?Q?sRRlnjD96Mu1L1nxyR+98W8caIQN44ugCSTQMVWdfx+0rx0lj4+LL4EiohG6?= =?us-ascii?Q?Kx7J+VEAj65iJHT46lRbqs3fUci2ugEaZjRB9/mJ/3FYX8nKLfrUyiDBvDpY?= =?us-ascii?Q?oSLmXPpn+sjaDLWqKjGjO2jmLbznQ0idMuA63U0UhTXvipWhY9akZ0pgpcFX?= =?us-ascii?Q?NegxaBDDt6Mg4ApJjvLsMG+HuMHu7C3Xzs7FvucIG9uapv9aQQcXFHAfbngm?= =?us-ascii?Q?0KwbiyYLHDAQ18MA/hnR4wNk/pjesSbMqYN5g02cMIQc4keBxEDxoi3FvEYe?= =?us-ascii?Q?djQWUEVF7AogXK9V8V7PLCwqoVDy4yRyrOVuDbn1j5OOSIR33GescDmUZMOY?= =?us-ascii?Q?9kTgoIb5qt2P/SpMEQZalUEW9sUELsRRaI/fD8pIB/m+JN0D+TQk70XIkLXB?= =?us-ascii?Q?0CUZ6jnxSyUvbEnNScAFF08DXaIZeTC3GmnVpJrS6CLJLyHLwM79aE0XqczO?= =?us-ascii?Q?gGQtlpnM/kiiBMOM487/maC6MW1B3UytU/wB1Djjw2wv85lYjurEPVH1SInb?= =?us-ascii?Q?1X+1mM8Wou2VAqYjEnceYqbp2PX0+pMp9WKrOcS79Hc7rl3jV9nH8i/CsN+L?= =?us-ascii?Q?OHOdUCzeTK2xufLkwsNCI9GH9ghoX17K4gqu3eKQqj1ifUi9+xhaUUNlteT9?= =?us-ascii?Q?QHS+0DwYrDpKixDBYMDF61wrnb1zvHUMXLpToieCXoQUQ2SSLBXThE6qG8EX?= =?us-ascii?Q?xn3wpNPs4DyyoxZjQEv27ZhpQnN9KpYQN6iGbzZel4xq7sc79eUh5U+D8SyF?= =?us-ascii?Q?7alE8GqkpxjBkTmMXlCtk2acHAsSEGFlMxrXzxaAd8nei7gkVoS5RWDbHq/u?= =?us-ascii?Q?HGIaNcUtNhLRrZbXR6BgqoxpVBTI0OXXPFqwjCJcadLygRoGuAZ2esYwZ+M3?= =?us-ascii?Q?souBeh3behzZr9P0xHhoSAtw0kVImSw/0ZHyngPJc6q9o97UQNaFO5pmopxN?= =?us-ascii?Q?20e53Igj/puc5OQuhncUVrww6d64TRypOY5QWE3zY76nYKduz/9iTeP6INJd?= =?us-ascii?Q?AlInOZVJLbUZRi2Ig/4pkmaFFFZqm42hxZCt65UbgQS1lbeh6uGAWr+TgiOk?= =?us-ascii?Q?fey/axSv1WOMFqk8dhxxNvDt+Sisc1xFvc9XN+OsjxpvOZDgRaggQdxoMT+8?= =?us-ascii?Q?JlGTsNgP9c3LD2F8EEETRkBpFig6580vXkzHaO29KwhuxWNHY3U9iUq1BUWS?= =?us-ascii?Q?Q/zMTto0ZhygPl5sTzv71g5ZwPvbrU9C5lfyja+MwYW+naIC4MyWJYVwEfXe?= =?us-ascii?Q?vrJY7OBG1GiBqSo2uRUj/H4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 966a5868-e874-4200-8fd2-08d9a270baa1 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2021 04:32:09.9678 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M6sva8EyOm0M1hQ5xlAa57XiCIc6r+ogRMXBsR8diH/Dx496OfpBxcuCioisiEWCNFcp2DxEolZqFSJp45jqQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4800 X-Proofpoint-ORIG-GUID: EKZBPQ8wKNxvwJaE022M8xpSts-kUcPN X-Proofpoint-GUID: EKZBPQ8wKNxvwJaE022M8xpSts-kUcPN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-08_01,2021-11-03_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/cryptodev: fix incomplete data length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kai, Also, couple of nits. Please check inline. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Monday, November 8, 2021 9:36 AM > To: Kai Ji ; dev@dpdk.org; Akhil Goyal > > Cc: pablo.de.lara.guarch@intel.com; adamx.dybkowski@intel.com; > roy.fan.zhang@intel.com > Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/cryptodev: fix incomplet= e > data length >=20 > Hi Kai, >=20 > Patch looks good. Wondering if we need same fix in functions such as " > test_zuc_auth_cipher()". >=20 > We were also hitting this issue when we enabled few additional features i= n > Marvell PMDs. Upon investigation, we realized that this issue would come = up > for certain packet size combinations if the padded lengths are not same. = We > observed the issue only with test_mixed_auth_cipher(), which is getting > addressed with this patch. Just wondering if you have checked whether > other places also would need a fix. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: dev On Behalf Of Kai Ji > > Sent: Friday, November 5, 2021 9:12 PM > > To: dev@dpdk.org > > Cc: Kai Ji ; pablo.de.lara.guarch@intel.com; > > adamx.dybkowski@intel.com > > Subject: [EXT] [dpdk-dev] [dpdk-dev v1] test/cryptodev: fix incomplete > > data length > > > > External Email > > > > ---------------------------------------------------------------------- > > This patch fixes incorrect data lengths computation in cryptodev unit t= est. > > Previously some data lengths were incorrectly set, which was > > insensitive for crypto op unit tets but is critical for raw data path > > API unit tests. The patch addressed the issue by setting the correct da= ta > lengths for some tests. > > > > Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless > > algorithms") > > Cc: pablo.de.lara.guarch@intel.com > > > > Fixes: e847fc512817 ("test/crypto: add encrypted digest case for > > AES-CTR- > > CMAC") > > Cc: adamx.dybkowski@intel.com > > > > Signed-off-by: Kai Ji > > --- > > app/test/test_cryptodev.c | 16 +++++++++------- > > 1 file changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index > > 52457596e2..b926412742 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -4102,9 +4102,9 @@ test_kasumi_decryption(const struct > > kasumi_test_data *tdata) > > > > /* Create KASUMI operation */ > > retval =3D create_wireless_algo_cipher_operation(tdata- > > >cipher_iv.data, > > - tdata->cipher_iv.len, > > - tdata->ciphertext.len, > > - tdata->validCipherOffsetInBits.len); > > + tdata->cipher_iv.len, > > + RTE_ALIGN_CEIL(tdata->validCipherLenInBits.len, 8), > > + tdata->validCipherOffsetInBits.len); > > if (retval < 0) > > return retval; > > > > @@ -7335,6 +7335,7 @@ test_mixed_auth_cipher(const struct > > mixed_cipher_auth_test_data *tdata, > > unsigned int plaintext_len; > > unsigned int ciphertext_pad_len; > > unsigned int ciphertext_len; > > + unsigned int data_len; > > > > struct rte_cryptodev_info dev_info; > > struct rte_crypto_op *op; > > @@ -7395,21 +7396,22 @@ test_mixed_auth_cipher(const struct > > mixed_cipher_auth_test_data *tdata, > > plaintext_len =3D ceil_byte_length(tdata->plaintext.len_bits); > > ciphertext_pad_len =3D RTE_ALIGN_CEIL(ciphertext_len, 16); > > plaintext_pad_len =3D RTE_ALIGN_CEIL(plaintext_len, 16); > > + data_len =3D RTE_MAX(ciphertext_pad_len, plaintext_pad_len); [Anoob] Isn't ciphertext_pad_len guaranteed to be the larger one of the two= ? Do we need another variable and the RTE_MAX? =20 > > > > if (verify) { > > ciphertext =3D (uint8_t *)rte_pktmbuf_append(ut_params- > > >ibuf, > > - ciphertext_pad_len); > > + data_len); > > memcpy(ciphertext, tdata->ciphertext.data, ciphertext_len); > > if (op_mode =3D=3D OUT_OF_PLACE) > > - rte_pktmbuf_append(ut_params->obuf, > > ciphertext_pad_len); > > + rte_pktmbuf_append(ut_params->obuf, data_len); > > debug_hexdump(stdout, "ciphertext:", ciphertext, > > ciphertext_len); > > } else { > > plaintext =3D (uint8_t *)rte_pktmbuf_append(ut_params- > > >ibuf, > > - plaintext_pad_len); > > + data_len); > > memcpy(plaintext, tdata->plaintext.data, plaintext_len); > > if (op_mode =3D=3D OUT_OF_PLACE) > > - rte_pktmbuf_append(ut_params->obuf, > > plaintext_pad_len); > > + rte_pktmbuf_append(ut_params->obuf, data_len); [Anoob] Now that more things are common across the branches, can we move ou= t some bits outside the if condition? Like, the above line is definitely sa= me and be kept outside condition. The append call prior to this can also be= kept common if we can rename the local variable. =20 > > debug_hexdump(stdout, "plaintext:", plaintext, > plaintext_len); > > } > > > > -- > > 2.17.1