From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07019A054A; Wed, 25 May 2022 09:06:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A96D9400EF; Wed, 25 May 2022 09:05:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 338BE400D6 for ; Wed, 25 May 2022 09:05:58 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24OK8NxF020584; Wed, 25 May 2022 00:05:57 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g93ty2k95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 May 2022 00:05:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aplt9hyZiOoLf5qqXudZUBpCz2mBTDBjnf4FkUoy5JkIYf00SxE9b7CCir32DBnTAXRs0I3bHc37B0WPQTRwt3ZsuSl839+3gDhrDU0IH0IY0ppTGnd3/JxIC1H4zeVSehNErc9p24t6ka6klJm6OeGCTAN/leoRXSqac3wQSK/z1ZvsF/SocIhad1wvkbO4cT9UajyQDz7H00hB8Mj5thWY/XkF2Tojaz/tetHKu4c7TC0qsylRpfLr9qv4J+AWpVdJ50Dj2TEyLaNJT8OPEsWfBpVcUpojIa+G4VYBdVc3Hol0rrN2tZ1KXlso9bQzRVgu5EFNESX7FbWuki1tJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IWP9DwN7hikr3+KV7JSLuuMraDKdP9kJPwCorPDuOz8=; b=mgrcj1TH1Z1dUY9WdJVmsYTeBCpzvEum1GV6/8cokhV3R3QWy7CvkII9t2X9m6RrH/mP3oFfD6jMx+fPDSSd023f4f+VR3YLy3F+bt2t2E6+3Pmprni13Lga06/FGRp3ZzrzKpLI3ta/M7zi7yuE8rGxx0IeDBCrDT3ITFDFksU9igkFXrFPmvAYEDYU9M40udYwwBZaKUIBCM0oAst0EnhTdrvXeClCnxtra5FVRbpzW6YCVxuZ0u8WshfemZJIbkelLo/tqKoxZY3FE7XLKrtSPklI0EEahSg6HUqkR4O3dcFan/QzeKMBLwDMYF80K3Oy/zE+SKj0GuRSDLRMGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IWP9DwN7hikr3+KV7JSLuuMraDKdP9kJPwCorPDuOz8=; b=hJPTa22EqADOxUtFAexwAEdHJ11Dym8r5wgyHvLMpIqqs62Hx0N8+zGfbSmXCQ75APvdBgAcms68NN4zPSZjYQzFh0bM4Ds7xonzYkXqwhN75yii2U9SakhIR4rCrIJT8YbqkfJhXiZ89x64a7URRHgw2Q7tD1nHeW0/a9Z4P4s= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by DM6PR18MB3226.namprd18.prod.outlook.com (2603:10b6:5:1cd::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 07:05:54 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::141b:43fb:348e:f3a]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::141b:43fb:348e:f3a%5]) with mapi id 15.20.5293.013; Wed, 25 May 2022 07:05:54 +0000 From: Anoob Joseph To: "Kusztal, ArkadiuszX" , Akhil Goyal , "dev@dpdk.org" , Kiran Kumar Kokkilagadda CC: "Zhang, Roy Fan" , Umesh Kartha , Ramkumar Balu Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Topic: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform Thread-Index: AQHYbBelwNWHI0EqxEqJyWBKRfYRyq0t5jIAgAA7+gCAAQCsAIAACHaAgAAERNA= Date: Wed, 25 May 2022 07:05:53 +0000 Message-ID: References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> <20220520055445.40063-12-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aded46cb-9ad1-4e34-3f5d-08da3e1d0254 x-ms-traffictypediagnostic: DM6PR18MB3226:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GhqMfEF5+9Xpq72NPTsNPmh2j4RTQ20tbqn8CcY5W0auubMGuvYKy9Y8pf7P/SxthhWWQzLtvfpSRCObNBPjmJLT7B3UIaUZc0EsR/IPC1jxjmG+P3C34A0/jZDtdVNWUVLL8BtRqoMQwC2kOIYxeVeYhr73AMtBHSldIINOYTqsJxFySkYfmS58jg6RF7J++4CbU2H2+w+BswruUyqnMs1GJyYUjEI021QUeoSEqcYm2F+6l2Hg+/Sdfzu8coMX+4LT1I7NZoFOIf2sDM/jXbL/dSi1AEmImrvP3LJFDSsCAEI8U+lOIYTXUA9adxMLaDdRrRI8jw6bUnnH7guyDTVFqHtSl3QSSY4cmvI7y/i2Po8S8XKWIdSr/da51wmp0VKhijZTsToavk/ZzTCBJEUDTXOuEuT+PltMXzYcqH02fsDnCgkvIVSvKOLlXvHSDyzdEK15t1VYS0/Ws4ShfGLEwMZECfNSnBFiIL1XDZGqmNAJndS0RmNsktT/ts+7u4XSkz855wgClypS4/yu3w79MA9zQNR41XutKNQQxnRv7HSzYfhXe6pjA+IpBg08z4vXeMIAXxYUgwsiB/ankxCNh8xr9zbL6l+ulLGujz76/DQoS0BYyA3I36mSCN9XzTMiMNJceg4Q9zNivZ/YRd4WHFK0oJag8FslZZP43RPez7v3lkDBkSXPi1nJTM49LH0EFtzQYh3t5P0dN/KMjnBO9OsHa8o/7gD594N1xu6swNy6so6d9tIejnVfo66XdIDT8qNsdBSSdKRgWdmIHasdW1Dsu/oj6Rc047sOEOo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(38100700002)(186003)(76116006)(55016003)(66556008)(66946007)(66476007)(66446008)(4326008)(9686003)(64756008)(71200400001)(107886003)(110136005)(53546011)(54906003)(6636002)(7696005)(122000001)(86362001)(966005)(6506007)(508600001)(33656002)(2906002)(83380400001)(52536014)(8936002)(5660300002)(38070700005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5hQSbfDFkzQ9pNn8i0jYJplZ5shhvxcmd2x3SktLFe75gN+dV0FPADWBaihu?= =?us-ascii?Q?DtdXWIGlph0vCmxNPhUPsVVc3Ozwy0yCpF8LEqIl7yXNwtQMRQEef4/ZbADC?= =?us-ascii?Q?6OIbGilWCj2dQjTEp+KZMcNCDcqCQ5wgN2fy1ZWZmuXI5o3ewMt+04qtnoby?= =?us-ascii?Q?PnSeaJhA9nQlPNE4hYWQkJwmcbzH4boOBQSNnLVO1A47N4kwxy3d7StVMAGh?= =?us-ascii?Q?3sJjnRxi3VVT4BV4/hFlN7OAN+kPdTvVnydAjuN2cxsoLh9dG0oJ2UgltnFY?= =?us-ascii?Q?LYRmzFtyTiDLKCjB371BoMI0tG0/xy9vRNHnn1hYd+guuTtoWPKBhokbk3NR?= =?us-ascii?Q?IVIexpltK5iU5XdUKU/Qi9AxLhdlUuoHGvDhZmlg6nIsPAozNaqzu1uWuyCY?= =?us-ascii?Q?76YfLZ4CfgeghGCJSfcTiTCJ7Rl4OcdcLV2W7l6C+KmN++VStACEYGf4uq/M?= =?us-ascii?Q?0NaFqiNsN5E13vCpUdAUaAjAi72+XhfZB/qlDPM7AJ0Aqg7NP1nxr8fDsU6e?= =?us-ascii?Q?sSn45cjOyBR99GstBVl5rWdhQZPK0FVA0fSxCxnuBODQMjFMSFuebQP8A8oZ?= =?us-ascii?Q?7rSPlyxhe8UZdHsYsFaazG+UmKEm9WKy5BpgKR+QDjqUx1np1X1kAla0bOs+?= =?us-ascii?Q?qourX4wKW+rtIJ0Wr9fPcqa8xBh3A3n6FaU9T4WRmCGBLYouWSw7EDFTYY9T?= =?us-ascii?Q?XFfKIdPeiBXIUR+Tz9r4TfsjRrFQQkLCT/pYNoCuQKTEn/uy/j4SV0OsLy9T?= =?us-ascii?Q?HJ+9XQfE9mJhXikrFpJXmZiDjkFyndbDPiY27ekOdhFseSzYCdzmLySc2LX8?= =?us-ascii?Q?45x3UCzW88i4STTkNGEumFVMHZwXf1iYw1HlzSMSY6FsdInnOVaulbtLo39y?= =?us-ascii?Q?nd1fkP/sCwugDIFjW4Poz/7P1qn+iI5mk5tve+zoxp5y2fGZNQWGW0xl5oLE?= =?us-ascii?Q?icNf/T1emE2zTQ1YmOACrvtBR+YINN5ADi5IEfVX8MKv4j8o8RZnE3pOhYRD?= =?us-ascii?Q?buhhvhrIpRoXTiE6njL8XGpa+CHfoMwZS2I27OAhXpKI7nTAjwEkLiraIert?= =?us-ascii?Q?jNNV4OygEJNdVWs7uxiqSqh6pnXst+C4wfcuasE+W6xQ31o2TBDbl6bI6bnb?= =?us-ascii?Q?p8FZSI9TcIP6VFKqjtlU0Nk2lz+DBa88RPY3tFGjDmpFNGeGHtF1N6/MjXG4?= =?us-ascii?Q?9a4fO84T1euqLGMnTIEP6FACS/pHIqiKRhB0GU0hD8Je3WtW4iP5G0WhTaWB?= =?us-ascii?Q?G0Flh0xVUxC1SLXRj8olIkiccKveK3aZHHhwvRHlYHnM8Lr1bGFjh41H7nyc?= =?us-ascii?Q?9hhb+ufNkRqX6st/n2YYPL171eksOVrGY84tv47X9KfQRXMiGBShG3SU/fjj?= =?us-ascii?Q?gX7i3UL2si9gU8BqUHMzX2IFcbbtRwR5D492N8TglpHZMycV2CsEQEsJCUK2?= =?us-ascii?Q?vD9ozWy3plekKTZjdDH04BcouezsyyRwNr1bNUaogxsIRCAz7ReZrRdkAPTG?= =?us-ascii?Q?n0wCWqXD1Bb/TFy/YjZlxUA8Lcg0s6LvJsJwYJMng6NNNYiedUbdljMg6AX6?= =?us-ascii?Q?Bg3ktmAdS1Wra/ZK9hLu6EJhp9JoOcdu3e2wyfW6pSqwpGBVOctOO52z59HS?= =?us-ascii?Q?ba/TWCJm7byeIhnErxs5L3FO5MYH/oVpedJh+sjQVfPPogXHIo5QcanfQHSN?= =?us-ascii?Q?X4gZOLAhy90SB5NxD2jlmNRHhtrsnYkJN1v/Sf8dQzQGNxiHdPi5LUqJmJys?= =?us-ascii?Q?VUW2v+XaMlahbkB1+y2atQK3t/BaP+LFs3RnP6OxZl14N2LPv4P72L6XL7xT?= x-ms-exchange-antispam-messagedata-1: IvgQRSkXqmnHSg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aded46cb-9ad1-4e34-3f5d-08da3e1d0254 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 07:05:54.0071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: keOpsSxhLcfr5Gx6bt/TCZpOk3LFr0NTGIynRsMJ3ZmPp6a2OCM2Itkpt+xZElTQhgvJjzMvw7wai+/XsEyk/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3226 X-Proofpoint-GUID: fMryaLZ82xRbq3lXnuNAS0scyuCCruTv X-Proofpoint-ORIG-GUID: fMryaLZ82xRbq3lXnuNAS0scyuCCruTv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-25_02,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Arek, Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, May 25, 2022 12:06 PM > To: Akhil Goyal ; dev@dpdk.org; Kiran Kumar > Kokkilagadda ; Anoob Joseph > > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform >=20 >=20 >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Wednesday, May 25, 2022 8:06 AM > > To: Kusztal, ArkadiuszX ; dev@dpdk.org; > > Kiran Kumar Kokkilagadda ; Anoob Joseph > > > > Cc: Zhang, Roy Fan > > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next > > xform > > > > > > > - removed asymnetric crypto xform next field. > > > > > Rationale behind having chaining in symmetric crypto was a fact > > > > > that encryption and authentication are usually done on the same > > > > > set of data independent of algorithm. > > > > > HW usually will be able to handle it in one PCI call. > > > > > In asymmetric there is no such relation between algorithms, > > > > > therefore next field would be useless. > > > > > > > > > > Signed-off-by: Arek Kusztal > > > > > > > > Please check documentation "doc/guides/prog_guide/cryptodev_lib.rst= " > > > > Not all asymmetric crypto xforms are supported for chaining. > > > > Currently supported asymmetric crypto chaining is Diffie-Hellman > > > > private key generation followed by public generation. > > > [Arek] And why do chaining when this can be done even with one bit fl= ag. > > > > > I believe it is OK to remove next. @Kiran Kumar Kokkilagadda/Anoob > > please confirm. > > > > If we are removing it, then documentation should be in sync. > [Arek] - although, we may keep it for now, I am not dropping it in v2. DH= priv + > pub can be done with priv_key.len =3D 0 -> similar as 'k' in ecdsa when k= .data =3D > NULL. > But I do not see any situation for now it will be useful, it may be drop= ped later if > not application found. > > > > > Also, currently API does not support chaining of > > > > symmetric and asymmetric crypto xforms. > > > [Arek] - This is one unlikely scenario to combine symmetric and > > > asymmetric. One I can think of was once proposed DH + DSA > > > integration for random number. But not much else, although we can > > > keep it around for a > > while. > > > > Yes it is highly unlikely to use this combination. [Anoob] We may need this support when we add EdDSA support. That would invo= lve a asymmetric operation after hash is generated (symmetric).=20 https://en.wikipedia.org/wiki/EdDSA#Ed25519 And, asymmetric chaining may become useful when we have PMDs capable of doi= ng more operations together (like the case with EdDSA). So my preference wo= uld be to retain the 'next' field in asym crypto xform. =20 > > > > > > > > > > > --- > > > > > lib/cryptodev/rte_crypto_asym.h | 2 -- > > > > > 1 file changed, 2 deletions(-) > > > > > > > > > > diff --git a/lib/cryptodev/rte_crypto_asym.h > > > > > b/lib/cryptodev/rte_crypto_asym.h index 1652a434a5..b355cbe5fa > > > > > 100644 > > > > > --- a/lib/cryptodev/rte_crypto_asym.h > > > > > +++ b/lib/cryptodev/rte_crypto_asym.h > > > > > @@ -492,8 +492,6 @@ struct rte_crypto_ecpm_op_param { > > > > > * Structure describing asym xforms. > > > > > */ > > > > > struct rte_crypto_asym_xform { > > > > > - struct rte_crypto_asym_xform *next; > > > > > - /**< Pointer to next xform to set up xform chain.*/ > > > > > enum rte_crypto_asym_xform_type xform_type; > > > > > /**< Asymmetric crypto transform */ > > > > > > > > > > -- > > > > > 2.13.6