From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C900BA0C53; Fri, 3 Sep 2021 11:46:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B424340DF7; Fri, 3 Sep 2021 11:46:54 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id B5B9440DF4 for ; Fri, 3 Sep 2021 11:46:53 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 182K6jrb013895; Fri, 3 Sep 2021 02:46:52 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2040.outbound.protection.outlook.com [104.47.74.40]) by mx0a-0016f401.pphosted.com with ESMTP id 3au5c32p3q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Sep 2021 02:46:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pj2plHmWk/912mRXy5PyJxz9ore2Qj29NlE/OWaw6UKiaGVcAbKEQ18AFmGpsH9RXWEABsna8tOp0W59iFu27sZ8mPF+FbcLctjVJf2+WCswp8LMZiZGkrCZOZ3Dsfmz73g1xQTnYUebcULXT/pWCwo612KhkK8gOORgopVyB8XR4YvHNeC+VMKEeVfWvY6aXQS5Ib08Xn3MsVza2y5SNqw3zDHHrzQWdulSgyajtAcgjl8e/zFXCEtFCU+XwwZ9ZQ7XkhkvLEIrN9VE9vSzAIfDevCOylypcgVq9a1t5DocVAM5mQIJPQ0hggBN1jR8LqPNc4WaLeSyhNB15jjvAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8LYppmco0LHKdvgC/AAMeFkQBeHoBd0ik9jjQ0urV7I=; b=VOpNPPchMUhWNEV9WfQWct6EsP4JVW8I5j1Bo+p5iuvbNixDy+msQx3zRW3itopslZW7o9w5LgtQX83Pvo9+jeqIirzCAWp/LYyBfopEdM4sgjWkfVmeG6SMNoXIYpnU3yUb3IyChtymky751YVXWaZ6XfY8HMA2OElxfc8clKp1Ndolx0Ii48BWSsE17I9qJudo26uCWYOmhetTbyWipLZcngB/0JBCpMNi6yXON9tjS0/TG3ANh9dZYj7uHXcIxTLMLVZKUcuj9Th/wEzygQY6nwI2rCenQMVyvMh8bzs8pNnhB+Ao0c5gfbgqcUoHRy0jD0dVJbN3g2w0kzxU1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8LYppmco0LHKdvgC/AAMeFkQBeHoBd0ik9jjQ0urV7I=; b=mUWIAYXEbG4idFwKZRUWntQnhvtHMpF/AyJp3jx3a3ClfQLrj1rPEJKc48gU1YV4a9K7S09MeMSDctMv7MVmxHT03qr21VfEPHCZ+pjHeoVkzEEhvj7kjkCeJyGj06/DGhI3drm0OXugXhx5nKhyXNnLlvVAQK1cRuzG8qB/4kw= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by PH0PR18MB4427.namprd18.prod.outlook.com (2603:10b6:510:d5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Fri, 3 Sep 2021 09:46:50 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::85aa:3d01:94f6:984]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::85aa:3d01:94f6:984%5]) with mapi id 15.20.4478.022; Fri, 3 Sep 2021 09:46:50 +0000 From: Anoob Joseph To: "Power, Ciara" , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: Jerin Jacob Kollanukkaran , Archana Muniganti , Tejasree Kondoj , Hemant Agrawal , "Nicolau, Radu" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v3 1/5] test/crypto: add lookaside IPsec tests Thread-Index: AQHXoH7Pe0i5mlPBLUm4LMC94GWgO6uSDfYAgAABE8A= Date: Fri, 3 Sep 2021 09:46:50 +0000 Message-ID: References: <1628675138-17300-1-git-send-email-anoobj@marvell.com> <1630644420-1256-1-git-send-email-anoobj@marvell.com> <1630644420-1256-2-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0234d369-e4fd-4952-83cf-08d96ebfc109 x-ms-traffictypediagnostic: PH0PR18MB4427: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V7ay2mkDwyMGTdmUFOpCPgMRfLTXEztF9S5yaw4t6ibNndxZ9fOpKo16dI4Q/OVj2Cjh08lgaj0Rr6H6sVGjSt6qRCWXyShFfQQmYW1WYXKtKxznY5uwNkEejZhGRoJYenaLZN+RxDnWWWNg564pl3Xyv1Dx0/tK7EelUeAKbC6CYZ8Y5tmFfIZw4BxhyuBZyhf4lONX3h/SCe8GJNbaYn5nR7WE4AbRXsBA/QBxh5Wo6PSLXZXD6SCpW820ekSUhBIZZPb7w0WEIV5rRW6e1DblkBfn4c/NRYc2+QLuRQcrSCTzoYWw57gelsphF+0EkgWi5ZR/EhIvLd92GfvTZDeeCcl4JPEPb9ejf6JuLFWCLX25hCA6PhlNuP87evi5YF5oASDa5LN7eBXNndgUDJTCO1HXJ3f9yFVquhSc0QaRaB473Oqh9qqeFjGDhFTpsB8Nx2X8ta6MKgE1Ub7Xhiwrf8aoP0QRcSiQEoI92HzuSd0A1rxrIl+nNJTHdkXCpa7vtEs2aFX9n7af2IsASeA640PHh+qQFrFxV9ydzQ4z8TeYci1RJVGirBtNj/6xaTbrPtmaGwQBZhWL/jQGs9MC89nEqEDUqQiCrB0s93/WH9zhVpyb5A0Xd7CuLDlvoi9ohOtFUWhQLXuEnH9oQZ8l6Tbt+pMzdTVgyC9lXHC1SLCg/kcRMPKBP5TL2vc62s6/UTHQNPUNvJcWKrAxCQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(64756008)(66476007)(478600001)(8936002)(33656002)(9686003)(122000001)(66946007)(38100700002)(76116006)(26005)(66556008)(38070700005)(7696005)(52536014)(66446008)(186003)(8676002)(53546011)(316002)(6506007)(2906002)(83380400001)(5660300002)(110136005)(4326008)(71200400001)(54906003)(86362001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rpw6uCeiswanF9T1dQdoKFOO795LPI5f6Qs0P5o+e+/wWzBnThGAQklrDhXF?= =?us-ascii?Q?uAC1Om0dBqNrKKsosyteKwmV6578Ui4rZ60MT2JPlrdPz0vBKRTrfOe0l4Kd?= =?us-ascii?Q?H1ny8MFu3j6taHe7KxD1Z2nsjD0VGjUNgCV4Bt9CCCQf4r71WTqAn/8NPuJp?= =?us-ascii?Q?WzTa7eQZeJtIiFnsR+aazQfCZDW6LLvCI9Jm2LR+i068ebSQnV8WcUulo5qc?= =?us-ascii?Q?JB2zHk8wYRr1qvQpNhM7zOnqq1mqSG4BXzEECC3NHxP3eBoFLDXzJJEnPUUf?= =?us-ascii?Q?KLKupOXfM0d+az/DRSm9BbRT/TzY2HZxtea1oCM+yQy1kjFaGTZ1wkNDKnHI?= =?us-ascii?Q?Y18kC+jttqBA76ts3c+/ssmvuxotD+2LKBtxtZQuimujUxCiRdVlmdcOomzs?= =?us-ascii?Q?K7Opnd8hKuRzvfc1He47S0UrANkf+SHnqRZRJwzkc04Atfny2k7CZ7y7Nyr8?= =?us-ascii?Q?nxS7LoJPemUgVNeTAuy1mec8Pp/065/2RzX+dOjWtUYLPAuNwIxhwr3sRi3r?= =?us-ascii?Q?EPU2hi1Fu3OJdvORzBlUEVgBBvqivYJGcfHEYNou8Ygk75YGua9xlYQTShCO?= =?us-ascii?Q?k7osH0ZlOneL/yCk2tD1wi/fmN7wpCk8OasnlX1B80fTMcYs/Q6Zn4eCIoSo?= =?us-ascii?Q?3OG+cKS0WfmDwXuleU/FyKK3sRvqAIWZlKNRRrx3pwEKp6jJTqmvoLUnBwkc?= =?us-ascii?Q?SeWQvuXV2QR9GcIkVyG1K4SPcHBifh8vdxIt4ghHZOueLpBbhEWWR5qG6SbY?= =?us-ascii?Q?xOcY5aviUD51iCkehJXG70S4vy543TSTISWw9kUQIfcUnMI1WCnnejMLGzkB?= =?us-ascii?Q?ZM9jRm4iIYx4mtmUC+gbvqg6kgBFxLBQ534DHXftcXvNpG7JCsRaHnqlzKxt?= =?us-ascii?Q?ceuVIwc6XAo3vKXNDlL18eizUZ6KXFGY2h/v+w53QgwlQUadYg3ocxKkqbgH?= =?us-ascii?Q?Tx5ob3SzdKBnCBH5iSqbvleZb9mep0UsHnYIPX4HeQqJoY6l0HVFHAn3s0xB?= =?us-ascii?Q?ctN7IT5eChz7S+ynRN5oysbd/EI61MbmH0F7qFzDVX6jY+uy16UekzKKoePR?= =?us-ascii?Q?c+BOb4HWh4HxbLtgZEjo/0b+mn2fKxbI1dUShnOGnZQ0SG6FCl5ZRgLPWPrL?= =?us-ascii?Q?CICvYRPv/O2XLQEzQ1LEF+M0dXTjwkWajWovcGFgDdCqtoprkEQ56WZfrFPi?= =?us-ascii?Q?CNqprTrHZ7Eu1Z0Zk5UZ2hUr6oLCIa/b+0EyA2xl+H8dDv+ddoTr+6uY6aH4?= =?us-ascii?Q?wKA2MMrbBmwTl/zmmgpGxVjdrI6/LLDORvGvcpDbA5mUSqXkmE1bsRmfZ0lN?= =?us-ascii?Q?rRlLMDEiiS1bwAUUvgXs3KJQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0234d369-e4fd-4952-83cf-08d96ebfc109 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 09:46:50.5145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qzQ/nM5JrLwyBjv/fTj5d+j1NJQ8XUJgAYZc8u5IJiTDMBTgRC7i1jCP4UvP3U8Cgx8SqnQUj4p1WeIggOKW9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4427 X-Proofpoint-GUID: YxG-owQhJ-Ef1UA4CuXcZ6nDt3EaRgcJ X-Proofpoint-ORIG-GUID: YxG-owQhJ-Ef1UA4CuXcZ6nDt3EaRgcJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-03_02,2021-09-03_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v3 1/5] test/crypto: add lookaside IPsec tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, Thanks for the review. Please see inline. Thanks, Anoob > -----Original Message----- > From: Power, Ciara > Sent: Friday, September 3, 2021 3:09 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan ; Ananyev, Konstantin > > Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti > ; Tejasree Kondoj ; > Hemant Agrawal ; Nicolau, Radu > ; Gagandeep Singh ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH v3 1/5] test/crypto: add lookaside IPsec tests >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > Left some comments/questions inline. >=20 > Thanks, > Ciara >=20 > >-----Original Message----- > >From: Anoob Joseph > >Sent: Friday 3 September 2021 05:47 > >To: Akhil Goyal ; Doherty, Declan > >; Zhang, Roy Fan ; > >Ananyev, Konstantin > >Cc: Anoob Joseph ; Jerin Jacob > >; Archana Muniganti ; > >Tejasree Kondoj ; Hemant Agrawal > >; Nicolau, Radu ; > >Power, Ciara ; Gagandeep Singh > >; dev@dpdk.org > >Subject: [PATCH v3 1/5] test/crypto: add lookaside IPsec tests > > > >Added test case for lookaside IPsec. Inbound known vector tests are > added. > > > >Cipher list: AES-GCM 128, 192 & 256 > > > >Signed-off-by: Anoob Joseph > >Signed-off-by: Tejasree Kondoj > >--- > >=20 > > #ifdef RTE_LIB_SECURITY > > static int > >+ipsec_proto_testsuite_setup(void) > >+{ > >+ struct crypto_testsuite_params *ts_params =3D &testsuite_params; > >+ struct crypto_unittest_params *ut_params =3D &unittest_params; > >+ struct rte_cryptodev_info dev_info; > >+ > >+ rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); > >+ > >+ if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_SECURITY)) { > >+ RTE_LOG(INFO, USER1, "Feature flag requirements for IPsec > >Proto " > >+ "testsuite not met\n"); > >+ return TEST_SKIPPED; > >+ } > >+ > >+ /* Reconfigure to enable security */ > >+ > dev_configure_and_start(RTE_CRYPTODEV_FF_SYMMETRIC_CRYPT > O | > >+ > RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO); > >+ >=20 > Just a question on this - each testcase uses ut_setup_security which in t= urn > calls dev_configure_and_start, Is the configuration resulting from this c= all > just being redone when the first testcase runs? [Anoob] The tests prior to this test suite can have SECURITY disabled (whic= h is the case currently). And in that case, rte_security_capabalities_get()= would be returning a NULL (since the device won't be having SECURITY featu= re enabled). I was addressing this aspect by reconfiguring with SECURITY en= abled.=20 >=20 > >+ /* Set action type */ > >+ ut_params->type =3D > >RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL; > >+ > >+ if (security_proto_supported( > >+ > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, > >+ RTE_SECURITY_PROTOCOL_IPSEC) < 0) { > >+ RTE_LOG(INFO, USER1, "Capability requirements for IPsec > Proto > >" > >+ "test not met\n"); > >+ return TEST_SKIPPED; >=20 > If the test is skipped here, the device is not stopped, which I believe w= ould > cause problems for the next testsuite setup configuring the device. [Anoob] Missed this. Thanks for pointing out.=20 >=20 > >+ } > >+ > >+ /* Stop the device */ > >+ rte_cryptodev_stop(ts_params->valid_devs[0]); > >+ > >+ return 0; > >+} >=20