From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE5E9A04A2; Mon, 31 Jan 2022 15:46:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A35D41183; Mon, 31 Jan 2022 15:46:42 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 801054069D for ; Mon, 31 Jan 2022 15:46:40 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20VCCu21027713; Mon, 31 Jan 2022 06:46:32 -0800 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3dw5yqmryy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Jan 2022 06:46:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cw5SRz8BKYccxF0tZpcUaiN5IZImzZNxXFLdl/x1DkzjXUX6kvuvhNPHTgDRFArtZmGvXX6GoQLIzSWtayhFMvp4lJQhlyNh8khoScydt7SGxyH/cPfPoqYTqyOVCSNwFdZuhrwX1erqvtFYlieA44EOkIlHt2rwk8mKziTVQmTAd3j9qLJZFqJMzUa87Ak7Owg06XQ6h7zVTF5p9WnMnS1QhcZcHO4gvIvPy5cF97BwvDoV8q+/+afeGefAdhLNn6In92kI2SxXpBec7nOsM6/uKhVVDZpgblqxaU18RKRkKmP1FNMLmPssTkP/fjQxFtAofbfTu+leGxrgq4lA7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fNLNpdTSPw4YuWMrlDRFV7WTO5YJlPYNfOPgkkeh2Y4=; b=QjRgPibXEYTg+xUS5MsbT0+4UEP0IMHKA6LbCfdoiDEld3mYTzZOykNxEE/D8uEJmELJnaUginKOASP3Tgj5jFQ4jSPmEZ4B+2jcKAp2XJoN/1R8usRFQy28l07v5rG9MgKcjGT3MTkFbmvYHCY13XGIFB+gFRol5VoymRiuwpWGAmkaGpoydtEcHeWMYPcccpxlfAEPlfzS6KOmJso9vTfUk1bu2Hq7qD8LXZUx/72F/v4gBm6oAmYlaZvGtG2nLPqUb+kwN631jegm+1RTfvrdr58qKwtD8Er0gBjxKLTV4oGcT/mmdTj/RamkH7htVbo/9rgEuLaDaAGsrEzuNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fNLNpdTSPw4YuWMrlDRFV7WTO5YJlPYNfOPgkkeh2Y4=; b=XuW23jyODNbR0ZJ3OBCa89UM31PDhgTCVbPQbL1A+jnzoPkwKfAjxLYHKfVwUf7loOPgdP8hm63KxQRinLwbHIkRclF+q773RcaI+MryeQj8Y34p7G81/Vel/OCi+6Eu9bxOUqcSrYRxI1okLNDvBASVbaL88Rn0tLJwH5IMHAE= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by BN6PR18MB1505.namprd18.prod.outlook.com (2603:10b6:404:128::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.21; Mon, 31 Jan 2022 14:46:30 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::9490:685c:8235:9b93]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::9490:685c:8235:9b93%4]) with mapi id 15.20.4930.022; Mon, 31 Jan 2022 14:46:30 +0000 From: Anoob Joseph To: Ciara Power , "dev@dpdk.org" CC: "roy.fan.zhang@intel.com" , Akhil Goyal , "mdr@ashroe.eu" , Declan Doherty Subject: RE: [EXT] [PATCH v2 3/4] crypto: add asym session user data API Thread-Topic: [EXT] [PATCH v2 3/4] crypto: add asym session user data API Thread-Index: AQHYETOgmFtY2qxkIkmdd/Na8npvlax9PUJQ Date: Mon, 31 Jan 2022 14:46:30 +0000 Message-ID: References: <20220124150339.280090-1-ciara.power@intel.com> <20220124150339.280090-4-ciara.power@intel.com> In-Reply-To: <20220124150339.280090-4-ciara.power@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20e7880b-0f05-408b-6d12-08d9e4c877fb x-ms-traffictypediagnostic: BN6PR18MB1505:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ldwQgoJtSVBgCGhnQFu6F/S3/82UTu1kZoVzo5+5qKhtbBH13DUEMpLz2m6IkqI+0gPa/u8UablJUhlVY3S5LGS1kGU+MwYlxGhsP7M4fj5ZkCrVhF2PWJs+DoRqEk/8pHUklfRvEIZ2+a49XiPwCNSNiBwkxN1F7SYyKKzPjEW1wbdunSkLRnpE+94DrT6PFhxjM/NmndjyZfU7Ulh94oI3cj9kyDtVN0vUgWnXCtwIWpy3oMXXcyQtZ2rQr1QN0ocOQvf08WEPphUbJLlSCgSjI+dIhEYgbAYmSoJMa0FD0gmihPAnQQFKHe3+pQm/7SIq1TC+Vtbg8V5I+Z8TeqC3Al++khUhDYiXnkVGRtXx0EKlDiGIa6c5uBIgvn6/WEH7fhObSHo64Np2LtIVIUeVXnMWukfdCbNg5TqqxappPLwd0p1r6pMmTM0klKr4LPivC7CynAq5w+f8WK0MeMhX4m8xEWZU6oeW7NPeamholknmVfhVl9DQSbGpQBvtl5l7aM21ayFfCU59VuHQisxu6Q+0Z6lkhCY0BS+bc7xGR999MoqKRmn8LV5UcV5A1C2DzN4ffwkeIRg4PXJOqOt2yMWrrAAh3u76tVQ9s7bfaBdaM4HMtT9WsekddO/xstAUSgCWE1SOScPQ+bJCd9tHvUe7U/Wfu05aPBF9hepYRzbOxKQn2ykojB7Ory/Pob4JMdWQA0adWVCQwHUMQQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(33656002)(55016003)(38070700005)(122000001)(38100700002)(86362001)(83380400001)(6506007)(7696005)(53546011)(71200400001)(9686003)(316002)(26005)(186003)(52536014)(66556008)(8676002)(110136005)(508600001)(2906002)(4326008)(66446008)(66476007)(64756008)(66946007)(8936002)(76116006)(5660300002)(54906003)(20210929001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?phOnN46JweMayOYPVWuvbnh5qmKAOMV/1u8ZH6XMLE+7s9p4lxKscZC9LTyM?= =?us-ascii?Q?oyWsVCcWyG+uRhqA+Y9MVtrSrg385EF6Jk7HU1LXQbx8ttBxL8zizw7vFjUw?= =?us-ascii?Q?eVfUJd8ZjrXCrcbQEwz3ovgTu1cnR1SqHEQvUpgrK0M6HayXb7NoXOBp/PGJ?= =?us-ascii?Q?/iiuYBmeM/9/Y9+SnJTDQFq3uEjJqPaMI4cWfkrvBQwNHoId3KgPzAYQJLdy?= =?us-ascii?Q?Sd0CHO2IH33+GvQw7O+HHl5xH05WP704NJOJNKBirVPcXhk2fa5Dd/GLdIpj?= =?us-ascii?Q?lK6qk7GJ+j8qItKDpn9yTUkMmGArF91oJexehxxXZWaKYZatFW0G9C0DA510?= =?us-ascii?Q?H9bQfBv7RgiZBQyax6yCM3OtCU6M4bJx7b/R+eob+EWzjuIG8U01BL8Fjckg?= =?us-ascii?Q?P2oq57tBkCHMIZ2WKd7VM8r5pCASWmGYItUbUt8fbaSWOeIOlvdgq+n5UYSu?= =?us-ascii?Q?+bE5GnHq6jZm/XqeQzXsO+3spQ6FjQldNb4H+damSTglMjTzYx74lkneuk73?= =?us-ascii?Q?dyQG5AENFtc5kU+aAU8xZwnepPzgXrqXIQo4jyeHdbcRmKEN+t0DgRiNaZM5?= =?us-ascii?Q?PiCn9D9azt1QagIr8pl9LXWYerFRzZaAYuGM7RLoNiWc0j4eFnrLBVn4WjYG?= =?us-ascii?Q?n9seVYTDo4ALTi6ltaJTOZ+3lmaTZ1Rfnk0mxHKWDQsW9kPY7LxERjJIUkCP?= =?us-ascii?Q?hrCwQ77Jg5p/TGAMGeGVgdXNWGTLDGS3LL9WEmya4UrIc0p9SjId4riZQweP?= =?us-ascii?Q?RRHDzLuFCxWSsTep5p5Y6XmrenG4ZacYJaLGCrUpd3jtLAdGE7NaYLb46qpk?= =?us-ascii?Q?Abza+TuM6se88kOZNAwGK7MnrFcusvny+Yh6X4MizcljNt3+gjQK9s3G4Fzy?= =?us-ascii?Q?SHAAtNd7XnqPqdsoFu8ndczUp6hX0Q+qYSRqHd9vi4AlK4XzCwi8GjIptIsW?= =?us-ascii?Q?XPkmLPxWMM7MwlJ0jlF0boLiFG7U+DnVfGSP6L2xaT/FhR/ALlCRAiUcws31?= =?us-ascii?Q?bxLxKVQqnH7WrevKE195YixAdnnzUFCL+BlKsod+JgZf/UlXU1a9v/cqJvG8?= =?us-ascii?Q?tj6V/6XkxQWnk53P5kve2aeGFcLyPEPDPnNXffWIobzkuhSngDIPGw6TxGOt?= =?us-ascii?Q?Pr0a2dZta7dJTT5M6n+CVYK2xbd+Dt/5pSUkGD96y3xHhM278+6WHJnJOKOi?= =?us-ascii?Q?q23upFs5+0kEIb3cOldTPmm9FBwkIGQJ094oAO78WNFZt+V4DkkhJq9ohZS2?= =?us-ascii?Q?j2YY1cc2dr2Hw54qIN5WS6Mc06jW0MqSht4UKoFH2++yqtayw4JkE4bfNzoi?= =?us-ascii?Q?3irR3wh+H0TiJlNxrjaSvW+zPAlaThyVm5bfRYnWzZC5mB7TN3X5mdeEM2Oy?= =?us-ascii?Q?aaKHNJl4rNMZF1bu7IzxQxAtLoVxExfMIWNRh02Qig9BKYp/pJDnHvO4ARC/?= =?us-ascii?Q?6GSVkZW5ag5lrGUuaeZZC8T/oGvuLfSvHCSIQrARohenIGm8BGDNk9NAnWw8?= =?us-ascii?Q?JMq++DPKJiqA9MpIF9Wx4lsnono6e5an83cnBmL+Xr6mFY8v7oqcnyAY/hJq?= =?us-ascii?Q?VD4LyQRVLuOoS5o3z4G3qMZFe/+B4+hcYmzdmE9hE9YSoLJyYFVg/iw6crc2?= =?us-ascii?Q?0w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20e7880b-0f05-408b-6d12-08d9e4c877fb X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2022 14:46:30.6712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WWe+APWUCYZAkDolLmeYAG3UP3jYA86+LxqlZfQx/NQtYyjbJpHiDLLws9FY5ZGSxf9xcXvUr4FZmKQEVr365A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1505 X-Proofpoint-ORIG-GUID: W8xJ0-hhcJuOuM2cebLfvbq6ykO7WPQj X-Proofpoint-GUID: W8xJ0-hhcJuOuM2cebLfvbq6ykO7WPQj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-31_06,2022-01-31_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ciara, Minor nits inline. Acked-by: Anoob Joseph Thanks, Anoob > -----Original Message----- > From: Ciara Power > Sent: Monday, January 24, 2022 8:34 PM > To: dev@dpdk.org > Cc: roy.fan.zhang@intel.com; Akhil Goyal ; Anoob Jose= ph > ; mdr@ashroe.eu; Ciara Power > ; Declan Doherty > Subject: [EXT] [PATCH v2 3/4] crypto: add asym session user data API >=20 > External Email >=20 > ---------------------------------------------------------------------- > A user data field is added to the asymmetric session structure. > Relevant API added to get/set the field. >=20 > Signed-off-by: Ciara Power >=20 > --- > v2: Corrected order of version map entries. > --- > app/test/test_cryptodev_asym.c | 2 +- > lib/cryptodev/cryptodev_pmd.h | 4 ++- > lib/cryptodev/rte_cryptodev.c | 39 ++++++++++++++++++++++++++--- > lib/cryptodev/rte_cryptodev.h | 34 ++++++++++++++++++++++++- > lib/cryptodev/rte_cryptodev_trace.h | 3 ++- > lib/cryptodev/version.map | 2 ++ > 6 files changed, 76 insertions(+), 8 deletions(-) >=20 > diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asy= m.c > index f93f39af42..a81d6292f6 100644 > --- a/app/test/test_cryptodev_asym.c > +++ b/app/test/test_cryptodev_asym.c > @@ -897,7 +897,7 @@ testsuite_setup(void) > } >=20 > ts_params->session_mpool =3D > rte_cryptodev_asym_session_pool_create( > - "test_asym_sess_mp", TEST_NUM_SESSIONS * 2, 0, > + "test_asym_sess_mp", TEST_NUM_SESSIONS * 2, 0, 0, > SOCKET_ID_ANY); >=20 > TEST_ASSERT_NOT_NULL(ts_params->session_mpool, > diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.= h > index 2d12505d3c..a0f7bb0c05 100644 > --- a/lib/cryptodev/cryptodev_pmd.h > +++ b/lib/cryptodev/cryptodev_pmd.h > @@ -636,7 +636,9 @@ __extension__ struct rte_cryptodev_asym_session { > /**< Session driver ID. */ > uint8_t max_priv_session_sz; > /**< size of private session data used when creating mempool */ > - uint8_t padding[6]; > + uint16_t user_data_sz; > + /**< session user data will be placed after sess_data */ [Anoob] The formatting of comments is slightly inconsistent here. Like "Ses= sion driver ID." v/s "session user data.." For the line you are adding do y= ou mind making S capital? Same comment below as well.=20 =20 > + uint8_t padding[4]; > uint8_t sess_private_data[0]; > }; >=20 > diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.= c index > c10b9bf05f..2a591930de 100644 > --- a/lib/cryptodev/rte_cryptodev.c > +++ b/lib/cryptodev/rte_cryptodev.c > @@ -210,6 +210,8 @@ struct rte_cryptodev_sym_session_pool_private_data { > struct rte_cryptodev_asym_session_pool_private_data { > uint8_t max_priv_session_sz; > /**< size of private session data used when creating mempool */ > + uint16_t user_data_sz; > + /**< session user data will be placed after sess_private_data */ > }; >=20 > int > @@ -1803,7 +1805,7 @@ rte_cryptodev_sym_session_pool_create(const char > *name, uint32_t nb_elts, >=20