From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AF68F42B6D;
	Mon, 22 May 2023 09:03:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4EB94410DD;
	Mon, 22 May 2023 09:03:49 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
 [67.231.148.174])
 by mails.dpdk.org (Postfix) with ESMTP id BC85F410D1
 for <dev@dpdk.org>; Mon, 22 May 2023 09:03:47 +0200 (CEST)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
 by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
 34LNAPjL030818; Mon, 22 May 2023 00:03:46 -0700
Received: from nam12-bn8-obe.outbound.protection.outlook.com
 (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172])
 by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qpujnddk9-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Mon, 22 May 2023 00:03:45 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=Amjg2BOfcHGJsW/LEO1gdvmvKTy6aXNYSf18+1QklhZSxnKuQYXJhQcjQRYhf8B2GxY/HWUuy14uQxPXvKZ2v+NhszetkFL8ZVeCThmZRGYFXIQ61zSaYUCqFPab9xK9kyWKciiFBgoeWKwGHjflGK1mvFOhWSzj4Dc+7uIF17ANvEqhT3iooK11Ihv/fQq3RMCcq1SBOHGx9kIMQ925SVL3UFwN6SlqBtO0xxwp4nMvByQJlyg8sMvLTDhWdvy88JTguIu+5wcp6SE3f4BGpXNF503vilV71keGLw3OdCoXcl96sDt6lybMGWe1v8QR54w1CuIRaJADHUFx7uHKPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=AE5wBKI/4nKp9YjMKr9kNdVmpl4JbX7/5DeDX+SHFgg=;
 b=QsVG48vK0Ba/5BdtwPyrYHIhSGSufSTp7LtBo3PveL9QIqwnGfa5kxhUfX3GEW1Uo9DhFmd0JSop1KuvPJRcAo4z111D5OWGGiLL4eDhNBP4w0FpSyZdVEz8AdxE9yxXR8TF+/Lj+aDGobmW4x0p4TMh3BN7CoRyupMCdVALIJ6WsDx1nbCK3tZvXnDTQ8wdNF1qk5Ehvs7gmQAz8xN3r4ISi2PjjortlUGrGmViYv1qAGR7Mh3pJvNEmuf2u9GNjxLd2KMUxUq2xY4i6ltxv0jLyWRT7wmAEWl099Ht0sklS1ckEri5lK+/+xn8CC5TE14Kcuk6EvRJBwJe1C9Ufg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
 dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AE5wBKI/4nKp9YjMKr9kNdVmpl4JbX7/5DeDX+SHFgg=;
 b=E4kzqd/Q+VsdGy800Krm+2mp2wG5PSf+fjOdRkIXF1RzcSSvo2ODeryywJj6foviPWYCSucJNg8ZTEPh/7k6UgY829nX7PbE5I3lYgP0ZujWrczAY9LE7GujgzfOJMUlc9+udmEs9wvHFDR1qw8Yp5M7BNaiVJuMkQZbEDbkjzs=
Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16)
 by DM5PR1801MB2028.namprd18.prod.outlook.com (2603:10b6:4:66::39)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Mon, 22 May
 2023 07:03:38 +0000
Received: from PH0PR18MB4672.namprd18.prod.outlook.com
 ([fe80::9225:bda3:4faa:a84b]) by PH0PR18MB4672.namprd18.prod.outlook.com
 ([fe80::9225:bda3:4faa:a84b%4]) with mapi id 15.20.6411.028; Mon, 22 May 2023
 07:03:38 +0000
From: Anoob Joseph <anoobj@marvell.com>
To: Akhil Goyal <gakhil@marvell.com>, Thomas Monjalon <thomas@monjalon.net>,
 Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Konstantin Ananyev
 <konstantin.v.ananyev@yandex.ru>, Bernard Iremonger
 <bernard.iremonger@intel.com>
CC: Hemant Agrawal <hemant.agrawal@nxp.com>,
 =?iso-8859-1?Q?Mattias_R=F6nnblom?= <mattias.ronnblom@ericsson.com>, Kiran
 Kumar Kokkilagadda <kirankumark@marvell.com>, Volodymyr Fialko
 <vfialko@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, Olivier Matz
 <olivier.matz@6wind.com>
Subject: RE: [PATCH v2 02/22] lib: add pdcp protocol
Thread-Topic: [PATCH v2 02/22] lib: add pdcp protocol
Thread-Index: AQHZiAtrqtKeoy/hzEyY8C+Y79fxFa9d5kjAgAHBnwCAAAtf8IAABxQAgAYr+qA=
Date: Mon, 22 May 2023 07:03:38 +0000
Message-ID: <PH0PR18MB4672DBBFD6509DAC1D1436ABDF439@PH0PR18MB4672.namprd18.prod.outlook.com>
References: <20221222092522.1628-1-anoobj@marvell.com>
 <20230414174512.642-1-anoobj@marvell.com>
 <20230414174512.642-3-anoobj@marvell.com>
 <CO6PR18MB4484AA4404813D7F704A207FD8799@CO6PR18MB4484.namprd18.prod.outlook.com>
 <PH0PR18MB4672A80373324E35B5A93DBADF7F9@PH0PR18MB4672.namprd18.prod.outlook.com>
 <CO6PR18MB44840E14331F2EF2153F9755D87F9@CO6PR18MB4484.namprd18.prod.outlook.com>
 <PH0PR18MB4672E6D161EF7F24CCDD1803DF7F9@PH0PR18MB4672.namprd18.prod.outlook.com>
 <CO6PR18MB4484CF0A74704099F05CDDB8D87F9@CO6PR18MB4484.namprd18.prod.outlook.com>
In-Reply-To: <CO6PR18MB4484CF0A74704099F05CDDB8D87F9@CO6PR18MB4484.namprd18.prod.outlook.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-dg-rorf: true
x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW5vb2JqXG?=
 =?iso-8859-1?Q?FwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0?=
 =?iso-8859-1?Q?YmEyOWUzNWJcbXNnc1xtc2ctYzQ0YzBjYTctZjg2ZS0xMWVkLTljNTItNG?=
 =?iso-8859-1?Q?MwMzRmNWY5YjRmXGFtZS10ZXN0XGM0NGMwY2E5LWY4NmUtMTFlZC05YzUy?=
 =?iso-8859-1?Q?LTRjMDM0ZjVmOWI0ZmJvZHkudHh0IiBzej0iMzk1NyIgdD0iMTMzMjkyMT?=
 =?iso-8859-1?Q?I2MTUyMDEzMzQxIiBoPSJwZ2NOMXJXT2g3OU1Pdk9nektaNnNwT3NwN3c9?=
 =?iso-8859-1?Q?IiBpZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2?=
 =?iso-8859-1?Q?dVQUFId1FBQUFkdHFXR2U0elpBWm0zamN5c3p5V0ZtYmVOekt6UEpZVWFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFBTUVBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBRUFBUUVCQUFBQThBTU44d0NBQVFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUo0QUFBQmhBR1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQU?=
 =?iso-8859-1?Q?dNQWRRQnpBSFFBYndCdEFGOEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFZd0IxQUhN?=
 =?iso-8859-1?Q?QWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFBRzBBWWdCbEFISUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFjd0IwQUc4QW?=
 =?iso-8859-1?Q?JRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQU?=
 =?iso-8859-1?Q?FBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?=
 =?iso-8859-1?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFB?=
 =?iso-8859-1?Q?SE1BZEFCdkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQW?=
 =?iso-8859-1?Q?FRQjBBR1VBY2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRz?=
 =?iso-8859-1?Q?hBYlFCZkFITUFjd0J1QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtB?=
 =?iso-8859-1?Q?Y0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFITUFZUUJuQUdVQVh3Qj?=
 =?iso-8859-1?Q?JBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlRQmpBR3NBWH?=
 =?iso-8859-1?Q?dCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
x-dg-reftwo: =?iso-8859-1?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZk?=
 =?iso-8859-1?Q?FIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lB?=
 =?iso-8859-1?Q?YVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFH?=
 =?iso-8859-1?Q?RUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQURBQUFBQUFBQUFBQUFBQUFBUUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISU?=
 =?iso-8859-1?Q?Fid0JxQUdVQVl3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QVl3QnZBRzRBWmdC?=
 =?iso-8859-1?Q?cEFHUUFaUUJ1QUhRQWFRQmhBR3dBWHdCaEFHd0Fid0J1QUdVQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0Fa?=
 =?iso-8859-1?Q?UUJqQUhRQVh3QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCak?=
 =?iso-8859-1?Q?FIUUFaUUJrQUY4QVlRQnNBRzhBYmdCbEFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFB?=
 =?iso-8859-1?Q?QW5nQUFBRzBBWVFCeUFIWUFaUUJzQUY4QWNBQnlBRzhBYWdCbEFHTUFkQU?=
 =?iso-8859-1?Q?JmQUc0QVlRQnRBR1VBY3dCZkFISUFaUUJ6QUhRQWNnQnBBR01BZEFCbEFH?=
 =?iso-8859-1?Q?UUFYd0JvQUdVQWVBQmpBRzhBWkFCbEFITUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQW?=
 =?iso-8859-1?Q?JRQmhBSElBZGdCbEFHd0FiQUJmQUdFQWNnQnRBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
x-dg-refthree: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFad0J2QUc4?=
 =?iso-8859-1?Q?QVp3QnNBR1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFB?=
 =?iso-8859-1?Q?QUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQV?=
 =?iso-8859-1?Q?l3QjBBRjhBWXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQU?=
 =?iso-8859-1?Q?FBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3?=
 =?iso-8859-1?Q?QmpBRzhBWkFCbEFITUFYd0JrQUdrQVl3QjBBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VB?=
 =?iso-8859-1?Q?Y2dCMkFHVUFiQUJzQUY4QWNBQnlBRzhBYWdCbEFHTUFkQUJmQUc0QVlRQn?=
 =?iso-8859-1?Q?RBR1VBY3dCZkFHTUFid0J1QUdZQWFRQmtBR1VBYmdCMEFHa0FZUUJzQUY4?=
 =?iso-8859-1?Q?QWJRQmhBSElBZGdCbEFHd0FiQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcwQVlRQnlBSFlBWl?=
 =?iso-8859-1?Q?FCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFGOEFiZ0JoQUcwQVpRQnpB?=
 =?iso-8859-1?Q?RjhBWXdCdkFHNEFaZ0JwQUdRQVpRQnVBSFFBYVFCaEFHd0FYd0J0QUdFQW?=
 =?iso-8859-1?Q?NnQjJBR1VBYkFCc0FGOEFZUUJ1QUdRQVh3QnRBR2tBY0FBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
x-dg-reffour: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZU?=
 =?iso-8859-1?Q?FBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpRQmpBSFFB?=
 =?iso-8859-1?Q?WHdCdUFHRUFiUUJsQUhNQVh3QmpBRzhBYmdCbUFHa0FaQUJsQUc0QWRBQn?=
 =?iso-8859-1?Q?BBR0VBYkFCZkFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCdkFISUFYd0JoQUhJ?=
 =?iso-8859-1?Q?QWJRQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFH?=
 =?iso-8859-1?Q?RUFjZ0IyQUdVQWJBQnNBRjhBY0FCeUFHOEFhZ0JsQUdNQWRBQmZBRzRBWV?=
 =?iso-8859-1?Q?FCdEFHVUFjd0JmQUdNQWJ3QnVBR1lBYVFCa0FHVUFiZ0IwQUdrQVlRQnNB?=
 =?iso-8859-1?Q?RjhBYlFCaEFISUFkZ0JsQUd3QWJBQmZBRzhBY2dCZkFHY0Fid0J2QUdjQW?=
 =?iso-8859-1?Q?JBQmxBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWU?=
 =?iso-8859-1?Q?FaUUJzQUd3QVh3QndBSElBYndCcUFHVUFZd0IwQUY4QWJnQmhBRzBBWlFC?=
 =?iso-8859-1?Q?ekFGOEFjZ0JsQUhNQWRBQnlBR2tBWXdCMEFHVUFaQUJmQUcwQVlRQnlBSF?=
 =?iso-8859-1?Q?lBWlFCc0FHd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0Fi?=
 =?iso-8859-1?Q?QUJmQUhBQWNnQnZBR29BWlFCakFIUUFYd0J1QUdFQWJRQmxBSE1BWHdCeU?=
 =?iso-8859-1?Q?FHVUFjd0IwQUhJQWFRQmpBSFFBWlFCa0FGOEFiUUJoQUhJQWRnQmxBR3dB?=
 =?iso-8859-1?Q?YkFCZkFHOEFjZ0JmQUdFQWNnQnRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFkQU?=
 =?iso-8859-1?Q?JsQUhJQWJRQnBBRzRBZFFCekFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQU?=
 =?iso-8859-1?Q?FnQUFBQUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCM0FHOEFjZ0Jr?=
 =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?=
x-dg-reffive: QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQT0iLz48L21ldGE+
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH0PR18MB4672:EE_|DM5PR1801MB2028:EE_
x-ms-office365-filtering-correlation-id: 5fd1bd7e-068b-408b-88a4-08db5a92aaf3
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Ivy7ofuDk48CEeRC/FRgxGpsNxy4xOArI9foAEtBqyVBba2zIk7w0HSSoTP+27rOkxEtdbYc3US1nZBl/f4vKXgtRVRC2s7GKcgd4KzZAo4NJGIBd/Bu+GB1u/fLGAVPqHoy/NznSLv7IswL27gQwdo4ryeK1fwYRewywiHoYzhRQ2M1JJMUA+kt29oKt8ZTr1ldE0npplzoIo2y6VQKV4zb6X7U0rO9nMofKvucdM/W6+eIFcSuVJrA4YecqtxhdRfttLcfvSSENJeou6JhyfXx+aIbZ3IIVRbiSdS25BEQ5iNQT8CzXoUrGWfoqDFKAZ/wnBvuykHlOgcPyKa5zTSN8Y3Na0bu/c/s+En4q2zN4t3cBY/JU0y9e3/pwEXeuVUL1cyDCNoO7RFJZ0l8exuYtVtOCc4T2CcfQPu8dUBtYpxKyP3jvd1d2K/Qkky26xuIvkSEpfQBgKZh4U6AQLIM/MG/GurVnrQBDXoASqiANI4sAKBzwA3A6vDILraUC+rijNrumAS11vAIFkJFttYi5QeGL2VDiG/HWnWRKn0rs27Q/jblTFvqsqwuPQt8xZOhEIjIwxxhKK04UMvFp3wGmGAprQrJz9UQmKSHFOXTctz8tdth4BVciBMk3Ooq
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230028)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199021)(66446008)(66476007)(478600001)(76116006)(53546011)(66556008)(66946007)(316002)(110136005)(4326008)(64756008)(7696005)(54906003)(41300700001)(66574015)(71200400001)(5660300002)(186003)(9686003)(55016003)(8676002)(52536014)(33656002)(8936002)(26005)(6506007)(38070700005)(83380400001)(38100700002)(122000001)(86362001)(2906002);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?is/ZWYxLtDXBI9eib5QuiLKZpkN5FMmWGxFu6rVgqhYar4IrRi0bwzDfUi?=
 =?iso-8859-1?Q?gddmcoAd7gDnAlpnZFOniPcefM7bqCxkmIQjyIWqKEkZdv+vevrJtBSDQ4?=
 =?iso-8859-1?Q?7UN0s0xxaRcxfawd3tmlEtC3SZmd1I1N1hP8Z7pZhjwEV74wSJvYyTKDpW?=
 =?iso-8859-1?Q?gw+ABEzGCD02ANGgp+FqojGiYKc4Ku9Pq0CEUkyFG6XHKg4Lr+/iIpHMDj?=
 =?iso-8859-1?Q?y9zTbiezd8mmGUaUTArgbYH4HweT2lFJZmj9tA3KGCIpwJi8tU5quVgp5W?=
 =?iso-8859-1?Q?tqTuSYTH/JyKGRDwW/J21JWrkDFEU73k21VBDDmzZVfjdhWJlaUWUsQJGw?=
 =?iso-8859-1?Q?x2HcevkraM/eUFhbRqfLqs4DJll9vlAvo6OYicFIWvXahLjP9+T9hQLTTz?=
 =?iso-8859-1?Q?asoAQFbLFmzLBVIPJl2GQJZa6k7eDHiOfvqDRMMSA27uahcHPkLeAPivMh?=
 =?iso-8859-1?Q?sF7SNSewmp/9jj0ugL1tbE36BWY+MYgBgrso89PbHmn7jbo5/DIFpTnQHt?=
 =?iso-8859-1?Q?txfFPLiDng0+rMzB6NdgGKrL83ZsOMEzLXn49uRVSCiWYAtyMi4IQHdfMt?=
 =?iso-8859-1?Q?ChRkzmHQBxCGz9ZEGqSkvjrL2WbuacK3khwxhIQ4F4sRCIG0fB0QHGuHIe?=
 =?iso-8859-1?Q?lg40YJBMPvBb7/Da6eQ3aYIKOhTGoaxtioE8572Lgu9eRmNFwkFD1DjWde?=
 =?iso-8859-1?Q?VQBm5ozVXEreX6nBtxx32kJrKg+2QRDhn4aORdaGaPz/YtJtA3IG6or48L?=
 =?iso-8859-1?Q?yfBl/yhGyU+JAtYIbdb/wVf4t6tLSeEuMwXboK6PwrRLEjOXj7thEyQns9?=
 =?iso-8859-1?Q?5rAFuAji5xbtS23BdnpkG7KiRiNjIULpuCJkcEpnB+Hk7C9B8lfnyRKCvJ?=
 =?iso-8859-1?Q?Nw9Mw/OxWrHgwm0jisqIRYyl9fuv0rm6NyX4A0YRqhwO8A7YHfrCRLJOXz?=
 =?iso-8859-1?Q?Vut+cam9xokppUfcEKmsIkT3/PHo0jM2OBASeVXqRF7a/0dOksysrx3ZdF?=
 =?iso-8859-1?Q?H+sfbuF8ctuiuP8NHw7IZOpUOszaOzOuwlcNT1Q1vlfOeUJ6AclERzNRr0?=
 =?iso-8859-1?Q?GvUX1HIuTfZB2xeStoFM9cud4MmLFxYlWvK1ju12q8Ums136h0LF96b9js?=
 =?iso-8859-1?Q?uTvVqrZatkzL2swTvpmBGTBTOaMJeH3egFmUViHk/tBf4E3EtMi9g/wYl/?=
 =?iso-8859-1?Q?Kuvx281/GUCqdMUZECjrBSX6OSn5iZApnb8SKZDmYc9u+2V8DoC7YysVNJ?=
 =?iso-8859-1?Q?Yyq6Y6RyVY3iWjY5x5ucRuH7R4G1yIFDpm1kq4/yfTi32skdmH2tHcxTOR?=
 =?iso-8859-1?Q?aXo5eUvH8PnASmHuyvkpLL2bQ1quVTbfAClYdqobkCCIdQZfsJ3TNixKCZ?=
 =?iso-8859-1?Q?d6fGruMPTVdAIFSg7ZjtKA8VMPqomfaKc3fWHGa290DAioBKJ/+KXo8/IW?=
 =?iso-8859-1?Q?FjV5DebosB1288enzHSmp260ZHP9ldvAoXhm0I+SIiThhvwwGyo1FQY/Z5?=
 =?iso-8859-1?Q?SkodUbp42KYUcUoZOrklf6cVrUiO0+1s8QYiEDgIUJIVeR5z6TtKtnP/vQ?=
 =?iso-8859-1?Q?o/S+Ca2uKtR549LZ5nlhkwAacy8Ik1rrgU6mKApg7NMrzi8dJelgsKijXI?=
 =?iso-8859-1?Q?U4mDGznNBOYcU=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd1bd7e-068b-408b-88a4-08db5a92aaf3
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2023 07:03:38.2545 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dT2fKKV/bNT6WtgyYP/YywLh7gFWLujHhLFuxAvkZjmjh0y0q2pB9DnWb3vvrMi5rqZNXPuDgvRxTEx346yfjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1801MB2028
X-Proofpoint-ORIG-GUID: LyykXZjOOoQSldueZrdbSlBQRUZTGNjq
X-Proofpoint-GUID: LyykXZjOOoQSldueZrdbSlBQRUZTGNjq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-22_04,2023-05-17_02,2023-02-09_01
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Akhil,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, May 18, 2023 2:16 PM
> To: Anoob Joseph <anoobj@marvell.com>; Thomas Monjalon
> <thomas@monjalon.net>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>; Bernard
> Iremonger <bernard.iremonger@intel.com>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Mattias R=F6nnblom
> <mattias.ronnblom@ericsson.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Volodymyr Fialko <vfialko@marvell.com>;
> dev@dpdk.org; Olivier Matz <olivier.matz@6wind.com>
> Subject: RE: [PATCH v2 02/22] lib: add pdcp protocol
>=20
> > > > > > diff --git a/lib/pdcp/rte_pdcp.c b/lib/pdcp/rte_pdcp.c new
> > > > > > file mode
> > > > > > 100644 index 0000000000..8914548dbd
> > > > > > --- /dev/null
> > > > > > +++ b/lib/pdcp/rte_pdcp.c
> > > > > > @@ -0,0 +1,138 @@
> > > > > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > > > > + * Copyright(C) 2023 Marvell.
> > > > > > + */
> > > > > > +
> > > > > > +#include <rte_errno.h>
> > > > > > +#include <rte_pdcp.h>
> > > > > > +#include <rte_malloc.h>
> > > > > > +
> > > > > > +#include "pdcp_crypto.h"
> > > > > > +#include "pdcp_entity.h"
> > > > > > +#include "pdcp_process.h"
> > > > > > +
> > > > > > +static int
> > > > > > +pdcp_entity_size_get(const struct rte_pdcp_entity_conf *conf) =
{
> > > > > > +	int size;
> > > > > > +
> > > > > > +	size =3D sizeof(struct rte_pdcp_entity) + sizeof(struct
> > > > > > +entity_priv);
> > > > > > +
> > > > > > +	if (conf->pdcp_xfrm.pkt_dir =3D=3D
> > RTE_SECURITY_PDCP_DOWNLINK)
> > > > > > +		size +=3D sizeof(struct entity_priv_dl_part);
> > > > > > +	else if (conf->pdcp_xfrm.pkt_dir =3D=3D
> > RTE_SECURITY_PDCP_UPLINK)
> > > > > > +		size +=3D sizeof(struct entity_priv_ul_part);
> > > > > > +	else
> > > > > > +		return -EINVAL;
> > > > > > +
> > > > > > +	return RTE_ALIGN_CEIL(size, RTE_CACHE_LINE_SIZE); }
> > > > > > +
> > > > > > +struct rte_pdcp_entity *
> > > > > > +rte_pdcp_entity_establish(const struct rte_pdcp_entity_conf
> *conf) {
> > > > > > +	struct rte_pdcp_entity *entity =3D NULL;
> > > > > > +	struct entity_priv *en_priv;
> > > > > > +	int ret, entity_size;
> > > > > > +
> > > > > > +	if (conf =3D=3D NULL || conf->cop_pool =3D=3D NULL) {
> > > > > > +		rte_errno =3D -EINVAL;
> > > > > > +		return NULL;
> > > > > > +	}
> > > > >
> > > > > errnos are normally set as positive values.
> > > >
> > > > [Anoob] I do not think so. I checked rte_ethdev.h, rte_flow.h etc
> > > > and all APIs are returning negative values in case of errors.
> > >
> > > Check again lib/ethdev/rte_ethdev.c
> > > rte_errno are set as positive values only and APIs return error
> > > numbers as negative values.
> >
> > [Anoob] Okay. There are many APIs were this is not done correctly
> > (check
> > rte_flow.h) . For lib PDCP additions, I'll have this handled. Some of
> > these conventions should be documented to avoid confusion.
>=20
> I am not sure what you are referring to.
> I cannot find any discrepancy in rte_flow.c as well.
>=20
> Can you give an example where it is wrong. We can ask specific people to =
fix
> that.
>=20
> Regarding documentation.
> It is mentioned in rte_errno.h
> /**
>  * Error number value, stored per-thread, which can be queried after
>  * calls to certain functions to determine why those functions failed.
>  *
>  * Uses standard values from errno.h wherever possible, with a small
> number
>  * of additional possible values for RTE-specific conditions.
>  */
> #define rte_errno RTE_PER_LCORE(_rte_errno)
>=20
> And errno.h has all positive values defined.

[Anoob] Agreed. There are descriptions in rte_flow.h which got us confused.=
 Thanks for the clarification. Changes in PDCP will come in next version.