From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C4BBA0C43; Thu, 23 Sep 2021 13:30:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 654E04126C; Thu, 23 Sep 2021 13:30:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id F049A41250 for ; Thu, 23 Sep 2021 13:30:19 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18NBI21r022285; Thu, 23 Sep 2021 04:30:19 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by mx0a-0016f401.pphosted.com with ESMTP id 3b8rk9g11n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Sep 2021 04:30:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n7Md07EginmzZHxd1N8+Fv4xz8FTXPTxxEaB6gYmclOaZiAeo6Be74GajjG2xeUm6nL8xCc8Gy6UxpGLoy7PleKYOKdqcTRdMpmdK+QJ6e7q0ZmQ2FJQkVNe6VBOTBC2qxVIKMLoQoPZ6y7pEl4n0ii5LWBXqoAZt1pXyuCWI+RIS+INrL/7BvrOTGobAtDcf+NoxxsXwQ0MrXt0pFJp45qVfcq94Tj4z0huLfKhVs99Xq/Y40dgrcl9w93am2rqy/dTb6yynEH4xvLMyGLCs42aylAZxQeTTyGhBiQORUYF2IOaaE0XSIhSLTIQMPWgEqpq0ak+4D9xiXyc6vRTOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=G7uHOAn3Mm7HArPu+ClwTE3q2EvDJLw686E30TmX66A=; b=NGCdSEX5A+BZPYBMZHhKuFrmVPxRQY054Foj00b0/3iaL6h3um06RCMHDtmw0xzjt7dNgT7T8oyTgMyC08T4xvsYschSUnue6ovxlVXcKEPATZMAy2vp4I59JoMv4zSBLCh2I7Apz3+X4SdxOa5rKuq01NxcptB06BjX4N+txXts+etSvYW+nD+CtJlvlfhfNDrtZ6EWPjuB86BFP0kX/5LEFzdAG6KhOOikQzKTMvJbnJPuEm9XvkZ/IQSVymP1x8hRqfGk4UtXym7z9NaaBCn7kZkn6HBQEEHH6O+v+9b7BIu7JB5zEy4dDSXKPAub4TLPnROZLDNQ+r4+7+vtKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G7uHOAn3Mm7HArPu+ClwTE3q2EvDJLw686E30TmX66A=; b=WbGdLZR3Ob5iLxI9sfJq2lbaqfPL26H1F3rMlkd9zmAc1uNbUWq9X5po7q2a9YjYBWkAQoNBVe0uPbc2YLrF6yb/B+YHO7k9GNMI6L8KZSzcLYy33bUTc7+xw18UZ3ZCO9QaGr480TeVY/Emtc02fe7de+eUlKK0bLxbFs7V1Dw= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by PH0PR18MB4720.namprd18.prod.outlook.com (2603:10b6:510:ce::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Thu, 23 Sep 2021 11:30:16 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::85aa:3d01:94f6:984]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::85aa:3d01:94f6:984%4]) with mapi id 15.20.4544.014; Thu, 23 Sep 2021 11:30:16 +0000 From: Anoob Joseph To: "Power, Ciara" , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: Jerin Jacob Kollanukkaran , Archana Muniganti , Tejasree Kondoj , Hemant Agrawal , "Nicolau, Radu" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests Thread-Index: AQHXq8YlPuTK/Vsp1UCSiVhU2yefFauxdwSAgAACdQCAAArEgIAAAIlw Date: Thu, 23 Sep 2021 11:30:16 +0000 Message-ID: References: <1630644420-1256-1-git-send-email-anoobj@marvell.com> <1631884523-836-1-git-send-email-anoobj@marvell.com> <1631884523-836-2-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca01521e-bfa6-4fcc-d4d7-08d97e85846a x-ms-traffictypediagnostic: PH0PR18MB4720: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fG4Rrb/UzC+u/i0siQXRpm9bPi2CBSU7jrihkAIl6xqeTUXDciWkmoIsXE7P5LnZzZkVy2v8c8tm4v+xpfRdWmh6y/5MwmiaBDv9QWl22LjPhwjL4quHFUfd1cegQTsTqIYm+64aOd9l6+B1tsO9yx08L2OEo3csjY0UlsO3sZgUYEL6Wy1EbixbQEAU7g1LlUuowjURvPzTYsDMoBnXmY8EXpyL3yGhZnv2yFr37NVm7HfmBDu6s5qxbv5LH7UaAR8yNVn6FtebcitxTPXQrok7qrLQdpjjK4gKIX8yvCu6iR+JBbi0puwDzglHn5lb7GiIm6Pb/kcGX43tqE4aUgvIOxBUiBRll78x6HPc3on1BOWqdnls7Tf7nH2Z8hg9mZ9vkwejG3cCmi2sMz1HwNMzeWVFsecTJpzkiwJ/kxPx3+8+AvXZ8XdTYnE40SQG2KOvHYL5GcZ6j3t5g4A550Kj04U08r/cMkR/V7WDn37r4avM/UVmmwiicJHpIrbc+3vm+Gf08jjeQZEZ6tKTu2tXE0cgFHZC0hw6RGoD8e9Ro5KxOQjY+FEiL1gwYjKq0nuQNOrLeq27WLMXS48ewt4+8qy3WHi4GxF0BctRi5QpgmGMeugnkCi/tQ/1N0OUg9zwcVmZRNQAnEDVlyeARra5r0tnHiHsztSbMhVCkRYvPvvRwn7D63FIVyfLQmPlEcYCotV2bbPflA/CjOQJ3Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(53546011)(186003)(6506007)(9686003)(55016002)(8676002)(5660300002)(64756008)(110136005)(71200400001)(66946007)(26005)(52536014)(316002)(76116006)(8936002)(33656002)(508600001)(38100700002)(38070700005)(66476007)(2906002)(122000001)(66446008)(7696005)(86362001)(66556008)(54906003)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aK1uI+5LyfZvF687rhglIi+C2Deh/T9evJaPJY9bjQMttk8or2odDGuRRtOw?= =?us-ascii?Q?wA6ZVm2zQ6wPsrun1GIQ+L185U7rXY2XBFh1ivYe2UkjemOYjdEWl7e+pd2t?= =?us-ascii?Q?G6wFMoa0C9m7JpeLh93OzkplVrEUyhpIcM118kcQInOT9SZMEEBnZrkz05aT?= =?us-ascii?Q?k59NxRPCih2Ig6ES0JU27CbIUgjSp4ANCUQ1qRy4oWW47LdTzh8MZOsfZDyn?= =?us-ascii?Q?wR4xkkpWYJ03iheCqs+GR6O3pYPbykvmdJZF4gOmivAE5CCjdmBIb0OU13wg?= =?us-ascii?Q?BqMqf1o5uUxhm3huA2SOp5J99AM3dIJe5CVQNgcn09v+7rHorwFzoVSSJPHb?= =?us-ascii?Q?Lq9Wt6R8eZDEzhZ8k0o2Rwk+DtL4txo2mvCrZV9OGutor0Yad50t5X24jd1M?= =?us-ascii?Q?vMUFaX3nphuuwi51NT7HL7NveSMVW5mRDFe8QufLxUztoUus7PMhMXvkQMbT?= =?us-ascii?Q?9bx9j8spphMM4wAixSgSDYE7koAoaP+5tLVvtbi9F1EGyh5pUq50afMAduoH?= =?us-ascii?Q?MB9uoXh5hbKmDktb2linfrnP+y6862dr74cbECwH9jOYCJQ/OMm0ZOOJjekg?= =?us-ascii?Q?9d59mkpxqyM6La4qLF1z0GwKYp4VNIxwpdTOeLIMlDOklxZDCxdynuNvwRMa?= =?us-ascii?Q?/RXbEsn3k9fmVqNBLoeCqsIMJ9cyuAoAXA604+I8pjfo5Uu2VWsvkfSNOyx5?= =?us-ascii?Q?VlL0iIuhmXHnDlfpELFcGddmaVnyVVm2u7e/u/rcV3fkm2DsBtrZQyklaW/v?= =?us-ascii?Q?E3BNzh/w1F0kbxvYxsODnrhZC/FFEzmuu2LWLHtd8XpBd7Y6W8Rt1l8ororn?= =?us-ascii?Q?xQRoVAN78P1eDzxEjjOikElU8nNRi3Ve6BCilakJzQqAHxtnzUHg4bNq/uFo?= =?us-ascii?Q?B9yMMfrAqPo/ITCR7+0SliK43MIVc0iaXzuux6TELoZ3zl1T2UhAvFDNIXr+?= =?us-ascii?Q?gMOpE06vAT2DS/OvoS62vqEVjGJ0bqupwvps+ZgSXmC60x1T0C9LPpePIFPl?= =?us-ascii?Q?7SQA8Hoe2QWD/nVzhC5VY0aoegsyqzA/Bx2xD3rFr4/fFVNXwHeO7pracvON?= =?us-ascii?Q?XLNX9BjEExikTTqVT9pVif8buzGSBIKaMv6pKbXW5QH3ele2KyFp2b+mjwV9?= =?us-ascii?Q?r6uQoFTgXH9WTSw/je1NX80KpTt6gJ/oZlTPJsPIs6oED7v2tpq1umYukwKR?= =?us-ascii?Q?9+Cn4GCjQMB0bxZzCkuemVpagzo3WMQA+DA2b3aMWix782Z2lsrE1h9uRDft?= =?us-ascii?Q?ENFOuGT3sACwKFGaSRFSIVfy5lVx5q6ZnI2Zypeq30kmzzrxGKFLRb5RGEW9?= =?us-ascii?Q?0GimYF1Pkl61Fkqp9gDR1ucb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca01521e-bfa6-4fcc-d4d7-08d97e85846a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 11:30:16.4630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LO2UXWUqmiRvOrA5QOVSbOoIRCWzlziD4nxzh65pidWSBwCDaGK1wgzcTadbtQoA10b1rIgl/LnmfdOGKBbkGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4720 X-Proofpoint-ORIG-GUID: FfqMA-bCII9LStb0Qyo3tthDRLjf6zl5 X-Proofpoint-GUID: FfqMA-bCII9LStb0Qyo3tthDRLjf6zl5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-23_03,2021-09-23_01,2020-04-07_01 Subject: Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ciara, I'm planning to send next version addressing Akhil's comments. Can you revi= ew and ack patches if you don't have further comments? Thanks, Anoob > -----Original Message----- > From: Power, Ciara > Sent: Thursday, September 23, 2021 4:57 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; Zhang, Roy Fan > ; Ananyev, Konstantin > > Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti > ; Tejasree Kondoj ; Hemant > Agrawal ; Nicolau, Radu > ; Gagandeep Singh ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 >=20 > >-----Original Message----- > >From: Anoob Joseph > >Sent: Thursday 23 September 2021 12:09 > >To: Power, Ciara ; Akhil Goyal > >; Doherty, Declan ; > >Zhang, Roy Fan ; Ananyev, Konstantin > > > >Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti > >; Tejasree Kondoj ; > Hemant > >Agrawal ; Nicolau, Radu > >; Gagandeep Singh ; > >dev@dpdk.org > >Subject: RE: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests > > > >Hi Ciara, > > > >Please see inline. > > > >Thanks, > >Anoob > > > >> -----Original Message----- > >> From: Power, Ciara > >> Sent: Thursday, September 23, 2021 4:09 PM > >> To: Anoob Joseph ; Akhil Goyal > >> ; Doherty, Declan ; > >> Zhang, Roy Fan ; Ananyev, Konstantin > >> > >> Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti > >> ; Tejasree Kondoj ; > >> Hemant Agrawal ; Nicolau, Radu > >> ; Gagandeep Singh ; > >> dev@dpdk.org > >> Subject: [EXT] RE: [PATCH v4 1/5] test/crypto: add lookaside IPsec > >> tests > >> > >> External Email > >> > >> --------------------------------------------------------------------- > >> - > >> Hi Anoob, > >> > >> One comment inline. > >> > >> Thanks, > >> Ciara > >> > >> >-----Original Message----- > >> >From: Anoob Joseph > >> >Sent: Friday 17 September 2021 14:15 > >> >To: Akhil Goyal ; Doherty, Declan > >> >; Zhang, Roy Fan > >> >; Ananyev, Konstantin > >> > > >> >Cc: Anoob Joseph ; Jerin Jacob > >> >; Archana Muniganti ; > >> >Tejasree Kondoj ; Hemant Agrawal > >> >; Nicolau, Radu ; > >> >Power, Ciara ; Gagandeep Singh > >> >; dev@dpdk.org > >> >Subject: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests > >> > > >> >Added test case for lookaside IPsec. Inbound known vector tests are > >added. > >> > > >> >Cipher list: AES-GCM 128, 192 & 256 > >> > > >> >Signed-off-by: Anoob Joseph > >> >Signed-off-by: Tejasree Kondoj > >> > > >> >--- > >> > app/test/meson.build | 1 + > >> > app/test/test.h | 6 + > >> > app/test/test_cryptodev.c | 232 +++++++++++= ++++ > >> > app/test/test_cryptodev_security_ipsec.c | 212 +++++++++++= +++ > >> > app/test/test_cryptodev_security_ipsec.h | 66 +++++ > >> > .../test_cryptodev_security_ipsec_test_vectors.h | 321 > >> >+++++++++++++++++++++ > >> > >> > >> > #ifdef RTE_LIB_SECURITY > >> > static int > >> >+ipsec_proto_testsuite_setup(void) > >> >+{ > >> >+ struct crypto_testsuite_params *ts_params =3D &testsuite_params; > >> >+ struct crypto_unittest_params *ut_params =3D &unittest_params; > >> >+ struct rte_cryptodev_info dev_info; > >> >+ int ret =3D 0; > >> >+ > >> >+ rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); > >> >+ > >> >+ if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_SECURITY)) { > >> >+ RTE_LOG(INFO, USER1, "Feature flag requirements for IPsec > >> >Proto " > >> >+ "testsuite not met\n"); > >> >+ return TEST_SKIPPED; > >> >+ } > >> >+ > >> >+ /* Reconfigure to enable security */ > >> >+ dev_configure_and_start(RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO > >> >| > >> >+ RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO); > >> >+ > >> >+ /* Set action type */ > >> >+ ut_params->type =3D > >> >RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL; > >> >+ > >> >+ if (security_proto_supported( > >> >+ > >> > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, > >> >+ RTE_SECURITY_PROTOCOL_IPSEC) < 0) { > >> >+ RTE_LOG(INFO, USER1, "Capability requirements for IPsec > >> >Proto " > >> >+ "test not met\n"); > >> >+ ret =3D TEST_SKIPPED; > >> > >> The device still needs to be stopped here I believe if capabilities no= t met. > > > >[Anoob] Here we are just setting return value. Function returns below > >only (after stopping device). > > >=20 > Apologies, yes I missed that. Thanks! >=20 > >> > >> >+ } > >> >+ > >> >+ /* Stop the device */ > >> >+ rte_cryptodev_stop(ts_params->valid_devs[0]); > >> >+ > >> >+ return ret; > >> >+} > >> >+