From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D31EBA0C4B; Mon, 8 Nov 2021 05:05:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5722D40151; Mon, 8 Nov 2021 05:05:56 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id AA32340040 for ; Mon, 8 Nov 2021 05:05:54 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1A7MVKCQ030331; Sun, 7 Nov 2021 20:05:53 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2103.outbound.protection.outlook.com [104.47.58.103]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3c6j509y2c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 07 Nov 2021 20:05:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jYXqsyRhLc3tDZTDxBcdnWoweggVKk7n1GtI1quc8czgK5hPXYiQsFa133V8JEb6ixQKzb1KBNU7iDk6YeyFZmyrpI+gBW6QgknVRLucymARoVWQh3guuVukizuYIGVVUn1wG/joe1s/ubB9Wq2ZOZxzhA/gN8/D7RMDDVbat2gX5mS/8Js5zI4uKJd/VoskLgj0jlnEbmC6ZVHrOF9tb2zBlxsQRFvNvr0LfHYTk3eb31M5VvdX70FIu60b10k78ZSuTA1VmGCSn792NAkjIxEE5WoDi4r9q87WaRZrPYropnAT4qSaRI90dmL9j2ZERjaSWyYsrOhS8H6qKYieoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X/zwMdedxfN3+PKTs2y1r1cfNkoQPx5WhCNJx3wTX6w=; b=TrQDRxTcV692PS5GbTmXWnRaJY/12kR4R3AI37yAMqjekn9jnJx0kYbI3OQikF0uyCh1Cb4PJ34kVkMtQWcEOIYGoD+k/9tRjkBavoggR4obFucZ1wkRwmRlZXyIIZEldsWIgaoTbCQ3dsxK7OczifqhbThPNAORbE45xL/iJHZA52jPqfwZAIjxvKavwqYBYpOacReRJbMkFIf3B43zqW2t5IGD1ghFJyqZcJK0XSu6TRy05OnqixLjMatOeyGNquhvj2QNxuXLYtbeJxwfegE/+pOfYhMmj3Az6RupA83XreeMbv20eG9QIWQVcvjC0yquhqJcVvQYQ4DrGv35hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X/zwMdedxfN3+PKTs2y1r1cfNkoQPx5WhCNJx3wTX6w=; b=TXkMPVxOe1DJMp5rmtXFI5JxMRNAgffqWayU24pmNUXKpyYYvcoleWeczqFhJdhdt6EB/hPR63kmaiZpF+V6NeVOj73PXq4G7lBKz7YmPAi1DodIFzDf6p0UfcXwqqHVujWtqw7ni18DiqYNFsPVPbR+hIzqlTQLXb4rqvC+N8g= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by PH0PR18MB4814.namprd18.prod.outlook.com (2603:10b6:510:ca::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Mon, 8 Nov 2021 04:05:50 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::30fa:e30f:a8cc:92aa]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::30fa:e30f:a8cc:92aa%8]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 04:05:50 +0000 From: Anoob Joseph To: Kai Ji , "dev@dpdk.org" , Akhil Goyal CC: "pablo.de.lara.guarch@intel.com" , "adamx.dybkowski@intel.com" , "roy.fan.zhang@intel.com" Thread-Topic: [EXT] [dpdk-dev] [dpdk-dev v1] test/cryptodev: fix incomplete data length Thread-Index: AQHX0lu3GsUYipfREk60HPcsxIFgdKv5BWmQ Date: Mon, 8 Nov 2021 04:05:50 +0000 Message-ID: References: <20211105154204.7191-1-kai.ji@intel.com> In-Reply-To: <20211105154204.7191-1-kai.ji@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 753df7ea-19c2-4ea7-abe4-08d9a26d0cec x-ms-traffictypediagnostic: PH0PR18MB4814: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4ARKLAK+okTrUjZhMpYXv86KJdrom2lZmCsVfZY1XDZiaLjfpVJwobUzkd1OR1ceaksEUbF4G3aogqSsN50/8D3LiqZ6kTgkEWBSrV+GKFE+ExPvyMDJ/bjpcC3gN2e3EaKuzkXabIPeHiVdjPZ2v7jqgkgVTkZ589MnciTWkIAFM/ZsMQ2ozL4xOhV764l1xXzb4CcUF2a/OKD0SifR+1R4P2sesdrBgqirHYKcGG2Mgtyt9oM3zmVK4gioJ0XnUtxX09h07gPhMtWTF5ZtRcxdjsgKspFo+D/2n+9/eZ1Wq9rYfiOJxdLXQS26KhUDsN4Q4MAI8HaXWrm4bEzxujeaOU8teqEx9OOnzMenBYmjvEH2uHicxmPwDgN5sSYtBOOo5Gm3lFf5dGEDlXU3GLIrfx51utGD05ScQ/34guH+9pHVt/uhtptUZWF8rPmzWl1RYxqx1MhNkgAZLriY/dwv9Q+w7H2Z47UcNzt4E47usuosGltlpktAdTzoAVTeNzTwCyASzdcHYjhV3Unrm5/EvdF2ukwHEokm4aAOmzzgNouWuExTN3b1nRSmO9RhtOVlAjMV+ilnfCsg2pYsb88IxErEnzc322ExxRifOxCrm+LkEcz3vwCZdHSHv07sI5C+AAu5ih5X8WnsYyAhK3ekoWb6IvprQdu9pbbLZab8Mc56zxLx2XH+7WCQjjnh6FGd+OFWE/zDaDFNrY984w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(76116006)(508600001)(66946007)(66556008)(66476007)(64756008)(66446008)(4326008)(83380400001)(33656002)(86362001)(38070700005)(122000001)(52536014)(54906003)(53546011)(2906002)(6506007)(110136005)(186003)(5660300002)(55016002)(8676002)(316002)(8936002)(26005)(9686003)(7696005)(6636002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q//CM0+VD7Xuysmsn8BTzaPzAXxO9COAkJx5pPYYhB24HiKDui9PYyILd9v8?= =?us-ascii?Q?BWghR+KNFvPalQ++Zd/9HhtHHdKaUU8LHpAs1uKJ3Z0yegzb6tQGLL0Aljku?= =?us-ascii?Q?DEAvnqx0vB3OpBp3PkERdITIoxk21+hHd6fK3V1naUSK2EKHShIvbfLunGmQ?= =?us-ascii?Q?YmqXAH1+Ez/EFs3ZvAL4dv3KxmMouNCI0yhPuzZoz7FOW6ydVojc7rQ5sxUC?= =?us-ascii?Q?uxq0PSkYzRnyAfElQHe24/VNiIJwRlPUTl6T57O0mnze7AgyFP5/9BQCJxBz?= =?us-ascii?Q?cIDU+d6k6qQt4uwho3thRwk3JrahyOy8UQEgR8IttrPH92nX4knznmOgKyBh?= =?us-ascii?Q?FE/UjMQZmNaBc31/im8t0+DqDF59AAjbTD1Bgb9P/wzbsrvFhwCuw+o0pi/R?= =?us-ascii?Q?7EFIFc6f4stog6E1F5FK50s5Uel+g3tTVxa7iUJw5gcW8jwCBfX8KKubCZlD?= =?us-ascii?Q?f4mpCvT82h2ZuXU+r9nfc/QI8X5EPKSWMZo5Oq2VXyZfJracbcMuAedrGJ7B?= =?us-ascii?Q?BiVvWBTkWF2oCVMNvwRRI/E6oBOphyzwLKSzof9ZFbJsPk/OUEDK5ZFaufPm?= =?us-ascii?Q?I0CwvYwMjAC7QTPqMN0EZFJtdN6e9hNbxK/re5we5AkPJRiv2Lm8CKeyP1k7?= =?us-ascii?Q?Vyb/d3M9MImH8sqeYgEmBwVvJh/5uy8hrheovny9egD5pjNo5c25Ez687l+i?= =?us-ascii?Q?Aek+LOiw8NTSy9cWxWxfqy5vhjfwmJ65MQZxo1QTW+QIJ5S3Ek3xf4iCD+8v?= =?us-ascii?Q?j7O447y6otE4lZGuBQIizQhwpcfoQnVJ40fTYnv0ASwO8jy0Mj6V5M4qqL3t?= =?us-ascii?Q?TAZXgSkqAlvZMFGRAUAhIowldYxKQtIoeqYsvm0+/AQ9bKYSVMYTHgc2MoYR?= =?us-ascii?Q?VswhqUVbtHYsR01URdDS8qBLozrtWiwAjZ8VgiqMeLYZJxc66s1xtvxD8QKW?= =?us-ascii?Q?y+iiArZzDAkDND1+LDxDmN8Pat/Al1b9h2D8BcVHGsLUuaXgq/STXRytQ6yg?= =?us-ascii?Q?/+t1VoQBiVx7tuHJ5c0EqiNMtUHmcsIHocOOwGUXCRqkWstB/lvkGWyI9FmB?= =?us-ascii?Q?FzZEIGVVf8yYevKRcpjwV1Pg5yfmLjbsEj8w/vz3zvyhwmnlE211TzEAlX9R?= =?us-ascii?Q?xiOuekbanAl5Y5o3592s16wjjtCxG+w1cQg3t65mtRDFx5G3Spyu2vFTYqCN?= =?us-ascii?Q?L8bna2sskfkltNcLjdReooKTQcGOnHgIyp/N1k+46pqKqMy+qIBYVIewDTui?= =?us-ascii?Q?JXZZv0N8/T+fQAJiq1AKfARi2zXLhsY9DQgO7ZQrXZH5l0JtJgUwgcO8xaSE?= =?us-ascii?Q?27CgvgIyEs6HrBLCbw19VMcJUQZMUaJepScRC2HLcX8O2TcM522APSDNGesa?= =?us-ascii?Q?x011xp+finHGG+SPFH7+0ztfmyebd0YRkSC4gWL4HHkm2Dt4GcaSAlhIQ64L?= =?us-ascii?Q?3T//FdAkXpI3aDCZQXDipvyDJOxCR3G/F15FPhRhiFJ8GYf1tDxqssOEW2XT?= =?us-ascii?Q?vuTfzZs657/i4B8DMDYJ4VTgTKkTQyuK5wfrgtNR0fkid61/3VvoY0jd6B7N?= =?us-ascii?Q?EuO3il5X72AvPWz1W6ZCtnxFUl+MrwXVB4fiZ42Y/s6HksyvE8mI3obok2A3?= =?us-ascii?Q?cI1d9TgF56rO38eISFtao/8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 753df7ea-19c2-4ea7-abe4-08d9a26d0cec X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2021 04:05:50.0413 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JpKozLeBW3b6M+uS9DATJomw3V+MCcZUkD1IexC3Mx8+KReAqpKTMWAFaTumk8K97Tida0Xn6D9nVjiGYZz2Fg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4814 X-Proofpoint-ORIG-GUID: GyWwzjn_rlW4EnwvY4QSdt9kucRVQOvx X-Proofpoint-GUID: GyWwzjn_rlW4EnwvY4QSdt9kucRVQOvx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-08_01,2021-11-03_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/cryptodev: fix incomplete data length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kai, Patch looks good. Wondering if we need same fix in functions such as " test= _zuc_auth_cipher()". We were also hitting this issue when we enabled few additional features in = Marvell PMDs. Upon investigation, we realized that this issue would come up= for certain packet size combinations if the padded lengths are not same. W= e observed the issue only with test_mixed_auth_cipher(), which is getting a= ddressed with this patch. Just wondering if you have checked whether other = places also would need a fix. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Kai Ji > Sent: Friday, November 5, 2021 9:12 PM > To: dev@dpdk.org > Cc: Kai Ji ; pablo.de.lara.guarch@intel.com; > adamx.dybkowski@intel.com > Subject: [EXT] [dpdk-dev] [dpdk-dev v1] test/cryptodev: fix incomplete da= ta > length >=20 > External Email >=20 > ---------------------------------------------------------------------- > This patch fixes incorrect data lengths computation in cryptodev unit tes= t. > Previously some data lengths were incorrectly set, which was insensitive = for > crypto op unit tets but is critical for raw data path API unit tests. The= patch > addressed the issue by setting the correct data lengths for some tests. >=20 > Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless algorithms") > Cc: pablo.de.lara.guarch@intel.com >=20 > Fixes: e847fc512817 ("test/crypto: add encrypted digest case for AES-CTR- > CMAC") > Cc: adamx.dybkowski@intel.com >=20 > Signed-off-by: Kai Ji > --- > app/test/test_cryptodev.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > 52457596e2..b926412742 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -4102,9 +4102,9 @@ test_kasumi_decryption(const struct > kasumi_test_data *tdata) >=20 > /* Create KASUMI operation */ > retval =3D create_wireless_algo_cipher_operation(tdata- > >cipher_iv.data, > - tdata->cipher_iv.len, > - tdata->ciphertext.len, > - tdata->validCipherOffsetInBits.len); > + tdata->cipher_iv.len, > + RTE_ALIGN_CEIL(tdata->validCipherLenInBits.len, 8), > + tdata->validCipherOffsetInBits.len); > if (retval < 0) > return retval; >=20 > @@ -7335,6 +7335,7 @@ test_mixed_auth_cipher(const struct > mixed_cipher_auth_test_data *tdata, > unsigned int plaintext_len; > unsigned int ciphertext_pad_len; > unsigned int ciphertext_len; > + unsigned int data_len; >=20 > struct rte_cryptodev_info dev_info; > struct rte_crypto_op *op; > @@ -7395,21 +7396,22 @@ test_mixed_auth_cipher(const struct > mixed_cipher_auth_test_data *tdata, > plaintext_len =3D ceil_byte_length(tdata->plaintext.len_bits); > ciphertext_pad_len =3D RTE_ALIGN_CEIL(ciphertext_len, 16); > plaintext_pad_len =3D RTE_ALIGN_CEIL(plaintext_len, 16); > + data_len =3D RTE_MAX(ciphertext_pad_len, plaintext_pad_len); >=20 > if (verify) { > ciphertext =3D (uint8_t *)rte_pktmbuf_append(ut_params- > >ibuf, > - ciphertext_pad_len); > + data_len); > memcpy(ciphertext, tdata->ciphertext.data, ciphertext_len); > if (op_mode =3D=3D OUT_OF_PLACE) > - rte_pktmbuf_append(ut_params->obuf, > ciphertext_pad_len); > + rte_pktmbuf_append(ut_params->obuf, data_len); > debug_hexdump(stdout, "ciphertext:", ciphertext, > ciphertext_len); > } else { > plaintext =3D (uint8_t *)rte_pktmbuf_append(ut_params- > >ibuf, > - plaintext_pad_len); > + data_len); > memcpy(plaintext, tdata->plaintext.data, plaintext_len); > if (op_mode =3D=3D OUT_OF_PLACE) > - rte_pktmbuf_append(ut_params->obuf, > plaintext_pad_len); > + rte_pktmbuf_append(ut_params->obuf, data_len); > debug_hexdump(stdout, "plaintext:", plaintext, > plaintext_len); > } >=20 > -- > 2.17.1