RE: [EXT] [PATCH v1 1/1] net/qede: fix redundant condition in debug code

[Rasesh Mody <rmody@marvell.com>]

> From: Anatoly Burakov <anatoly.burakov@intel.com>
> Sent: Tuesday, November 30, 2021 10:29 PM
> 
> External Email
> 
> ----------------------------------------------------------------------
> Expression "a && 1" is equivalent to just "a", so fix the accidental inclusion of
> a literal in code.
> 
> Cc: stable@dpdk.org
> 
> Fixes: ec55c118792b ("net/qede: add infrastructure for debug data
> collection")
> Cc: rmody@marvell.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Acked-by: Rasesh Mody <rmody@marvell.com>

Thanks! 

> ---
> 
> Notes:
>     This isn't a bug, this is just a syntactic anomaly, likely a remnant of some
>     kind of debugging code.
> 
>     This issue was found with Control Flag [1], which i ran on DPDK codebase
> just
>     out of curiosity. This was the only issue worth addressing that the tool
>     produced output for.
> 
>     [1] https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_IntelLabs_control-
> 2Dflag&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=Vhi2FR3R84xPMUtUhj
> NPxoiMSxcj1IW0xDKEoZ0F00o&m=OrZLdoVFyT0inpO-NpRW-
> bqCiG9lrnzODBoic5Pwb8qrKh_6y0JbHFKrzJ6vHBQH&s=d76wgQiSey5O9D5N7
> HhUGNvReAzVZpe4wmjHgXhJI78&e=
> 
>  drivers/net/qede/qede_debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/qede/qede_debug.c
> b/drivers/net/qede/qede_debug.c index 2297d245c4..ba807ea680 100644
> --- a/drivers/net/qede/qede_debug.c
> +++ b/drivers/net/qede/qede_debug.c
> @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct
> ecore_hwfn *p_hwfn,
> 
>  	/* Dump MCP HW Dump */
>  	if (qed_grc_is_included(p_hwfn,
> DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&
> -	    !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) &&
> 1)
> +	    !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))
>  		offset += qed_grc_dump_mcp_hw_dump(p_hwfn,
>  						   p_ptt,
>  						   dump_buf + offset, dump);
> --
> 2.25.1