From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D018BA0351; Mon, 10 Jan 2022 09:43:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E9B2411F3; Mon, 10 Jan 2022 09:43:48 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 699E14013F; Mon, 10 Jan 2022 09:43:46 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 209NU61u022025; Mon, 10 Jan 2022 00:43:45 -0800 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dg7nksk9m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jan 2022 00:43:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LECro93CGLKWtqxW24z3+OAr0if0DUkDlOWWJ8hh/89QUjEjX9TxLVVHkpD7+uKue6tmgvORk5QUXsSeV/PSuxAR2DMzw1aWOI3YuWm8XXjG0asLc/qFvganQOw0Ibh60bZOP9Wk5RyEsd3rYE+Qc3LLWFzBlVJ9F0geTo3J/WHJGiFTRtRJScI7CA4vIthaMO/jorWBWKJH3mVRIzNR9INefbXjQ/Kt1fTsBGr5s/SqAzD7uH9u08x2DtNEB0O/yXJ30DTL6MUE4TJ9Xf5zrWqFuvSlaASjaZkcAPGNB6k/siVPoMPs4Rn8c9wAiuyxWKrXzQgERIPMly9SyLrJZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KWWgN/WRYxtiAJdS6RkaJmH8gBqqDamN1IGTQWA3v2M=; b=jbvxaD6u3TudLdyi0uxo+LA6w2946ns8K9UbGpgPtDKafrvxYlYvfWDgVmC/RfltigWPQ1V+OQtsY53AXsxG7IvblEi0uQ2maUnxe8XKfl7/R1TxwyFhHzkh3kwsYljECDuSW3ErUgfc7M3slF/uHQRU2OcdvNH9ztSsjagWs39BEYfgCccdEryF7v5/Sa3SPZzh6m8Dk99TVbg2EGIsoGUVL6cZrjfkp8Oh2V4EQO5z9ExEzj8zY0tbaE/+iOscqaBM43Cqe8cktj4ztwSTutTp8wDrUPox6KhL9RmqHO116RPdV2fR7baD4+8IdnbCuR5qB+DU2KleZzKmWI6p9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KWWgN/WRYxtiAJdS6RkaJmH8gBqqDamN1IGTQWA3v2M=; b=rT8JQDS13/8AG7+1J8umhUMkMkQMeXYNQH5PvarjBR+ZdcBCZMb4cp/XoLfe47rv44/U1iUfArkTp+wsN1IR4xjHwbj7lABot3POr3aZda9PGrDrhWV8/WqGtU/JDNuulbxR0r8Znzl5j2LEjbWbH39NfLzD0GH/u+4aOkbthCI= Received: from PH0PR18MB4832.namprd18.prod.outlook.com (2603:10b6:510:cc::5) by PH0PR18MB4972.namprd18.prod.outlook.com (2603:10b6:510:11f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Mon, 10 Jan 2022 08:43:41 +0000 Received: from PH0PR18MB4832.namprd18.prod.outlook.com ([fe80::2da1:71f3:4285:57a1]) by PH0PR18MB4832.namprd18.prod.outlook.com ([fe80::2da1:71f3:4285:57a1%6]) with mapi id 15.20.4867.012; Mon, 10 Jan 2022 08:43:41 +0000 From: Rasesh Mody To: 'Anatoly Burakov' , "dev@dpdk.org" , Devendra Singh Rawat , Igor Russkikh CC: "stable@dpdk.org" Subject: RE: [EXT] [PATCH v1 1/1] net/qede: fix redundant condition in debug code Thread-Topic: [EXT] [PATCH v1 1/1] net/qede: fix redundant condition in debug code Thread-Index: AQHX5guy6/hb/FLMtUqdqDMMPjTVM6xcL8Gg Date: Mon, 10 Jan 2022 08:43:41 +0000 Message-ID: References: <7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com> In-Reply-To: <7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8956e7c7-5079-4afd-b617-08d9d4154dea x-ms-traffictypediagnostic: PH0PR18MB4972:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gsur0/TqC6bJDQv1qlzQUgMPJsYvR3ChSvg5YueXugk2SH88HetGMOx9TGYqg29JkjCp8BF4mlJjK0FQO+ZhTWO9dQODJWRvGBvTQRxLBi88xZsa3zftOocmlyZdJGangkzUtp3DlIaqDaEmUsgbBKsGJztKBuOjuQHw29WEcEF0u8KyHMDyr4Bzh4Wkz8COh3JMcpeI447ptuop3t6mfqZeaES9RK9T7dfHtG/5Tm2SNDlEz3Ha6x+mQmQAxAL42FXO9YMufdE19+xG6tu1oMF20nt3GKUTS25vWXqhO8obzzKHmB9+8n7u36Nu03cNJzEVnZmS8kxi7loJM93oAsw5YovF2CnZ/F+bKO8IHCk2W4wCKoTaTD+DKPOB7FI/T1hMeRZ3Sv1XbKN9mEYCQXXfXRpQXu1RSxe9dQ59ZMVG1drqJVE+RkUPNnwwawCoDs7Hr8cucpjco4rWytt6iw+yZwgygutM18CVQZeVxGEPhFj7dYvSQBl49fYv/518nDwk/hcPTQHvNZZHHQ5O4HUeioaSLTElWMXXLuqWjKX7lHNT+U+RZcbpuuG4UIiVE8q2v6Lfum0uEQN1qqvmRJB9E3YYixU+i2s/rWboGHuO7YHYXd4CN9x+dcNYFAcFmkXTTh97frW9XvoCiVp9TbzzzPsu7vCZhJiL5iXZ4TXn7n9e4ryP85IHYA/CK3eHyU4MosTVdegChsXTQjboUSkK7A0rOeb6KqGqXW0A7sOVvcKEL1IEmUsNRvwysnhTz+fGcRf5OaxcgnGtb2s9iA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4832.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38070700005)(110136005)(9686003)(5660300002)(122000001)(966005)(66476007)(66446008)(4326008)(26005)(508600001)(19627235002)(6506007)(2906002)(38100700002)(52536014)(316002)(66946007)(76116006)(71200400001)(8676002)(7696005)(8936002)(55016003)(64756008)(6636002)(83380400001)(66556008)(86362001)(33656002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oWhCcBIRXqxjswWOzFclW3nlVx3K2nwVhK7GfcFWZKCMQsEVoXlPek3oN/sM?= =?us-ascii?Q?bGm/oDNBeHM7n/RmpJcrsAG9vEugSW5vB0ztSElVnWBxgZX5CE5jGbpGqZpS?= =?us-ascii?Q?pcppi3nlC+ikeN6fxTwzFI/SX2dEgEIwf3buL7y2grliZSGuMNI8oPYA8w84?= =?us-ascii?Q?6WLl4ny7aB5wiHqdIm0oSwfq8TFxCczVLkfcRWl8ag8FOPmn99phNoRyqepb?= =?us-ascii?Q?Ryjvl/ACokB9DgdX9+Vh0/uVKGP/ZGttR/oZT3Q3GVuwNMc0wetALo+eTY5a?= =?us-ascii?Q?nPBJypdGos/STVV4aRH56LecZAQgSIaXI6nmtcMKYmeJ4KQUg9a6YOdaVpOH?= =?us-ascii?Q?0MW5uNKw64px490oNZXqIUcreEDq20F2VIBFMwDrsliutv4iilRgRT6tsS4l?= =?us-ascii?Q?lXjDhtYCPQATMWaCU5xZNBjnMtBi0pMrbFEsBp88jWiBPjrfDeMY02lZv2fL?= =?us-ascii?Q?6DToVbPB8cOyeQ4oPCogSl+fMJs7sjxiR9e6ALAqF8guKZeNBFmy3ydrStgn?= =?us-ascii?Q?1NaG4hqhZbp2Yao42FTvPxVhEmFyFcqg+d6O6YI9bCDpYzHviLoVY/5CTZKQ?= =?us-ascii?Q?lmSoj25dmH5SohU/iobSx1Vmi0QuSud2H4eboPM50T6edYaPlTof/vHeu45P?= =?us-ascii?Q?wAReeIi1l1fbSkEpJJs/UV8tU11eFaDSvxN7Xr9ih1+gQbRbtkvUuGTPxBb9?= =?us-ascii?Q?kgCXj/LX2/SzwhxJDrBnJjp54uwRikybEAv+cwiov8zI3lxVt9/TmzjqbYiE?= =?us-ascii?Q?KPSMF5gRC8ZTHtRV6tjqiSO/omAbC3br51pDyameibSif0upO3AdixL2iJZE?= =?us-ascii?Q?sRN8W2oCqVPaySg8wwsUDYGnryB1zukxYk77KP3Fe5yGzmNu4uqYvhuK8ykN?= =?us-ascii?Q?5PZtBP/QnZrnQhY+oXUuiLbZhqKk9HgPaHyIhUi3+A++Mb2PFeMeMCjnxYzY?= =?us-ascii?Q?RYfZI9qfeUtm8Fs8cBATMPia69Vt34DRUOS+PwxnSwyyOmYRrMciH1rLMYmB?= =?us-ascii?Q?+JEvwrxHnSiWPpxajEaeFPMHCV3Vh3/uGnXsnDu+YpU/lMpSq0TMaZC4kJfA?= =?us-ascii?Q?4pujGFxTOJSgxpCQ00aKPar1S8Z8ugW9R15STHwF/gX/AwvNw4Fd3KOaQnDp?= =?us-ascii?Q?cV636rzu53ogXDq80ft9J3q+c6o25GHELZb/6r5UQTDOSqYwKjiE9g/h0atz?= =?us-ascii?Q?prYH0ptRQ2d/D9KW8j5+R9a08wcZMa19lmgqHmRrHmC+TYOmrAwUeqYIjAS4?= =?us-ascii?Q?5eh0pq6Er1IpOEEiE+YEeWfQzPPktSu4HdHeIiUzEFnyfCuxN20ZPJNusspV?= =?us-ascii?Q?kXNpBMnsmvryLE8+ELyvigniuihcCzKDTDr9XCCKJY6uL3ka75WDTTxg4tjF?= =?us-ascii?Q?DHrUszoqCU0rYmGvmUrsXmsSca24rTHWrij/MfFxP/HQ2Y8HVfDp6KStB/Ri?= =?us-ascii?Q?xINjBGZrNJN1PaiRj92B4eXiN6smly4hNAQCuBbzR+Rv3ytZaja0rNeX2tBw?= =?us-ascii?Q?AwSn9Wg+RQ+laDZzbf/bymLys7EaYQZcLuOPQ6runA+kstWLg+Zn6cas0/i9?= =?us-ascii?Q?IsojWIJ+t0bpXDYcCtF1LN5b4P87E1/6y/+LAq2VQJT46MOb1sZT/GZi5O/a?= =?us-ascii?Q?JQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4832.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8956e7c7-5079-4afd-b617-08d9d4154dea X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 08:43:41.4703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W/COveGE7Y4RwOqERIoodo6wEtfiv93SbQeTWlcjAJ3vuUKeG7BeSiIYtM3YQKSJWQVQKeyXu8rTiB4qLbIVQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4972 X-Proofpoint-GUID: RXwpepU0mu7KgNqc55y67zp2RPLqppwo X-Proofpoint-ORIG-GUID: RXwpepU0mu7KgNqc55y67zp2RPLqppwo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-10_03,2022-01-07_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > From: Anatoly Burakov > Sent: Tuesday, November 30, 2021 10:29 PM >=20 > External Email >=20 > ---------------------------------------------------------------------- > Expression "a && 1" is equivalent to just "a", so fix the accidental incl= usion of > a literal in code. >=20 > Cc: stable@dpdk.org >=20 > Fixes: ec55c118792b ("net/qede: add infrastructure for debug data > collection") > Cc: rmody@marvell.com >=20 > Signed-off-by: Anatoly Burakov Acked-by: Rasesh Mody Thanks!=20 > --- >=20 > Notes: > This isn't a bug, this is just a syntactic anomaly, likely a remnant = of some > kind of debugging code. >=20 > This issue was found with Control Flag [1], which i ran on DPDK codeb= ase > just > out of curiosity. This was the only issue worth addressing that the t= ool > produced output for. >=20 > [1] https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__github.com_IntelLabs_control- > 2Dflag&d=3DDwIDAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DVhi2FR3R84xPMUtUhj > NPxoiMSxcj1IW0xDKEoZ0F00o&m=3DOrZLdoVFyT0inpO-NpRW- > bqCiG9lrnzODBoic5Pwb8qrKh_6y0JbHFKrzJ6vHBQH&s=3Dd76wgQiSey5O9D5N7 > HhUGNvReAzVZpe4wmjHgXhJI78&e=3D >=20 > drivers/net/qede/qede_debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/qede/qede_debug.c > b/drivers/net/qede/qede_debug.c index 2297d245c4..ba807ea680 100644 > --- a/drivers/net/qede/qede_debug.c > +++ b/drivers/net/qede/qede_debug.c > @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct > ecore_hwfn *p_hwfn, >=20 > /* Dump MCP HW Dump */ > if (qed_grc_is_included(p_hwfn, > DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) && > - !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && > 1) > + !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP)) > offset +=3D qed_grc_dump_mcp_hw_dump(p_hwfn, > p_ptt, > dump_buf + offset, dump); > -- > 2.25.1