From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86CCE42B3A; Thu, 18 May 2023 15:45:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 238B940E25; Thu, 18 May 2023 15:45:36 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 86F7F4014F for ; Thu, 18 May 2023 15:45:34 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34I96ehu025565; Thu, 18 May 2023 06:45:33 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3qmyexc7yd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 May 2023 06:45:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nf5XdIpuMyl5WYa+oCvSxnZ4kndFV4Bivhjpm13WZkHSb6zotv++7K/KGOz0H1k+Smp4DLpZeteyhz50qcCAq5Q2FqMw/QfT7KbaXnJkTJu3Djw7MqSQl60dtQ5uMiU3RpiaJrUcAWqV+Nxnv2klW0vQ14QPXweTNS9SRQ4R8hhXk5YaJ8O3WqkSsSHkAZ6oHiSiVkoqDHOXquLvsvXkUnU8HDc6a/FVlUKo6fLSCFyF7WsiW1HE4wMthVpkOG2pglrWDSpOz5tkfZDBUJZMaKwjJFmvWrzyMZxyA19HF096Iuiz5GcmBUv9bwC6G5MuT2vclfGwi1ljh+2N3rKUQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FoOTfhcFwvAOaP4f4IOSZxEjH0WO9H04+cvqteftV6E=; b=W9G6KyRyvAdjZNuV1QUtK0Vki8Zc34by2m3VBJ58S3y56+QO4S8qlMKf7cJZbhVLANzkYfAUSkng0PAavoH02EBhFpX8HhvoO/WEL3w8vJ3kX0XgeGuxyn3byuf3WkHPdsgE/HrCZTIHK0N5fmE6cGcmGzm9APxPrgsdk6LGYXLoSA1ljjZ7isIOQS9VJab5Cclk5PyDPTF+GETFHEWhWxl0za1w7gPk+VT7pt8AVs4ODBxBc5sZ15wXGqGg4/sD4PrNONzUJHfdZmhlj+pEWGQdjx49IJuwSHA28jp4OK/eQBbTOFd/w6dS2eQ6/LIUXG/LLPOHzNLZ5qaE8b2U6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FoOTfhcFwvAOaP4f4IOSZxEjH0WO9H04+cvqteftV6E=; b=UcEmgbdAw+jZKb2oAQDazYTejwGsQzOBkGE9HPToahznw1l0UuksKMVNM3mOovqYediaQo+Bs3GvbvkChztSM3Mji+Du/W44+UZELgtUHX+pMpBNDUVPXpyfQFtShoBlCWhulc1NivIXDXtkIS1U5BnfetVUwEp3ZV5+7TbBURs= Received: from PH0PR18MB5003.namprd18.prod.outlook.com (2603:10b6:510:11e::10) by MN2PR18MB3312.namprd18.prod.outlook.com (2603:10b6:208:168::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 13:45:29 +0000 Received: from PH0PR18MB5003.namprd18.prod.outlook.com ([fe80::2adc:db61:a6f8:c0c5]) by PH0PR18MB5003.namprd18.prod.outlook.com ([fe80::2adc:db61:a6f8:c0c5%4]) with mapi id 15.20.6387.030; Thu, 18 May 2023 13:45:29 +0000 From: Ankur Dwivedi To: Thomas Monjalon CC: Jerin Jacob Kollanukkaran , "dev@dpdk.org" Subject: RE: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch Thread-Topic: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch Thread-Index: AQHZUO0mo8TXvfdXGk+LLoGksad4va9ge39A Date: Thu, 18 May 2023 13:45:29 +0000 Message-ID: References: <20230303155811.2751210-1-adwivedi@marvell.com> <20230307120514.2774917-1-adwivedi@marvell.com> <20230307120514.2774917-2-adwivedi@marvell.com> In-Reply-To: <20230307120514.2774917-2-adwivedi@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYWR3aXZlZGlc?= =?us-ascii?Q?YXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRi?= =?us-ascii?Q?YTI5ZTM1Ylxtc2dzXG1zZy0zYzZkNjBiOC1mNTgyLTExZWQtOTU0NS1lODZh?= =?us-ascii?Q?NjQyNWYwOTJcYW1lLXRlc3RcM2M2ZDYwYmEtZjU4Mi0xMWVkLTk1NDUtZTg2?= =?us-ascii?Q?YTY0MjVmMDkyYm9keS50eHQiIHN6PSI4Nzc3IiB0PSIxMzMyODg5MTEyMzY5?= =?us-ascii?Q?MTM5NTgiIGg9IlZLbFFPU0h6TWlUcGlGc2FubFYwVm5OQlBtYz0iIGlkPSIi?= =?us-ascii?Q?IGJsPSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQU1nTUFB?= =?us-ascii?Q?QW1XOGIram9uWkFleEdHTDdzWDdjRDdFWVl2dXhmdHdNVUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFIQUFBQUJZREFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFFQUFRRUJBQUFBNCtVdERBQ0FBUUFBQUFBQUFBQUFBSjRBQUFCaEFHUUFa?= =?us-ascii?Q?QUJ5QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4QWNB?= =?us-ascii?Q?QmxBSElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FB?= =?us-ascii?Q?QUFBQUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VBYmdC?= =?us-ascii?Q?MUFHMEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhV?= =?us-ascii?Q?QWN3QjBBRzhBYlFCZkFITUFjd0J1QUY4QVpBQmhBSE1BYUFCZkFIWUFNQUF5?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFH?= =?us-ascii?Q?TUFkUUJ6QUhRQWJ3QnRBRjhBY3dCekFHNEFYd0JyQUdVQWVRQjNBRzhBY2dC?= =?us-ascii?Q?a0FITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWXdCMUFITUFkQUJ2QUcw?= =?us-ascii?Q?QVh3QnpBSE1BYmdCZkFHNEFid0JrQUdVQWJBQnBBRzBBYVFCMEFHVUFjZ0Jm?= =?us-ascii?Q?QUhZQU1BQXlBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFB?= =?us-ascii?Q?QUFBSUFBQUFBQUo0QUFBQmpBSFVBY3dCMEFHOEFiUUJmQUhNQWN3QnVBRjhB?= =?us-ascii?Q?Y3dCd0FHRUFZd0JsQUY4QWRnQXdBRElBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FB?= =?us-ascii?Q?QUdRQWJBQndBRjhBY3dCckFIa0FjQUJsQUY4QVl3Qm9BR0VBZEFCZkFHMEFa?= =?us-ascii?Q?UUJ6QUhNQVlRQm5BR1VBWHdCMkFEQUFNZ0FBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFaQUJzQUhBQVh3QnpB?= =?us-ascii?Q?R3dBWVFCakFHc0FYd0JqQUdnQVlRQjBBRjhBYlFCbEFITUFjd0JoQUdjQVpR?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCa0FHd0FjQUJm?= =?us-ascii?Q?QUhRQVpRQmhBRzBBY3dCZkFHOEFiZ0JsQUdRQWNnQnBBSFlBWlFCZkFHWUFh?= =?us-ascii?Q?UUJzQUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVB?= =?us-ascii?Q?QUFBQUFBQUFBZ0FBQUFBQW5nQUFBR1VBYlFCaEFHa0FiQUJmQUdFQVpBQmtB?= =?us-ascii?Q?SElBWlFCekFITUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQndBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFB?= =?us-ascii?Q?QUNlQUFBQWJRQmhBSElBZGdCbEFHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFG?= =?us-ascii?Q?OEFiZ0JoQUcwQVpRQnpBRjhBY2dCbEFITUFkQUJ5QUdrQVl3QjBBR1VBWkFC?= =?us-ascii?Q?ZkFHRUFiQUJ2QUc0QVpRQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNn?= =?us-ascii?Q?QjJBR1VBYkFCZkFIQUFjZ0J2QUdvQVpRQmpBSFFBWHdCdUFHRUFiUUJsQUhN?= =?us-ascii?Q?QVh3QnlBR1VBY3dCMEFISUFhUUJqQUhRQVpRQmtBRjhBYUFCbEFIZ0FZd0J2?= =?us-ascii?Q?QUdRQVpRQnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?RUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdC?= =?us-ascii?Q?aEFISUFiUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFB?= =?us-ascii?Q?QUFBQ2VBQUFBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJq?= =?us-ascii?Q?QUhRQVh3QmpBRzhBWkFCbEFITUFBQUFBQUFB?= x-dg-refthree: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFB?= =?us-ascii?Q?SUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QWNBQnlBRzhBYWdC?= =?us-ascii?Q?bEFHTUFkQUJmQUdNQWJ3QmtBR1VBY3dCZkFHUUFhUUJqQUhRQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcw?= =?us-ascii?Q?QVlRQnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFGOEFiZ0Jo?= =?us-ascii?Q?QUcwQVpRQnpBRjhBY2dCbEFITUFkQUJ5QUdrQVl3QjBBR1VBWkFCZkFHMEFZ?= =?us-ascii?Q?UUJ5QUhZQVpRQnNBR3dBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dB?= =?us-ascii?Q?YkFCZkFIQUFjZ0J2QUdvQVpRQmpBSFFBWHdCdUFHRUFiUUJsQUhNQVh3QnlB?= =?us-ascii?Q?R1VBY3dCMEFISUFhUUJqQUhRQVpRQmtBRjhBYlFCaEFISUFkZ0JsQUd3QWJB?= =?us-ascii?Q?QmZBRzhBY2dCZkFHRUFjZ0J0QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFB?= =?us-ascii?Q?QUFJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdVQWJBQnNBRjhBZEFCbEFISUFi?= =?us-ascii?Q?UUJwQUc0QWRRQnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFB?= =?us-ascii?Q?RzBBWVFCeUFIWUFaUUJzQUd3QVh3QjNBRzhBY2dCa0FBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: QUFBQUFBQUFBQVFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUE9Ii8+PC9tZXRhPg== x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5003:EE_|MN2PR18MB3312:EE_ x-ms-office365-filtering-correlation-id: a45c2835-0aec-409d-6286-08db57a624af x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tVnc5wBjZTnz+wjwSUyH6UstjHbnwjLGz68DHBIRg7BZD7EmB6uw+IILX8OcWgp7jrsph/rvY12YQluw9yz4vI8Ry8n2CpWl5aPvBcfaWkWfLouvswNvwkhARwkieG171cKAbNjvXJPrCO4iCkRz5+m3PeUSbPnKoiRUi1WtrOVieGCbNPMSnEt504WDklABSUNj5F4GntFVereDmHnMtbK3r+7q70WQIh0jey53HRXzlzBot90cEYS3zIzU6V43a7yOL6KgviCtQMAM8drUR7vQN0XSebGJJ13HX8loCErckCmQgb1EKY5qN0jdkgkW6GfTPSgvua6f7HjVTQI13s1WxMt/wBf2RUbppFJiF3hP+cDPsMh1G2kpppQuxmbbxM/AJTiGOtPDjVXfBstvSTxuP6zaHE/udI6UeTaZKPbmjgoWQiYo/ZT4XRh2Cxtg0GiYP6n3oCU2XHtckbkREhuV6didE/m+sKXnzPWSy0dCuOFg45uiIRtD8qr+8INjkYKw9QuUFiTmUpdYELmUoPUsWGGQKEROyD8uCL+aiVZ3btigTVoXvXz9XFKItgXzFy47Uyx3h8F0aC3cWx+qdlCHiEcVr+lg5+O5l6NDCTzjjamKNFyDVyVc+OoVnqUR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5003.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(366004)(136003)(346002)(39860400002)(451199021)(76116006)(4326008)(6916009)(64756008)(66446008)(66476007)(316002)(66556008)(66946007)(2906002)(33656002)(86362001)(52536014)(26005)(5660300002)(8936002)(6506007)(186003)(9686003)(122000001)(83380400001)(8676002)(38070700005)(38100700002)(55016003)(71200400001)(54906003)(41300700001)(478600001)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/uSMkQz1do0Kd8PzeTg71C7pdO48eh11Cpy5CohLpwRvahyfyngdn+q/ywM/?= =?us-ascii?Q?uWSDq3X8etbxQgE6HnlTQGvDLzfghGdKkLTVpP+tObreNJjTvV5MlMR8TmEW?= =?us-ascii?Q?2sW6IPwxatS9TC8CSm1HdUEsw3Oixd9nZfF20avAYlpVuzaeJTSwyw/8+EgA?= =?us-ascii?Q?ZE24UlEebREGUxcrplnUuaf0sLFWZp9Rr9y8xJyrZAnETrtwzci9AzRDRyR0?= =?us-ascii?Q?8xWZTBLlVAdnrL7g8FKM71KjfS5yYGStt5KkZTDihd5jWvpBHq4C/pf42ZMu?= =?us-ascii?Q?+udzxZM9hYs1cHTBQLy2KVqx+wngaAQaBlxYzwMN+LQCjx/2h0Ezb4LR1bvo?= =?us-ascii?Q?lQFFyu2iydFkaNKBubJ8e9oeP9ThFUgyoIhUlMsmhEI1wOhTuBT4Ci5hEVRK?= =?us-ascii?Q?YEVed2bLyhp+uFo/rF7XTFinbyKCHvtHs97/ShPHzIsz22xHxG9ARM0GyfZv?= =?us-ascii?Q?VNGU1YTMcp7geOg708jKIUX0BPouPsEcq72fBfLZQvOy2Exg+6NU8a46FpGl?= =?us-ascii?Q?QwcKDcQOTF20atlNyEA10go81u4U+Qa+Te7+1TnzZxkGC2MWsTLC6SAjtsQa?= =?us-ascii?Q?+J6Vf/u/oCiKF04GA30rs6aFFi7WZvbYdrvKz5ptkAXgiRkxMYzClvJ0Zd/E?= =?us-ascii?Q?mASd+eXtw0WDcdmO4VrFXnDxdRdkPW0yaz28wbyhK6xkc0bHVqkD6qVKg7DE?= =?us-ascii?Q?e9mj/l28Ch7VKh2yEQOTJNc5J7S5yyQ9CeEEiHnVn7JB9AR8g5JeV9dI8IbE?= =?us-ascii?Q?eF1CPdemU4a1za1onyUjEQrlG1THpcv9HV6HJNGsdNZdKYvlZntbO0zImYc0?= =?us-ascii?Q?oflxzkX9ToZzSW8Th8wywmYUWKfrkrq78kVY9eIRJqJBBvUfxlhRxxW0TrV6?= =?us-ascii?Q?K5a8bP6SA8VHzoA97UshE3btE9p9FqXDNOe5lCQDsqh6DrkLX2XzvchQSfnQ?= =?us-ascii?Q?I9ZOtHbfWkdWcc6dD4JL6BiKWvCXics8Nt7Bbnt4wn+N0/RpqybtkRrE90mr?= =?us-ascii?Q?k8ACljmZ4xx0obYN7CFgJrk9/KvDxJBgK5cSS0w3kN53LxhAle8BdyFgblxA?= =?us-ascii?Q?AqMvvwOW4KvNdNYbOgA4a4GrpjaO5PYUsd8gtm3ZhMc8nJSYqCYmVmd1QnPu?= =?us-ascii?Q?5iJtSNPJNp+tCk6YTv01Fcqb7c1ADJax7madV5ZktAEjRnnsFHVljPz1eD+u?= =?us-ascii?Q?Et3THpfcTEL3qWTJA4Z0G3VuxP/79cZ4CodCNeYsZpwgxI7xUpM1GtMnwtAE?= =?us-ascii?Q?yKOnnWq7Pph47+SKze8/BMCGZyNavsx1tKYGVJbK4AbsPizxRIbGDC05uHsE?= =?us-ascii?Q?/QldCUWEFLvXHDK/TP55J3O4jssm/X1BwsQY2doWqx8+1grWDsN9Ok6q+KH0?= =?us-ascii?Q?yq0wCvGbnaWaZEbeI82LYwtaHILgu1vLBCMrQhHqnRcvghxDkTjKFaBXZqI6?= =?us-ascii?Q?8pT5LX46bRCEG2foD57Zbm/YrrKCzLEZBm0oOax1FsiBsYUMOa6wwwLr19bw?= =?us-ascii?Q?qodq85NfYEK/GvoCXFH4grJw+/3ZoJ6FSqMMuHtvky4VXmojswrAPEmNcEVB?= =?us-ascii?Q?vLcQfybKTEkm2nVGI12Y9gOf/itpCIDqzjJ9mufl?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5003.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a45c2835-0aec-409d-6286-08db57a624af X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 13:45:29.4610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wElO/vAKOnjhz0kIKiiU8U1Mp/1e3puLijy4EBcCYGCEcJRJq8ptT+YgOGqbs3GbbwpJc5DqWsp98e+S+UKVlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3312 X-Proofpoint-GUID: jJ6blEwaRrbRxlN-lIqqz03Kl7sptXQ8 X-Proofpoint-ORIG-GUID: jJ6blEwaRrbRxlN-lIqqz03Kl7sptXQ8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-18_10,2023-05-17_02,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, Please let me know if there is any feedback on this patch. Regards, Ankur >-----Original Message----- >From: Ankur Dwivedi >Sent: Tuesday, March 7, 2023 5:35 PM >To: dev@dpdk.org >Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran ; >Ankur Dwivedi >Subject: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch > >This patch adds a validation in checkpatch tool, to check if a tracepoint = is >present in any new function added in cryptodev, ethdev, eventdev and >mempool library. > >In this patch, the build_map_changes function is copied from check-symbol- >change.sh to check-tracepoint.sh. The check-tracepoint.sh script uses >build_map_changes function to create a map of functions. >In the map, the newly added functions, added in the experimental section a= re >identified and their definition are checked for the presence of tracepoint= . The >checkpatch return error if the tracepoint is not present. > >For functions for which trace is not needed, they can be added to >devtools/trace-skiplist.txt file. The above tracepoint check will be skipp= ed for >them. > >Signed-off-by: Ankur Dwivedi >--- > devtools/check-tracepoint.sh | 223 +++++++++++++++++++++++++++++++++++ > devtools/checkpatches.sh | 9 ++ > devtools/trace-skiplist.txt | 0 > 3 files changed, 232 insertions(+) > create mode 100755 devtools/check-tracepoint.sh create mode 100644 >devtools/trace-skiplist.txt > >diff --git a/devtools/check-tracepoint.sh b/devtools/check-tracepoint.sh n= ew >file mode 100755 index 0000000000..88d6b1fd53 >--- /dev/null >+++ b/devtools/check-tracepoint.sh >@@ -0,0 +1,223 @@ >+#!/bin/sh >+# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Neil Horman >+ # Copyright(C) 2023 Marvell. >+ >+selfdir=3D$(dirname $(readlink -f $0)) >+ >+# Library for trace check >+libdir=3D"cryptodev ethdev eventdev mempool" >+ >+# Functions for which the trace check can be skipped >+skiplist=3D"$selfdir/trace-skiplist.txt" >+ >+build_map_changes() >+{ >+ local fname=3D"$1" >+ local mapdb=3D"$2" >+ >+ cat "$fname" | awk ' >+ # Initialize our variables >+ BEGIN {map=3D"";sym=3D"";ar=3D"";sec=3D""; in_sec=3D0; in_map=3D0} >+ >+ # Anything that starts with + or -, followed by an a >+ # and ends in the string .map is the name of our map file >+ # This may appear multiple times in a patch if multiple >+ # map files are altered, and all section/symbol names >+ # appearing between a triggering of this rule and the >+ # next trigger of this rule are associated with this file >+ /[-+] [ab]\/.*\.map/ {map=3D$2; in_map=3D1; next} >+ >+ # The previous rule catches all .map files, anything else >+ # indicates we left the map chunk. >+ /[-+] [ab]\// {in_map=3D0} >+ >+ # Triggering this rule, which starts a line and ends it >+ # with a { identifies a versioned section. The section name is >+ # the rest of the line with the + and { symbols removed. >+ # Triggering this rule sets in_sec to 1, which actives the >+ # symbol rule below >+ /^.*{/ { >+ gsub("+", ""); >+ if (in_map =3D=3D 1) { >+ sec=3D$(NF-1); in_sec=3D1; >+ } >+ } >+ >+ # This rule identifies the end of a section, and disables the >+ # symbol rule >+ /.*}/ {in_sec=3D0} >+ >+ # This rule matches on a + followed by any characters except a >: >+ # (which denotes a global vs local segment), and ends with a ;. >+ # The semicolon is removed and the symbol is printed with its >+ # association file name and version section, along with an >+ # indicator that the symbol is a new addition. Note this rule >+ # only works if we have found a version section in the rule >+ # above (hence the in_sec check) And found a map file (the >+ # in_map check). If we are not in a map chunk, do nothing. If >+ # we are in a map chunk but not a section chunk, record it as >+ # unknown. >+ /^+[^}].*[^:*];/ {gsub(";","");sym=3D$2; >+ if (in_map =3D=3D 1) { >+ if (in_sec =3D=3D 1) { >+ print map " " sym " " sec " add" >+ } else { >+ print map " " sym " unknown add" >+ } >+ } >+ } >+ >+ # This is the same rule as above, but the rule matches on a >+ # leading - rather than a +, denoting that the symbol is being >+ # removed. >+ /^-[^}].*[^:*];/ {gsub(";","");sym=3D$2; >+ if (in_map =3D=3D 1) { >+ if (in_sec =3D=3D 1) { >+ print map " " sym " " sec " del" >+ } else { >+ print map " " sym " unknown del" >+ } >+ } >+ }' > "$mapdb" >+ >+ sort -u "$mapdb" > "$mapdb.2" >+ mv -f "$mapdb.2" "$mapdb" >+ >+} >+ >+find_trace_fn() >+{ >+ local fname=3D"$1" >+ >+ cat "$fname" | awk -v symname=3D"$2 *\\\(" ' >+ # Initialize the variables. >+ # The variable symname provides a pattern to match >+ # "function_name(", zero or more spaces can be present >+ # between function_name and (. >+ BEGIN {state=3D0; ln_pth=3D0} >+ >+ # Matches the function name, set state=3D1. >+ $0 ~ symname {state=3D1} >+ >+ # If closing parentheses with semicolon ");" is found, then it >+ # is not the function definition. >+ /) *;/ { >+ if (state =3D=3D 1) { >+ state=3D0 >+ } >+ } >+ >+ /)/ { >+ if (state =3D=3D 1) { >+ state=3D2 >+ ln_pth=3DNR >+ next >+ } >+ } >+ >+ # If closing parentheses and then opening braces is found in >+ # adjacent line, then this is the start of function >+ # definition. Check for tracepoint in the function definition. >+ # The tracepoint has _trace_ in its name. >+ /{/ { >+ if (state =3D=3D 2) { >+ if (ln_pth !=3D NR - 1) { >+ state=3D0 >+ next >+ } >+ while (index($0, "}") !=3D 2) { >+ if (index($0, "_trace_") !=3D 0) { >+ exit 0 >+ } >+ if (getline <=3D 0) { >+ break >+ } >+ } >+ exit 1 >+ } >+ } >+ ' >+} >+ >+check_for_tracepoint() >+{ >+ local patch=3D"$1" >+ local mapdb=3D"$2" >+ local skip_sym >+ local libname >+ local secname >+ local mname >+ local ret=3D0 >+ local pdir >+ local libp >+ local libn >+ local sym >+ local ar >+ >+ while read -r mname symname secname ar; do >+ pdir=3D$(echo $mname | awk 'BEGIN {FS=3D"/"};{print $2}') >+ libname=3D$(echo $mname | awk 'BEGIN {FS=3D"/"};{print $3}') >+ skip_sym=3D0 >+ libp=3D0 >+ >+ if [ "$pdir" !=3D "lib" ]; then >+ continue >+ fi >+ >+ for libn in $libdir; do >+ if [ $libn =3D $libname ]; then >+ libp=3D1 >+ break >+ fi >+ done >+ >+ if [ $libp -eq 0 ]; then >+ continue >+ fi >+ >+ for sym in $(cat $skiplist); do >+ if [ $sym =3D $symname ]; then >+ skip_sym=3D1 >+ break >+ fi >+ done >+ >+ if [ $skip_sym -eq 1 ]; then >+ continue >+ fi >+ >+ if [ "$ar" =3D "add" ] && [ "$secname" =3D "EXPERIMENTAL" ]; then >+ # Check if new API is added with tracepoint >+ find_trace_fn $patch $symname >+ if [ $? -eq 1 ]; then >+ ret=3D1 >+ echo -n "ERROR: New function $symname is >added " >+ echo -n "without a tracepoint. Please add a >tracepoint " >+ echo -n "or add the function $symname in " >+ echo "devtools/trace-skiplist.txt to skip this >error." >+ fi >+ fi >+ done < "$mapdb" >+ >+ return $ret >+} >+ >+trap clean_and_exit_on_sig EXIT >+ >+mapfile=3D`mktemp -t dpdk.mapdb.XXXXXX` >+patch=3D$1 >+exit_code=3D1 >+ >+clean_and_exit_on_sig() >+{ >+ rm -f "$mapfile" >+ exit $exit_code >+} >+ >+build_map_changes "$patch" "$mapfile" >+check_for_tracepoint "$patch" "$mapfile" >+exit_code=3D$? >+rm -f "$mapfile" >+ >+exit $exit_code >diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index >1dee094c7a..471db1d21b 100755 >--- a/devtools/checkpatches.sh >+++ b/devtools/checkpatches.sh >@@ -10,6 +10,7 @@ > . $(dirname $(readlink -f $0))/load-devel-config > > VALIDATE_NEW_API=3D$(dirname $(readlink -f $0))/check-symbol-change.sh >+VALIDATE_TRACEPOINT=3D$(dirname $(readlink -f $0))/check-tracepoint.sh > > # Enable codespell by default. This can be overwritten from a config file= . > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL to >a valid path @@ -386,6 +387,14 @@ check () { # > ret=3D1 > fi > >+ ! $verbose || printf '\nChecking API additions with tracepoint :\n' >+ report=3D$($VALIDATE_TRACEPOINT "$tmpinput") >+ if [ $? -ne 0 ] ; then >+ $headline_printed || print_headline "$subject" >+ printf '%s\n' "$report" >+ ret=3D1 >+ fi >+ > if [ "$tmpinput" !=3D "$1" ]; then > rm -f "$tmpinput" > trap - INT >diff --git a/devtools/trace-skiplist.txt b/devtools/trace-skiplist.txt new= file >mode 100644 index 0000000000..e69de29bb2 >-- >2.25.1