From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92623423A2; Tue, 10 Jan 2023 12:26:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B5EB40A8B; Tue, 10 Jan 2023 12:26:42 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 8244140687 for ; Tue, 10 Jan 2023 12:26:41 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30A8T2dr008041; Tue, 10 Jan 2023 03:26:40 -0800 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3my94tu4p4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Jan 2023 03:26:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nAJzyV1d+65m7NGw8ugKkYv6n8HHfZYXiXkgUp1UTUMfzB2vCUFFGYSk/DPv4WwU7j5J5msON6khW6mMJM/c15nR8I/CgnuHoWh6ZEZeR9u6hFSBlQQO86if1ZUX0DECfq23bZZRBX0KKGG/UYXsdef97hRj+E8QG+V1cC/l+M4szK9HWHerEvnCsOvlZ6+NIt2tU6H+hA72wD9oLmRy4xnoAtkXehy918qO4h69eS7dqBSHzUqkXUE8ElzFBNJN+LiSPzE+eAQ66V7/TfxIGkUhpu5NKmTpQiUooxqvS2YSe61erPFwD5euhOSPuNsKlJR6Fe2lVJch2rWYNjHchA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BED6UnL9AZWNbVzIhRdktmqLXDGQo6YHGJQnMtVb6/k=; b=Ad7cURat34/AJMNePm1EeRz9hImN063aUdd6SwixE4gQkq7HhbEr7IdEzGq72v0jdRo6/FNe/5d5znrVywGi2+aHD0l6B4CsQ2jqWxMKg8acFbs3Tvwjv0mcW3mPajwCbSRW7AvxFRkW/08lWvuItgIE77jmWnO9zzInhPftt2DLBh08SlLPVwo0g8glHidpp2XHakiX1iCO20I0J9VKDDlyM4kMO0lFiDaKUCkJX6sWexMUxDUPpjnVrEn48ejvUbZ7dDL9aYnvwLsHQ3w5Uny5cuE7NFl4ZmYtZQfy6IIDSv8zmCRUCaPd94iZZCIffBKrvcatrFOAtf7cTPoGKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BED6UnL9AZWNbVzIhRdktmqLXDGQo6YHGJQnMtVb6/k=; b=Jbrjfcx6O05OrxnPGI2+xDUfgkgoZFlijcD4PheENejli0+kEYEc8HhO615biJASf3HmKQR+RXvk+PPjd6zSUQpCED5eRdcjpGjsR3JLV/ICdg58YXsUc/RrpoaQCREAla1NEjRNIbwZtPyV/3anH7upQWyF33MwCjZPQ/wtKpY= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by DM8PR18MB4504.namprd18.prod.outlook.com (2603:10b6:8:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 11:26:37 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39%9]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 11:26:37 +0000 From: Amit Prakash Shukla To: Stephen Hemminger CC: Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "dev@dpdk.org" Subject: RE: [EXT] Re: [RFC PATCH] graph: add support for pcap trace for graph Thread-Topic: [EXT] Re: [RFC PATCH] graph: add support for pcap trace for graph Thread-Index: AQHZFsaJr4Wtltv21UGzXVMYgC9FP657rt0AgBWS/HCAAJHkgIAFypSA Date: Tue, 10 Jan 2023 11:26:37 +0000 Message-ID: References: <20221223120235.3171516-1-amitprakashs@marvell.com> <20221223084714.446ebc08@hermes.local> <20230106105655.3eaa6129@hermes.local> In-Reply-To: <20230106105655.3eaa6129@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW1pdHByYWth?= =?us-ascii?Q?c2hzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctYTMyMWI4MTAtOTBkOS0xMWVkLWI2Y2Qt?= =?us-ascii?Q?MDBlMDRjY2FkNzJiXGFtZS10ZXN0XGEzMjFiODEyLTkwZDktMTFlZC1iNmNk?= =?us-ascii?Q?LTAwZTA0Y2NhZDcyYmJvZHkudHh0IiBzej0iNTA5OSIgdD0iMTMzMTc4MjM1?= =?us-ascii?Q?OTQ3NjYzNzgzIiBoPSJueDRpWFJCSks1TExGNTEyYXA2WTlzTkZMYWM9IiBp?= =?us-ascii?Q?ZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFO?= =?us-ascii?Q?Z0hBQUNuUVhsbDVpVFpBVlI1TEoxTjZKaWxWSGtzblUzb21LVU1BQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCb0J3QUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBUUFCQUFBQTNUekZBQUFBQUFBQUFBQUFBQUFBQUo0QUFBQmhB?= =?us-ascii?Q?R1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFG?= =?us-ascii?Q?OEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFnQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdV?= =?us-ascii?Q?QWJnQjFBRzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?akFIVUFjd0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlB?= =?us-ascii?Q?TUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5n?= =?us-ascii?Q?QUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?us-ascii?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFC?= =?us-ascii?Q?dkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VB?= =?us-ascii?Q?Y2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?= =?us-ascii?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1?= =?us-ascii?Q?QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFB?= =?us-ascii?Q?bmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZB?= =?us-ascii?Q?RzBBWlFCekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFY?= =?us-ascii?Q?d0J6QUd3QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFH?= =?us-ascii?Q?Y0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQURnQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIUUFaUUJ5QUcwQWFRQnVBSFVBY3dBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBQT09Ii8+PC9tZXRhPg== x-dg-rorf: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|DM8PR18MB4504:EE_ x-ms-office365-filtering-correlation-id: 2210ba01-538b-4bee-5103-08daf2fd89ae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OrTHzHjkpSe+6r9Xqh/GTMe1Ne1uz13GAGcl8rKJDZjzrBIn9HEyEffanKww/45j7WXv+Um9PmA0C9MnfWGmjAdcrwEz9vDaiA+x6jFnXsgD4P4DjxdblvqdV9Rozm7IuDNXE4yBW86fmRQm1j2bnlFQGKVrvewGh2suf28bote8XDHIAEeUkzNnlhXkSsNVehjcCxpsl4tI/W0LxgwsSDRYIqxMl6ORL6CwSwpARE2sNMx5FgYTrI7f/Izqx9Cr1EojZebVo6bpPjRcitvnaLc33aIQoj6Aa6lsoNo7XPVRqVGf4xUHOD+K7o55rtzent/lybmC8Ytik/2rObGHZkTuPyccmkZu3j/HHlbXhlFuA4QbaiKWAIvcnB2/5bq63I0QbZHNluUfRmx1zvZ4liA75OWN46I6ewSSJ2sG+FmcjCCyxS/3/J37tOhKoMChjn9w0qgpuswQUIc6g6cVu2WLcLpQEyYWa3N+NgiU8LhrXFAfZe9cG2sws+EI3SJSJJSujMbpM0+r0SguMGXAuFAdhlhxTXZeW/Mk9NmhBgVfezM2qGcZzvHHhWoFajySUuyZZ8nbmQ573Eln9R6LwcVjkOFawO9q3ihEABjXOkypGQ2xlAuSl4LhDs/jldQ0z+UK0Fpm8qUHB7zoEzK3t1P+cGbvGMopFV1jVNFeVLbp6susN52/5VUvkFx1k3gbkn9qCSrsPjAAsiTe8FKPJg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(366004)(39860400002)(396003)(376002)(136003)(451199015)(86362001)(54906003)(66946007)(6916009)(41300700001)(8676002)(4326008)(66446008)(66476007)(66556008)(64756008)(76116006)(38100700002)(33656002)(122000001)(38070700005)(53546011)(71200400001)(186003)(6506007)(7696005)(478600001)(316002)(26005)(2906002)(52536014)(5660300002)(55016003)(8936002)(83380400001)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lFxE2q8msH7I2tQ1Q+8q1o7DjxVb9Ow6LGu0hnKAR632Gmdq7MScoklVpOMi?= =?us-ascii?Q?NPSU9lgAKw/ZwsntiLVySaBHNchr4qqjFJIpGnphOJdV26jjvK1CNc9/vjVM?= =?us-ascii?Q?y0gzfAIB9u+QDOHeWOQTH+CbGMxwweVJ2yFGf3bVr4AC2KiAEszo6isMpgQ/?= =?us-ascii?Q?pU2NZmOB92ak/+KD34Y4/b7jw8deXGL72/H42iiXLP3ykIjdEpV0BkhslMH9?= =?us-ascii?Q?OjBjJzGBwgauU50zGgIxYOz5hxXF87io73K/lX3M8jlRpqC4HB0RI2AAIgWw?= =?us-ascii?Q?t2PyL1vvuU+OQUAdjhSgCUfktUTA7geAvnwM9o7QbpmPyUU+qezpbCAmZw+P?= =?us-ascii?Q?EaX1u5J3v0WZe1Q/9QCEdBzNnCSobcAT3PfNV1JL1h50Rzt0BrQU5NUZdJIG?= =?us-ascii?Q?2rsUYYoi7NinJkJUx1UJCuYBTPQop6gzHsswArAaU6AU4vcHkncZ8/zTvRGx?= =?us-ascii?Q?RW5Bg+frJMpKY2Ot4jOHTGWvZxjXVetbZ2npZU6AX+iB6d+0dZ4f5n/xzGRI?= =?us-ascii?Q?XXfVbkr59lLmHKl6a0/WnajqLiG2Hvhyn+YdBQAoxs/wVtvqWccUqUWk3eon?= =?us-ascii?Q?EU3iea8VYSJJJ6GS0EtPZqFgpD+99WT8LI6QwNDWuuGjT4IGKywXFxqcrgP2?= =?us-ascii?Q?/KxyYxlTC9tO6KCnhwx/CPJf2AOLmPTexm59aWvuXS+rMmEeczkj0mkY4Eh3?= =?us-ascii?Q?yHi7473WgUnMwvcDf4oKvuGi/SfrjeqZSsfSkVnn+dQTUzzP16f3JfdQUjYt?= =?us-ascii?Q?wR5eWSd9LP/WRWBKkMLRPrLMjeod7CpSyUXmjdbnelHyw9nupnbDRLYQWfAq?= =?us-ascii?Q?4TjN4ETyLBZ8+gXOCRQzWKijbsMztrYI5JKapMCXBQby+DD8GN/++ZNFDNTf?= =?us-ascii?Q?30XRu68KB6osYWa5Mn4xwwIW7+ZZGe2WfC/L8c6dGDvn3EdwZkpcXK7CkyEs?= =?us-ascii?Q?6Xuqz9tGQQ01HTxdccOL3ypvWnyMAD2D0TcTVQe7ITngCFbN/pWSDbvA/ICi?= =?us-ascii?Q?Yzkq7aCySUavloiJEF4rXMQVubSv/TAysphaD92Wkvm9tBaixIeUyRBdAUCq?= =?us-ascii?Q?pO8mx3oMO3Mtcw9+z2uBe5kEFXVI5sHNJNoatL5VkF1lRrhwcKz7XVXFBiw/?= =?us-ascii?Q?4OJl2m3FuqyqHdEOHz5QZcjtYp00AMBe3qKJ6U/0+vqy0kjLmSEh4vIjmT7Q?= =?us-ascii?Q?qZUpu5EuvmpSJ+k1XckSy5fNL0FwvZXVqKZDI4ZpIPcJBlPVqvWzfyV2yyOW?= =?us-ascii?Q?rZJY7uAWGMn0yMazwpKtYYsifiUz7ncEPM2Lux+MubLBlWwG59DTfMb46PjD?= =?us-ascii?Q?6hbudort5UdN/ncxaEtcYmIGnAMUMjAYj6Adn7iB02P/rOgO4GxERbhviX9L?= =?us-ascii?Q?OxHNe688OdY9XCcxa9Z2jpghpaIqBs35tnwf9bxFkfIUCsf8eL50QF3bVV08?= =?us-ascii?Q?CyCyTZKnC3R8z0z8lG9eK0q9KmGmwUmDGnAdShKdrLWxLwgQdV8QkF9exspB?= =?us-ascii?Q?HiaFyBG/pjHhwRJvRKCnb/F9ovTwAUbHdRYsoTOPGC8ZBsAEGScnzgnk7Frj?= =?us-ascii?Q?zB4HO06jbFCovr0Dp1aa6hl0phEB7znAgGE51BXz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2210ba01-538b-4bee-5103-08daf2fd89ae X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2023 11:26:37.6583 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xX+uyvUQtdmVAyJ5YHn9perz6n1K8OYXDMKnLtfZ58hmkPt0y2f4CKbOU7DxnlZA63Sa1Ujeau9snF3JHVZGJTeGDTc35/imp53cw+drlcg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR18MB4504 X-Proofpoint-ORIG-GUID: 0zEw5rftLgTHvuKm2-DqNnKUNqMUMbkC X-Proofpoint-GUID: 0zEw5rftLgTHvuKm2-DqNnKUNqMUMbkC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-10_03,2023-01-10_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Stephen for the pointers. I will post next version of the patch with= the change. > -----Original Message----- > From: Stephen Hemminger > Sent: Saturday, January 7, 2023 12:27 AM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; dev@dpdk.org > Subject: Re: [EXT] Re: [RFC PATCH] graph: add support for pcap trace for > graph >=20 > On Fri, 6 Jan 2023 10:40:30 +0000 > Amit Prakash Shukla wrote: >=20 > > Thanks Stephen for the review. Sure, will use lib/pcapng. > > > > I see dpdk libpcapng adds most of the debugging data, however I would > like to add a node name to the packets which I am thinking of adding usin= g > 'comment' option under 'Enhanced Packet Block' . > > > > Please let me know if that's fine. > > > > Thanks, > > Amit Shukla > > > > > -----Original Message----- > > > From: Stephen Hemminger > > > Sent: Friday, December 23, 2022 10:17 PM > > > To: Amit Prakash Shukla > > > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > > > Kokkilagadda ; Nithin Kumar Dabilpuram > > > ; dev@dpdk.org > > > Subject: [EXT] Re: [RFC PATCH] graph: add support for pcap trace for > > > graph > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- > > > On Fri, 23 Dec 2022 17:32:35 +0530 > > > Amit Prakash Shukla wrote: > > > > > > > + > > > > + pcap_trace.file_descriptor =3D open(pcap_trace.file_name, > > > > + O_CREAT | O_TRUNC | O_WRONLY, > > > 0664); > > > > + if (pcap_trace.file_descriptor < 0) { > > > > + ret =3D 1; > > > > + goto done; > > > > + } > > > > + pcap_trace.n_pcap_data_written =3D 0; > > > > + > > > > + /* Write file header. */ > > > > + memset(&file_hdr, 0, sizeof(file_hdr)); > > > > + file_hdr.magic =3D 0xa1b2c3d4; > > > > + file_hdr.major_version =3D 2; > > > > + file_hdr.minor_version =3D 4; > > > > + file_hdr.time_zone =3D 0; > > > > + file_hdr.max_packet_size_in_bytes =3D ((1 << 16) - 1); > > > > + file_hdr.packet_type =3D pcap_trace.packet_type; > > > > + n =3D write(pcap_trace.file_descriptor, &file_hdr, sizeof(file_hd= r)); > > > > + if (n !=3D sizeof(file_hdr)) { > > > > + ret =3D 1; > > > > + goto done; > > > > + } > > > > + > > > > + while (pcap_trace.n_bytes > pcap_trace.n_pcap_data_written) { > > > > + int n =3D pcap_trace.n_bytes - > > > pcap_trace.n_pcap_data_written; > > > > + > > > > + n =3D write(pcap_trace.file_descriptor, > > > > > > NAK please use lib/pcapng rather than rolling your own pcap format > > > code >=20 > Something like this: >=20 > diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index > cb590ea0096c..216ad80f7ed6 100644 > --- a/lib/pcapng/rte_pcapng.c > +++ b/lib/pcapng/rte_pcapng.c > @@ -492,7 +492,8 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue, > const struct rte_mbuf *md, > struct rte_mempool *mp, > uint32_t length, uint64_t cycles, > - enum rte_pcapng_direction direction) > + enum rte_pcapng_direction direction, > + const char *comment) > { > struct pcapng_enhance_packet_block *epb; > uint32_t orig_len, data_len, padding, flags; @@ -552,6 +553,8 @@ > rte_pcapng_copy(uint16_t port_id, uint32_t queue, > optlen +=3D pcapng_optlen(sizeof(queue)); > if (rss_hash) > optlen +=3D pcapng_optlen(sizeof(uint8_t) + sizeof(uint32_t)); > + if (comment) > + optlen +=3D pcapng_optlen(strlen(comment)); >=20 > /* reserve trailing options and block length */ > opt =3D (struct pcapng_option *) > @@ -590,6 +593,10 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue, > &hash_opt, sizeof(hash_opt)); > } >=20 > + if (comment) > + opt =3D pcapng_add_option(opt, PCAPNG_OPT_COMMENT, > + comment, strlen(comment)); > + > /* Note: END_OPT necessary here. Wireshark doesn't do it. */ >=20 > /* Add PCAPNG packet header */ > diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h index > 6b8aaffc6e0f..98f35e8ea177 100644 > --- a/lib/pcapng/rte_pcapng.h > +++ b/lib/pcapng/rte_pcapng.h > @@ -126,6 +126,8 @@ enum rte_pcapng_direction { > * The timestamp in TSC cycles. > * @param direction > * The direction of the packer: receive, transmit or unknown. > + * @param comment > + * Optional: comment on packet > * > * @return > * - The pointer to the new mbuf formatted for pcapng_write > @@ -137,7 +139,8 @@ struct rte_mbuf * > rte_pcapng_copy(uint16_t port_id, uint32_t queue, > const struct rte_mbuf *m, struct rte_mempool *mp, > uint32_t length, uint64_t timestamp, > - enum rte_pcapng_direction direction); > + enum rte_pcapng_direction direction, > + const char *comment); >=20 >=20 > /**