From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C204423B5; Thu, 12 Jan 2023 10:57:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07BD240156; Thu, 12 Jan 2023 10:57:56 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 188D1400EF for ; Thu, 12 Jan 2023 10:57:54 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30C9dqxs021081; Thu, 12 Jan 2023 01:57:54 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2105.outbound.protection.outlook.com [104.47.58.105]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3n1k56ybvn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Jan 2023 01:57:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HbmN6di9RZ0QUt7gRgKlG4h2CRYNbBsV24ReVAOTh6SIBkL0QtL1xEKAHnJOItml2iQRtiQqnUDroPvfZY+Qh4g3qr/ot7neb6ujchNwXkU+KqsJv6qCeo9oGgIGMlsyjT2C1j83sFlPMwxVorIg0oDT99BxUV4XQnX8tFyVNKKabdeR6PzbBFCBNi0uLPojN5gPIHps//uYHiKRWAIoZX3fQKuRA7PCEUNndWwnIYda7Kokh4vURQo8bjCZclaGIzaycOWITrDVvcufElaAnIERCnkiy6v4vX4BEczx+pZtlwXSSDMiypmnIW6PIArVQBKgANE1vUMXkPs2VE/LSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zl1Et8sGv4hCBjzeLPazKJKiWA13AmgPvOTsTA1zv2Q=; b=cl7Ce5AE4twpZ/CliquKbJC2FI4TJYBWnLnXH5FBFj7JpHcjDkbe+A/W3CS1WTr84c9xubhqvhIyDQS9lZL+NoPme/bTq55MSueij8INb7Zsrv+BglRIwRoLDL4gOsT99nmO3cZ4KEwNcR/m9Q5m7sJ/xAJG1kD7AaCMQPBT3yg87+/s4S8c6r+Faw84gABOle7cIoyuxqAa2qKq7mJphOTzGH0DvT8oZARefj4q2xCrC9uh1VPWoFMoZYApWybOqySjH6rp8aBP0bD49OjQq4U9ctHhBEFYGqj3wx3HVehmHf21zyyV4DQa4X7mQ2y5+ZDOHXyQTiw4c40B45BvrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zl1Et8sGv4hCBjzeLPazKJKiWA13AmgPvOTsTA1zv2Q=; b=MdKycImKiC3S7NCmlclXV3SSMguxBcKwKv34l2p0/6aPm4J4oefkXlLr7OgPB84pbYoecOJb3IVQJrOtlX8iCM03FlrseaYPo4rFI5VWvq4a8Wond1ULVht6FwCENcMC83XfANSDbxl7tFHbVgEY+H4ur6IKiNxXyVbjf9kZfoM= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by CO3PR18MB4893.namprd18.prod.outlook.com (2603:10b6:303:171::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Thu, 12 Jan 2023 09:57:51 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39%9]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 09:57:51 +0000 From: Amit Prakash Shukla To: Stephen Hemminger CC: Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "dev@dpdk.org" Subject: RE: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes Thread-Topic: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes Thread-Index: AQHZJZpHUJe0oKVgaEyLCJWdD2XSaa6ZYlAAgAEoyhA= Date: Thu, 12 Jan 2023 09:57:50 +0000 Message-ID: References: <20230110115847.1965096-1-amitprakashs@marvell.com> <20230111085343.2058993-1-amitprakashs@marvell.com> <20230111085343.2058993-2-amitprakashs@marvell.com> <20230111080710.0a6f1fb8@hermes.local> In-Reply-To: <20230111080710.0a6f1fb8@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW1pdHByYWth?= =?us-ascii?Q?c2hzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctOTEwZTU0YmMtOTI1Zi0xMWVkLWI2Y2Qt?= =?us-ascii?Q?MDBlMDRjY2FkNzJiXGFtZS10ZXN0XDkxMGU1NGJlLTkyNWYtMTFlZC1iNmNk?= =?us-ascii?Q?LTAwZTA0Y2NhZDcyYmJvZHkudHh0IiBzej0iMjU4NSIgdD0iMTMzMTc5OTEw?= =?us-ascii?Q?NjgxNzI3NDM2IiBoPSJBYXR5Q0E5b3pnMS9hY1lUQzB5NmVMWEh0Vjg9IiBp?= =?us-ascii?Q?ZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFO?= =?us-ascii?Q?Z0hBQURNRVdkVGJDYlpBUkE3M2w1VFc1UHhFRHZlWGxOYmsvRU1BQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCb0J3QUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBUUFCQUFBQTNUekZBQUFBQUFBQUFBQUFBQUFBQUo0QUFBQmhB?= =?us-ascii?Q?R1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFG?= =?us-ascii?Q?OEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdV?= =?us-ascii?Q?QWJnQjFBRzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?akFIVUFjd0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlB?= =?us-ascii?Q?TUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5n?= =?us-ascii?Q?QUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?us-ascii?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFC?= =?us-ascii?Q?dkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VB?= =?us-ascii?Q?Y2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?= =?us-ascii?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1?= =?us-ascii?Q?QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFB?= =?us-ascii?Q?bmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZB?= =?us-ascii?Q?RzBBWlFCekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFY?= =?us-ascii?Q?d0J6QUd3QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFH?= =?us-ascii?Q?Y0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJ3QUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIUUFaUUJ5QUcwQWFRQnVBSFVBY3dBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBQT09Ii8+PC9tZXRhPg== x-dg-rorf: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|CO3PR18MB4893:EE_ x-ms-office365-filtering-correlation-id: 87bb52cc-9139-46a8-ee22-08daf4837795 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tIfiPFnngc7YZMLa3DpQ0kC/BwVqON8APq/SF9C7pYcvOmv92FZ0ncyrd4GawzqaHaAASAK6+bfiPff+U4bbBFywue5iCy50bfxJn3JjOUTG25T1b96ZUyUWw+2PV0/oUvwLZFY4bA+yxjHqAuZekC4m+eBO9PWYUxJCf6Y9uGXaxWDJXN3Uox4nulnquPcPZhwInAnqgQO6GKlX6phPzrf5XfpDVzz7x923P07LvNjMAr2LqW8NJ0rXtDlNpCZPP3Uu9QKPlpAdAMpr5CzRrSz7Dwxh9onsIuma0suR/+hWrompg2L4K0AoC0EEm/+8P8tphj4VlSROKEoCgrvzgT7iTo6yIO8ORPEey9gr/4Rh//2m4tn8fl4N80w9qtXBxPOsIZFfziGgSijbFpuirKGEmP0zgPiMzeoEaybEeBGjH9pvLcxVxdPdGqmAk7+4S/P1cRfqhRUB87s/b9cxEETGxd4jJYbkzLN0lUA1MkmQm/3o9qvZiekjlYVEDITKyIURxN1G3z4m8PTYGORLa+YVtg44vld1M9aylNUXjMxJ5arL0LKAmG7IrG+9adDEZvqLosj3D2q2ZI0+sIfNhpdlxWQHAePqUFQSpmBHVkZ7OQmp3SfQ6zE/aWyjGB19pnTmgQ2DoqjsWDQ2ZFtZV4QmaWjwiJLXreSkFsShOvJOTV1Ft8nGjQsT3NeipRs3i6P3ADLNQrMaOlV6DQ/JHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(346002)(366004)(136003)(39860400002)(451199015)(478600001)(52536014)(8936002)(5660300002)(316002)(83380400001)(33656002)(55016003)(54906003)(41300700001)(86362001)(66946007)(76116006)(66556008)(4326008)(6916009)(8676002)(66446008)(66476007)(64756008)(71200400001)(7696005)(26005)(186003)(9686003)(2906002)(38100700002)(6506007)(122000001)(53546011)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sEZXL87JPVnE7ceHlYJLHd6OOv6+hwOP9mN4kYwRdamf+LuTH0lkUXk68Q31?= =?us-ascii?Q?/Z+M+Ne/fw9LSb7HUCa+H6Wh0Vmfotblu2Kd1YywR0thBWrxIQn32Z0EaIl2?= =?us-ascii?Q?TFCUDS2kJb4vvZflDHgV96SeEMENFrEw0eDAvB7RINS8hboP9/fanTSLA4h+?= =?us-ascii?Q?0PmZVU+W25pmKKnowCjZKp3Qi8B7saBXXLgpOeG6qzJ8Mry3iAfbsWxBs6ti?= =?us-ascii?Q?LGwNxnGTGx5+ksuSZs1yq/7vLhNGH16I1Gd74x3TRmLLYvQcwTBOD3Pkr2Aw?= =?us-ascii?Q?+4nEUrBKdROswbGOzz8thOsndgF4Ed4Wb4NHupmbilDbQpm7l5zWa3/Y7Rpf?= =?us-ascii?Q?c3ErBlPYcAqGTWSLRbjiO3VUyYKs69KE0LfDeJ2KZQWFpXctFHjDejxHEpwz?= =?us-ascii?Q?ejAAhT9D+DZxdsKqKQRiAHyGa8ZQMfMZszovs8GTuNQtyyJ4lbvZrrGM29aT?= =?us-ascii?Q?CiqN5twiBv3hdU/RXzy3YIu3QhpkmceMEke6Uxxe9BQgHnBYJPF/76ZJ1m3t?= =?us-ascii?Q?HcnLErmsVk5qSetw5TTCr6j4PrWPAK5sbVWtMHnjQs0uJ2H0dQpYz4NH2IDJ?= =?us-ascii?Q?x4mZickJK/IsZH5dEFBXXsIMpqnaJfwWCDUn2j5XNa2uSsZr2CjlgbHfuHyr?= =?us-ascii?Q?AHiFHfIqH6Z754L7TNg+i4VGll6HgGcTJ6T0DGTxPnIyJw48VMjgGNAf+jwV?= =?us-ascii?Q?PO35HWAjzrgn1TlPX7lDr45OM3IHW2tBjfaNO0hUHwcv+SKFLjgnhTnpl2PK?= =?us-ascii?Q?4tvcPxLF7Iwa8yzWWffT8Xs9kMYY2qMoZkkA6a2MAZgMuUWxAqE8ffDzhNPZ?= =?us-ascii?Q?eNOJywSrtzbqABsh+1NKWtpZVFfq5RaEKJPkyoaLXu3uoTu/TKj61vKLdSBh?= =?us-ascii?Q?JTBqKPIHMHSYTfxeJLMR47P8wuAXvRyHO++SciC+EqzhFAZl1YdXBIDYEwHV?= =?us-ascii?Q?Qb8FmnSsjRHaSWfcum+6ywrPmW1x494LDF6+PEtPPj0WtPBKIyDuPCMxpD72?= =?us-ascii?Q?LKBlJxauOkDUPsrwTeBZjm9FR1wiy08Q/i47DX+94yzN7WlZAWycyZwbDGJ/?= =?us-ascii?Q?YlRa2yEBJsh4jZM/oqJvkqzSB9laduBfdMD3BZtBWpvDYW6vCrD1TmWyXo5i?= =?us-ascii?Q?dPuCgE9D5amVNDcUCHSWham/nB8h+94hM3MwsuKd7FB1IfsGy7O3Chhd/6zN?= =?us-ascii?Q?14DqXst9h6qPLqellQC9hG4gd2LTJ35XCkaL9QpmYiMBwa4ogO2IAjBxlhCF?= =?us-ascii?Q?3n1N3wxfrzNQ746WR3cC9fqEKPgribc1jc+BtbWAU376s+IALyM5Qdq+pM9L?= =?us-ascii?Q?dzMRKRTSo2jkVO7wuiz1MpBmc6CJCAOoegH+IOtzSeI0w9P013C1wWRzpP+W?= =?us-ascii?Q?jAF5UcchEtnA7Jct49aSFtV8JTtCnxoCvt2ZNR9A8mE0bJKTtUWHZaewvyQN?= =?us-ascii?Q?ZodZb2Q8vuQBbViqYpfKkg0pJzo4uic+ryfbl1iLrohW7VpZTlIdwzPSMZ+K?= =?us-ascii?Q?AfXd4mdhhcNMrfIn0g6bHc9oLcR41xTBNIaNNepKmkwnUJSmlCS+8GdTzm2s?= =?us-ascii?Q?OhfgKjbpbFA13KtKn7MV5WduNq0Yu8qhh4S/yQic?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87bb52cc-9139-46a8-ee22-08daf4837795 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 09:57:50.9929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tPX5DqwDT9aIgnZ7fmxilHmWRywEcpeQxcXs0IWrxnsUStGGghhEY9W+MBo+0gNU6eKiVQ0EoJmDJYGmkrp6xOuoFlOaOnCHgSZfZAQsanE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR18MB4893 X-Proofpoint-ORIG-GUID: ZBrKoDR6l5c3U3iJEh1XnMxXsPvFfKX5 X-Proofpoint-GUID: ZBrKoDR6l5c3U3iJEh1XnMxXsPvFfKX5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-12_06,2023-01-11_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, January 11, 2023 9:37 PM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; dev@dpdk.org > Subject: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Wed, 11 Jan 2023 14:23:41 +0530 > Amit Prakash Shukla wrote: >=20 > > + > > +#define PCAP_DUMP_DATA(dbuf, buf_size, cur_len, sbuf, len) = \ > > +do { = \ > > + if ((cur_len + len) >=3D buf_size) = \ > > + break; \ > > + rte_memcpy(dbuf + cur_len, sbuf, len); = \ > > + cur_len +=3D len; = \ > > +} while (0) > > + >=20 > Why do you need this to be a macro. > Macro's are evil, have side effects and hide code. I had added macro for future, if lot of custom data is to be added to pcapn= g. Anyways I will remove it in next version of patch. >=20 > > +uint16_t > > +rte_graph_pcap_trace_dispatch(struct rte_graph *graph __rte_unused, > > + struct rte_node *node, void **objs, > > + uint16_t nb_objs) > > +{ > > + uint64_t i, num_packets; > > + struct rte_mbuf *mbuf_clones[RTE_GRAPH_BURST_SIZE] =3D { }; > > + char buffer[GRAPH_PCAP_BUF_SZ] =3D {0}; >=20 > The initialization probably is not needed here. >=20 > Couldn't you just do: > rte_strlcpy(buffer, node->name, GRAPH_PCAP_BUF_SZ); >=20 > > + for (i =3D 0; i < num_packets; i++) { > > + struct rte_mbuf *mc; > > + mbuf =3D (struct rte_mbuf *)objs[i]; > > + > > + mc =3D rte_pcapng_copy(port_id, 0, mbuf, mp, mbuf->pkt_len, > > + rte_get_tsc_cycles(), 0, buffer); > > + if (mc =3D=3D NULL) > > + goto done; >=20 > The code will leak mbuf's if pcapng_copy() fails. > Suppose packet #2 caused the pool to get exhausted. > That copy would fail, but the mbuf for packets 0 and 1 would already be > sitting in mbuf_clones. My bad. Thanks for catching the issue. I will correct it in next version of= the patch. > > + > > + mbuf_clones[i] =3D mc; > > + }