From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76E1642417; Thu, 19 Jan 2023 15:37:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 149E640223; Thu, 19 Jan 2023 15:37:56 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 41EB3400D5 for ; Thu, 19 Jan 2023 15:37:54 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30JDWxKY010712; Thu, 19 Jan 2023 06:37:53 -0800 Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2041.outbound.protection.outlook.com [104.47.57.41]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3n6nju3djc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Jan 2023 06:37:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TuDC0476m1umcri1IGStVcAzdhqPvRKNBzV3pGNKBKjwr4/y63nhv1HhEAo2FpPyACoBTvAJI6Yhcucn4FzyetWpxldaOfy24QtqXSRgihnVV4MrmnNoXtkPw9H9mqQXR0j2is2bWeoG2NrmGymPy2hBo66mSoOZKWShkGWX8nBgKcxzDmVvNzK/Pr1JazT+O9Mamlyh92ftDNoFYS+Lq2GudRSfo7OKohyPoHQ0JJXZAmsRXVNam8Bp09MyrswfkTk3cyaHCS7ZJUjr+5A7O1F+/+beMPGxeqkCpNft0WGbihzhMHQ9cRM2z1SUuYgCTT9Pu2zTXaB80cICTrkMtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9z63wfb54j62WWJFp4XDHVid7h/hvMGPO9ozM6VHyIo=; b=U5lFwE8XPdu5VyIfR35qMi5bSW471oBgRiwKiM2CWH2Qae6zS9Q74tkPRf5up6oINzO4jJrCDDq+9Xouf1aNeB3u3xRDdhvfyLfU4PwzSscsifJr91y8+1lv6QT0e83eg7BroP1BZA4+jCtOVf2Ex7BSQgM2HCheKmv89XqXz5yu5rLXC/Kce/6VvYFuB9xpWS2ObOZGrbXaytnutIyIxUiFXR3dWkK3XJRHl4PSXz0ouAJU3H0DwjGvfTFXmW8/N6RJIUWqRa/CbVdzD75qx0uXkkOKMEFa/0SQ5RuUurh8wPKrg+6l+jD7yP1sgUhAzG7SfLkVNoN4GQHmfZ0qBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9z63wfb54j62WWJFp4XDHVid7h/hvMGPO9ozM6VHyIo=; b=HZSzMPllEeEZuKztixDYthryfnsNSPEB+krtaJFkXIeyQJ76YlZEk0aEB2Z3IoXG3z3fOeFPSHYiiH3wYaR9eivBISOuaUEwDG1dj7T+pSuZlrlhEJEcmkphalCX+UCU9JphcoKjBWerOK+oKo6NZVFhYV/Wc+boohMTGrQNUwI= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by SA1PR18MB4551.namprd18.prod.outlook.com (2603:10b6:806:1e2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.26; Thu, 19 Jan 2023 14:37:50 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::71b3:f3d6:e353:ae39%9]) with mapi id 15.20.6002.024; Thu, 19 Jan 2023 14:37:49 +0000 From: Amit Prakash Shukla To: Stephen Hemminger CC: Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "dev@dpdk.org" Subject: RE: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes Thread-Topic: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes Thread-Index: AQHZJZpHUJe0oKVgaEyLCJWdD2XSaa6ZYlAAgAEoyhCAAHAIAIAK3Wiw Date: Thu, 19 Jan 2023 14:37:49 +0000 Message-ID: References: <20230110115847.1965096-1-amitprakashs@marvell.com> <20230111085343.2058993-1-amitprakashs@marvell.com> <20230111085343.2058993-2-amitprakashs@marvell.com> <20230111080710.0a6f1fb8@hermes.local> <20230112083024.17c68431@hermes.local> In-Reply-To: <20230112083024.17c68431@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW1pdHByYWth?= =?us-ascii?Q?c2hzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctZDc0ZDM1ZjItOTgwNi0xMWVkLWI2Y2Ut?= =?us-ascii?Q?MDBlMDRjY2FkNzJiXGFtZS10ZXN0XGQ3NGQzNWYzLTk4MDYtMTFlZC1iNmNl?= =?us-ascii?Q?LTAwZTA0Y2NhZDcyYmJvZHkudHh0IiBzej0iMjk4NiIgdD0iMTMzMTg2MTI2?= =?us-ascii?Q?Njc5NDc4ODYwIiBoPSJsK1FucldlZ3FTY3A0VkhmVnZDYzlwaFNSQUU9IiBp?= =?us-ascii?Q?ZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFO?= =?us-ascii?Q?Z0hBQUJNa3IyWkV5elpBUi9BQW5jR0hqY0tIOEFDZHdZZU53b01BQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCb0J3QUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBUUFCQUFBQTNUekZBQUFBQUFBQUFBQUFBQUFBQUo0QUFBQmhB?= =?us-ascii?Q?R1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFG?= =?us-ascii?Q?OEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFnQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdV?= =?us-ascii?Q?QWJnQjFBRzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?akFIVUFjd0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlB?= =?us-ascii?Q?TUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5n?= =?us-ascii?Q?QUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?us-ascii?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFC?= =?us-ascii?Q?dkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VB?= =?us-ascii?Q?Y2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?= =?us-ascii?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1?= =?us-ascii?Q?QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFB?= =?us-ascii?Q?bmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZB?= =?us-ascii?Q?RzBBWlFCekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFY?= =?us-ascii?Q?d0J6QUd3QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFH?= =?us-ascii?Q?Y0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQURnQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIUUFaUUJ5QUcwQWFRQnVBSFVBY3dBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBQT09Ii8+PC9tZXRhPg== x-dg-rorf: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|SA1PR18MB4551:EE_ x-ms-office365-filtering-correlation-id: 475ce32c-b007-4981-3640-08dafa2abd5a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wutlQtkcNveEBbSlQlYUGW8sQdfdJOwuMoba7UAhI5jz9WMM2d7OpmTxyEQQYV4soDU1UYKEn/5isNoy+nHqBpVWTCyfUMuZR0zJXJ+pNEzxpzmML/0gif5poDLNFbYfLlgnesg+pmYoE5v7+ZnLDpo8nTI0ibA9sQkYkL3r0FDFz7Q4dYO5H7xEA6QXOEhEsM8sSCtLnz/TICXNVQ4Yh+m0halA1YmdNXB0XLkJqQbzM1hsLScaR6n22i/+Mz44cmdcaG388cJ3rhzX5VV/4jttObzOg4zqAfWlJ/wx+WsP+ilUou4efsgodJBtB+eg3EG7zwKke2UoQ6UdahlFO4vEenRTNmOknuD6bqZzcic6nbLMFfgq0hTRENTd9sTnuL4BkgGx0z+QBxL5gvklYNxUvxkya4TE75Lk2NxTSyyp5U2ufTwXa+DmBIFPurK7ySB/TjEsdYW84ABw3K94JcNVDNd8EHNEeUiUT3EEyigMfKk2L6O4ouVotdLY5OPkrQkjI4+XsGFBqkFj7GUax8vcKzFabGpd3CMliGqUZah3py8QtO8Dh/dDQxRv3PM6Qf5bEhFKESugtVnpXd6or4c0A3vkv59l/Hk9ZU91CE5LIiVwKbTuhhUjrRF6EXm5GywbGj21SWyYyvwJ690uSnYhDb0yLSsoR5vAfj/nmgnbfu8CEM9UYP0jKe1FwwbEwYjH8Ox23uTjhMpvi+dNEmEBlsqrehDcpRBMNNab/Ik= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(451199015)(9686003)(66476007)(66556008)(76116006)(66946007)(186003)(26005)(122000001)(66446008)(64756008)(41300700001)(8676002)(6916009)(4326008)(71200400001)(7696005)(478600001)(966005)(316002)(54906003)(55016003)(6506007)(53546011)(86362001)(38070700005)(83380400001)(5660300002)(8936002)(33656002)(38100700002)(52536014)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ad/XwWHYI7x1cBhJbfj8XanzK0Axh3b8d36X27O3B6eoLSfqYx9dEN0wxXpl?= =?us-ascii?Q?BjNTu9R2V3Ut/eThQ6qZhZNy1qSakrz6E1/Ub7rsfIjgM7k2blBc1zYbuPEV?= =?us-ascii?Q?+EKM51yrmodtlmj86EC4CVyKwjLJNidxR4QI6KUGqhyoXmuB+AhRCVCjyDOz?= =?us-ascii?Q?wpQSsxS2QfTrMws10Dht6OTLHZ0D0EqeZ/5vZOoY+Np3JBApE2o3NT0Kr9Uv?= =?us-ascii?Q?NL7vA/Y7fpvsmEOAQV8hNQl0dv6uP2YB2yXMrEKCIVtMTqlO+HeYs7cW6bj6?= =?us-ascii?Q?dWFaBfmQ6gEyvhWKr4+9zfRC2EM7ERy92AvIEAllRz6NcZfASxbbYnPUi7c8?= =?us-ascii?Q?KApxjDdoHkFClpFmbtAQC/Kw+tCvi1ZR/1L+ZTbSsXnQq7qcWKvoZA8Wz3M3?= =?us-ascii?Q?LuefMlI0Vnb6c6wDqmuKRe2EbBZWuyrV3dIFgkdrYWN/QLk1OzHvkAd5HCaF?= =?us-ascii?Q?a36f66batIz8XW/LQd2pCY1efJvr8PA0S6abUYv300tXzPg6XCU/yafZ+M/X?= =?us-ascii?Q?N7eVcVJdqevJadUIepOaDsveYaVUHO3UPcVSF89gEOMnMcMQ7LRJPx4LVif1?= =?us-ascii?Q?AI+OUqPDb9MbiECCLmZ244nc/ca4GIa3t1OLbCfvbpgQbIisj2BLhStr6P2C?= =?us-ascii?Q?30AhMtWRrpsoMfVdEhDQo1ftGVpfObj2W+N5RVLdGSQA9xkr608fPDNeJfSn?= =?us-ascii?Q?aOFkXtlf0ovKtGPQ/K0YurVryvwnVZzGTCzwBJnnqqgdqIFEoHAUpnqTpfQo?= =?us-ascii?Q?PYy6IvnV/odTFx/LIaRApfDyBP5WlLZcmn4L8ld07uFKkNeHWZ13M/xWa+ck?= =?us-ascii?Q?DpPA/KN2aDyAv1hmKlB1HIyUNGAVCFNn1kMSzvgeFGpeGYbvmoUfvHVTTSkB?= =?us-ascii?Q?Cn8n4m/VheawfBha5MhVEOsLs2XRRpfA58g/RZw2bNQE67NWGmUysXNg9hhb?= =?us-ascii?Q?8jcVCm2+9WwMJI72FhHYRZtTlp+pvX9Yng0Z2EwEBoPZS6YjFoU1WU8FH90r?= =?us-ascii?Q?cPMS34XbnT9Jht05x1fBmJPNrkbxXbkWx8k4X5AXoNHLdMUO0FyAOq60MiD7?= =?us-ascii?Q?sPR8smAHOS3+o1W/V9/fsqjJpUbbKwmboB+Mh7lBfDvtdUYjAD5KUeyse61z?= =?us-ascii?Q?09ySI5Z9w3V2Xyl6tijnfSCECxTXOVylDwMl2IFQaBFTXTlUzjQem77xZUrg?= =?us-ascii?Q?wgAapw1PWtHu+S4Q4+nlFjGkooOeIkCVmsBOprCq/zsq8SDSKbYoIKIZlakU?= =?us-ascii?Q?N2y8Uwk2E91biBfn82FqT7hGpFoBL8tqgWSdAAtAqnBXJOGpPl/epxwFoh+B?= =?us-ascii?Q?Z7SuoiPdS/1uCSN8LTqeSOYhgp7XT9T3uzD3x8L2eXN4rwn6hAdp1r/VBsvR?= =?us-ascii?Q?kOaRe/2ieU9epJRSHYperecWNG3gNsIQdofltb/xRgngplfsgWYm4ffH4ZoQ?= =?us-ascii?Q?ittD0O7gOHBHoIN8Ob4vlOaZKejQ/aSKltTGNDdqBxkuuQBhD0Hhzdh6Scyr?= =?us-ascii?Q?fD+Mqg7RAgmc4G1VgL/+XgGyEmppnbAcyYP1a6uuQM6KoUEYc4aXtNNR3tdM?= =?us-ascii?Q?yP6uEr7C5NG0/+GyFAdYSBbDBAX/ce/40TOgMkEE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 475ce32c-b007-4981-3640-08dafa2abd5a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2023 14:37:49.8566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yXXWvzxdrH/Mu/886JwH5RFYcCseQbc0NxBMDeu0amzSnRxlOGjyqRHezC9pyboKNJ9QgOXB02K+0gXpxSZYfBAcDLgMrcrVpnpTRx2DIZo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR18MB4551 X-Proofpoint-ORIG-GUID: VQrIok4Gpb1eClw0pVWGD0Cj5ZXxe0zY X-Proofpoint-GUID: VQrIok4Gpb1eClw0pVWGD0Cj5ZXxe0zY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-19_09,2023-01-19_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, Thanks for the reply. Please find my reply in-line. > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, January 12, 2023 10:00 PM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes >=20 > On Thu, 12 Jan 2023 09:57:50 +0000 > Amit Prakash Shukla wrote: >=20 > > Hi Stephen, > > > > > -----Original Message----- > > > From: Stephen Hemminger > > > Sent: Wednesday, January 11, 2023 9:37 PM > > > To: Amit Prakash Shukla > > > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > > > Kokkilagadda ; Nithin Kumar Dabilpuram > > > ; dev@dpdk.org > > > Subject: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph > > > nodes > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- > > > On Wed, 11 Jan 2023 14:23:41 +0530 > > > Amit Prakash Shukla wrote: > > > > > > > + > > > > +#define PCAP_DUMP_DATA(dbuf, buf_size, cur_len, sbuf, len) > \ > > > > +do { = \ > > > > + if ((cur_len + len) >=3D buf_size) = \ > > > > + break; \ > > > > + rte_memcpy(dbuf + cur_len, sbuf, len); = \ > > > > + cur_len +=3D len; = \ > > > > +} while (0) > > > > + > > > > > > Why do you need this to be a macro. > > > Macro's are evil, have side effects and hide code. > > > > I had added macro for future, if lot of custom data is to be added to > > pcapng. Anyways I will remove it in next version of patch. >=20 > One other option is to add a new custom block type or options in pcapng. > Keep comment as a string, since that is what wireshark etc no how to hand= le. > Also, packet id data might be useful for graph. I gave a try by adding a support for custom options in libpcapng, but it se= ems wireshark does not support PEN in custom options as of now.=20 Wireshark was not dissecting dummy PEN that was passed in custom option. >=20 >=20 > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__pcapng.github.io_pcapng_draft-2Dtuexen-2Dopsawg- > 2Dpcapng.html&d=3DDwICAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DALGdXl3fZgFG > R69VnJLdSnADun7zLaXG1p5Rs7pXihE&m=3DL7hbHExlVJ9DVyJLvofg2oChAcRcF > GBypawp8vQkR5nAGLbwS2NdSNepsq8v5Zx7&s=3D1tIiV96rTBAhzcLS_JiJ5FRbL > PUja4HyT3rhQA4RIsg&e=3D