From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CC51A0551; Fri, 26 Aug 2022 11:45:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C35B1427E9; Fri, 26 Aug 2022 11:45:25 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1FB5940A80; Fri, 26 Aug 2022 11:45:23 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27Q1oMpv020745; Fri, 26 Aug 2022 02:45:23 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3j6fbn3f3y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Aug 2022 02:45:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IeV/OgQZ3FJBBHGutbrbZ070PqAQY7FN+cATQofFFDy1YFKce/mA7OgoGKDvE9A1yEYTYMfEBTAAgZzefophpItmznO+sWo0dDsziYD/LjEYWjLLXDuXIq9egxz4Fr46ev4+cKvWkVQNKhXh6b0jdWXyhvZO9XaUmHXr7G+UVhBPugICG5aAIYXwu2ZlJw50MN+Llo3j1Tx4j7cDYAMxBumBhNxoQIii1DBPV2vf5SJBq9yG4k9r0FaytyN0qjqB+nxbLNzqCAFnJW/Ie6ptf8k1q95rRBifSIIE9R5wA08lWM14xfpJcmJlfIL2xbLlztvicQCMpMaz3OIPBrmhfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3oIuZvaT++6EsMy9hu0xp1FHtVWfI3nIesTQxHIhIOc=; b=bQvDvRyh3+JY3XlBvWCmjVGi38pO6uHJVJKPzS9BsKqvQ/Jv3ii1VAyX8hr7IQdzhglBpxkgRJ1wkJOI1mRwdp3HOgdgMFqK4Nm6Qsg+tjgjiLqXclzzBvG/1q/RYgpt8TABFFlsK4VnNIJhwg7IBGjL6oQE7DP1Xts8SQaCGBr1kv+OyTW2CX2NpgkgEPB5qYZq6ulE42EFGrPpegz/n3rNKuOGkCEt+vxRy9HdXLlC10N78q8PgKDoiD2AlR4SpVUjozteVjTuuYfQlOdqzi5ntrJfiFa+rXsAqduhb3V6cE/WGSIQHJuHq2zlze5cSURbmc1YGEa+jHvEISq0VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3oIuZvaT++6EsMy9hu0xp1FHtVWfI3nIesTQxHIhIOc=; b=t9pwwsJA/mt0jpAyZrRHPikjE/IG/f9WiCvRXWTxrNYuckorGtOrMFdFbMP4rXoe73zZl2d9gMIO+MFXhKvbcHux5k1+AYe3ab8Qxn9/7koSG5BieJv14iRiDSw615CF5D3WQPaoWIwTbeVvX2nHywIX4Uz/LWqNlQglDnilXQE= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by SA0PR18MB3662.namprd18.prod.outlook.com (2603:10b6:806:9e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Fri, 26 Aug 2022 09:45:20 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::90f7:9eb4:ce15:7a2c]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::90f7:9eb4:ce15:7a2c%6]) with mapi id 15.20.5566.015; Fri, 26 Aug 2022 09:45:20 +0000 From: Amit Prakash Shukla To: Amit Prakash Shukla , Yuying Zhang , Beilei Xing , "mb@smartsharesystems.com" CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "stable@dpdk.org" Subject: RE: [PATCH 1/2] net/i40e: compilation fix for GCC-12 Thread-Topic: [PATCH 1/2] net/i40e: compilation fix for GCC-12 Thread-Index: AQHYt8JWLGoUVZzyh0yvdRjPYq4ub63A7XFA Date: Fri, 26 Aug 2022 09:45:19 +0000 Message-ID: References: <20220823105742.2276506-1-amitprakashs@marvell.com> <20220824140339.2581716-1-amitprakashs@marvell.com> In-Reply-To: <20220824140339.2581716-1-amitprakashs@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cdc17596-fab4-463e-f1be-08da8747b086 x-ms-traffictypediagnostic: SA0PR18MB3662:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yxC6W9MsCjRlvooUEr10JY3PAUOSL6zP8J8wwoZ8Jjmh176h5bMK93c3ResGVIsnb48ZGh9ItgF9JwEFYF86BzKqmH83PvuQY2lcR8BQx+MwLTUdkk5xNSt7MdrPlGn0BOWl8IC9DTBFlLHMcsWsbYNea5RZ75qFQ/ylM8SPu9Cfu4Mg2ekU2FwWSmQnck7WW9bJnG9ue9DRUrFzyRkRdZDVzSRiZYkeJoNaIwhWvvKFvr/9i7BGWVSJM9MAWT9+v4QJ0HozrK4uLBAxSxDwpD06q8CdShFP4gJb9flQ0l915oS6v35f5CixdiD8ONtJfJcGcu2WTYImMD55jlC5wcCdHLPQWH53J21/Qua7qb7KD0t89Rmhk8g8GydVjrmsJnxwnftqMe1HBvCyeH6sJbUtHh47h67i+pM5AqdeyS1IQQ9DDjmX6ALUydlk0XQltbPHe+gR06Xgt6+TzM08cOHaeK05ipPPkTRZHaa/jqSh6O0fSNnESVXYjKv492kEpdLseHFWrB4d6L99M2uLjEIl/RlVlp9D8l/J6kNiU9B3e50Xr/fo2QSR6B2SkAB/DuAbovm/BnSREm3VeJiGInt/CXauow/HHz90Jf+6iuTDEVv3X/jcoQrGh2B/32oDTsWZGTZ/BTbJqCnDe6lJABr20rGk/1OfPrHkHXShyDh+OhgdjQ+qdbUjvPX6JZFDn6W0My6+uzq6qtbVD8hcpA47FcaefVOpn0xWcMVhVagqhP8hHCYZxUtI1uAoN3nqqn/Oeh3dX2whJZWuA8BAxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(38100700002)(76116006)(66946007)(86362001)(66556008)(66446008)(64756008)(8676002)(4326008)(66476007)(33656002)(122000001)(38070700005)(83380400001)(7696005)(6506007)(9686003)(53546011)(71200400001)(41300700001)(478600001)(26005)(54906003)(55016003)(316002)(110136005)(2906002)(186003)(52536014)(5660300002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lWw+JSC/c9MnH1uz5q4M6rlozpMTTHaMKkidhi8NfJSvcBCfkjNRD7JuM3L1?= =?us-ascii?Q?WDb6PwEfYeMYjHtoIZlk0/yGFXTdl0AUxjQcf3hAxaHR1uhuKonYJYopC9c6?= =?us-ascii?Q?G+Ku7M53onTa2V3IWeUZx0rX3LAHhcmj617LiuJFiE6O+Ejf5ewNElInwHV+?= =?us-ascii?Q?GVAPwM5z0L/y6tgmy7HXkBnZZ+szvMI5P+k59/aH6WIjM+c+3AHhZkLWaGs5?= =?us-ascii?Q?kgKrwtRl0wJZcCNHVqRVx9Ng8M9yubZX0/Ix7JRegJBIa8b0rRNA+zyRkzAs?= =?us-ascii?Q?1te9edZHCUsnUmZyaqjd3pz+qztGYGfO3GnO9q6oTDc+lsjX9x5kUOz5km2V?= =?us-ascii?Q?vbhwhsDv6gjd6vun9luGHphu3ZN/TkcMh1A3zMxbZz5b7IkhTNoYvuaq85QA?= =?us-ascii?Q?UXiQZgNgl/9zOZJP0F7AiVcQ/u2CYSlu07s7f3XEEAKZAYWCYUos0ghxBX7r?= =?us-ascii?Q?iDB6vdQVcHLTmHHl+0Ys/4yuEA2X5blokX/RqgbdO4EDrj/jPNRy23MI6MNh?= =?us-ascii?Q?F+igYnb/6bgf0pabT303DEldR0ghwooEKdUXKbhvBzOHPDaHl/joG+dH1q7x?= =?us-ascii?Q?JSDPR6p121h4h1u9Jl2wejltzfUwAg4APUmJKQ2Ms7izVZfyLxiF37Z9CRRY?= =?us-ascii?Q?kTGcfP+7iKdUil7LvWNXwGOZiiOKvg7M1yzV/hbxD8jAhn6/nhoGJlczrtYD?= =?us-ascii?Q?W2Q0vRGyNelAKzbcIiYrAo8DMnimHgEdrmECKU9nc7/HtTOD0qzpOfU1FBSI?= =?us-ascii?Q?2ZtAhIdCP53bc4jfOdMDjLsHuJ97Upk9ylBgBH9izI/GN6YmEBD4mU9gVJXD?= =?us-ascii?Q?YPbk08Gs07M9yG67oj/h3yVfk79qSwYXopO0qL0HNX6bog/igQ68xgr3mDxx?= =?us-ascii?Q?2G97uzFwgt0ZQENeGQLcyQdUcplyfGUH+lL4JjVluIq4gTJBE0cUIQOdHa4/?= =?us-ascii?Q?a7ZVWBsBzoJGm3sUSULm4H/rSTZr8mtHGiy9g47eOl2GVqW0YedvteXJ46nj?= =?us-ascii?Q?K34CA4qhv2C2hUePlnQZho02oq0j/diSJ8eKRgbtEu+cREkqIwJDI9qkkTJP?= =?us-ascii?Q?LuMkcYr2l97+wYQIQWNuf1dIWZC96QqR42OKcvBadR2MSk8RqMxz7R96TveI?= =?us-ascii?Q?o5gTm+XX4abLe0iq/ruCiQ36nTkfFmRUzEfWiG1x00X2kjDGxXRtLZ7GBVfZ?= =?us-ascii?Q?2bS6nYyh+8UGlkds4gKmNsGhO6cIjNfl/QmcoVoS+e4aQADSZ+H+6nTOZGHc?= =?us-ascii?Q?wUvq9rV1dixeDtPX1usCvSjIyJqb97Sag8xrzmzeCymI+Y2zMPHCr7ECiMsL?= =?us-ascii?Q?oqMNvhEILuMv4GzjeP51CYhw9BBWjhUJwLhp2bEtuANkVcH6vp8Yf3a1lmii?= =?us-ascii?Q?cYYRMf7iBywczLwDoT6Qs+XE5I04lUFIPW3DYCQEjOy0Ih1vYYi3PavihnW7?= =?us-ascii?Q?X+T4MwT3SnYZ0F8sWFB9qHBXCcdOVUQjsM1ouE6KkPXqQFyapqPfS7gH1WW/?= =?us-ascii?Q?nxRpGVy53jBpPzx86zFu3RyoOYBLw/5ZSakSyIabBshkG+pUZpFkq6MWkksW?= =?us-ascii?Q?xpzQv8cm9uMhN+OqRPhguNsRUyTmj26oDd8nSzBg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdc17596-fab4-463e-f1be-08da8747b086 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 09:45:19.9770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aouAbzZF7F7um2pIkObgHlgZT9xzIj3voXHy1RZGwM9D1ei50TVCX/VCUkZ7FEgNYyXOiGOM5pbB41sKbfyf0VuHTCxy3hcTn+eZ2cnRLdQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3662 X-Proofpoint-GUID: 2fAhwNC9kXiZqGVrUFiFbRg3Kagug_t_ X-Proofpoint-ORIG-GUID: 2fAhwNC9kXiZqGVrUFiFbRg3Kagug_t_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-26_04,2022-08-25_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Morten for the review comment.=20 As the change is not in datapath, branch prediction optimization was not do= ne. > -----Original Message----- > From: Amit Prakash Shukla > Sent: Wednesday, August 24, 2022 7:34 PM > To: Yuying Zhang ; Beilei Xing > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > stable@dpdk.org; Amit Prakash Shukla > Subject: [PATCH 1/2] net/i40e: compilation fix for GCC-12 >=20 > GCC 12 raises the following warning: >=20 > meson --werror --buildtype=3Ddebugoptimized > --cross-file config/x86/cross-mingw -Dexamples=3Dhelloworld build > ninja -C build >=20 > In function 'i40e_hash_get_pattern_type', > inlined from 'i40e_hash_get_pattern_pctypes' at > ../drivers/net/i40e/i40e_hash.c:520:8, > inlined from 'i40e_hash_parse_pattern_act' at > ../drivers/net/i40e/i40e_hash.c:1147:9, > inlined from 'i40e_hash_parse' at > ../drivers/net/i40e/i40e_hash.c:1181:9: > ../drivers/net/i40e/i40e_hash.c:389:47: > error: array subscript 53 is above array > bounds of 'const uint64_t[53]' > {aka 'const long long unsigned int[53]'} [-Werror=3Darray-bounds] > 389 | item_hdr =3D pattern_item_header[last_item_type]; > | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ > ../drivers/net/i40e/i40e_hash.c: In function 'i40e_hash_parse': > ../drivers/net/i40e/i40e_hash.c:182:23: note: while referencing > 'pattern_item_header' > 182 | static const uint64_t pattern_item_header[] =3D { > | ^~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors >=20 > Fixes: ef4c16fd9148 (net/i40e: refactor RSS flow) > Cc: stable@dpdk.org >=20 > Signed-off-by: Amit Prakash Shukla > --- > v2: > - Removed "examples/ipsec-secgw" patch from this series and posted it as > seperate patch. >=20 > drivers/net/i40e/i40e_hash.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c > index 8962e9d97a..a1ff85fceb 100644 > --- a/drivers/net/i40e/i40e_hash.c > +++ b/drivers/net/i40e/i40e_hash.c > @@ -384,8 +384,10 @@ i40e_hash_get_pattern_type(const struct > rte_flow_item pattern[], > } >=20 > prev_item_type =3D last_item_type; > - assert(last_item_type < (enum rte_flow_item_type) > - RTE_DIM(pattern_item_header)); > + if (last_item_type >=3D (enum rte_flow_item_type) > + RTE_DIM(pattern_item_header)) > + goto not_sup; > + > item_hdr =3D pattern_item_header[last_item_type]; > assert(item_hdr); >=20 > -- > 2.25.1