From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3769541C4D; Thu, 9 Feb 2023 11:03:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD4734067B; Thu, 9 Feb 2023 11:03:06 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id AE2D5400D5 for ; Thu, 9 Feb 2023 11:03:05 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3199DCLx019663; Thu, 9 Feb 2023 02:03:05 -0800 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3nm65m22dk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 09 Feb 2023 02:03:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoIYG0SAcH8Us4aHJ4FvrqDosBOWMAajIou6GLW9uAUE0ar1nvP5BA7vMhQ9+LzdlQYy0V6Ac615sg31NymCyNgAJJWau61gQwP5cn2mSzFkEGdNoQ2mkOCTGaNaxA/pTiWDImjUbGFAgAyUhC+ouB8ahRSQcIIxT/vL23TTv3GNu9s0G+338JFL5uMFcXfSQy7KpX8MbAOtM95tgsotRShQ7fZ1b2dIgJadQuIAD0xELwjHrcGtP0UZYaL1UlWr3s8/YYnujY0C1zITq75uZxv7c9WBOOEjpDw3aW3VPh8kI7DeCA7JWioKul4pJVge4+rkexTq3d1O4n615hCijA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7ll0sNsexNd6fMgtjvdhV8+ASRIzweuIwa7ug6l/5b0=; b=Adh4vMnss/fYeIROypwpVQ8WOi/NDS3B4jSY5H+buf4mOsMThoJmAuuEQKodm2BXOJautGeh5vKP0xVEzqxh1PoUlknYD0qAHToSguggNOIzPvVGkNRQt+mJZReU3+/C3stE6aeTn6iT8/z2yRH45ZuraCGcqsDGRgGd9dx3m7kcIqo/MQUYrLi0uiw/WjFDKjmIc7YtoGwYOIUckuQDt3TypdxeP7V1HCaGir9j5/ljnMFEuAVwYbk1+E/UGFPWPOZ9Px92pnghDrYk+5kUt+4aHAX4cl79WQb+YMUllJs5ESj7aTTOrN4YVaa4rfnR9IfVTP4mtKY/TVkjfiFmPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ll0sNsexNd6fMgtjvdhV8+ASRIzweuIwa7ug6l/5b0=; b=WKH6FYzS5YH+LLtpoXhXmEKwqmdi8oBuAbz5KedHNxjkE3FmPSmE9NH5NZcS3RScSxbQAS8ElaWnli9Z7ksKz/AHiRa1XNFsVT2Tr+iTpdtM0wYJ+URU41Zow8K+/UJ/loku1RoZ1EGTT5FOdWBSAUHr70pMdT8kZc2Fni7Dk9U= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by MN2PR18MB3639.namprd18.prod.outlook.com (2603:10b6:208:269::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 10:03:01 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::9862:ff18:d4e8:9f4c]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::9862:ff18:d4e8:9f4c%4]) with mapi id 15.20.6086.019; Thu, 9 Feb 2023 10:03:01 +0000 From: Amit Prakash Shukla To: Amit Prakash Shukla , Reshma Pattan , Stephen Hemminger CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Subject: RE: [PATCH v6 1/4] pcapng: comment option support for epb Thread-Topic: [PATCH v6 1/4] pcapng: comment option support for epb Thread-Index: AQHZPGzGB4RQckFBoUev2e2ivZwetq7GYlKw Date: Thu, 9 Feb 2023 10:03:01 +0000 Message-ID: References: <20230203081925.2201007-1-amitprakashs@marvell.com> <20230209095614.2459659-1-amitprakashs@marvell.com> In-Reply-To: <20230209095614.2459659-1-amitprakashs@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW1pdHByYWth?= =?us-ascii?Q?c2hzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctZWUyMTdhM2EtYTg2MC0xMWVkLWI2Y2Yt?= =?us-ascii?Q?MWNjMTBjNDc0ZGNlXGFtZS10ZXN0XGVlMjE3YTNjLWE4NjAtMTFlZC1iNmNm?= =?us-ascii?Q?LTFjYzEwYzQ3NGRjZWJvZHkudHh0IiBzej0iNTM2NCIgdD0iMTMzMjA0MTA1?= =?us-ascii?Q?NzkzODUxNTc4IiBoPSJUbmtuTWk5NEQrS0Jjd1ZoMWFwbkJXSS94MVU9IiBp?= =?us-ascii?Q?ZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFI?= =?us-ascii?Q?WUlBQUM2VUhld2JUelpBVVQ0ODRGaFlNdDRSUGp6Z1dGZ3kzZ05BQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFBR0NBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBUUFCQUFBQTFGSDNhQUFBQUFBQUFBQUFBQUFBQUo0QUFBQmhB?= =?us-ascii?Q?R1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFG?= =?us-ascii?Q?OEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdV?= =?us-ascii?Q?QWJnQjFBRzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?akFIVUFjd0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlB?= =?us-ascii?Q?TUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5n?= =?us-ascii?Q?QUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?us-ascii?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFC?= =?us-ascii?Q?dkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VB?= =?us-ascii?Q?Y2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?= =?us-ascii?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1?= =?us-ascii?Q?QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFB?= =?us-ascii?Q?bmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZB?= =?us-ascii?Q?RzBBWlFCekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFY?= =?us-ascii?Q?d0J6QUd3QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFH?= =?us-ascii?Q?Y0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dB?= =?us-ascii?Q?Y0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZB?= =?us-ascii?Q?R1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFa?= =?us-ascii?Q?QUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUNBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNB?= =?us-ascii?Q?QUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpR?= =?us-ascii?Q?QmpBSFFBWHdCakFHOEFaQUJsQUhNQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFH?= =?us-ascii?Q?RUFjZ0IyQUdVQWJBQnNBRjhBZEFCbEFISUFiUUJwQUc0QWRRQnpBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUVBQUFBQUFBQUFBZ0FBQUFBQSIvPjwvbWV0YT4=3D?= x-dg-rorf: true x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|MN2PR18MB3639:EE_ x-ms-office365-filtering-correlation-id: dcccb970-efc9-47c6-116a-08db0a84d45f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /NDraY3r9ArfClG7Kch2MdsRUPQhe3CePGXi3gj7gSp/d2XYUQRQSJhGeLsM88ZHyU5K1+gNUWbVzymwwtzpbee0KneWpFyzcScUK8BFDAKmjtZNBJSXOBZagmBhL+StLGLNXU+kk3Q0gf4nzFV+DMociZK5gd2Le526ah04Lmabg6azsWxtRXXtHqhPQmZefwvHNxysr72aFU9nwmjEJRle9IC1CijfJwI7TgQ6cI2gljNTDZ8jYmbAqirIZ+7uifqlpxMmUsJLSAItJ7/QRYGALefIzs3NQ2x+Dc2sabrvi8fGG5pYESHDNlwYSV/o6KU8Ta/a3hmL+/duU2UqtXnA7h2bkYIBsxQzXRMRncOOkw5TrZQH6xej7db0SXiXpLpxK2Gi7BGE0gFepAls4yWxo6Qjw1YMCa8kOgbI4spBCdBlrXRgSS/SUTDawG2ZQQKvC2ppAirN8//N+pgdwfs5+qiQkNWbJ75bvZLfJsEV/UR9IrvNcEHPaEg1KXaKGs1vsEokWoCPKLTZaOX0NJ+M1yL7Z5mbQop3nFfeKXji6uMlRmVfja6ltWAqFP4fffC2zJURLW0k/uOzk8tUh6Pv6+2EXR2GBwdL6+ZN4hJM2Mj2lteXMjDuePcZRVxPNC8Zq6mlAZDKjkhyXoHE48K6H1SrPpZnBZ2kbGTZm/7f9hifqGTjwICcK3aGnFqe4t3Vx4Cr9D0HDUbuVHG9IA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(396003)(376002)(366004)(136003)(451199018)(9686003)(186003)(53546011)(38070700005)(6506007)(2906002)(52536014)(33656002)(5660300002)(478600001)(8936002)(41300700001)(55016003)(7696005)(71200400001)(64756008)(66446008)(8676002)(66946007)(4326008)(76116006)(66476007)(83380400001)(122000001)(66556008)(86362001)(110136005)(54906003)(316002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xAUm+7siYkC5tyXX2hxuEWdJ3sM9/vVLfybjFra/bYEIrmbsn4pu4yzFuYQJ?= =?us-ascii?Q?QyUapgQfcP7mjIBn8yj2unDKqLogLHapHP4quv5R1TEU+1SvdvEBgAwvoRRH?= =?us-ascii?Q?QRI6nbs63LiU3eQdEu0lEDVQ/RMPtWT8sgxDw/qr9bXbTPrtq5VNpdYaH5fB?= =?us-ascii?Q?s0QCs+dBs1LBI4/vaDI75X+DoJVQjMSQI31M9V7b2mzV97kWP6uJhmBEJbUD?= =?us-ascii?Q?QDSEPCsAd8BR9gwa4r+V2EiDB8KQ9LXBh+42mSHNC6jmlmrsZO43NXVxj4Zw?= =?us-ascii?Q?oZjkKVmT3+fcMAXeg45stO90J/+/3rWqtRk7ObHxwN6PWDB1eUVYtPMSxxqg?= =?us-ascii?Q?YzASWY0KqGBcSbZknMEMbUUEWC4txpsv6P5dqjWGZ9ahKBHl2SmCgVgvHNjy?= =?us-ascii?Q?DGuMFcXFO9eA/6yRtmI1FwYY8w9HdrCXy3p8z2kLpoC97n03+l7ZqdSjkPUc?= =?us-ascii?Q?giVk+GmLol9g0JWAi1aDqqhlpUXIooCZPLN+c6PLDkDI1NuvrB2e2CEHlRKE?= =?us-ascii?Q?Y5VJ9Plq2YaqO0YMEIL12u76vdw72IgO/mefz5TQdFqURlG1iUH6vOlIW3+j?= =?us-ascii?Q?NOnP91HGXPT4WHIyBN1mp+DoTYnn+yabEQHHIyeK4rb9ItquLNn/2opegiMD?= =?us-ascii?Q?Va01YRMijMmJn4lZ/tgX68YD5As/5f2Vg3chzTK6sFoVOZjf5OkFFDIcbE4B?= =?us-ascii?Q?GgaQVUF/8JPmC6VnpfMpmAX/wW6xOV0SNDCsIJvEUB6Dyp0xd8ugcukGQ17Q?= =?us-ascii?Q?NwelfUodIT1rdnCpCWodbOVu0Qd77XA3hxjekB/9CB/7vDIlQIwjDJY5KbAA?= =?us-ascii?Q?JA/MK9XJdPDr4RELsOmg2/cYaZakqstb3AgY9hhRFRBYRC6iSXTUcDuF6ijy?= =?us-ascii?Q?EuZSSxWvDnpMI5DSl3ibwxIayE+g2LlG5WnxNUn12NvxaZ+xM4xow4NJ+pRc?= =?us-ascii?Q?ueVhP6h6TKJ7hLRtChfZdVlvqp7xoykpo+48avNuNOxSoCKQX7WMiD8dqOpH?= =?us-ascii?Q?LFfIFKw1OTu7wSo8Qnyj+3HW9PtIYkD5CKyoAx4ctaz4kJ1UpTiETSupB686?= =?us-ascii?Q?I74PP1la9dhvtn/pj1mQdRrlIcRkkQOzufeeXVjr9SwI+WpnFHvvCkt2ZM3/?= =?us-ascii?Q?j4oFbpMghtCVEym+m02kwkShhJmU2p/p0PFJpIQksJjMTz/LjlQceecd5XS3?= =?us-ascii?Q?E+ALCv/z6mp2/stJFTNFOOvJNTRRWqIGUOKm5F7FpZ7Cwq1prd8HmnVuVXZ4?= =?us-ascii?Q?GxeAXoo1lm6TtCWITAhYI2sPoCpXxtW8XCbka2xEHd9Xnnos+oelj3RCAKOm?= =?us-ascii?Q?DCZapfBX1ObvKRsEp3hqXCt99SX06qJ8gJZPe1mC7gSSP+emR+c/4VwnnMbL?= =?us-ascii?Q?opZku93R5re+LPMceM/8szdyUmLM3yiqSfNsjstPX1rnJQQdPARZdSxouzf2?= =?us-ascii?Q?gUEwgov0woX98QCFDC0mKQ7zy82YOrtoFor7TJx6qcMrafUKZlYWQJbz9NoG?= =?us-ascii?Q?1jtWROxQUWN4OKYjpD6v+IQO4AhcZsKXkttIibeg4jeBVutXhIdcTCgwkTcZ?= =?us-ascii?Q?VK33cY5WrijHtu8ouVdfMmjlMd8JjqsP6O1BJn6PFQkyIwfPTRNdmEf+08tW?= =?us-ascii?Q?X33LY+U9BhTeYJ+syfdWyDBiJ+AMfs0K3/p0duAN2NBS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcccb970-efc9-47c6-116a-08db0a84d45f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2023 10:03:01.7862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QDyGVE6BEmjUBFNKIa7vKlX971jrwvILGyLYZW4CcbqTXj7B3nRHGqz/PmJ2y/XQEQsRTqFthVhnOoltANpyEFw4tV/q6CZm3Xw4goS2ctg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3639 X-Proofpoint-GUID: LcwshN5WFNn6zb_3MnWBZMRcc8L8_yBQ X-Proofpoint-ORIG-GUID: LcwshN5WFNn6zb_3MnWBZMRcc8L8_yBQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-09_07,2023-02-08_02,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please ignore this version. I will resend the patch. > -----Original Message----- > From: Amit Prakash Shukla > Sent: Thursday, February 9, 2023 3:26 PM > To: Reshma Pattan ; Stephen Hemminger > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > david.marchand@redhat.com; Amit Prakash Shukla > > Subject: [PATCH v6 1/4] pcapng: comment option support for epb >=20 > This change enhances rte_pcapng_copy to have comment in enhanced > packet block. >=20 > Signed-off-by: Amit Prakash Shukla > --- > v2: > - Fixed code style issue > - Fixed CI compilation issue on github-robot >=20 > v3: > - Code review suggestion from Stephen > - Fixed potential memory leak >=20 > v4: > - Code review suggestion from Jerin >=20 > v5: > - Code review suggestion from Jerin >=20 > v6: > - Squashing test graph param initialize fix >=20 > app/test/test_pcapng.c | 4 ++-- > doc/guides/rel_notes/release_23_03.rst | 2 ++ > lib/pcapng/rte_pcapng.c | 10 +++++++++- > lib/pcapng/rte_pcapng.h | 4 +++- > lib/pdump/rte_pdump.c | 2 +- > 5 files changed, 17 insertions(+), 5 deletions(-) >=20 > diff --git a/app/test/test_pcapng.c b/app/test/test_pcapng.c index > edba46d1fe..b8429a02f1 100644 > --- a/app/test/test_pcapng.c > +++ b/app/test/test_pcapng.c > @@ -146,7 +146,7 @@ test_write_packets(void) > struct rte_mbuf *mc; >=20 > mc =3D rte_pcapng_copy(port_id, 0, orig, mp, pkt_len, > - rte_get_tsc_cycles(), 0); > + rte_get_tsc_cycles(), 0, NULL); > if (mc =3D=3D NULL) { > fprintf(stderr, "Cannot copy packet\n"); > return -1; > @@ -262,7 +262,7 @@ test_write_over_limit_iov_max(void) > struct rte_mbuf *mc; >=20 > mc =3D rte_pcapng_copy(port_id, 0, orig, mp, pkt_len, > - rte_get_tsc_cycles(), 0); > + rte_get_tsc_cycles(), 0, NULL); > if (mc =3D=3D NULL) { > fprintf(stderr, "Cannot copy packet\n"); > return -1; > diff --git a/doc/guides/rel_notes/release_23_03.rst > b/doc/guides/rel_notes/release_23_03.rst > index 1fa101c420..bb435dde32 100644 > --- a/doc/guides/rel_notes/release_23_03.rst > +++ b/doc/guides/rel_notes/release_23_03.rst > @@ -116,6 +116,8 @@ API Changes > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >=20 > +* Experimental function ``rte_pcapng_copy`` was updated to support > +comment > + section in enhanced packet block in pcapng library. >=20 > ABI Changes > ----------- > diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index > ea004939e6..65c8c77fa4 100644 > --- a/lib/pcapng/rte_pcapng.c > +++ b/lib/pcapng/rte_pcapng.c > @@ -466,7 +466,8 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue, > const struct rte_mbuf *md, > struct rte_mempool *mp, > uint32_t length, uint64_t cycles, > - enum rte_pcapng_direction direction) > + enum rte_pcapng_direction direction, > + const char *comment) > { > struct pcapng_enhance_packet_block *epb; > uint32_t orig_len, data_len, padding, flags; @@ -527,6 +528,9 @@ > rte_pcapng_copy(uint16_t port_id, uint32_t queue, > if (rss_hash) > optlen +=3D pcapng_optlen(sizeof(uint8_t) + sizeof(uint32_t)); >=20 > + if (comment) > + optlen +=3D pcapng_optlen(strlen(comment)); > + > /* reserve trailing options and block length */ > opt =3D (struct pcapng_option *) > rte_pktmbuf_append(mc, optlen + sizeof(uint32_t)); @@ - > 564,6 +568,10 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue, > &hash_opt, sizeof(hash_opt)); > } >=20 > + if (comment) > + opt =3D pcapng_add_option(opt, PCAPNG_OPT_COMMENT, > comment, > + strlen(comment)); > + > /* Note: END_OPT necessary here. Wireshark doesn't do it. */ >=20 > /* Add PCAPNG packet header */ > diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h index > 86b7996e29..4afdec22ef 100644 > --- a/lib/pcapng/rte_pcapng.h > +++ b/lib/pcapng/rte_pcapng.h > @@ -125,6 +125,8 @@ enum rte_pcapng_direction { > * The timestamp in TSC cycles. > * @param direction > * The direction of the packer: receive, transmit or unknown. > + * @param comment > + * Packet comment. > * > * @return > * - The pointer to the new mbuf formatted for pcapng_write > @@ -136,7 +138,7 @@ struct rte_mbuf * > rte_pcapng_copy(uint16_t port_id, uint32_t queue, > const struct rte_mbuf *m, struct rte_mempool *mp, > uint32_t length, uint64_t timestamp, > - enum rte_pcapng_direction direction); > + enum rte_pcapng_direction direction, const char > *comment); >=20 >=20 > /** > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index > a81544cb57..9bc4bab4f2 100644 > --- a/lib/pdump/rte_pdump.c > +++ b/lib/pdump/rte_pdump.c > @@ -122,7 +122,7 @@ pdump_copy(uint16_t port_id, uint16_t queue, > if (cbs->ver =3D=3D V2) > p =3D rte_pcapng_copy(port_id, queue, > pkts[i], mp, cbs->snaplen, > - ts, direction); > + ts, direction, NULL); > else > p =3D rte_pktmbuf_copy(pkts[i], mp, 0, cbs->snaplen); >=20 > -- > 2.25.1