From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9ED042C02; Thu, 1 Jun 2023 13:22:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1684406B3; Thu, 1 Jun 2023 13:22:47 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id C02B2406A2 for ; Thu, 1 Jun 2023 13:22:45 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3519maMe009681; Thu, 1 Jun 2023 04:22:44 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3qxs1b8ap9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Jun 2023 04:22:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V9Gt2AIkEc+znzq0QxELWwAcqXUOWBadMHOPzZV5oDg8rX9/g08jJsdXf5EaSR930FAdkjLlE8mSqMFk7/p4j3AAzm1ol1++y9mhYc5RJMTrpvlRKK9ZgAtPSDmC/eMXitjqyztyQwBo1HYk6HFd0NXFv/8ilydpAUNRQid1GXuNVROWCws8i9w0ycfsDEUKQxJvyBXTE10YbWE+7RrROloLi802fYLPUkkIAKaokEoStA4tJ0Ljyc0qTw2KiF3Sad9pIvthUTU3zqReNF6FmOuw15K+pXVFcSBFv6GGEr262A0+ALxFDXJJqhVnuHbMPzNg5zwVV5oLcPHImVUeEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HI+U3hZHZvP49I5QaU+CShp/TToxUwD+6Io0r6tIow8=; b=F3dnfo4vv9eUGZn4RIAQkfsDkqD9OoOXoNi1AObLem8SppdfkluMIEVOOTnMPIlDhbedIqB9KBtR5OmpmALjNi/9TVGGLMcFj/z8jN1xCDk33OShZSQLXD66pQYfe3ntTfk8HEGxGoPg4VS9VwV8rWiMZZRCEG444gSYq9HWTP9fmsYNvKYuf1Li/3A4TctgAUgzKs+LHGdbemTZlBGUraogv02VxWumXImmgdUphLbToA+il338hoQ6AdodH0mq2o67vvIkMbgKUzNS7ViXcBaG6kuDKgJEUu+LxEirjhERezdfvxfwuun9AyZoeymeyKcQ/hnaisDgQgnkAMyIrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HI+U3hZHZvP49I5QaU+CShp/TToxUwD+6Io0r6tIow8=; b=J5TISywyxZ8z/1VwSJShHKsYRBr/q7wBF9bnKyLzFRcK/jGSK2ekgAsSfbZnwxWHJu4zTm2iWYkaL2KA9ltBnXwDS2hbLSGamkbWLoFg1GpzcIe613MATLfpyp0ybzIJFGqvo9CRweRYK7oqidx6vdLTx5UIMxp/ahds84UdSTo= Received: from PH0PR18MB5167.namprd18.prod.outlook.com (2603:10b6:510:168::7) by SJ0PR18MB3835.namprd18.prod.outlook.com (2603:10b6:a03:2ee::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.24; Thu, 1 Jun 2023 11:22:38 +0000 Received: from PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::75fe:8527:aaf:bbda]) by PH0PR18MB5167.namprd18.prod.outlook.com ([fe80::75fe:8527:aaf:bbda%7]) with mapi id 15.20.6455.020; Thu, 1 Jun 2023 11:22:38 +0000 From: Amit Prakash Shukla To: Stephen Hemminger , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram Subject: RE: [EXT] [PATCH v2] graph: fix pcapng file support Thread-Topic: [EXT] [PATCH v2] graph: fix pcapng file support Thread-Index: AQHZk+VD9Bi/h8QuKEeFRRkDTQ8qsK91rG7g Date: Thu, 1 Jun 2023 11:22:38 +0000 Message-ID: References: <20230530190834.142932-1-stephen@networkplumber.org> <20230531172753.65074-1-stephen@networkplumber.org> In-Reply-To: <20230531172753.65074-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW1pdHByYWth?= =?us-ascii?Q?c2hzXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02?= =?us-ascii?Q?Yjg0YmEyOWUzNWJcbXNnc1xtc2ctOWE1NTM2NDAtMDA2ZS0xMWVlLWI2ZDct?= =?us-ascii?Q?Y2QyODFjY2U5OGE2XGFtZS10ZXN0XDlhNTUzNjQxLTAwNmUtMTFlZS1iNmQ3?= =?us-ascii?Q?LWNkMjgxY2NlOThhNmJvZHkudHh0IiBzej0iMjU1MyIgdD0iMTMzMzAwOTIx?= =?us-ascii?Q?NTQ2NTMxOTkzIiBoPSIzay9CSUxVUU1LZmFIRGR3R05XT0lwK09EOVk9IiBp?= =?us-ascii?Q?ZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2dVQUFO?= =?us-ascii?Q?NFBBQUNaWkFOZGU1VFpBVnZ4YzZtM1ZqNy9XL0Z6cWJkV1B2OFpBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCdUR3QUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBRUFBUUVCQUFBQUk3cVRwQUNBQVFBQUFBQUFBQUFBQUo0QUFBQmhB?= =?us-ascii?Q?R1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdNQWRRQnpBSFFBYndCdEFG?= =?us-ascii?Q?OEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUF3QUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFB?= =?us-ascii?Q?QUNBQUFBQUFDZUFBQUFZd0IxQUhNQWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdV?= =?us-ascii?Q?QWJnQjFBRzBBWWdCbEFISUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFC?= =?us-ascii?Q?akFIVUFjd0IwQUc4QWJRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlB?= =?us-ascii?Q?TUFBeUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5n?= =?us-ascii?Q?QUFBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?us-ascii?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFBSE1BZEFC?= =?us-ascii?Q?dkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQWFRQjBBR1VB?= =?us-ascii?Q?Y2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFB?= =?us-ascii?Q?QUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRzhBYlFCZkFITUFjd0J1?= =?us-ascii?Q?QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFB?= =?us-ascii?Q?bmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZB?= =?us-ascii?Q?RzBBWlFCekFITUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFY?= =?us-ascii?Q?d0J6QUd3QVlRQmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFH?= =?us-ascii?Q?Y0FaUUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dB?= =?us-ascii?Q?Y0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZB?= =?us-ascii?Q?R1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFHRUFa?= =?us-ascii?Q?QUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUNBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNB?= =?us-ascii?Q?QUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISUFid0JxQUdVQVl3?= =?us-ascii?Q?QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QVl3QnZBRzRBWmdCcEFHUUFaUUJ1QUhR?= =?us-ascii?Q?QWFRQmhBR3dBWHdCaEFHd0Fid0J1QUdVQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFH?= =?us-ascii?Q?RUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QnVBR0VBYlFC?= =?us-ascii?Q?bEFITUFYd0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQUY4QVlRQnNBRzhB?= =?us-ascii?Q?YmdCbEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUY4?= =?us-ascii?Q?QWNBQnlBRzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFISUFaUUJ6?= =?us-ascii?Q?QUhRQWNnQnBBR01BZEFCbEFHUUFYd0JvQUdVQWVBQmpBRzhBWkFCbEFITUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFB?= =?us-ascii?Q?Q0FBQUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUdFQWNnQnRBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-rorf: true x-dg-refthree: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFB?= =?us-ascii?Q?QUFBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFad0J2QUc4?= =?us-ascii?Q?QVp3QnNBR1VBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdB?= =?us-ascii?Q?QUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQVl3QjBBRjhB?= =?us-ascii?Q?WXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBYlFCaEFISUFkZ0Js?= =?us-ascii?Q?QUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3QmpBRzhBWkFCbEFITUFY?= =?us-ascii?Q?d0JrQUdrQVl3QjBBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFB?= =?us-ascii?Q?QUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VBY2dCMkFHVUFiQUJzQUY4QWNBQnlB?= =?us-ascii?Q?RzhBYWdCbEFHTUFkQUJmQUc0QVlRQnRBR1VBY3dCZkFHTUFid0J1QUdZQWFR?= =?us-ascii?Q?QmtBR1VBYmdCMEFHa0FZUUJzQUY4QWJRQmhBSElBZGdCbEFHd0FiQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFu?= =?us-ascii?Q?Z0FBQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J3QUhJQWJ3QnFBR1VBWXdCMEFG?= =?us-ascii?Q?OEFiZ0JoQUcwQVpRQnpBRjhBWXdCdkFHNEFaZ0JwQUdRQVpRQnVBSFFBYVFC?= =?us-ascii?Q?aEFHd0FYd0J0QUdFQWNnQjJBR1VBYkFCc0FGOEFid0J5QUY4QVlRQnlBRzBB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFB?= =?us-ascii?Q?QUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBYkFCZkFIQUFjZ0J2QUdvQVpRQmpB?= =?us-ascii?Q?SFFBWHdCdUFHRUFiUUJsQUhNQVh3QmpBRzhBYmdCbUFHa0FaQUJsQUc0QWRB?= =?us-ascii?Q?QnBBR0VBYkFCZkFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCdkFISUFYd0JuQUc4?= =?us-ascii?Q?QWJ3Qm5BR3dBWlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCdEFHRUFj?= =?us-ascii?Q?Z0IyQUdVQWJBQnNBRjhBY0FCeUFHOEFhZ0JsQUdNQWRBQmZBRzRBWVFCdEFH?= =?us-ascii?Q?VUFjd0JmQUhJQVpRQnpBSFFBY2dCcEFHTUFkQUJsQUdRQVh3QnRBR0VBY2dC?= =?us-ascii?Q?MkFHVUFiQUJzQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUVBQUFBQUFBQUFBZ0FBQUFBQW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3?= =?us-ascii?Q?QndBSElBYndCcUFHVUFZd0IwQUY4QWJnQmhBRzBBWlFCekFGOEFjZ0JsQUhN?= =?us-ascii?Q?QWRBQnlBR2tBWXdCMEFHVUFaQUJmQUcwQVlRQnlBSFlBWlFCc0FHd0FYd0J2?= =?us-ascii?Q?QUhJQVh3QmhBSElBYlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FB?= =?us-ascii?Q?QUFBQUNlQUFBQWJRQmhBSElBZGdCbEFHd0FiQUJmQUhRQVpRQnlBRzBBYVFC?= =?us-ascii?Q?dUFIVUFjd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJ0QUdF?= =?us-ascii?Q?QWNnQjJBR1VBYkFCc0FGOEFkd0J2QUhJQVpBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBRUFBQUFBQUFBQUFnQUFBQUFBIi8+PC9tZXRhPg=3D=3D?= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB5167:EE_|SJ0PR18MB3835:EE_ x-ms-office365-filtering-correlation-id: 9d15e9f1-8fe8-446d-eaaf-08db629281a4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NL7bg29Tf0iP8JdWU8ZqWp0X97We2dWJhAfivZR+UOwt/BkHEU17AJk9HYA99XEvA4kjAVh3kqniq1QK4ThSvoJt6uinSchvTLGXnCZ7Gvg0FzlttmMgJTv12nD8P9QlXsySUDyX4ynS8tnW8sBnuZkxezXSZSAdrq2+cQiIeBui0xU7dtGFP5bseC+9FP1aTqUaEAg82xO7S1vmiIzFqZQAtVX43EqHzOonI5fq86gp8AfKtdCWXI1CnfVztpejOgnRjNxh4pF4R2XYFzD3CuhApr7xA1VI5IWd4aRKb3UgF6PqheVBRC0UErNjbIfqPVZ1jJX/7Ih7P/rZWUZzdfXf/MxNTwH0mP7lSyaTBu3f7qBRBGmIi4qtibYBno+192cIJzU0wzN7aSfd+BjuNsKdal2AH6vBjpahecrE8w7Sd3aCb3CRnYW8SBfVX2F7t8Qr3Kec5G2mkx1ZxccPD5auccaUGhqneWN/yJ1HrYsqz38A3k8jNoLx8IFIyIKNIiT1IVLmLTL3JJlpKAEM5Bmj0uze5K/53wJIucmwmYQ/LFzISyGNEwQDzSp4x3mn+X5vPydoSW66NbSoHodt6poUirArdunhAFg2nVvlJc/cOwZj0K1drkAiv+Pwhfea x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB5167.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(451199021)(71200400001)(53546011)(26005)(9686003)(6506007)(107886003)(55016003)(7696005)(41300700001)(33656002)(4326008)(316002)(64756008)(66476007)(66946007)(66446008)(66556008)(2906002)(76116006)(122000001)(52536014)(5660300002)(8936002)(83380400001)(8676002)(38070700005)(86362001)(478600001)(186003)(38100700002)(54906003)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xWPCzYNZyM97tIGAHz52w+ALqtRMzkHe2f5PkBuB5mrbTwEsGfAPXK8NVHxr?= =?us-ascii?Q?upFpz4ij09CmsmBez+LvQhwCcAcQ1JEtrlUow4FICLpGaKNYSntRs6plBhg7?= =?us-ascii?Q?w3543U5yeqGswK25MzVJF2F8UkeQFRzeoCzhhl10lAWWvlCl+VPakJ7MU9xU?= =?us-ascii?Q?mnv1rAAdxnVOhxWTLtfPViSV5NP4Q517PR1MPVkpCcD4V6tP1jOtul4/Qzu4?= =?us-ascii?Q?aBtiIA3Gl9Jj0Kf0OKX8DICmfkroli+B1sW6CybBd3DIDc1s6QM8FmvHV+cx?= =?us-ascii?Q?KN5JwQu0sdQ7yyMvuDYBvJULSy6ovdBlGotCwo/XdE4GfkrF1S7Lbtdx7FG6?= =?us-ascii?Q?e4acZU2cuMD7c/PNeaTHG71tSN8GF2KyMkpMRumVvr/dR5uq6ZoWVApovKAi?= =?us-ascii?Q?mXDFZAN2c7mxC/eZEHfxX5biNRyl5NcHVeogu60RTs/++D0nLQkQdcqkuCq9?= =?us-ascii?Q?acXfPYTjoUeAOMZAhaR6zkKhCJQdUwvCKI2655s5RodsWxl5alG1daekaftf?= =?us-ascii?Q?2QMVgWYpl+CJ/hj51p0jE2Feb6w0ea+4zpDNIweI+kHi+okImiZwbPLOEzmb?= =?us-ascii?Q?xTc9Hl41adF+PxxF+bQGPEONcQolkdeyV5pFitfDBHs7VsIcRh1VJXV04HX7?= =?us-ascii?Q?GQ2ImaAyBOSFbrTBvG0ld9/8rb53aHtfOT8psV20sV5X12AqLqY9j8UvNphl?= =?us-ascii?Q?EAMH1k5W+LX+uCF+zcqaGF9uqWtAA6ed0S2BwVdPzHzR2EFrWFeLpohAnO/E?= =?us-ascii?Q?3dwVGzkIMDqHRrgSlCZJsbwq6489eQqygdIxGzcGNgPy2JFeGPYFlJijW41x?= =?us-ascii?Q?eBGP+dAR4VK9iBEkLw8ryDuselR8+3uPuaUVwtwrz/2oitCEZlgbfjExIK3R?= =?us-ascii?Q?k+aj7PMpQ86ymXHCBJa428M6exIBok9zmO6jrqSzDm8Dep6s6BbX3tczBXqP?= =?us-ascii?Q?TPKfuaPSHYGOHD4AjVWjYDotqcvpfPuPJQxeFicUA7OTsw0B9dHioZ05sdxF?= =?us-ascii?Q?MvP+mNHpDghkMOM0WTOSHNb6mr8AChaRWX3t7VcUBqSh5Z7E+0TSw+FvDnlx?= =?us-ascii?Q?SEM/zvZXkQcePCr7nOQG7NoelfjMqb3+JDHf330a8HbUKlJJN0DilY2zv2vc?= =?us-ascii?Q?NeajnZjajnRsS16eX2ZHwa4J5g384ME0Vl6RzzO8aQfNywRmygyvGJnB6BsU?= =?us-ascii?Q?CG5gLyG/2V9F6CZMTIxfku+AQ1rs8Yabe26kPIsVSIRQNk0Wd39lSYuGSWaM?= =?us-ascii?Q?/30ehjUFKWr05kOJwC/u8neqi6oUHsG2l+QQ4tJHnSc6GJuI5GLguvM/dVMQ?= =?us-ascii?Q?lwpA3FUwwNGLrc51OFuml+C6xUfRxpruA3zpngzog0ZhYntnesjPkF8I+USe?= =?us-ascii?Q?YVrRu8ODhcdr0aocsXL4jsQUWvP0PlUfpWZLi5Yx+OOt0/LbFhB3Ks69V5N5?= =?us-ascii?Q?7fHRpxTU6WGab1ULzEoL5ywg9TKinYUdL1lqHig8NTeoyKlpVNlXK0NaJ/+i?= =?us-ascii?Q?mEY7f5i+v7H1VjYVRrqmHUa0MPZe6Uppd44S7cv6TNd4gUoc1c5XEB3eNcT1?= =?us-ascii?Q?GFOuZ38vbuXSZRq1D0xEne+fZ3Q8iOIUy0dY+iBO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB5167.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d15e9f1-8fe8-446d-eaaf-08db629281a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2023 11:22:38.2326 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0F+fc64YtwjLcZXwpcVRsuLUqVtfM7SYtsD0G/evyJnyZhV8LbIS8E3ER9W4hoGuFkr1/IxUQaHq5yruKUVyRq+2bvW48VaigPtiYAZ6Q8I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3835 X-Proofpoint-ORIG-GUID: SRCOwDpayS5Rp2d8PUG52fJtnStPtaMl X-Proofpoint-GUID: SRCOwDpayS5Rp2d8PUG52fJtnStPtaMl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-01_08,2023-05-31_03,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Wednesday, May 31, 2023 10:58 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Jerin Jacob > Kollanukkaran ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > > Subject: [EXT] [PATCH v2] graph: fix pcapng file support >=20 > External Email >=20 > ---------------------------------------------------------------------- > The interface to rte_pcapng changed in last release > so that the interfaces used need to be added to the pcapng > file via the API. If this step is missing the pcapng > file will not be valid and can't be read by wireshark etc. >=20 > Fixes: d1da6d0d04c7 ("pcapng: require per-interface information") > Signed-off-by: Stephen Hemminger > --- > lib/graph/graph_pcap.c | 25 ++++++++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/graph/graph_pcap.c b/lib/graph/graph_pcap.c > index 6c433300290b..db722c375fa7 100644 > --- a/lib/graph/graph_pcap.c > +++ b/lib/graph/graph_pcap.c > @@ -7,6 +7,7 @@ > #include > #include >=20 > +#include > #include > #include >=20 > @@ -80,7 +81,8 @@ graph_pcap_default_path_get(char **dir_path) > int > graph_pcap_file_open(const char *filename) > { > - int fd; > + int fd, ret; > + uint16_t portid; > char file_name[RTE_GRAPH_PCAP_FILE_SZ]; > char *pcap_dir; >=20 > @@ -110,12 +112,29 @@ graph_pcap_file_open(const char *filename) > NULL); > if (pcapng_fd =3D=3D NULL) { > graph_err("Graph rte_pcapng_fdopen failed."); > - close(fd); > - return -1; > + goto error; > + } > + > + /* Add the configured interfaces as possible capture ports */ > + RTE_ETH_FOREACH_DEV(portid) { > + ret =3D rte_pcapng_add_interface(pcapng_fd, portid, > + NULL, NULL, NULL); > + if (ret < 0) { > + graph_err("Graph rte_pcapng_add_interface port > %u failed: %d", > + portid, ret); > + goto error; > + } > } >=20 > done: > return 0; > +error: > + if (pcapng_fd !=3D NULL) { > + rte_pcapng_close(pcapng_fd); > + pcapng_fd =3D NULL; > + } > + close(fd); > + return -1; > } >=20 > int > -- > 2.39.2 Looks good to me. Thanks. Acked-by: Amit Prakash Shukla