From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55A1BA0093; Fri, 17 Jun 2022 12:23:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED1D140DDD; Fri, 17 Jun 2022 12:23:37 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id F17DB40698 for ; Fri, 17 Jun 2022 12:23:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655461416; x=1686997416; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ps18D7k+PsGEAuGwgspOvcl03L4H1G+aGIc7fohub1o=; b=oIjCLpKbsVPKvJ4h8ssCu64t/tsrigXinLCksTW30snhPuOIbnpAMxPa oKD1aXIYRhej59R9soNCNJCqCGR/7JVqrAdTkYKqm5bMFBNXvExA8M1B/ s9diLsXNuUeiaSi3gRLEjV9oPfsx17LhTCGgjVFkljTG779/T1otIInNo MXNLKBymQfXz7smxaE3iZELN3yKIbcVbeDv9jSrTJGYqFLpSboXKGR1Zz FGUlV4vLT0rgoMDJB/PzoqJzsDWZBgnxY56tlnSt+jqp6FPTIyG/GSbmc Y6HcrkDJct6f1A/P6HjcJKFKc8nmPkLWet9qwY9nKc6pN/FForf4ZJj6W A==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="262493321" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="262493321" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 03:23:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="590068228" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 17 Jun 2022 03:23:34 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 17 Jun 2022 03:23:34 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 17 Jun 2022 03:23:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 17 Jun 2022 03:23:33 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 17 Jun 2022 03:23:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WOj3Lmy1fxiR67S5kZ68pzYll+uNZw5VUQZc/e6HTy5UiTpwA8sGIQ1jY2mPLva0fqL5iCg55t7KoOE86yDckClEj4JbAxIWyd8s2rwSV9ko7RrzILTG3Sr5nFofl8DTvvVeW5Ck+ydF1CWhZdHMZ81gGnaUbeHz+BwikSPbOTLe8FIe30VP2+lZT5ADH/Xhu1Cv41Xz0XrIKQe+T/+C4HNeOIs44TTUjyLPyvklmcFHPA7m+66tYbYXRNtDYd0naMZMlyu1twDMJQPdcorQ19IcF1sKv4EQHLmB89fOSwDFlL34uTYagPpYbUZskKi2+Z6Ofl0FRCfbKGd7k3EfOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NJUgSxit+gEAThbntKcUge4BK+kMYjuHQW3DqpR1otg=; b=GsjMa0ia81TqwPCAAPJ3sP61iiTYcOjLIBRFd+WPDMLyRgSuvkc4Ek7l2Jr1xLmw3lwwRFFGjmFBMd1lfhQW9StLkXPVu9xgbUPf5JK50J+KxQ9CAaALyMyIMPMwjwcdoUAeTS+BY20r4APoelp3ZEftwfRhWdrBGkwqC7PZUqR3Cc0qKCo+m43E7TO3aMUCEGE3F6Vg1VqQN5KGXKZwXsuIxj7FYwxL5aEKZwvcMJHauU3UkOQwCuJzWMoE5VKAWzyU/NNtgOLr+BoN/vaEVg0nrfOp8W/rKS57K3bBqq17zAOcsjcCDZ5niAUDuO4TyaYS1dvuoKW1Ca+Ied3frw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5817.namprd11.prod.outlook.com (2603:10b6:510:13a::14) by MWHPR11MB1648.namprd11.prod.outlook.com (2603:10b6:301:e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Fri, 17 Jun 2022 10:23:27 +0000 Received: from PH7PR11MB5817.namprd11.prod.outlook.com ([fe80::6024:7f58:ffc6:64ce]) by PH7PR11MB5817.namprd11.prod.outlook.com ([fe80::6024:7f58:ffc6:64ce%2]) with mapi id 15.20.5332.020; Fri, 17 Jun 2022 10:23:26 +0000 From: "Zhang, Roy Fan" To: Ashwin Sekhar T K , "dev@dpdk.org" CC: "jerinj@marvell.com" , "skori@marvell.com" , "skoteshwar@marvell.com" , "pbhagavatula@marvell.com" , "kirankumark@marvell.com" , "psatheesh@marvell.com" , "anoobj@marvell.com" , "gakhil@marvell.com" , "hkalra@marvell.com" , "ndabilpuram@marvell.com" Subject: RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch Thread-Topic: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch Thread-Index: AQHYfOYwgQGD4679GUu1z4hLaSTfZa1TbUuw Date: Fri, 17 Jun 2022 10:23:26 +0000 Message-ID: References: <20220610162113.1827884-1-asekhar@marvell.com> In-Reply-To: <20220610162113.1827884-1-asekhar@marvell.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 79e313dc-b5e1-415e-a596-08da504b6a80 x-ms-traffictypediagnostic: MWHPR11MB1648:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VZGQy3XyEUFbtELZRxzr/iZUkTrm1Qlc8zGpOh7qCmWgvyNlrom1az0zA5Ss4hoNy4mCAxyQzjnvJYZ/AJ3dC9m8vVp8qnABBaJ7cTFJYs0SAaoApu/25XqYk1/lZcLEcWoaxNeAnrkgahehd1xr2unj3uKS1fbaUhpk7CzWwJnYpbk/wrt1gu3V+BIkR7eFM6aGWWC1Kb9JC7lt17cgILSPsjN3koK5GwTda0lFahu141xGPsyTKyB5Mj4ciDwIr6hWQVxucxf3UMBqTEd9N3G/erlOcuN/wKqDbHTHWGmwf72cFSDftGW2aXrlH9SdK+H0JVtB8OXB3Gpy9IOPL+SzxiM3vpR/ScPCEp+a+BExqZlYFSlVK8QxP4qJ5rpbyCjIJzeJMU296TwvRhzUEMcbcADFtihULo4uWXf+xfK/CAaMGQWXJFsS335dtOFjPZaNjGpk+RuYLAxDhjN75SFYkZMA8+UVakluiBMAwCTWEe9w7ng7n13HBTTRqscvJ+ivQcYYN6VR9N4VtY+itAaBHF5sjjiYe2jHiwaGzQBZxUl3jK2gRkuyhPL0KaI22s1yarkTzPqoeNv/v4NHOqls9SyUAkfW+XS+hTxUH0/X95kllxYSR9dqweKxPE9zvrQC0dc5O/mX3LXrKsaJL9CXCUebe51yfXSWOGKav4i0RvFofi8ck6tElfKFCO3kRWs6k36DxCnXovsXLgvYaA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5817.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(2906002)(7416002)(55016003)(498600001)(8676002)(5660300002)(8936002)(6506007)(26005)(53546011)(71200400001)(7696005)(52536014)(33656002)(83380400001)(38100700002)(76116006)(86362001)(66946007)(110136005)(66556008)(4326008)(186003)(66476007)(122000001)(64756008)(66446008)(38070700005)(316002)(54906003)(9686003)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?Dt10UMmZrwvAYog4a6JhgbI6UPJ7n00Oc1lhwhj0NTzxFlB1s+YruAvR?= =?Windows-1252?Q?2glKy11+hRO89ygTCNJAGuhLl234cdii8BC5Y9BQRoyLu4rrqOA3GbNN?= =?Windows-1252?Q?+EDBqdFB7yQqZ6ubPniiXYZBGQtcxTSHhidQ7TSNwyUNMiForSsTnusX?= =?Windows-1252?Q?1bLVc5a33qUzVw7nIoMyCp4d2ot6L/a9Pgp2LaxsSge8fdULN4ScHYnr?= =?Windows-1252?Q?l2d4fIg/QXu5l/0cXMvnbGav2++5ovtGN6Wo15zxRtnJEN/Hsaesa0DH?= =?Windows-1252?Q?6FRp8ImbegdSSfsyAApv8Vdp4+rgcqqAiPCiXT5af6Y2cVRsSRrWnmXk?= =?Windows-1252?Q?AFU2gLBm9A/VVe9qGZXJ5A7Lj1MsIgsmh2NVTHpSZwBeme5tbxqr26N7?= =?Windows-1252?Q?1VrPWssThK9j0rHoIV4bsRdmi5PCWQ5SPD2lASGUfudPWE3c9CYMRJUL?= =?Windows-1252?Q?8gqKw6RPmu9Zk4wxzk6GZs6+wFLQ/lJ3NY+tok8AUDTNeOrWa/eu3Nkm?= =?Windows-1252?Q?e59diXraA5p0psajM/a3SNNIgs0p6G7bG6eYvtZAIMpPr93NRcrGFAGQ?= =?Windows-1252?Q?2JwTYhPSIQ9AuDnFXBo74pInh1PYZK2SQ3rEOgUhKpdUPsqYuNiXhud4?= =?Windows-1252?Q?Pj/7p/O9jmALgene4gdI04jreCUgi+MYrr6xdG7nDsfK2x7WsjgtxDqB?= =?Windows-1252?Q?kJKMz/oL3+EF1fiPbx2V4JmAkYkyPWpuNujxZIgwsvWROqThDvurm+bP?= =?Windows-1252?Q?tk9RozMVuBm7pLJdelIT2I+rXHJ8NrSQQ0K6Crl5H7GAPQ2VauBJBBkv?= =?Windows-1252?Q?nv46yaCBpj5jIjPiew/oQUTL2jNgFU1RCqHjXqfkbJttgjIOk6OyO3nJ?= =?Windows-1252?Q?iajmyZFohJ5fqEyQaWdpejEQkR0ImFVnR3OsO6tCtWMU3qQd2gbc69gC?= =?Windows-1252?Q?K+QNlPS+pCtato0SHE2nVJ0IzHGl/8szXiJA5r3MXJ8XGkAPXKT6pq+G?= =?Windows-1252?Q?Lj4K1Dyqq1Uk3NwdMSN1hbj+xmovsSpH9DigYMunQYboDeI3nQzHMQjm?= =?Windows-1252?Q?tvMAU9J5U5QREetmXypzCzp/mINI7g/K7rToEMalvVim1trtzyWAsS0p?= =?Windows-1252?Q?6BcPiOPWGJF75H984ElSsJjoFXLsABSZfJXcxJXKlqyes/vXyUgzN6Zj?= =?Windows-1252?Q?0gyk6XPOOgbWlwI0RXzFqUL1jDAyTbDyktp8FWHNaylADsO64iOzi7l/?= =?Windows-1252?Q?yrw3A7S5NRnYvicZ3QOVBFNSGOZ0tk5vVpSvXJcoyJRXpPNyV6NYPbhA?= =?Windows-1252?Q?cSmesM7mCHY6sxtesCO3G6T5FnsjgyCrN+FP+gUMPhzFUFzT1mAe4zXC?= =?Windows-1252?Q?jCC/E6+5Xt4UGbz+ei2Kp7tLkfnk8VzWxGwNGjjQZWkqoXx/Pjt/DgIh?= =?Windows-1252?Q?f4ZdgRJzSqxs3lte2m+mXfvLqh8skayZxowtAur5MzFiaf7blFtJmXhw?= =?Windows-1252?Q?/KEqFHSJH2HwW4wKuJxyPk0dka0WJBkOrTndca4zKauum0A4okqeACz+?= =?Windows-1252?Q?tkIOHekFvmCGdNgla1sjTEOQjm7ew48vLCFcF7hiaUmpBH8jIqrDwzOi?= =?Windows-1252?Q?4RPs+VnmxLhH7QMcPp0EuT4Gb2CovcN5C3P9Wg9iNcdqsCETsf9GSAoa?= =?Windows-1252?Q?9l4S6zqfIBZ7DEjkmCmPLQFyjH+WjhEHuDHZeoaEA+K7MPo8xKabKh17?= =?Windows-1252?Q?aSN0n8rAwK9CfSz1MN3tMJkJ1SL5hMIXANP2eqD4tZ0lGjqn/cGKUTk7?= =?Windows-1252?Q?dszFFsTTDZOxCywlz8dEv4C04kCv1mpvHo6IRhUV/sE5gcPa+ttOjbNI?= =?Windows-1252?Q?aqZ5zXtPjSgcWA=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5817.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79e313dc-b5e1-415e-a596-08da504b6a80 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 10:23:26.5618 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L2MWhxXYL5ZK/g3ALSJj9laZdiHVFLlqXhwWJIoG8x9wBUGPVkKRloVrD5L8lQNT6QE0DNP4c3041yvCZjo/mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1648 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, IPsec-mb PMD should not be built at all if the library is not installed. Also, the code you are warping with macro only prevents initializing the ve= ctor mode param to SSE which is later used to add feature flag bits. To me = this change does not make much sense. Can you share with me the purpose of this change? Regards, Fan > -----Original Message----- > From: Ashwin Sekhar T K > Sent: Friday, June 10, 2022 5:21 PM > To: dev@dpdk.org > Cc: jerinj@marvell.com; skori@marvell.com; skoteshwar@marvell.com; > pbhagavatula@marvell.com; kirankumark@marvell.com; > psatheesh@marvell.com; asekhar@marvell.com; anoobj@marvell.com; > gakhil@marvell.com; hkalra@marvell.com; ndabilpuram@marvell.com > Subject: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch >=20 > Enable compilation for non x86 architectures by conditionally > compiling x86 specific code. >=20 > Signed-off-by: Ashwin Sekhar T K > --- > drivers/crypto/ipsec_mb/ipsec_mb_private.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c > b/drivers/crypto/ipsec_mb/ipsec_mb_private.c > index aab42c360c..9ea1110aaf 100644 > --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c > @@ -53,6 +53,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev, > const char *name, *args; > int retval; >=20 > +#ifdef RTE_ARCH_X86_64 > if (vector_mode =3D=3D IPSEC_MB_NOT_SUPPORTED) { > /* Check CPU for supported vector instruction set */ > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) > @@ -64,6 +65,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev, > else > vector_mode =3D IPSEC_MB_SSE; > } > +#endif >=20 > init_params.private_data_size =3D sizeof(struct ipsec_mb_dev_private) + > pmd_data->internals_priv_size; > -- > 2.25.1