From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51074A00C3; Fri, 17 Jun 2022 19:05:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02C5842B6F; Fri, 17 Jun 2022 19:05:05 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 99525427F3 for ; Fri, 17 Jun 2022 19:05:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655485503; x=1687021503; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=njAmyyaaa7DNcsW6XhFu+4ce/yRR5HwQQ+GeeLjeqkc=; b=Momhmf+6KCFBCKRRTV40poq4LD2OE8C3ndaQSc8+asA/FVfAaqzvCqY4 y5zGNX3WWMPuuQOOzGwC6pYxGhK6YwSAQdB1Q/PFs0SAjWkf9MyfRwOnH bQNqa1OXHy/Eh6TrDAwTO++tO2fqyYazADCe96+7wBhpVOCNL6bOnbTUv jJ3L/dDELfOjP+EUugDcY6a8+swhuULXYp4Om9RBxulPSYCBr1rOYzwVM BHTBV07eVEcP90x31GyVw6VxB1TlKPGHTqlhaHOqhqSW4GgjP/AmkWsgH c2oFB0FNx5uDN/F+se1ecHeBuCjrB/L77eZIndv1DB+Fzq4g3jpzWD8GP w==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="259938394" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="259938394" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 05:59:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="642024887" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 17 Jun 2022 05:59:51 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 17 Jun 2022 05:59:51 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 17 Jun 2022 05:59:50 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 17 Jun 2022 05:59:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3rmD83OyIiUnM61Sey9zY9zBrpa7klG50Wp3sxJAO14oRD5D5p0pGAWRnExlipcYOcuhAirbWYQhnyHDCj8TPnNLe/ooQVW/lZqsA3XQDE8vuvIu2MaI8Y6V05RLxUdyHDswTReAOq24DFw32dAko+vFUbvOlvS2m1PgyA3p0ZRN+lUXpib4DYgAuuj/DkSwmOslADrJmQp9pc6ZRhA6RggjHafeMVUrYWUR+PDSqfmdujR6N4RCVhgCABfNaAyv/nAzq3VMD8p+C45wBbc7x1MyG7zecjBdpHKll4KVHxs8eLcfYRKfnDBY5DbtXEu1heOeEXEHNii7nSIuD2aBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TOduCRPllF8mEoIhpynppICKM2fjH1P7FKFv+Tk/KnI=; b=nlngGgsEnNJ8Qy0ir2dZku0x5cwc9J8oXgoB3zuDHGEB+j/al4JGzCXxGQnNRYXUPko5CPsnRWWFVwDYLoFzTmWbmCkwugbrCKz5Kadsuv+h0PZdTXpCDY+cfj7pjtM1Vao0Xiq4ZB+vA4/RHxk9G+NpZz0SMS6qgykweONZ9PyOLZ405NyDBzr9JGlDhIijHSQdsZR4wTGomabMs0Cxnty4yCGunGWjRLL/o2UB9MBmJyWPDrn3Bpk7YkyYZ3WpL7umgClyCYLgDv8J0tIzuxnIlViMWCvffLaGzNt7oD3boS5e5Gg9D4+JfCZrTAzfjpYGeVOYgue0T317lTEVXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5817.namprd11.prod.outlook.com (2603:10b6:510:13a::14) by BL1PR11MB5239.namprd11.prod.outlook.com (2603:10b6:208:31a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Fri, 17 Jun 2022 12:59:48 +0000 Received: from PH7PR11MB5817.namprd11.prod.outlook.com ([fe80::6024:7f58:ffc6:64ce]) by PH7PR11MB5817.namprd11.prod.outlook.com ([fe80::6024:7f58:ffc6:64ce%2]) with mapi id 15.20.5332.020; Fri, 17 Jun 2022 12:59:48 +0000 From: "Zhang, Roy Fan" To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "gakhil@marvell.com" Subject: RE: [PATCH] crypto/qat: fix cleanup function default behaviour Thread-Topic: [PATCH] crypto/qat: fix cleanup function default behaviour Thread-Index: AQHYgIZmgrr3VmCI5US9kcPAtNJSTq1TkyXA Date: Fri, 17 Jun 2022 12:59:48 +0000 Message-ID: References: <20220615055756.26482-1-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220615055756.26482-1-arkadiuszx.kusztal@intel.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bcf06918-7928-4fca-7025-08da506142a5 x-ms-traffictypediagnostic: BL1PR11MB5239:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IQRh+MRfMAmAOYLCvkglx9mO8d9jjw5aUJoDDzUVZRdnBnYTwo/gC1m2OMm8JHHTe96fKbOYA5fN0dNnN+tkoCyS3iAXlkKSbmoM9hztsanna9Hdcm96EEkyB0nEgOFAoazKkWojcDLz6i/op4fm41cMj+SoHO3AubxavOzcGFVCNAOrf0WXGJer2aJToU0WE4xFg2W41blc15R+z8oYMsV5ek3Yl1p21qp1y8ahkHKIj2zZPlWcIDX9lAGQoDAuq+KPn2nXA9xO+qtoPHXCrudaZWdhFyPIilygvaD75+XW1A0ATmOiD03pLe5cz+uO6PZ/VJ+NmxFlUZbBF4XYEHM+ylc0q026MkkYYMufVhCSUCPwnC4OzsVKdQ2D2gf+ZsbjEfFUsCjuRytDl+s/cArfetUuIzUtwV0IrPRjOBh54hSzQXaUrfJxnP2F4fTp3HVvbgt7hOnjgTqACVB1lPq+Zz3OVtKcmtA2c984WALDi/BG55N6pT/UNyxA47qxzovWJI85kXFSY0FWAhHBUbg2wGCWce5bE3NfY/0J8DlHEsHbw3UsAV/FRYtQbzZA/ZXUbPzrrhUr1Cdled74uuFG0JB0cEz1XO4F0vPQNEM0gZQOO6dSWOozq4FSwV+5I6D3wkHIIQoYkTUd9skYl44FnpAfHTrqybV7G8wByqtKdMoYGZxPLoGKbkXuhdzdfdiW42jdKo2hUuOU1AAZpg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5817.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(38100700002)(82960400001)(186003)(110136005)(52536014)(122000001)(316002)(55016003)(33656002)(83380400001)(5660300002)(8936002)(498600001)(9686003)(26005)(86362001)(6506007)(76116006)(2906002)(66476007)(66556008)(38070700005)(7696005)(53546011)(66946007)(4326008)(64756008)(8676002)(66446008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?V7VNSWS0f+8ceyQ/xpsb4TDvBbfrbEfd1PnCSTMMJfBX40FYFmIHDuxa?= =?Windows-1252?Q?XnQYZCRULQUKhn3gvem2kykMf238FL9hr2JYO10bcSU+GcIVRUdEkiOe?= =?Windows-1252?Q?q26ssEOE5ziwSwT6A71MtAiavAEvUzVUTnuKPkT5bcdVjQc8Q1d5GqBA?= =?Windows-1252?Q?ZWW8mZubkJVW5AZlgxrrR52hkwksJjRuC/4WL3edXFCUeuqy5TpyAzAc?= =?Windows-1252?Q?6x+BTRZpKvtXGlqbg7C9PSXLvH1ih9hz1kuQsyEpNVoRKPBwanI5hbgh?= =?Windows-1252?Q?mkIWkngZjSVPIb7UmeGzpAG9vf5w2q+yKp9ev9PXp5RRwxrwKSbXExPw?= =?Windows-1252?Q?EYFwQHHdwUD8tsf8RF7s7zYgqWFrWCjA0G9XA6yNR9bO6lAQpgX9N41E?= =?Windows-1252?Q?gn4aCTqkPxiBfgpt5vRAVBlGvBqzgi5J6vON4SIjKq6VqqEffBWQhevY?= =?Windows-1252?Q?aE3wQVrCRG4A8DiSj0Hmec85ffAi3AbqIOcp5h+YSo4bDtLb6mqnI7w3?= =?Windows-1252?Q?V9VHVWoQC+S7HhUGZR3lxtqcXVkO1LrYmh786KrqztLCAiiqBDTBGh+h?= =?Windows-1252?Q?S1G7I7tOqHu9XAJn66js9jCFyPlptdTmCZXZmjll9lYjGA7L96HtLRxC?= =?Windows-1252?Q?vKX1jEa0/PYxnDye3pSmZ9O6SWhcc/7HGoelKRv5t1iaKTv0tjMW//BM?= =?Windows-1252?Q?I40BPPKvwxxr9vyOo3i+VKRWSp5UsvqnTeKq6qo7JwY1jfxkSIjTwXyB?= =?Windows-1252?Q?fllrv49Kvguc2xUowAW4Kdpj1BxQHDrdlR2HMVXzcDyKWLzzvSm78pRl?= =?Windows-1252?Q?QiKXPvPnZw4HTrOu+w7YeT18jk5kqvq//Y1EHcORgVSbA9nk6yN2o8Kl?= =?Windows-1252?Q?/Z/mO6h5IYpvA1iioXhJ26YZrvU2JCXhbjgpBI9dMl/elMEVPXVSMuQO?= =?Windows-1252?Q?/HSF5vAcJfvMQQ4J29Htn042wd9r9t1/b2VKGgdzKNY367NJdk42qfCw?= =?Windows-1252?Q?XQsP8zOqMB3/s9T7n16PTRcES/bpDbSIqhxZjXW9R3NbS306zcm3ej9C?= =?Windows-1252?Q?Q4RtFkecUljv8u0JT8X2EZqbRuIcBni0LonxKELMM10sTmBIkhxTUUf5?= =?Windows-1252?Q?zrWkkzheNGjG/KdMyboJsUXVQiPwnV1I/SFKz0p6O7K0syU3gEmXsw7P?= =?Windows-1252?Q?ZWVWKapvVqnQFkNb0Asd9GYVh/0QjyMROxtTWW4/p8h5xrOBj6CVpvDe?= =?Windows-1252?Q?8XPflKbl/cvP/ih3/QbCMqvAKp0gCCAidK51KIlJClMivrs6QR4fhSFN?= =?Windows-1252?Q?FmvaIW4zPwWxcpIWZmguT4h5Uaa9GLtze0GYk9FdnpRfrdjOV67YDc0m?= =?Windows-1252?Q?ilLeyNM43jaxoTXbDv9sfh0oKoN4gWUzpGKISysfbypDtidRI6LZm7p6?= =?Windows-1252?Q?n1b39q/tTe/UT02kQxYd4kCDGQ7lbshay+JCerZ8JukbpRAQ48V9DtqY?= =?Windows-1252?Q?P8r9ISHFSym4NfK/ePk0au+trHy8XofTsjQtubME7F5PN+kKPKTBflA2?= =?Windows-1252?Q?HLenWPXMFQUbHVyu3y8fK+4pOMpJ9eQvMpfp88pXb63QAiIYZy1bwDxD?= =?Windows-1252?Q?FpPh19p9TzmIwyd5l67CxLwaBhRESq73OTevcVNE9cjBDUYzmx4zWOoj?= =?Windows-1252?Q?HrdVT4XuNGVW3Z5qwhqyCQXcGnVEyUclFYkTgh7nFu7ULr/0FlIHsv1J?= =?Windows-1252?Q?k+rymj3cMxT3a1QPeXO9htBl6Aj8mEuNz4oAPoys4x3fbQ7SHqI8CXPF?= =?Windows-1252?Q?33NgI7IzXRPhro0DIesKDDGsDysX7BckWQsS4CHll9pWde4kghiHjQmD?= =?Windows-1252?Q?qhKXqix0cn9TrQ=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5817.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcf06918-7928-4fca-7025-08da506142a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 12:59:48.6222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RTSEJE7TF/Ncga32MnpZIQkLnYidyEI7HhvGERNGGQpig6f0vIEIxw9YeSZqftrC23psdiu1xhI6s0mjr2YABg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5239 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, June 15, 2022 6:58 AM > To: dev@dpdk.org > Cc: gakhil@marvell.com; Zhang, Roy Fan ; Kusztal= , > ArkadiuszX > Subject: [PATCH] crypto/qat: fix cleanup function default behaviour >=20 > Full cookie data should be cleared by default if not algorithm > specified. This is protection in case algorithm specific cleanup > is not implemented. >=20 > Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions") >=20 > Signed-off-by: Arek Kusztal > --- > drivers/crypto/qat/qat_asym.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.= c > index e4ab4bf33d..6e43a6cac8 100644 > --- a/drivers/crypto/qat/qat_asym.c > +++ b/drivers/crypto/qat/qat_asym.c > @@ -144,6 +144,10 @@ cleanup(struct qat_asym_op_cookie *cookie, > cleanup_arrays(cookie, > QAT_ASYM_RSA_NUM_IN_PARAMS, > QAT_ASYM_RSA_NUM_OUT_PARAMS, > alg_size); > } > + } else { > + cleanup_arrays(cookie, QAT_ASYM_MAX_PARAMS, > + QAT_ASYM_MAX_PARAMS, > + QAT_PKE_MAX_LN_SIZE); > } > } >=20 > -- > 2.13.6 Acked-by: Fan Zhang