From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E744AA0540;
	Tue, 13 Dec 2022 06:43:28 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8B90A40684;
	Tue, 13 Dec 2022 06:43:28 +0100 (CET)
Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31])
 by mails.dpdk.org (Postfix) with ESMTP id 52F2340146
 for <dev@dpdk.org>; Tue, 13 Dec 2022 06:43:27 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1670910207; x=1702446207;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-transfer-encoding:mime-version;
 bh=ow2orSi+MobcaFGnKJ2XKyFZs1Hhsm0FMBOxtEUWf/M=;
 b=QEd/dyfqWIBeevv1/JWoJSMxr/PwTQ6VValfpB8nI17fGd+XAaP9qOrs
 ri7jpR5UeA3zJ/zoqzEIpxldYd0C9UwIj3PzNdMZHXN0qgvgjK7tDS0Fd
 iIxkGeIk8fYDBjTwXWDZaTjDJNWPiyUUQ9N6Gwa4axbuanb8HnSVhNxKD
 r1wS1LWdeGTWBcjsM5xXzDOEcNcWD0PBUIYhFU10A5Yp7xajnVD4jQQnv
 GzCsy0LN36WiYU3qdvPq/RvJ+WK3AO/h6E8/lHOUafaA0Zx8wIF2SzGuf
 yodoDwuS4lhmhi6nMD1Th6LpKyyvdVC6qsTJVnXAUgX0z6YdaZFkSCkYn w==;
X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="380254250"
X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="380254250"
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Dec 2022 21:43:26 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="893780913"
X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="893780913"
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
 by fmsmga006.fm.intel.com with ESMTP; 12 Dec 2022 21:43:25 -0800
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.16; Mon, 12 Dec 2022 21:43:25 -0800
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
 ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.16; Mon, 12 Dec 2022 21:43:24 -0800
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.16 via Frontend Transport; Mon, 12 Dec 2022 21:43:24 -0800
Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by
 edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.16; Mon, 12 Dec 2022 21:43:24 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=EJfn9YIA9ZruE8IjbKPkx3XRV4IaXGdgkDyGxwyEqMcYXNB+5L8bGqFomsY3RZK8F/JPo9o1vbCNWMAOgbaYYxr8JPG2+VArW4OK+Oo1ak6jxu+/HOS+goVavG2gVkC3cZBZPqG8imx9uvhc9bIBxzgshY+dOUh9gCzhVub6cSpJb2IvuVer37jl2I6zBtoHJVKHmug4MscgDKnaWVXvhneNUT2b9cyLlax2Aw3HlpAiuUe1JrZmXxYhSU7Mwt1p23igOiRwY2Rx8JsFum8SOAUioyPo6zgDV/66Ux9671Utxzdtbgs7BxF5WjN2dfQAqjzqe/BHfzGCHM3tumKQDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=bUWznqtaTF+P6k21jKOsbHULx1VKp0olIxG/XdH4Fbw=;
 b=RTQcTy7wtkyd1LqBi3/b1pszN0gY68x34kPy42kza3Fk1hB8aSaM5mpfpVr4n3K6NsrCGU0LTUui7/c/nU3pDGlWqBG8cxGzM3AQJR90+r4wFSft/A/tzHgsUwBi9tratvZaCZLTOIorBLvktkDNsK9ZcGHjTBmWFHVu4wiRuStIS3ogZAwVUGqKPhmiT70tOkn3QJXPfaPyYM+a6mY8o7hUbODJaq7UGVyFtAn2/NG6PWpctRtB9xE+Fc+8nnsy7nDQdN2pEL8KDPw5DFkFzx5MqBAK9mfbhldoxYZNutQwERq8Dvi+GBXc9yBpDo5I1nwXJT9yRyru8XZLGvAKdg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Received: from PH7PR11MB5984.namprd11.prod.outlook.com (2603:10b6:510:1e3::15)
 by BL3PR11MB6458.namprd11.prod.outlook.com (2603:10b6:208:3bd::5)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec
 2022 05:43:17 +0000
Received: from PH7PR11MB5984.namprd11.prod.outlook.com
 ([fe80::4750:caf0:7127:adc7]) by PH7PR11MB5984.namprd11.prod.outlook.com
 ([fe80::4750:caf0:7127:adc7%9]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022
 05:43:17 +0000
From: "Zhang, Ke1X" <ke1x.zhang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Zhang, Yuying"
 <yuying.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] net/ice: add devargs for disabling mac filter
Thread-Topic: [PATCH] net/ice: add devargs for disabling mac filter
Thread-Index: AQHZAHrTIfFRhUbqNk2zizWA4uScHa5rS14AgAAclvA=
Date: Tue, 13 Dec 2022 05:43:17 +0000
Message-ID: <PH7PR11MB59843DDFB5DDFA5AFD03C311DCE39@PH7PR11MB5984.namprd11.prod.outlook.com>
References: <20221125025124.805466-1-ke1x.zhang@intel.com>
 <20221212195122.5b1cbd15@hermes.local>
In-Reply-To: <20221212195122.5b1cbd15@hermes.local>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH7PR11MB5984:EE_|BL3PR11MB6458:EE_
x-ms-office365-filtering-correlation-id: b57b9893-6f10-495c-6aee-08dadcccefa4
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2fQnvElYY1aRpRPlqctFZeLi/S1wtbMY1N9UIg6MNE9DbtdAcgw8dCCo3hJgbACKUqfRpB5bLhx2I1OqT5YBJAVi4JoXTS+agLNdpWqOtOnJCgEnXzcGwriy48+svw5AJ2MVoKu6CDOsN44d72jqjv1A2JtqqnhgK6xvfREMGar1yEU8XoAK8peNvRm7RGvz50Bbq8DNt9tRdvliW6JpSi5b3y8Z3X9GTdJYY16Fa4RxWx85tiigVDoYlesjgKDeLLGG2hXrSGETP33AYoXP/HNVB9aJJOCdtoIksRglcAkNl/2KQsO49UQaAP6RrSQ+ld1jmv0Me8AhdSnQk7C54oNNQbC2BwjbcqVqaDdmTRNsTauwxPobmGYoORt4ExHO8F4KKSYJBLnFsX2UKZttEacyzrNWiO/uo+HfS4ecHGwmRDGPuHFzejJ2yyLyyIf6pUHGzmKHExfQjvYjs0DV1kiTaDiGGw1pHaeGQs6rdbqn1/32uUWLfJseISSg883pUXSlKsnjyuNaU4DFnJs5VR1u0xLzQjun1XasdV5f/jfBTSFu348zYrmZcj2W8jJuuToPzv8xhNH27fggaoag9Mnpm5henJ2qYKzt9zPxGKgH0eZeanwfOc3gp2o3ynlGoGRynvyFjhrPTL1Wy5Pl5HtkOHshTEv5pChXEvgM72h/rEoElxrz7k+xjXtJAmOpmUR7UKr5f6guCv2S/4MAcQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:PH7PR11MB5984.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230022)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(55016003)(82960400001)(2906002)(38100700002)(122000001)(71200400001)(52536014)(5660300002)(54906003)(8936002)(6916009)(316002)(38070700005)(83380400001)(41300700001)(26005)(9686003)(478600001)(186003)(7696005)(6506007)(33656002)(8676002)(4326008)(64756008)(66476007)(86362001)(66446008)(53546011)(76116006)(66946007)(66556008);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U7oP5qZF2SuVdmeLJDl5Bgn89LabFLENfjpsDK1diQKHojdyEQ8uPI6IkhFx?=
 =?us-ascii?Q?Fnd7ECh26l54BwcsbDufyDa/hiGRANgqEGVTlODVvOhI+nOChjMdF+jc5vdv?=
 =?us-ascii?Q?PpWScWvdhtowEr2MENDJCzlAi3QsJRTY/DeyszkNhS/aLV/31CCVRO0nbZ8Q?=
 =?us-ascii?Q?BC+Mu6t/MyZfe6U7ximmDRdcfFvxoh9gd+mCwqHlLX1YKg1zvAYbGWD3RnbT?=
 =?us-ascii?Q?k2ch8tWEGOslLs7zF1QMPpTe9LY2m0/OdQKfXQ3NEvDdWoBxBdFO/uV3L85j?=
 =?us-ascii?Q?8MfvcPu2L8Zph0CMh7iK1kwB9136+Cv7hX62Yu0pfHPo1bJlEDWWYF5/KYmZ?=
 =?us-ascii?Q?gTQIjExEDI7DSy1ijjOMmPfaPYl3/C+3CLv5Xs9w3gTLW46eG9M2AmQpBWGR?=
 =?us-ascii?Q?jQ2XwTF67RILMUAeqNZogGZDBUHd61cBD8/ALVEcD+DyQLc4ZdN+HtpHyvbh?=
 =?us-ascii?Q?ldbQWHiR7gMJYLBv0AtMIWNkSiTEGwMUTMi7Z5X4OK2RUTmKOHGC65gCg4jB?=
 =?us-ascii?Q?hwHlw3X8dC1VE+7W2wxbf2OSuKMLnU2sMOj2JO5dU3KNB1QcMmCRpp7yTl4/?=
 =?us-ascii?Q?iV14NhlWFTHRjIDhC83jjej88UMupjRWnbCK4Iy70OrR2B/8oLGTkLE8HGbL?=
 =?us-ascii?Q?EfnJ2k9uvQnx+11q0lk5Qwz+Rhi36A37rTQGUnFMweJ2ABQ8aRub+1ugDy5a?=
 =?us-ascii?Q?L5rlOf87WH+mOwOEJhw+n70ka1o7p9DBHqhiZBYC6oahaTm1SkKxGA78GqN6?=
 =?us-ascii?Q?f8pMAF3WA5c0CnkDS8PeQG3KZCa+L77A+oeVo+mVUOiPGiEdAxIQBFtZTh72?=
 =?us-ascii?Q?e1zmTLr448P80TE8014fjgp7qWrfmbTWB0zPOjzmncFUWFDfCc/v97gjpXKf?=
 =?us-ascii?Q?Ua31O+V8xvIO8Y19+Fu96WMx6kNV9egrs7v0pCeAzCcuZ2VZ76IdkU5C5N+i?=
 =?us-ascii?Q?wK3BtZCHBMMQgvHT/WOpIC7LgLR0FONN8y9URnHkv4t4/x72ebdzgUQ846KP?=
 =?us-ascii?Q?K+05wTfdYptjs+qZh7ZhMCBUP7tYN7yZ3Pfspq+qnhD+LqyovxZV/KcBk6Da?=
 =?us-ascii?Q?RFhnTR41bGQZz9XsDIZgcWvykUigs7irCTokjwE6U2a+CSXOQdOI6mKcN8Qh?=
 =?us-ascii?Q?S3bJrqtAVmc2nLpp4DTXTGOq01lWRqSqUYGlIsh2ohGMSfhcfTzIJJ9UiHWA?=
 =?us-ascii?Q?O5KU7on1060QkpKVc9e3b0XpqaifPWeLL+36cnDyCIAtS59SIZk3HYyoeRuB?=
 =?us-ascii?Q?UF7N3qtpqFe15k+caeFLLcLqKGgx+v8jFptY6oTD3ZwVwfCE7QW0MleuYlET?=
 =?us-ascii?Q?vbG0McWIieEqckqY95salbd2jvqF0mCAQQCV5WA51hEjPk7IozIWOuFycVYY?=
 =?us-ascii?Q?t5Eq7Fdt+ZJKRXiXGYO3/B2VGxcx96QM072sPni6p7yY/a/PZ+O0KbBy/Hkk?=
 =?us-ascii?Q?flmZ3KTzPq2YH9AEBcBSMOjPAkVLdnaew0fBquJsMIWGPJDGz0noKP+Umu54?=
 =?us-ascii?Q?d4/sHWBVCztujFeq5qYAU0YurTMrIwlrk7aRK12+egDMHsUAu76dS2I6J7Ue?=
 =?us-ascii?Q?JEDf1F2bTbR4R6x9qz5a33yn7FbZjE+vTW7RcFNL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b57b9893-6f10-495c-6aee-08dadcccefa4
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2022 05:43:17.8002 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: K5iS4e21oRVV66XhXu9ncgKAeKrdEr6zx7gY6UlHeTNXnhLk/wKNXUh/DKqI+STh1oH9q00auBmTcJ2xJSuMCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6458
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Stephen:

Thanks for your comments.
I just follow the definition of other variables like pipe_mode_support, saf=
e_mode_support.
And when I run the testpmd , I could write the command like this:

./dpdk-testpmd -l 16-32 -a ca:00.0,mac-filter-disable=3D1 -a ca:00.1 -- -i
The value could 1 or 0.

Would you please give me some guidance about the definition of the variable=
?

BR
Zhang Ke

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, December 13, 2022 11:51 AM
> To: Zhang, Ke1X <ke1x.zhang@intel.com>
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] net/ice: add devargs for disabling mac filter
>=20
> On Fri, 25 Nov 2022 10:51:24 +0800
> Ke Zhang <ke1x.zhang@intel.com> wrote:
>=20
> > diff --git a/drivers/net/ice/ice_ethdev.h
> > b/drivers/net/ice/ice_ethdev.h index c8311be179..0350c6584a 100644
> > --- a/drivers/net/ice/ice_ethdev.h
> > +++ b/drivers/net/ice/ice_ethdev.h
> > @@ -563,6 +563,7 @@ struct ice_devargs {
> >  	int safe_mode_support;
> >  	uint8_t proto_xtr_dflt;
> >  	int pipe_mode_support;
> > +	int mac_filter_disable;
>=20
> Why use 4 bytes for a flag when a single bit would do.