From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B2A0A0542; Sat, 17 Dec 2022 16:22:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37B8040695; Sat, 17 Dec 2022 16:22:27 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 566ED4068E for ; Sat, 17 Dec 2022 16:22:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671290545; x=1702826545; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=WLLZxmYjIv2hlZ7P30qWZP8z8IR7st3Jtlycg3xoEjw=; b=k/LCHMASkUt+ePEHVR+A+JJGES2Ie0P2AKe09BkOlrac2T4W34samwD3 Wcfun2ShK6lqzw/yPWMusaGs+zCBj/m5YVi4xq/ZIv8ukKzZ6leik0+dL 2MgzcQVgZP9U1K/ulmTOeWqClhAyhD3JLPfy7IkV868/h5R5xjj96uidV jhSK7wpddHSLPch6f9FknWNIaIQJIHfxZKhV5MiRxigOsB1Z+yw8KMenm nKTsvy7z2zmhoAa7N3YUiTX/F0e/2Yp/RdauMoXdUD9GIdBm+U4rxa+Oh CU1B5rix/LIqyNton7YeJIJF937k8110atK7nwPy7koYHYTdGCTDxuaiE g==; X-IronPort-AV: E=McAfee;i="6500,9779,10564"; a="298809128" X-IronPort-AV: E=Sophos;i="5.96,253,1665471600"; d="scan'208";a="298809128" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2022 07:22:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10564"; a="680771071" X-IronPort-AV: E=Sophos;i="5.96,253,1665471600"; d="scan'208";a="680771071" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 17 Dec 2022 07:22:24 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sat, 17 Dec 2022 07:22:23 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sat, 17 Dec 2022 07:22:23 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sat, 17 Dec 2022 07:22:23 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sat, 17 Dec 2022 07:22:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UW56lMvVK1VWbm3SACmHHnBgA6SEC7FfYa5zcurikRC7LeuBFxbrnOy72qobNpByHP9PZUv3Y+sGZoCbTOcoKaej0F+3dl97BScEoB8Y5xIpiIlGpdUn51taWyuirQfhgrAMjhT4dJ6FaKBCTo/7D6NxnvrH5+kN/4HsjNsy03/QN/XgK8RkD6x4KSHjFwkpd5HO3FIWqQ0uEPT33+IbI0TaBCqBNvSTtuPFGq16WusFHILLTd2XukSuv0l2YXomfh+L4B776LpUFavhZ4e2PvYYJVIYno6+2io3VU9ddvfUB+kL14hd5vA/Ufo70+k5i/13q17UwwrUih0s+mCg7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SVqfLlP6ZEctFS7+kHqnwNnwYICONIEQtlhlHHZuANA=; b=kSeWu9kzsF+3hU6o+0+ctLRVGaJgX/9CFoJuhGR/sn/tiawcfvPoLtzPxpBb2ClLwXt+m9U9byWC0l6ONIqpFhveu7R8tVqWmufdnUuqvZ5gqgqw6T6uyVPqlOTdvqYLXUWJWAh1oHuF7yhskdQdCUaQ1h7u3wptuVdK5+Zmkmuv5KVV9skXrAXV1bhM2jEssWip0X5iP3h6XGOkXxVs4vFIy04G5+IBPMiOp6vyU5BLmyuxhwtTQriWcHoU+LzAPNWzi9FgWft3DrLWg8BHLSGWTSAfjqMRLd1TZXXn8FwcG+i1WcL7cB/jTbt99HXtCuYwIbKF2AMeaOfPBcp4kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5984.namprd11.prod.outlook.com (2603:10b6:510:1e3::15) by DM4PR11MB5469.namprd11.prod.outlook.com (2603:10b6:5:399::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Sat, 17 Dec 2022 15:22:21 +0000 Received: from PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::4750:caf0:7127:adc7]) by PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::4750:caf0:7127:adc7%9]) with mapi id 15.20.5924.012; Sat, 17 Dec 2022 15:22:21 +0000 From: "Zhang, Ke1X" To: Stephen Hemminger CC: "Zhang, Qi Z" , "Zhang, Yuying" , "dev@dpdk.org" Subject: RE: [PATCH] net/ice: add devargs for disabling mac filter Thread-Topic: [PATCH] net/ice: add devargs for disabling mac filter Thread-Index: AQHZAHrTIfFRhUbqNk2zizWA4uScHa5rS14AgAcJViA= Date: Sat, 17 Dec 2022 15:22:21 +0000 Message-ID: References: <20221125025124.805466-1-ke1x.zhang@intel.com> <20221212195122.5b1cbd15@hermes.local> In-Reply-To: <20221212195122.5b1cbd15@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5984:EE_|DM4PR11MB5469:EE_ x-ms-office365-filtering-correlation-id: 1c36d41e-8fb8-4186-8317-08dae0427dee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fiuNyepLGqkyNlb9zDzVkpOnC5LhSbb2DX6eW7cBCpmUQg/lEJkkSNU9Z39/c9c8PV2VArz1xkEj1EafroYt8Dv6MPA0zR8yRq1M2n201Nl3hVAGZeK/5Byt4rZ9x/WTMysaqYAV88+y/M7y0UN1gAQ+QAWkZ/XSvcb+ps9IIcVGJsUgW8nhe7TT1xBvo6ynpUZbAzrZ2SFyWM9GgMlmt00YbE9pMlL2uUmrq92eG63k9lG7DrFEms1iCU0C2ANB6Dk9ljjK1YbOoup/fc2cR2IzpQ13WHQSGbhIkzCG/XvJA6URJjZzi+7A3NKRV/6aU5MjtSsW3KL09BYeNYNd/XqB6cZevfxzstnzlJU77ah0Gqg8B/kh0o5yyU8EIoyqScEYJVdjD2NYA5im2y0nXCfhhUOQ2YSBdl0cjb1F7Bbkex58rY4nZXCNLxeBU7mCz8aHRbzpVNXKIXarLNJTlo8NqC6Y3EMfCoyNniZqtz3yafKTQE6ME94iYd4DHiALXmeXKXW0AKPbfZoYPzCwxkKaMMj6y00lNXdSe5+pMkp77DFG6FIFiyXaaeZcRoyXFYySjc9YA3km4KCVVMhb+SBNAEWbbGxs/4orhAbxhtzt8/zQkTepWkCCAnGptG7zMw5yi1jxeFl8dpRWUULhOMVbPeXMGR/3XqWsR6GSrcNfz1rBfs0SSAUPvSGz04OSiBpBgwuQv2JrHWKz+UFfzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5984.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(366004)(39860400002)(136003)(451199015)(33656002)(8936002)(5660300002)(52536014)(83380400001)(26005)(55016003)(41300700001)(186003)(2906002)(9686003)(316002)(82960400001)(478600001)(38070700005)(54906003)(6916009)(53546011)(7696005)(6506007)(122000001)(86362001)(76116006)(66446008)(66476007)(66556008)(66946007)(64756008)(71200400001)(38100700002)(8676002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KReDUl3RleoOEXB6kGEaNjwTNIjydp9t/2i4bybTQxzt35I4w/pJZieHu1H+?= =?us-ascii?Q?o9wtsf7ldyPwis7DEzPegM7ahBURhkXOORqNfsBrRQ69pbhBsikt7arvzfZl?= =?us-ascii?Q?S/OPF7ubmwqR8RJgZ3sBYQQt6BYFRw/O4nmx/GGis5NMX2kfbEXGCcpaxxkk?= =?us-ascii?Q?SOIP5rZS7X1nxkS0jVnU1HUrOxuP3DMQzvUcus1pexAUcwjj2iJlhHp2jQ2O?= =?us-ascii?Q?HYzZ5vidlh3N3Ze444iS07jJxnpO9LsLf7/tj1ZwkCc2LvT6LEr4tv91Pv0z?= =?us-ascii?Q?5L/5F8eHkBcgVKsFSqTROhm+6MI47hDQKbB1t33YgX0TYkLY+psfmLoJiPEt?= =?us-ascii?Q?jngEDlN5rfUdbOIDedseH5+MGeEoYjoVSoUtBLtCLtQ5Nz0AB12DnQlRb2hU?= =?us-ascii?Q?g1v67KjJq34+InxawCpGqhONATNtWw3JeuZAGYFHbMuYLxeUdENLOZMvvK65?= =?us-ascii?Q?zu/IZ7X3Yg/VNtqwWs1iNA9jXQGogYnMseKVfE3NoV5zaYPl/ZKkwVWac259?= =?us-ascii?Q?ybMIvHaGbqdK5c3XD7FEJOy6/nhpabfSYSsEyiQ0rqi9h7G8TljNUwV3Qoz7?= =?us-ascii?Q?nmfS6X4h8f1zqfyCwNDdKhOInREl7IV+CfVH4vfRorhpaz+MFhc5nbeBuahj?= =?us-ascii?Q?CDe53ux1qMDoLyH3RyVXuu+ojVk5bPAWNAr2zqraMbc8AnZWcfisOcV6Wow/?= =?us-ascii?Q?0uuKTN8hsqBE94i9hBdlySdVp5IUodCtQ4PLOj1s8MJSiRYj61Ld/zzqn35r?= =?us-ascii?Q?BDaSLBzl68jrBMBga6hO6V/OCurzOkpRJYUN9Q1SuHG7kOxHhUSZGxdArM+p?= =?us-ascii?Q?qPsSD1D59eyfEL92gTKrw05w0ln47B/+QdVtrJbQlkM83Uv960HE4ga5a6hL?= =?us-ascii?Q?cE2LekiwRLPGHDKnFkeLkuNeGufRTQMP1cWy/gYnvpo8Um3l97RtNC9Sj1Pk?= =?us-ascii?Q?WnnyE83V311f/NUIP+p/zDbsBEUJwOgzQqBM6n2W2XA5tb0Amru2oMIzORQv?= =?us-ascii?Q?Q6CjkuiG4fYBRCVbgCQUARrlCbiIjiwSHsZf0V0jwFsvehlQ1RneweNtESCC?= =?us-ascii?Q?b1AXHu719cvC2Igz7poXmjDJRDIj6r2IOoDKfptB4CXtJnsuCC9QC9L9wZmM?= =?us-ascii?Q?5GrCA9WT9Op6XpQJ+yK1s7bhp/X7H/BW6Z5stJIhSmgjY5yBIjfIhVIFIwAo?= =?us-ascii?Q?a5yX3l3q16Z5x/uhtyH2NYKEgbFMf7tm61lhHnkYPBjsq3Ba6oZYnQjj6LYH?= =?us-ascii?Q?wNhEobrEw2AxSsBIYxVU+6e9gvNvlnScPVNXBabFfdOB9lFZFVLMlQ9cAY2a?= =?us-ascii?Q?3XfZZbnIBtWWwYddASgDsapqGFLi6b5c/S/04tYNVszLNwLHx5lL1miXV26y?= =?us-ascii?Q?baybI0M+ohUU44bdzHtP63DitnzNrpPH/NuDqMUgLG7R2AQxznKtl+HJRO9+?= =?us-ascii?Q?U03G+kt5qBXGuI8US09d0m4aSdLRSTOZGkmOdVS1yb5qcUPNyAbnmCi2OztU?= =?us-ascii?Q?jMaorrCO6WkJS6HKKSEHwetZ7i3EyssiSEruVM2ikGl/iu2LxvJWf73FWlyB?= =?us-ascii?Q?fv9NgeBawbzF76ukmvGaI7ctX0uz0QuaSmmkhJlw?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c36d41e-8fb8-4186-8317-08dae0427dee X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2022 15:22:21.0967 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s9EPoST1Z8RxoBpU1tqwIX0UTpRZ4SemMEmibUw4cbdMlIPaPJ5y0Oa/q/mApP43AZl7/j6PD54Z/fNE8VV/mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5469 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, December 13, 2022 11:51 AM > To: Zhang, Ke1X > Cc: Zhang, Qi Z ; Zhang, Yuying > ; dev@dpdk.org > Subject: Re: [PATCH] net/ice: add devargs for disabling mac filter >=20 > On Fri, 25 Nov 2022 10:51:24 +0800 > Ke Zhang wrote: >=20 > > diff --git a/drivers/net/ice/ice_ethdev.h > > b/drivers/net/ice/ice_ethdev.h index c8311be179..0350c6584a 100644 > > --- a/drivers/net/ice/ice_ethdev.h > > +++ b/drivers/net/ice/ice_ethdev.h > > @@ -563,6 +563,7 @@ struct ice_devargs { > > int safe_mode_support; > > uint8_t proto_xtr_dflt; > > int pipe_mode_support; > > + int mac_filter_disable; >=20 > Why use 4 bytes for a flag when a single bit would do. After modifying the code like this: struct ice_devargs { int rx_low_latency : 1; int safe_mode_support : 1; int pipe_mode_support : 1; int mac_filter_disable : 1; I met a issue when compiling the code: ../drivers/net/ice/ice_ethdev.c:2076:19: error: cannot take address of bit-= field 'safe_mode_support' 2076 | &parse_bool, &ad->devargs.safe_mode_support); | ^ ../drivers/net/ice/ice_ethdev.c:2081:19: error: cannot take address of bit-= field 'pipe_mode_support' 2081 | &parse_bool, &ad->devargs.pipe_mode_support); | ^ ../drivers/net/ice/ice_ethdev.c:2086:18: error: cannot take address of bit-= field 'mac_filter_disable' 2086 | &parse_bool, &ad->devargs.mac_filter_disable); | ^ ../drivers/net/ice/ice_ethdev.c:2101:19: error: cannot take address of bit-= field 'rx_low_latency' 2101 | &parse_bool, &ad->devargs.rx_low_latency); It seems that bitfields members aren't addressable.