From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D20141DA2; Wed, 1 Mar 2023 02:54:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6A5E40A8A; Wed, 1 Mar 2023 02:54:09 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 25F494067B for ; Wed, 1 Mar 2023 02:54:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677635647; x=1709171647; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZiZSYnL25xzj2leMs+eCSPtWurmMpx8n88kRdGuGRzg=; b=cTILPxj9XH7etjHb6ooYdCDUlUznMmXupfP4vr8gXEUpHOG3NB7N8VUK YwsFNfxHEzhDnMjTvqzb9FcbxcAHzkaN1h2d+OZojVKtEJcCnvR9VkYCs lhtmbExUdbtuAUqaHUYzaKZolD3nyAy5PIHnSGzpTLAWccuFe//nSPoG+ CV9GDqep/GplhlDCk607NRNgIL4N2H7BIPbA2CLYtLnwTh6qRGvc8/Rza jPxDaH9QK9yJmV/MeMecPdw+aZTfaAnQiV0Um1cOQ66IiPkkzwBu5muFE PAqn4ftw28E8pqMeIcoSLWUGorQO+vPZMGOSYo/oQnHMS8iBAuDNPE5EY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10635"; a="314720108" X-IronPort-AV: E=Sophos;i="5.98,223,1673942400"; d="scan'208";a="314720108" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 17:54:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10635"; a="1003457845" X-IronPort-AV: E=Sophos;i="5.98,223,1673942400"; d="scan'208";a="1003457845" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 28 Feb 2023 17:54:04 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 28 Feb 2023 17:54:04 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 28 Feb 2023 17:54:03 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 28 Feb 2023 17:54:03 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 28 Feb 2023 17:54:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SQxAp8X1KtLpcesWmsxTI14Z8ZnStfL3Op+5rhJ9mTg0JAaDVOsohv0YvoaCOa6VNflcVFO/tQwWYDbWhjVJD88zHfT+ifDt5bPuujX5mdH6x5diO5PgeNRVgzPnyTajwtSOJfkAfoIWMYp3rAz3lrxshZVB4W0dxwwRAXfDvYHgQPIs52oUs3bS28f1d1rJa0GXpM9S1Cv1EOKsFY+CHhnVPqLxEK92283hPhOGzhVIm/qfqZZULzQznT22mQfNBR1WXkpHUn7rY4QYhmMMu0I+jPmG1CGstKC0zkX9N74czzEfpl209MB6ZvpBGmGYnovY5BT7OT7VBbB4e7Po8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZiZSYnL25xzj2leMs+eCSPtWurmMpx8n88kRdGuGRzg=; b=XrbNV5UJVOVziVfRhB4ON5CdjouQTPvEo+VnV1PuX4rlM/sw2yVYpx0cqVNPJZ1FSw+0Cj5HFX3S4vIfaSuVAv6BVWNB2xnyQoc7FO3NS7QHhlyoi+tjOChusOGluFH6ayGjlW5B1Ft9oqS/fwtOhs8cablzuxAaeqiyeh0V5QifFoeYAY0rOeKtLOWfvzRwrEPZXhpYQG2tNTphz7T46TTZVcOgX/v57xJZMdUD1EDddMRMH5Fd5XA8lGH9Dd4mWG1M486dZPC3kNRWAC2I2ZhKrdxZtWi0cmYXpdTKmPe7pEOJwWhOFrBJJ8CO+3lCilXk97Qg9R4cAWUARUOfJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5984.namprd11.prod.outlook.com (2603:10b6:510:1e3::15) by SA2PR11MB5033.namprd11.prod.outlook.com (2603:10b6:806:115::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Wed, 1 Mar 2023 01:54:02 +0000 Received: from PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::bd50:8302:b513:5a3f]) by PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::bd50:8302:b513:5a3f%5]) with mapi id 15.20.6134.027; Wed, 1 Mar 2023 01:54:02 +0000 From: "Zhang, Ke1X" To: Thomas Monjalon , Tyler Retzlaff CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" , "david.marchand@redhat.com" Subject: RE: [PATCH v2] net/ice: fix ice dcf control thread crash Thread-Topic: [PATCH v2] net/ice: fix ice dcf control thread crash Thread-Index: AQHZP31RuNQmsHhw00ec3jhsDlW6wK7OSOSAgALutcCABc5pAIAOO5EQ Date: Wed, 1 Mar 2023 01:54:01 +0000 Message-ID: References: <20230208083005.290571-1-ke1x.zhang@intel.com> <3820540.fW5hKsROvD@thomas> <8025144.eFmWaWnqpD@thomas> In-Reply-To: <8025144.eFmWaWnqpD@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5984:EE_|SA2PR11MB5033:EE_ x-ms-office365-filtering-correlation-id: 22717e77-3a6e-45b0-ac13-08db19f7d4b2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zc8fdKc7urZrAjBkdyinN5GcwrhSbbjSF4E7uEodhRoJ6KUykboAJg0va3vN6rPhleUNVCyvslJgN81B1H1Jto5sVkTky0xAVsrAr4Woxi8YKX6kYZx1oPigaoDIvWXVqUvpPEc1i7RAFZWUFN6wvQu7nErbAeAuTvg5nEw7xs55MITtb4CK327RBy/Sih8WHIizjtTc34cpKLMU9MOKwbyVzvNbLAu7mL/Ejmv3YH/EVTfaNGpH3g8bfPNbCkniHId1VMtQB9q2EByCCUeE27963jH/OXqmEa45+PQzp3o3wry6MAdRZzPFDIgP1ZrL20YOHhRIhBGhQVMy23f13gIn9LRnKhGhK34twwdrfiEJIpfk1Ev4lOrnGYMnjcnsLANNYEKatYgmqSNCNl1grcADqWwFzuCzexF6j0Qq5Y/2Mrbp16+FwALRP6lampQ00uPuCBZrPkLo5TL1x6SNxsvKE2dQSu65sNxgFRUjdEDs37eiuvPSjK+/2SiXvoSNtHvFY/Z6DIhb/ivNctcYAbavE2grIwFSX8IDPCp/gmoZjSQLiOwffmTCsh3BRd6fC7UzTP0jrIbe2QPGgHv5NuANXO4qDywWS38sBU1ophePRKU2fs85+1h5fY83MPjNFyNmJACFJiz/3X+vMPraXKxBcBt0OHZ9VOxVsBsar2l93qLFUcrHbyhIYNNZSmhb8TNKTRkimI1mrUeN5zmRsg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5984.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(346002)(396003)(366004)(376002)(39860400002)(451199018)(83380400001)(316002)(110136005)(54906003)(33656002)(122000001)(82960400001)(64756008)(38100700002)(4326008)(8676002)(55016003)(2906002)(66446008)(26005)(478600001)(186003)(5660300002)(71200400001)(7696005)(66476007)(4744005)(6506007)(76116006)(66556008)(66946007)(8936002)(9686003)(52536014)(86362001)(38070700005)(41300700001)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TBIfeNzXHaml8dG+WrBHUgXcHX0/1WoMz/cHLkRXyHmWIGUuciHuh+HTJzuz?= =?us-ascii?Q?DNkHzU4JcDZXIqegKTrAVzc6c9BKboXrJwUP2ns46wf5LzYmdLy/9uQ9tn35?= =?us-ascii?Q?jvNWBRE70hUYRE7QyBISpQC17YnqW2NMEH1XWOmGSmAHrSbBED0QMya4dTX1?= =?us-ascii?Q?kDq6Lg4WL0UjLu1zVDj3nP5kRGiPflcai4N+acXvYv+pDopzLHKAzCn/OdS7?= =?us-ascii?Q?Bgygp8CTGNoxkvVMHPJtdCCCHMeunI38wvis2UcVNTENQTJQ9DwvYe7x9dJp?= =?us-ascii?Q?K1T/VbeZ1dllhoNZme5NU/XSmsciFSpia6344U6l6Uv8wHuEVclBaL3Kz8qw?= =?us-ascii?Q?WApp6nEBQU584Akm299uLWoUKNik2Dv4A4Yh4geNduY0lHG8wJMPasK2oxfs?= =?us-ascii?Q?v9GU5v5nlTsP8Dini5EvXBtvwk6RoR3lxmvXgbxIWfDyuX3wC3W8g53QpxUS?= =?us-ascii?Q?F4Ns7ndP69cF4E8qmMc2H1EQeuk7HRdOyt+ACA/HWe31hKQDJwmPQqTgTPNf?= =?us-ascii?Q?ZPuceZJ5ZuFmUXRdf995hBlg//vMGu6bzfWRwInDoNS6KrB9KRhE7bmINUoh?= =?us-ascii?Q?Q6yPoyEC3wTI+/GmOYXBEhwm6J88KuGxnzxnDrHkttZ/iMmBnFArCgrb3d94?= =?us-ascii?Q?D/h1HcleQEdJZN/vbCZdtpCrNqw1aiHOYDQYgBGN8gNt+MoYn7fdbQSWWfPU?= =?us-ascii?Q?nEYqMXWGOP8djVmGfasczvnQQ1K9SwkmsflgI5ZZkUwUc/IEhDtEPQSq+La9?= =?us-ascii?Q?QTfEd/H0ZjpIAehrUx/tri0Xm4ze/xHYLlsLru1CBvCBOTe0mLiDvTl5oKbI?= =?us-ascii?Q?3/7DBhto89ar4yyenrbVyLOpbh8yCNBEi0G8qneq2wY/dJOZgIZIpjTudBmO?= =?us-ascii?Q?8nJXH5o9JLJFab5RssI2w1/CPujGHpyprixs4tV4CtcIqsAQdIw6+f8SsFaS?= =?us-ascii?Q?jpW6YrLggqYmoNU5IDZ9c3Ff838zhrPxHqMBdfqyFNEdFFYSe+oYXDhUpVS2?= =?us-ascii?Q?wP8zqdxZ3M0U2DyR/rVrYVdbvymmFudeoD08FKHSh1G1J21i7OfdE26Oqd28?= =?us-ascii?Q?AIhHJztlBO6BngZqUZwraj8sMpDSuGgNEFNKrC7wAsHSSh1rq35NhHeEK8To?= =?us-ascii?Q?KpkFXh3RBPICPUvra2aVttpMFFexiHnELviqMb/NhzhAIs9fWmK0L8prRwGy?= =?us-ascii?Q?DLGNkwl2stT5aSZtp188eB00Vj75CPs3Kzbsd4oDu0N/mGGD/S8fQGqjPaTd?= =?us-ascii?Q?V9QY9RTkrutlClEoPRGG6aitPhXvW0yyIJOs/hf6BccyF/FkFa4tFXsvPfop?= =?us-ascii?Q?azdZIS8p0tx+YflVglzqYoTpxdIbXnhHIfFBqmMggraRbRFpIj9BYMSb3Bn7?= =?us-ascii?Q?p3w5snIC2fNuND2zRH/7toa5/HQb1e3SBcn2AJTU7xT+EkofCVqHlcMiC/Us?= =?us-ascii?Q?lql84WoZllwDfL608q2awWdJdVF/5SseicDLuclYkx0xsiJm/873D2IftfRj?= =?us-ascii?Q?rhxTsvOgAq0O6D0NBPDeKA3WiFIoovX65HAyjHYdFpPzJR/POxhBFQDhJXo1?= =?us-ascii?Q?+c7OEtXtEtcxoBsWQD6i/2VCbVndMl3Z/XHAIbJa?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22717e77-3a6e-45b0-ac13-08db19f7d4b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2023 01:54:01.8840 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lw2y2dipiplVyN3pMjGdmojSpXHhzhZpLUDBDK0OLfA5xq6Y4cYS15/NyZK7IMUfuwLm8NW6VsZe302bn5HhbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5033 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, February 20, 2023 8:30 AM > To: Tyler Retzlaff ; Zhang, Ke1X > > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; david.marchand@redhat.com > Subject: Re: [PATCH v2] net/ice: fix ice dcf control thread crash >=20 > 16/02/2023 08:53, Zhang, Ke1X: > > From: Thomas Monjalon > > > 13/02/2023 08:16, Ke Zhang: > > > > --- a/lib/eal/windows/include/pthread.h > > > > +++ b/lib/eal/windows/include/pthread.h > > > > +static inline void > > > > +pthread_exit(__rte_unused void *__retval) { } > > > > > > Please don't add more shim layer. > > > There is a new layer rte_thread_* in lib/eal/include/rte_thread.h > > > > > Thanks for your comments. > > Do I need add a function like rte_thread_exit() in in > lib/eal/include/rte_thread.h? >=20 > I guess yes. >=20 > > There is no function for supporting pthread_exit. >=20 > Tyler, how would you achieve the equivalent of pthread_exit? >=20 @ Tyler, would you please share any idea?