From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B2FB41C27; Tue, 7 Feb 2023 02:41:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E268A40ED9; Tue, 7 Feb 2023 02:41:03 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0125B406A2 for <dev@dpdk.org>; Tue, 7 Feb 2023 02:41:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675734062; x=1707270062; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TxyRWHQ7qEE7LV+Q59KFlemC88kR0uVNWsSjM0rSboE=; b=jfg6M5MfrBHIh6KPITKw2JPjFJXXrxuF9IjasNYc1b9NkzuIgndJajHg vjp3vMZ1dmzJx2BcTrFaFTP/+YUFrzYU1/+8MpzdPTdzlk/T3xfZ1k0+s y09jEaXquwfERlGq1J0OsbEzfZFpJA+/I7MQag4qLKXglqydfWa2da1gg V3/B/p2WXnJBsC0nalKc7UTo73vA1fAmuvOZTqothAxjmch3N1AbqZ5d/ zM16/GRCXgG8dtC8TZKa4PBjLJ2l7liEz5ddRkM2rEOmDiO2JS3uKrz8I eVywH8FgpsTILzlxTSc4Sy3XpTYet8b4V1J1yh6SENfkvJEW1Tni8IADk w==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="327056753" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="327056753" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 17:41:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="699065362" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="699065362" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 06 Feb 2023 17:41:00 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 17:40:59 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 17:40:59 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 17:40:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XY/EafGOy+iYrICxC0tDIS00EqX81lhO0vnERIJfqYO36EhS69ABEV0FRWH72fE/swwjM/MeGeWcu29Fa4i89PA63eSMal+uaZ/hwC9jbcSn5sp9qMh/VHT08XFYddLPPZCSlTranX/vk5IOqRJ09xMDqA5lzTeVzcCcY1RgRDTF91QeqD+InS+jjgZ7rhDBDxO1DIp4UMItcyiGNEJBTNboQFuFeQnEIe7pfvNYoiLY/D/c8UM0ZGRjbEaYPYNAotyR7HbLCxVtR4hq59ZOM7oMixLT5/9fgC+1xFnFd2sTP2e0nM8R7gZ78YFX0WqOUtDZh+iuclhWGpc4bSuPfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mWjszPOeTfLwBUSzbOj/vsBEE81XxZxl/X2RQ+agyh8=; b=cjHYq7cfVetgXAqroAr0oKJ7oqVnzTFM+mccghBgghbeaN3jsJuWsaYcxRAMyS2IODO0xSIIpQjfvWG081SCAg69gHyONjw+qv8TNp/Fa7QsN6GKFZOMMUUK11ngmRu7ZGeIh/zqTDs5Idn5BIBtX7kjt32XWO4ISjKPIJt2k+eFn00XnS6RvkD05+80xKbZz9rm7QBjtT8QoT22bY9YFAs7OfFajJbCHDCrdc6p8vhrdp/CrUqm8ovWd/Ka6bV0/jU5ry71jDo69teZcmqDP4ed47VCAZNHwUDZ44Yl2i3ufLgKUg/mxtVy9Qm1/Mw7ywaEYgyrQ/ruGGIB0Hz10g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB5984.namprd11.prod.outlook.com (2603:10b6:510:1e3::15) by PH7PR11MB6451.namprd11.prod.outlook.com (2603:10b6:510:1f4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 01:40:51 +0000 Received: from PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::985a:df84:4be2:7e86]) by PH7PR11MB5984.namprd11.prod.outlook.com ([fe80::985a:df84:4be2:7e86%6]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 01:40:51 +0000 From: "Zhang, Ke1X" <ke1x.zhang@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>, "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "ferruh.yigit@amd.com" <ferruh.yigit@amd.com> CC: "dev@dpdk.org" <dev@dpdk.org>, "Matz, Olivier" <olivier.matz@6wind.com>, "Zhang, Yuying" <yuying.zhang@intel.com>, "Xing, Beilei" <beilei.xing@intel.com> Subject: RE: [PATCH v2] net/i40e: support enabling/disabling source pruning Thread-Topic: [PATCH v2] net/i40e: support enabling/disabling source pruning Thread-Index: AQHZNIQXkFQVXyXN4kqIJZynptYR6q62qQKAgAE1huCAAhRHAIAIzjeQ Date: Tue, 7 Feb 2023 01:40:51 +0000 Message-ID: <PH7PR11MB598450C1431F6FE8CCDE8C30DCDB9@PH7PR11MB5984.namprd11.prod.outlook.com> References: <20230109022027.190627-1-ke1x.zhang@intel.com> <CAJFAV8yk_JsV727CJEQ5Xe42c4HqjpdgWnZF=UFRdzgFJfpK4Q@mail.gmail.com> <PH7PR11MB5984EFDDE2606F234A17F22EDCD09@PH7PR11MB5984.namprd11.prod.outlook.com> <2296416.n0HT0TaD9V@thomas> In-Reply-To: <2296416.n0HT0TaD9V@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB5984:EE_|PH7PR11MB6451:EE_ x-ms-office365-filtering-correlation-id: 13211419-8be5-435c-87b6-08db08ac5860 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7zV5h+trR+qe2ugUyNAE6n+r2buSRF0zSiM2wUrv5ROwfIMR13nELGXeorHkySVQM/CCvyft3eJLOitUyjxhCGhbKUKInC+KKVb3uirMnjJs30F6hfbwIQV46y5IyetTha+khvBFcx6homKrR75iZS3VxBXiYsVUtbLueFy8mj2MeHB80vtxTxwxAAkRH0LG4hfPsUzZIeoSC/LjtvOZ5ymr5GkJzZAZSPLxyys5eDCQjAMEcF9ejk/c/f6HjtJhkFZEW7K6U0MV6LkTMoxXJ0KkIMGcp5vY1ofmi0DiosCmAEH9Y+rWczr2J8/G4bnfjqIyGlhpcewoj/0hj6ky2kUmxWW+1hwqMmuxV2XztOk5MbbS0GLXLNwARqxdvE4Xuf6XtKIqtUaozkMhzskmKzX0Pj0gFVKDulAQd93ZVSk3CKgnqAIj1VkM4xbJnK36DeWeIEZAsMwJiCSdhB7sdbTPnJv5EQfssyyM9SN1KlrrUpTclkj77Xs6IWqiqN7rSO6raaalUk9VimFvst88UZn7j4hz+Qn8u07veB/E7tSjKw45m+Xjt0/LhM/ivHtZ5Nxrj0HNeODaxnCLTD7zpIbBCgq9RuYMp7MblidCQf8RdF4riMkubhi7p0xSVRgcIhdB57xC2JvNumrg01nYhZ61hZ6cyBifiKdYBUYEC1ytph+EAcPe2+0+/+mtqnKMapujUyzp523R1AMaZgTU/0MXI7w0B+jdzJZKZl2H+vs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5984.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199018)(110136005)(83380400001)(54906003)(66446008)(316002)(55016003)(2906002)(8936002)(52536014)(41300700001)(5660300002)(33656002)(38070700005)(38100700002)(122000001)(82960400001)(66946007)(66556008)(64756008)(76116006)(66476007)(8676002)(4326008)(107886003)(478600001)(966005)(9686003)(53546011)(6506007)(186003)(86362001)(26005)(71200400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XBbB5Ak7AO9mxyOdrJKImhTOPhLP8Rux6zybrReYw9FWWGXP8iv0CTkRTs2Q?= =?us-ascii?Q?NkyU5ljZy4/VdyktnAVUHeLs3EzE8TY0v4ZyQwUk1wwgExiFXO8E1qYEAXZe?= =?us-ascii?Q?efMq3F4M5MqexnFO81dJysczLcHEafF+1owJ590J4JcMWsuoI0mTIDAA7y6e?= =?us-ascii?Q?CooOad1Avv5Ndj3MoR4h2CfArqoLXazu0dZ6isdrRf56TajItIZz2Z6OUT+W?= =?us-ascii?Q?JqPPh5WxDGsyEpiBSEWRYANGhUF0JV04P9axRGcne6ek+psyY5J5A1P/CEkV?= =?us-ascii?Q?O9NSkOxX+gVw13B4mY2HmHqsew2+1Bk8dbNart1Dv64tay/UTJ/9e5UHSUuw?= =?us-ascii?Q?N2HvbWO5YYzFb/tgRkCuiwUElksiyQq0yAIXir/SWwJ/3nDHl0zWsqRs/vZx?= =?us-ascii?Q?XJgWH79qQi8fGGbDLccdGAaZgMmC5aA5gcuQXE0sk8OfqGiNwbN6oUm5U0Jt?= =?us-ascii?Q?gvOqe8Z9Ndgng7VPOK+la8RsVO+pKHpcYqtbr6m3ZPN+DRV0z0h+kZcWHmoM?= =?us-ascii?Q?Kp0r6XJgjUeR85NSduGO9PBY20j0JpAfrEnXzzkZPXs0B2TYobFv+9gya4nn?= =?us-ascii?Q?COVTRqV8HGJgZC86xtW+F2oxi81PaYrY1oj///D6IIzRhLBIpi3c8f0YTal1?= =?us-ascii?Q?sy1zMFGbt4gTTLMhVW91tPIP3z09xCCzyMRzYYHXkyx5qtakECCpfP+E63aU?= =?us-ascii?Q?dYg25PmO37jNHwEZ3KKvcYqnjzWMWBFTOdIggxcW1FVcLhFCvfO0/klN9Rep?= =?us-ascii?Q?39P936qP1bTi19p+SzLJwjE+fIH442mib4bvBFuEN6ghjoEtt/4lQYHdQm6U?= =?us-ascii?Q?nLdruFyHguV3ggT3ySpMDVmmToqWEnGC/rRstrnqdcnrTdPiI0OxhjE7zLkW?= =?us-ascii?Q?ZZwrPJjuUDqJvAWagTVZ/JCA2x44AMlg6HexZONawxnPaiUutAY4ViGLo+Sr?= =?us-ascii?Q?QxURsdSIArVJdgGmJiqarFBiWub1UvUxzQNm1KdcGYLXB4g/SEp07hSEh22c?= =?us-ascii?Q?gpKQoRJzf2+1kchzTXixDpjNQTghgoxn2Pir9MCmGY+ErcUcs+NcZ5nCUIgm?= =?us-ascii?Q?6wRX8pUEP9XnX00nQN+A8OhmVqHbglXiOuKOzp4kZzqKh9q07y9bhMc5t1iH?= =?us-ascii?Q?98lylMqSnwH0paS8JQc6Pu1aqVna8Vg+Ma0GxRLwbicaGJhEtYjzNtFbUobw?= =?us-ascii?Q?3kjLg0VLtkcJHX6p3hqjzaPHiO1wCxf0o5i8rn7KJ4P9eelIFYN8Cq3emKNR?= =?us-ascii?Q?rWpR+VV+1Sqjc6XVD+9rpcRhWMfZY8+DhxBmiiIrsaOh9rzQ0Hnx79IRor7z?= =?us-ascii?Q?IxDbNTcIVkRM5XbT7a5kb1rOez2bY0/PDxQkxcQH6JROoWqpvGh6r2W6QWKT?= =?us-ascii?Q?7yTWliXpfuj5ixOM8U8aKoeoHclKU+6Kv+0iJ9uTTtXQrl9q53Wg+cWYL7QR?= =?us-ascii?Q?bPNyeTKbohtY12Lo4g1WGn1mm3PPEBj6IVEpgXEeSdIkRuiJ54m7JxEF4e1C?= =?us-ascii?Q?bZEVECje5QMQ6RwWxIE5441gBXPxjwfaa9hynIJvwFE1tlj05bbwBHbhdKRp?= =?us-ascii?Q?dQud1sAe2Gi3y5WynvApuOPZxSrtnLIQSm++9y0o?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13211419-8be5-435c-87b6-08db08ac5860 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 01:40:51.3018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ipmzjt0we3Kxa4nMLEAq/FazDJWHmh40nf9URzxi/qyHoYrcnPjrv7VoGb/6FmdRs7SO24xp3TLYmh92YPNKbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6451 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Wednesday, February 1, 2023 7:11 PM > To: David Marchand <david.marchand@redhat.com>; > mb@smartsharesystems.com; ferruh.yigit@amd.com; Zhang, Ke1X > <ke1x.zhang@intel.com> > Cc: dev@dpdk.org; Matz, Olivier <olivier.matz@6wind.com>; Zhang, Yuying > <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com> > Subject: Re: [PATCH v2] net/i40e: support enabling/disabling source pruni= ng >=20 > 31/01/2023 04:28, Zhang, Ke1X: > > From: David Marchand <david.marchand@redhat.com> > > > On Mon, Jan 30, 2023 at 9:23 AM Ke Zhang <ke1x.zhang@intel.com> > wrote: > > > > > > > > VRRP advertisement packets are dropped on i40e PF devices because > > > when > > > > a MAC address is added to a device, packets originating from that > > > > MAC address are dropped. > > > > > > > > This patch adds a PMD specific API to enable/disable source > > > > pruning to fix above issue. > > > > > > > > Bugzilla ID: 648 > > > > > > > > Signed-off-by: Ke Zhang <ke1x.zhang@intel.com> > > > > --- > > > > app/test-pmd/cmdline.c | 84 > > > +++++++++++++++++++++++++++++++++ > > > > drivers/net/i40e/i40e_ethdev.c | 43 +++++++++++++++++ > > > > drivers/net/i40e/i40e_ethdev.h | 1 + > > > > drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++ > > > > drivers/net/i40e/rte_pmd_i40e.h | 16 +++++++ > > > > 5 files changed, 164 insertions(+) > > > > > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > > > cb8c174020..76a574affd 100644 > > > > --- a/app/test-pmd/cmdline.c > > > > +++ b/app/test-pmd/cmdline.c > > > > @@ -776,6 +776,9 @@ static void cmd_help_long_parsed(void > > > > *parsed_result, > > > > > > > > "port cleanup (port_id) txq (queue_id) (fre= e_cnt)\n" > > > > " Cleanup txq mbufs for a specific Tx qu= eue\n\n" > > > > + > > > > + "port config (port_id|all) src_prune (on|of= f)\n" > > > > + " Set source prune on port_id, or all.\n= \n" > > > > ); > > > > } > > > > > > > > > > - This seems i40e specific, please move to > drivers/net/i40e/i40e_testpmd.c. > > > > > > - Besides, I would prefer that something in the command name clearly > > > states this is driver (here, i40e) specific. > > > Like "port config XX i40e_src_prune" or maybe the other way around, > > > start with a "driver i40e" prefix. > > > > > > Maybe others have an opinion. > > > > > > > > > -- > > > David Marchand > > > > Thanks for your comments, this command could be used for other Intel > > NIC like ice, And It is only finished for i40e in this story: > > https://jira.devtools.intel.com/browse/DPDK-29564 >=20 > Only Intel has access to this URL. >=20 > On the principle, you should not update testpmd commands in a patch for > i40e. > We add testpmd commands when adding new features in ethdev. >=20 > Here specifically, you are adding rte_pmd_i40e_set_src_prune() with a > vague explanation: "Enable/Disable source prune on all the PF." > Without more information, I cannot judge whether the feature is generic o= r > not. > So for now, this is a nack. >=20 Thanks for your comments, this feature is only for intel NIC. Would you please share a solution for this case? Thanks.