From: "Ling, WeiX" <weix.ling@intel.com>
To: "Guo, Junfeng" <junfeng.guo@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"He, Xingguang" <xingguang.he@intel.com>,
"Laatz, Kevin" <kevin.laatz@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>
Subject: RE: [PATCH] examples/ntb: remove redundant logic for dev close
Date: Thu, 15 Jun 2023 08:28:05 +0000 [thread overview]
Message-ID: <PH7PR11MB600693AB868692541D8E6C4FEE5BA@PH7PR11MB6006.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230614051423.176572-1-junfeng.guo@intel.com>
> -----Original Message-----
> From: Junfeng Guo <junfeng.guo@intel.com>
> Sent: Wednesday, June 14, 2023 1:14 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; He, Xingguang
> <xingguang.he@intel.com>; Laatz, Kevin <kevin.laatz@intel.com>; Guo,
> Junfeng <junfeng.guo@intel.com>
> Subject: [PATCH] examples/ntb: remove redundant logic for dev close
>
> During EAL cleanup stage, all bus devices are cleaned up properly.
> Based on this, there is no need to do extra device close process, which may
> call the dev ops '*dev->dev_ops->dev_close' twice.
>
> If this dev ops for ntb was called twice, the interrupt handle for EAL will be
> disabled twice and will lead to error for the seconde time. Like this: "EAL:
> Error disabling MSI-X interrupts for fd xx"
>
> Thus, this patch just remove the redundant logic for device close.
> Ports will be closed at rte_eal_cleanup() in the main loop.
>
> Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
> Cc: stable@dpdk.org
>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
Tested-by: Wei Ling <weix.ling@intel.com>
next prev parent reply other threads:[~2023-06-15 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 5:14 Junfeng Guo
2023-06-15 8:28 ` Ling, WeiX [this message]
2023-06-28 0:12 ` Thomas Monjalon
2023-06-28 2:19 ` Guo, Junfeng
2023-06-28 2:37 ` Guo, Junfeng
2023-06-28 7:53 ` Thomas Monjalon
2023-06-28 8:08 ` Guo, Junfeng
2023-06-28 9:12 ` [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops Junfeng Guo
2023-06-29 8:03 ` Ling, WeiX
2023-07-03 6:53 ` Wu, Jingjing
2023-07-03 15:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB600693AB868692541D8E6C4FEE5BA@PH7PR11MB6006.namprd11.prod.outlook.com \
--to=weix.ling@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=junfeng.guo@intel.com \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
--cc=xingguang.he@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).