From: "Ling, WeiX" <weix.ling@intel.com>
To: "Wang, YuanX" <yuanx.wang@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>,
"Wang, YuanX" <yuanx.wang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/vhost: add flag to control wait queuing
Date: Thu, 2 Jun 2022 08:32:14 +0000 [thread overview]
Message-ID: <PH7PR11MB6006D21B765376BA8BB5923DEEDE9@PH7PR11MB6006.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220601142541.605301-1-yuanx.wang@intel.com>
> -----Original Message-----
> From: Yuan Wang <yuanx.wang@intel.com>
> Sent: Wednesday, June 1, 2022 10:26 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> dev@dpdk.org
> Cc: Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> <xingguang.he@intel.com>; Wang, YuanX <yuanx.wang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/vhost: add flag to control wait queuing
>
> update_queuing_status prevents PMD queue operations from affecting the
> data plane by waiting for rx/tx_pkt_burst to stops accessing the vhost device.
> In fact, it is only necessary to wait when destroy/stop the device, new/start
> device and vring_state_changed cases do not need.
>
> Since vring is locked when vring state changes, unconditional waiting may
> also cause deadlocks.
>
> To avoid deadlocks and unnecessary waiting, this patch adds a flag to control
> whether waiting is required.
>
> Fixes: 9dc6bb0682 (net/vhost: fix access to freed memory)
> Fixes: 1ce3c7fe14 (net/vhost: emulate device start/stop behavior)
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
Tested-by: Wei Ling <weix.ling@intel.com>
next prev parent reply other threads:[~2022-06-02 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 14:25 Yuan Wang
2022-06-02 8:32 ` Ling, WeiX [this message]
2022-06-27 5:51 ` [PATCH v2] net/vhost: fix deadlock on vring state change Yuan Wang
2022-07-01 12:31 ` Xia, Chenbo
2022-07-01 13:58 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6006D21B765376BA8BB5923DEEDE9@PH7PR11MB6006.namprd11.prod.outlook.com \
--to=weix.ling@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=xingguang.he@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).