From: "Ling, WeiX" <weix.ling@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"Ma, WenwuX" <wenwux.ma@intel.com>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>
Subject: RE: [PATCH v3] examples/multi_process: reconfigure port when rss or csum isn't supported
Date: Mon, 28 Feb 2022 07:55:56 +0000 [thread overview]
Message-ID: <PH7PR11MB6006D25ED1FBA1F99A9DCEAAEE019@PH7PR11MB6006.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YhSvxN9bCCs+4MRM@bricha3-MOBL.ger.corp.intel.com>
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday, February 22, 2022 5:41 PM
> To: Ma, WenwuX <wenwux.ma@intel.com>
> Cc: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org; Hu,
> Jiayu <jiayu.hu@intel.com>; Wang, Yinan <yinan.wang@intel.com>; He,
> Xingguang <xingguang.he@intel.com>
> Subject: Re: [PATCH v3] examples/multi_process: reconfigure port when rss
> or csum isn't supported
>
> On Tue, Feb 22, 2022 at 10:51:27AM +0000, Wenwu Ma wrote:
> > The default values of rx mq_mode and rx offloads for port will cause
> > symmetric_mp startup failure if the port do not support rss or csum.
> > This Patch make the app to reconfigure the NIC without them. Only quit
> > the app if the second reconfiguration fails.
> >
> > Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> > ---
>
> While I am surprised to see different error codes for different essentially the
> same issue - lack of HW support, that is a separate problem to the one this is
> addressing. Given this is just a sample app, I think this approach is fine for
> configuring things - keeping things simple for the user.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Tested-by: Wei Ling <weix.ling@intel.com>
next prev parent reply other threads:[~2022-02-28 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 15:17 [PATCH] examples/multi_process: add options to control port configuration Wenwu Ma
2022-02-17 9:06 ` Bruce Richardson
2022-02-18 6:49 ` Ma, WenwuX
2022-02-18 9:41 ` Bruce Richardson
2022-02-18 10:10 ` Ma, WenwuX
2022-02-18 10:22 ` Bruce Richardson
2022-02-21 15:35 ` [PATCH v2] examples/multi_process: reconfigure port when rss or csum isn't supported Wenwu Ma
2022-02-21 9:21 ` Bruce Richardson
2022-02-22 10:51 ` [PATCH v3] " Wenwu Ma
2022-02-22 9:41 ` Bruce Richardson
2022-02-28 7:55 ` Ling, WeiX [this message]
2022-03-08 13:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6006D25ED1FBA1F99A9DCEAAEE019@PH7PR11MB6006.namprd11.prod.outlook.com \
--to=weix.ling@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=wenwux.ma@intel.com \
--cc=xingguang.he@intel.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).