From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C5C6A04FD; Thu, 10 Nov 2022 03:01:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1145400EF; Thu, 10 Nov 2022 03:01:20 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6711B400D4; Thu, 10 Nov 2022 03:01:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668045678; x=1699581678; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0F82Q8f+gADryFrMSH5Cu9/V5Blc/Bopk/nyL4iqEO8=; b=USjKB+tyrZRAtALn5w7i99iad7R5dCgxccXYRgggfXfPVWAJOrUJVujY vh3nbsYEufrcn9f21qBJYojgCSJN3fEYbMqOMOL5n2p53oK+ycdTwE9ha gMe9VNOcS5kPf6+zrJFlzSArRTLYyn25WKdhpV1wlX3WeSuY1j5iC0zPQ ZuZ6nzjbVBY27ObfkUOyRwQWGs8VLcY4rgE0YmDQQnPgPamRo7pVSbawD jJDe0BygSOzuIHv2tVLzAjfWsTgeHUO/tHMPmq+KCmXbBswEcBxe2R+nC VH9wPTOyCYIqnRoh1sywdPivHCzLdWld5zqAGCWOw05YswW5x7ntWgu/B A==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="397477368" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="397477368" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 18:01:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="670176651" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="670176651" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 09 Nov 2022 18:01:17 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 18:01:16 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 18:01:16 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 9 Nov 2022 18:01:16 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 9 Nov 2022 18:01:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A2DGoss4keaPfUSHuxQ2c5aC/XcHlmhzwCkriHQErHNcrgSr5pwq1PCaQ0IDpY9eClUNpi07XSZkjjV46KiJt80KK7Bs4ByVfDXfhtEG5I8vXkUkvqC+KBotaOdqUDYfU8dyBBLQh9F/l75NoSYnVvg4dg6c2WOsH1+sckp40OvxL2b3h9tl9ZDpQN+Ra46G8FuMnti4GuISwPF4PHO3+DPFDfU61Wr1Poch4FhayYXHI+fs6G+kwsH/lVUG+SpfdBVf8EP1Hy7fWAVWbdqkHkscfMCnqKe5I19O5N5WwZp4ebEARLAjAjJNLpLK96qe/T0i87Uv1GFamyq7n4kEeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x2UaRtDz6WfwMGJtoankTlS6Mgk4Q7ODD6wEjmdB2SQ=; b=DuKtvfi1ftXloU2GqvTEjgsLD8//8OZ4I/UR9ZccdjccCxfg4CDeO54uTENXKl6kwgxvOrQ83I6O+JhBYIoEu7F+SKTH5zh/Z9yp3Iha/eker80V6nl4lVlvamKxfyKXXMrtK/ZVPqXox26fSYrjsdFjCFNx46lnr4sJZC2vLVxaQ212JydLlQnp9j8ApN3x1iW6EuVRFIDoBkPNtAA41nh3Y9CZrQskE5mejnKmu9a2E8ZbzwXMGgaje7WCbudOnKD/caMwE6Yq1XYUaEIn2p8jmL32NELDtvQ039CPw9q1alPjUr/Ss6s1jW34tlp24HmyVqSR4IQURltMSwTr2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6056.namprd11.prod.outlook.com (2603:10b6:510:1d4::20) by MW4PR11MB6619.namprd11.prod.outlook.com (2603:10b6:303:1eb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Thu, 10 Nov 2022 02:01:12 +0000 Received: from PH7PR11MB6056.namprd11.prod.outlook.com ([fe80::ba46:b69e:fad:6e4d]) by PH7PR11MB6056.namprd11.prod.outlook.com ([fe80::ba46:b69e:fad:6e4d%8]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 02:01:12 +0000 From: "Xu, Ke1" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" , "Zhou, YidingX" , "Ye, MingjinX" , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Li, Xiaoyun" , Ferruh Yigit Subject: RE: [PATCH v2] net/ice: fix scalar Rx and Tx path segment Thread-Topic: [PATCH v2] net/ice: fix scalar Rx and Tx path segment Thread-Index: AQHY8/mIzSBYt1W3FkS1iW1tC65pBq43aFaQ Date: Thu, 10 Nov 2022 02:01:12 +0000 Message-ID: References: <20221103172040.388518-1-mingjinx.ye@intel.com> <20221109125609.724612-1-mingjinx.ye@intel.com> In-Reply-To: <20221109125609.724612-1-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6056:EE_|MW4PR11MB6619:EE_ x-ms-office365-filtering-correlation-id: 5d9ace5c-a5dc-4b5a-8341-08dac2bf7190 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0b62Y/irdtXGVjq4Us8dIFxzc6ISU6XPsG5HWl9skPPKnIq9UG0siLi/WbgkTQmlCaiLCXjPI/PfVUlbqy1tH1O2jEyk8l3ee0/Qd5v4Rb9rBxo9xhcS/nsO6RHKwu7z/XArR48L0ZrPMM/1RemgsSCItpGEXTh/E4OruxTgYnoo/AxrdXE2fOZIAJ5DHZLblnyKm81e6OPNR1rIkH2OqN8JctgwlTNHO7mCjbWiUR82Up+eNiR9UbkW3Cnabbou5ej586JqqXpEj9JJ3RjhsDejeIUXE33DhLGTAnnZiVkRT4TVqSibV1TWNBWw3vfOWtXGgSTGCyj/kfaUdNf7JNl15kH+BpnCDhgDQRKdNAvdDSvNwUFdWNLlpNPP/sX+TxZ9jvS3BcDht1UaOvzTVgP8/dQI5wRaDevdB0LnMsUXBPDp2Ukghrx6vzkMXKOkZmV1uZ5f2dFyHpe9JlJVc9HEnTc0L7yD7dxvJ5Xy6QUOt4+wVFSZkGEi1ZzmZsiK+AWM042QbYRzvYVX2Tft32c0BmBKOKRUkhYQ3NpeTuObyeOoBBZbsNIExf08bKsZXirurpQ218PbkMKoky87e1bERkuPCcFfbHenTcEQkm+NT4/Gbk1PRLOBHXcLjixq3+rQdl3+/HGSOjyTU3mqShbtkAUVblYKidUa7ZpmHGGqQ8XRGwnOOlz1XFmA6sV4nWDxRKXdhZ0XJl3gYvkRnkgi8j8awDX6b86ho9emMonTP6+FZgYPA9IrZOWVIBk29ix8PxtXvAJoS+RHp36i4A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6056.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(346002)(136003)(396003)(39860400002)(366004)(451199015)(33656002)(38070700005)(86362001)(82960400001)(66946007)(5660300002)(7696005)(2906002)(55016003)(186003)(122000001)(26005)(38100700002)(53546011)(9686003)(107886003)(6506007)(83380400001)(76116006)(316002)(71200400001)(52536014)(66556008)(64756008)(66446008)(54906003)(66476007)(4326008)(8936002)(8676002)(478600001)(450100002)(110136005)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7Hkrl+dxEvSgQ+xH8DI0HT/xIMq/WMA9pUPn4eCGJFUpTTQOqfpcifnESVEA?= =?us-ascii?Q?QAO31polK5hDBXgbNjjz7VbISXb8d+dVbsyBj0U5mOUmz2BmVHLvzms3znlm?= =?us-ascii?Q?sW17vtaAvVo0s/TWeWkRFl77saHZFJk9ohQR7GlSvPtJO56PRkTxJkwVtV67?= =?us-ascii?Q?YanOMklspQ88UO5p5vObzjFp+ltKcPNaktPU9rKpdT+Rgn3bwncLupbjwoUR?= =?us-ascii?Q?8lk9XADgTo6eAOOEcRAdUWH6LQCjRVYqarLow0shuGMuaNDBmEr87WeHKFPV?= =?us-ascii?Q?VCUteaqONDjb9rUPV2L+CVJBJl8e4OTPxJV4pHJT7tqdbWVGdRxY5sM7wgpl?= =?us-ascii?Q?ndC6FmbBXaQZw/bbmRAJoowDO/XxC/ezKaiGwjQ0+wanq9IspVR4gK1n3udl?= =?us-ascii?Q?2kPCq8FajhTAzdJIw97aaANhMcnbM5xjiZs1N410BHnGTXSo0n3EHM5+QlXd?= =?us-ascii?Q?/7tepCm1Zbjur+6/0eDJsE18pHG5N2oNkhKkUdSJTHPI/uhkt8yZFA/w9lJy?= =?us-ascii?Q?GxXfNqO30O6+KTVM0JJQwXoPGNA5ZKFPJNGcAt8fbo+jwoEtsPIZ6QQFe6u2?= =?us-ascii?Q?0/MMOpJUK4RZR29Tb+srXJSQUAHKnCIUBn5cW9/ArdmsSkk2fxrwiiQyuygy?= =?us-ascii?Q?wSS3My/w6ZZpaSYI4VVIry+5uYOMGe/e0bpapAO6Hu06lge8+p541ospCqAm?= =?us-ascii?Q?tT2BTCRK6oP6MN72IbfrY+2873fCwCmK3osZ2wQ7023b+ssLatXU36d0vySF?= =?us-ascii?Q?YCGa9OKJOFsfCcvtR0GAHEKdJiRPFOovuP0fpZ8xg/+AHOTkIMYZwx5TP30N?= =?us-ascii?Q?2A7prUOXQ3ULBFa41GD92biSWO/DsD5bGKCzx4Hg70a1pfOjcgfQvrmZi3ou?= =?us-ascii?Q?27aQ6oX2HXV2OgEtZqMB0BjqdB4O73/yOrMIgyvwB5lWcjA0OPSD8EjXBrBK?= =?us-ascii?Q?Ir8rxUjsKJgp/7IMqewiUCmoCKtJxzfzVpu4gDY3zyKkat6p2gJenpW9VWvA?= =?us-ascii?Q?QxdqJXmKRcwNv+RHNe6F8vTQ7+e/ePEg9YjvLFJz3f+nore4ZtWIcp8riUgI?= =?us-ascii?Q?zvy/p0GfSPEWs7HQKcAMeFOUro6JIrlrvwVaIFz+6sHGtcLSzKuHXAGRPeG5?= =?us-ascii?Q?IsbTJU+/zb+ASdvT+uCpJR3SGc1mUnMG/RnuDiSTLIUtOb1MQS2sXk1ch7jb?= =?us-ascii?Q?tWrVFpev35piecspgX+u0lZFLWEfFLWWvwEp9GYd/f2RFi/dmbB0Vk3Ab4Dq?= =?us-ascii?Q?8P3Px0l0rAdWgK/W+7EJ7s/A6cF/+jX79P5iJKekEEdPSvBI5eDd4EAkgLPY?= =?us-ascii?Q?Rq1EnvVGdHXnQEHlLWRoq/eyUCbi7WuuQkjpbyFrk7ChKLI37xDXPZpLjh5B?= =?us-ascii?Q?T+6MeNtQXA3ttlBsB46rD8SXrZzrbrFBnYjxMv26Y3ZhXZCJxNUMWeoVr486?= =?us-ascii?Q?kNFvn0H73QzEX5VAu5by44rm3D8pGZ2CG9+99mxjb0IDo6R0JZulxpQgOEpg?= =?us-ascii?Q?joR4RExsTY4amlG3ACNuisVfHGgdYtr8D/NvoA9r0HGCk1LwTT3y9S1ef6pO?= =?us-ascii?Q?ypFgprIDX0X/okEntCc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d9ace5c-a5dc-4b5a-8341-08dac2bf7190 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 02:01:12.6028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wsbRbOafiH0pNEIkTolned2ScA9NfT6WVYfOSbrbkZRneR8AirdhpJHSzWJD7ffMBmzwWQZpIB4UlGHUwcuQlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6619 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Wednesday, November 9, 2022 8:56 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Zhang, Qi > Z ; Lu, Wenzhuo ; Wu, > Jingjing ; Li, Xiaoyun ; Fer= ruh > Yigit > Subject: [PATCH v2] net/ice: fix scalar Rx and Tx path segment >=20 > CRC is stripped by the hardware in the scattered Rx path. If the last buf= fer > packet length is '0', the scalar Tx path would send empty buffer that cau= ses > the Tx queue to overflow. >=20 > This patch adds a judgment for the last buffer length to fix this issue, = so that > it would free the mbuf associated to the last one if the last buffer is e= mpty. >=20 > Fixes: 6eac0b7fde95 ("net/ice: support advance Rx/Tx") > Cc: stable@dpdk.org >=20 > Signed-off-by: Mingjin Ye Tested and passed. Tested-by: Ke XU >=20 > v2: > * Fix log level in ice_rxtx.c source file. > --- > drivers/net/ice/ice_rxtx.c | 53 ++++++++++++++++++++++++++++++++++++-- > 1 file changed, 51 insertions(+), 2 deletions(-) >=20