* RE: [PATCH] net/ice: support vxlan gpe tunnel offload
2022-10-18 9:28 [PATCH] net/ice: support vxlan gpe tunnel offload Mingjin Ye
@ 2022-10-18 6:47 ` Zhang, Qi Z
2022-10-20 2:06 ` Xu, Ke1
1 sibling, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2022-10-18 6:47 UTC (permalink / raw)
To: Ye, MingjinX, dev
Cc: stable, Zhou, YidingX, Yang, Qiming, Andrew Rybchenko, Matz,
Olivier, Somnath Kotur, Ajit Khaparde
> -----Original Message-----
> From: Ye, MingjinX <mingjinx.ye@intel.com>
> Sent: Tuesday, October 18, 2022 5:29 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; Matz, Olivier
> <olivier.matz@6wind.com>; Somnath Kotur
> <somnath.kotur@broadcom.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>
> Subject: [PATCH] net/ice: support vxlan gpe tunnel offload
>
> PMD does not support VXLAN_GPE tunnel offloading, therefore, it will cause
> the tx queues overflow and stop working when sending such packets.
>
> This patch adds support for the vxlan gpe.
>
Is that an issue on the Tx descriptor if ICE_TXD_CTX_UDP_TUNNELING is not configured with a VxLAN GPE packet?
Better to describe the reproduce scenario a little bit here
> Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
> drivers/net/ice/ice_rxtx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> 697251c603..0a2b0376ac 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -2690,6 +2690,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,
> /* for non UDP / GRE tunneling, set to 00b */
> break;
> case RTE_MBUF_F_TX_TUNNEL_VXLAN:
> + case RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE:
> case RTE_MBUF_F_TX_TUNNEL_GTP:
> case RTE_MBUF_F_TX_TUNNEL_GENEVE:
> *cd_tunneling |= ICE_TXD_CTX_UDP_TUNNELING;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net/ice: support vxlan gpe tunnel offload
@ 2022-10-18 9:28 Mingjin Ye
2022-10-18 6:47 ` Zhang, Qi Z
2022-10-20 2:06 ` Xu, Ke1
0 siblings, 2 replies; 5+ messages in thread
From: Mingjin Ye @ 2022-10-18 9:28 UTC (permalink / raw)
To: dev
Cc: stable, yidingx.zhou, Mingjin Ye, Qiming Yang, Qi Zhang,
Andrew Rybchenko, Olivier Matz, Somnath Kotur, Ajit Khaparde
PMD does not support VXLAN_GPE tunnel offloading, therefore, it will cause
the tx queues overflow and stop working when sending such packets.
This patch adds support for the vxlan gpe.
Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
drivers/net/ice/ice_rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 697251c603..0a2b0376ac 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2690,6 +2690,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,
/* for non UDP / GRE tunneling, set to 00b */
break;
case RTE_MBUF_F_TX_TUNNEL_VXLAN:
+ case RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE:
case RTE_MBUF_F_TX_TUNNEL_GTP:
case RTE_MBUF_F_TX_TUNNEL_GENEVE:
*cd_tunneling |= ICE_TXD_CTX_UDP_TUNNELING;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] net/ice: support vxlan gpe tunnel offload
2022-10-18 9:28 [PATCH] net/ice: support vxlan gpe tunnel offload Mingjin Ye
2022-10-18 6:47 ` Zhang, Qi Z
@ 2022-10-20 2:06 ` Xu, Ke1
1 sibling, 0 replies; 5+ messages in thread
From: Xu, Ke1 @ 2022-10-20 2:06 UTC (permalink / raw)
To: Ye, MingjinX, dev
Cc: stable, Zhou, YidingX, Ye, MingjinX, Yang, Qiming, Zhang, Qi Z,
Andrew Rybchenko, Matz, Olivier, Somnath Kotur, Ajit Khaparde
> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Sent: Tuesday, October 18, 2022 5:29 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>;
> Matz, Olivier <olivier.matz@6wind.com>; Somnath Kotur
> <somnath.kotur@broadcom.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>
> Subject: [PATCH] net/ice: support vxlan gpe tunnel offload
>
> PMD does not support VXLAN_GPE tunnel offloading, therefore, it will cause the
> tx queues overflow and stop working when sending such packets.
>
> This patch adds support for the vxlan gpe.
>
> Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
> Cc: stable@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
Validated and passed.
Regards,
Tested-by: Ke Xu <ke1.xu@intel.com>
> ---
> drivers/net/ice/ice_rxtx.c | 1 +
> 1 file changed, 1 insertion(+)
> --
> 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net/ice: support vxlan gpe tunnel offload
@ 2022-10-17 13:24 Mingjin Ye
0 siblings, 0 replies; 5+ messages in thread
From: Mingjin Ye @ 2022-10-17 13:24 UTC (permalink / raw)
To: dev
Cc: stable, yidingx.zhou, Mingjin Ye, Qiming Yang, Qi Zhang,
Somnath Kotur, Ajit Khaparde, Andrew Rybchenko, Olivier Matz
PMD does not support VXLAN_GPE tunnel offloading, therefore, it will cause
the tx queues overflow and stop working when sending such packets.
This patch adds support for the vxlan gpe.
Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
drivers/net/ice/ice_rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 697251c603..0a2b0376ac 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2690,6 +2690,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,
/* for non UDP / GRE tunneling, set to 00b */
break;
case RTE_MBUF_F_TX_TUNNEL_VXLAN:
+ case RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE:
case RTE_MBUF_F_TX_TUNNEL_GTP:
case RTE_MBUF_F_TX_TUNNEL_GENEVE:
*cd_tunneling |= ICE_TXD_CTX_UDP_TUNNELING;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net/ice: support vxlan gpe tunnel offload
@ 2022-10-14 15:38 Mingjin Ye
0 siblings, 0 replies; 5+ messages in thread
From: Mingjin Ye @ 2022-10-14 15:38 UTC (permalink / raw)
To: dev
Cc: stable, yidingx.zhou, Mingjin Ye, Qiming Yang, Qi Zhang,
Andrew Rybchenko, Somnath Kotur, Ajit Khaparde, Olivier Matz
PMD does not support VXLAN_GPE tunnel offloading, therefore, it will cause
the tx queues overflow and stop working when sending such packets.
This patch adds support for the vxlan gpe.
Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
drivers/net/ice/ice_rxtx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 697251c603..0a2b0376ac 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2690,6 +2690,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,
/* for non UDP / GRE tunneling, set to 00b */
break;
case RTE_MBUF_F_TX_TUNNEL_VXLAN:
+ case RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE:
case RTE_MBUF_F_TX_TUNNEL_GTP:
case RTE_MBUF_F_TX_TUNNEL_GENEVE:
*cd_tunneling |= ICE_TXD_CTX_UDP_TUNNELING;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-24 15:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18 9:28 [PATCH] net/ice: support vxlan gpe tunnel offload Mingjin Ye
2022-10-18 6:47 ` Zhang, Qi Z
2022-10-20 2:06 ` Xu, Ke1
-- strict thread matches above, loose matches on Subject: below --
2022-10-17 13:24 Mingjin Ye
2022-10-14 15:38 Mingjin Ye
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).