* [PATCH] net/igc: fix disabling timesync
@ 2024-03-15 1:06 Wenwu Ma
2024-03-18 4:11 ` Liao, TingtingX
0 siblings, 1 reply; 3+ messages in thread
From: Wenwu Ma @ 2024-03-15 1:06 UTC (permalink / raw)
To: dev, junfeng.guo, simei.su; +Cc: tingtingx.liao, Wenwu Ma, stable
When disabling timesync, we should clear the IGC_RXPBS_CFG_TS_EN bit
of IGC_RXPBS, the patch fixes this.
Fixes: 4f6fbbf6f17d ("net/igc: support IEEE 1588 PTP")
Cc: stable@dpdk.org
Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
---
drivers/net/igc/igc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index 58c4f80927..690736b6d1 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -2853,7 +2853,7 @@ eth_igc_timesync_disable(struct rte_eth_dev *dev)
IGC_WRITE_REG(hw, IGC_TSYNCRXCTL, 0);
val = IGC_READ_REG(hw, IGC_RXPBS);
- val &= IGC_RXPBS_CFG_TS_EN;
+ val &= ~IGC_RXPBS_CFG_TS_EN;
IGC_WRITE_REG(hw, IGC_RXPBS, val);
val = IGC_READ_REG(hw, IGC_SRRCTL(0));
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/igc: fix disabling timesync
2024-03-15 1:06 [PATCH] net/igc: fix disabling timesync Wenwu Ma
@ 2024-03-18 4:11 ` Liao, TingtingX
2024-03-19 15:14 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Liao, TingtingX @ 2024-03-18 4:11 UTC (permalink / raw)
To: Ma, WenwuX; +Cc: Ma, WenwuX, stable, Guo, Junfeng, Su, Simei, dev
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
Tested-by: Tingting Liao <tingtingx.liao@intel.com>
________________________________
> -----Original Message-----
> From: Ma, WenwuX <wenwux.ma@intel.com>
> Sent: Friday, March 15, 2024 09:06
> To: dev@dpdk.org <dev@dpdk.org>; Guo, Junfeng <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>
> Cc: Liao, TingtingX <tingtingx.liao@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; stable@dpdk.org <stable@dpdk.org>
> Subject: [PATCH] net/igc: fix disabling timesync
>
> When disabling timesync, we should clear the IGC_RXPBS_CFG_TS_EN bit
> of IGC_RXPBS, the patch fixes this.
>
> Fixes: 4f6fbbf6f17d ("net/igc: support IEEE 1588 PTP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> ---
[-- Attachment #2: Type: text/html, Size: 5677 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/igc: fix disabling timesync
2024-03-18 4:11 ` Liao, TingtingX
@ 2024-03-19 15:14 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2024-03-19 15:14 UTC (permalink / raw)
To: Liao, TingtingX; +Cc: Ma, WenwuX, stable, Guo, Junfeng, Su, Simei, dev
On Mon, Mar 18, 2024 at 04:11:14AM +0000, Liao, TingtingX wrote:
> Tested-by: Tingting Liao <tingtingx.liao@intel.com>
> __________________________________________________________________
>
> > -----Original Message-----
>
> > From: Ma, WenwuX <wenwux.ma@intel.com>
>
> > Sent: Friday, March 15, 2024 09:06
>
> > To: dev@dpdk.org <dev@dpdk.org>; Guo, Junfeng
> <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>
>
> > Cc: Liao, TingtingX <tingtingx.liao@intel.com>; Ma, WenwuX
> <wenwux.ma@intel.com>; stable@dpdk.org <stable@dpdk.org>
>
> > Subject: [PATCH] net/igc: fix disabling timesync
>
> >
>
> > When disabling timesync, we should clear the IGC_RXPBS_CFG_TS_EN bit
>
> > of IGC_RXPBS, the patch fixes this.
>
> >
>
> > Fixes: 4f6fbbf6f17d ("net/igc: support IEEE 1588 PTP")
>
> > Cc: stable@dpdk.org
>
> >
>
> > Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
>
This seems a small enough, low-risk fix, so applying to
dpdk-next-net-intel.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-19 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15 1:06 [PATCH] net/igc: fix disabling timesync Wenwu Ma
2024-03-18 4:11 ` Liao, TingtingX
2024-03-19 15:14 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).